dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

3345 Commits

Author SHA1 Message Date
Brian Wilkerson df8e525655 Use InvalidUseOfNullAwareAccess and ThisOrSuperAccessInFieldInitializer rather than Unspecified 
Change-Id: Ib6bb02873129740217fcf589648f12d3f0ceccc5
Reviewed-on: https://dart-review.googlesource.com/65420
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-07-18 01:00:51 +00:00
Brian Wilkerson 7341da84bd Use SuperclassHasNoDefaultConstructor in place of Unspecified 
Change-Id: I6f912b28bfac2e6e068d1fb8d8485d491a2a4b41
Reviewed-on: https://dart-review.googlesource.com/65402
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-17 18:57:21 +00:00
Brian Wilkerson 62ce40f287 Map AmbiguousSupertypes to an analyzer error 
Change-Id: I3c9044eded49398895dac0fc973e574884fb3cc1
Reviewed-on: https://dart-review.googlesource.com/65400
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-17 18:43:19 +00:00
Brian Wilkerson 9ebab91896 Use ConstConstructorInSubclassOfMixinApplication in place of Unspecified 
Change-Id: I8a183ee4473249209587dd24c64cd40f5ccd7cf1
Reviewed-on: https://dart-review.googlesource.com/65384
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-17 18:19:50 +00:00
Konstantin Shcheglov 7a35e9cade Store resolution for using non-constant factory for constant instance creation. 
This also fixes https://github.com/dart-lang/sdk/issues/33642

Change-Id: I696da4895de28758264034f5a40914c3847b21b8
Reviewed-on: https://dart-review.googlesource.com/65200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-07-17 17:34:12 +00:00
Dan Rubel 75e1ebd55c Improve "else" statement recovery 
Change-Id: I122e84f80b13cf6d72080af17b3a0f4a27a14b53
Reviewed-on: https://dart-review.googlesource.com/65180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-07-17 17:17:21 +00:00
Brian Wilkerson 0fb284217d Map ConflictsWithSetter to an analyzer code 
Change-Id: I5f0b4bf6dc20733b980e6c4c8db4709a08e8d459
Reviewed-on: https://dart-review.googlesource.com/65380
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-17 17:03:22 +00:00
Brian Wilkerson 0a2eb8524f Map UnmatchedToken to an analyzer code 
Change-Id: Idb7130dee9692086e4ed844daa48787f9085b94b
Reviewed-on: https://dart-review.googlesource.com/65341
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-17 16:29:19 +00:00
Dan Rubel 4674961476 Improve missing ")" recovery and remove duplicate error messages 
Change-Id: Id3033d5a5a737b191bd96be4e6e20323e7e5bcfd
Reviewed-on: https://dart-review.googlesource.com/65040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-07-17 15:51:48 +00:00
Brian Wilkerson 3dba24bda2 Use TypeVariableInConstExpression in place of Unspecified 
Change-Id: Ib0f902979c33e97fa46660f0c0a4e98b092c274c
Reviewed-on: https://dart-review.googlesource.com/65240
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-17 13:23:18 +00:00
Brian Wilkerson 6927e30cac Use BreakOutsideOfLoop instead of Unspecified 
Change-Id: Ib420f7d2bb3c47da36f8fa81b4c2c09d319b74e7
Reviewed-on: https://dart-review.googlesource.com/65205
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-17 13:23:09 +00:00
Dan Rubel b571e9391c Report missing semicolon on last consumed token 
This moves the location on which a missing semicolon error is reported,
making it easier for a user to understand and fix,
and fixing some of the statement completion tests.

Change-Id: I11b9de57e2b3104238e1edb801ad1cd02e9a63a2
Reviewed-on: https://dart-review.googlesource.com/64900
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-17 12:30:37 +00:00
Konstantin Shcheglov 061004e9b7 Store resolution for instance creation even when wrong number of arguments. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Id9526b2e3bfc731b4a27638b3190795357878811
Reviewed-on: https://dart-review.googlesource.com/65168
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-17 00:48:34 +00:00
Paul Berry 6858559c48 Add support for Function syntax to analyzer/CFE integration. 
Fixes #33846.

Change-Id: I5b8836e55d2d3d450e368cd1e234dc01e2630269
Reviewed-on: https://dart-review.googlesource.com/65166
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-07-16 21:50:42 +00:00
Brian Wilkerson dfc2adf547 Map the error code for InheritedMembersConflict 
Change-Id: I89394fcf6fe47261f196a4c7c265a172f4302060
Reviewed-on: https://dart-review.googlesource.com/64940
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-07-16 21:28:03 +00:00
Brian Wilkerson 00c8cf84c5 Convert Unspecified to NonConst[Constructor|Factory] 
Change-Id: If71220e1ee7b8a57daea228191c9fafef22b6bc2
Reviewed-on: https://dart-review.googlesource.com/64920
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-07-16 21:22:32 +00:00
Konstantin Shcheglov a473a0da2f Store resolution for invalid member references. 
Change-Id: I7ce556bc4819a77e082d81bb96e54b9cedc68d78
Reviewed-on: https://dart-review.googlesource.com/65021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-07-16 19:15:01 +00:00
Konstantin Shcheglov 8b01effa5b Store unresolved prefix resolution. 
Change-Id: I03558469978ec6866d10c57f7a725e72fa6b4ec8
Reviewed-on: https://dart-review.googlesource.com/65163
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-07-16 19:05:41 +00:00
Paul Berry 7b964090b9 Adapt ResolutionApplier.visitFormalParameterList to handle function-typed formal parameters. 
Fixes #33845.

Change-Id: I6de918d644e9a22b1a9f9cd384b972047078a472
Reviewed-on: https://dart-review.googlesource.com/65162
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-07-16 18:07:48 +00:00
Brian Wilkerson 69a15d2006 Convert Unspecified to ConstructorNotSync 
Change-Id: Iabfad9797912fdb13dc86c22de6593d2c51b6716
Reviewed-on: https://dart-review.googlesource.com/64923
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-07-16 17:29:49 +00:00
Brian Wilkerson e8d715db84 Convert some uses of Unspecified to NotAConstantExpression 
Change-Id: I54df956afc9cdbc8f30d8dd8c3dd0d299907b97d
Reviewed-on: https://dart-review.googlesource.com/64880
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-07-16 17:12:00 +00:00
Devon Carew 0d52cb6a62 Write data to the driver cache asynchronously. 
This is perhaps a 3.6% performance improvement for the analysis server.

Change-Id: Ic820177dded1fe230e25ee19b979de8008a9b76b
Reviewed-on: https://dart-review.googlesource.com/65032
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-07-16 16:20:49 +00:00
Konstantin Shcheglov ce682638d9 Tests for invalid Map literal type arguments resolution. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I4e1e78b9c5497b1399a8a5ca3f600cdbbe86cf23
Reviewed-on: https://dart-review.googlesource.com/65029
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-16 15:59:45 +00:00
Konstantin Shcheglov 946be233f6 Use special error templates for for-in loops. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I7006468db607cf53d202b37c01913fb20bd722e7
Reviewed-on: https://dart-review.googlesource.com/65034
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-07-16 15:18:06 +00:00
Dmitry Stefantsov 31bed29d6e [fasta] Correct override check for methods with covariant parameters 
Bug: #32613

Change-Id: Id69e793afd2c933294299d796a28b66db6b5de17
Reviewed-on: https://dart-review.googlesource.com/64840
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-07-16 15:00:05 +00:00
Dmitry Stefantsov 48a258a4a5 [Fasta] Additional override checks 
Checks override on fields and for methods with type parameters.

Bug: 32613
Change-Id: Ia32d1080959bc706fd72a075fb6ba724fa93fd58
Reviewed-on: https://dart-review.googlesource.com/64542
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2018-07-16 15:00:05 +00:00
Dmitry Stefantsov 7d6cd21706 CFE and member conflict rules 
See https://github.com/dart-lang/sdk/issues/32613
and https://github.com/dart-lang/sdk/issues/33235#issue-326617285

Bug: #32613, #33235, #33237
Change-Id: I0d1432185b6811137e31135ac2c7f58c4de2de6c
Reviewed-on: https://dart-review.googlesource.com/64500
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2018-07-16 14:09:01 +00:00
Dmitry Stefantsov 0277432f28 [fasta] Fix inference for const redirecting factories invocations 
Fixes #33813.

Bug: http://dartbug.com/33813
Change-Id: I53708666f6c5d55760a8bc23f042565ba073812f
Reviewed-on: https://dart-review.googlesource.com/64841
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-07-16 11:24:36 +00:00
Konstantin Shcheglov 312a7d13ec Store resolution for unresolved type instance creation. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I91af78cc5b99924c8dab77662d6bd08786a24fd9
Reviewed-on: https://dart-review.googlesource.com/65026
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-07-15 16:50:49 +00:00
Konstantin Shcheglov 8f8d0bb1d7 Apply resolution to list literal type arguments. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I27eeb30b452a5fa74cda61b6926d48ec92918c8f
Reviewed-on: https://dart-review.googlesource.com/65025
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-07-15 16:50:19 +00:00
Paul Berry ae0a4d994e Rework how type information is communicated from CFE to analyzer. 
This CL introduces new Factory/TypeInferenceListener methods to
communicate details about types that are literally named in the source
code.

Previously, when an expression like `x as List<int>` was analyzed, the
resolution information about `List<int>` was communicated to the
analyzer via a kernel DartType, forcing the analyzer to walk the type
representation, applying each of its constituent parts to the
corresponding part of the AST for `List<int>`.  This was a lot of work
for the analyzer, it failed to resolve parts of invalid types (such as
`List<int, String>), and it didn't pave the way toward moving to the
Factory API.

The new approach is for information about each type appearing in the
syntax to be communicated to the analyzer at the time the BodyBuilder
converts it to a DartType.  So for an invalid type like `List<int,
String>`, the resolution of `String` is communicated to the analyzer
at the time it is converted to a DartType; later, when `String` is
discarded (because `List` only accepts one type parameter), no crucial
information is lost, because the analyzer already knows the resolution
of `String`.

Work still to be done has been captured in issues:
- #33844: References to type parameter elements are not translated
- #33845: Function typed formal parameters are not handled
- #33846: Function types using `Function` syntax are not yet handled

Change-Id: I96dd9b6f3eb573b0b7a46335e8644c59fb78bae7
Reviewed-on: https://dart-review.googlesource.com/64262
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-07-13 23:15:29 +00:00
Konstantin Shcheglov ed8824f686 Resolve loadLibrary() arguments (which should not exist). 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/33689
Change-Id: I0c35aafd4a1112190c6ecbd1af6f34190a7f1081
Reviewed-on: https://dart-review.googlesource.com/64827
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-07-13 23:15:09 +00:00
Brian Wilkerson d5c7f5af88 Convert more Unspecified errors to concrete errors 
Change-Id: Ia72c33e3258472aa8d17ff24c58c8cf63483b823
Reviewed-on: https://dart-review.googlesource.com/64803
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-13 22:55:22 +00:00
Konstantin Shcheglov 1145466844 Store resolution for method invocations that are not valid constants. 
Change-Id: Iec71ee1f464c05288eba658e086519cceee9ce16
Reviewed-on: https://dart-review.googlesource.com/64802
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-07-13 21:03:44 +00:00
danrubel 55921ed4bd cleanup insert synthetic identifier 
Change-Id: Ia7f2a94664f25ac51c0876d0c3317b78e5c2f63c
Reviewed-on: https://dart-review.googlesource.com/64780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-07-12 22:22:29 +00:00
Konstantin Shcheglov 51dd296cc5 Store unresolved variable prefix/postfix operator resolution. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: If31fa052eb2114ce9fd74d8492957e15e442ef57
Reviewed-on: https://dart-review.googlesource.com/64669
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-07-12 19:52:21 +00:00
Konstantin Shcheglov b3c27213eb Translate errors for conflicting members. 
This fixed language_2/bad_override_test/05

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I6f6b860bba40f2f6a4ce8804635d95a3828cf64f
Reviewed-on: https://dart-review.googlesource.com/64646
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-07-12 18:16:11 +00:00
Konstantin Shcheglov 6ec5801c4f Store resolution for 'throw' in constant. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Iebd1122ff887b75e94daa2153c43d59e77c3359d
Reviewed-on: https://dart-review.googlesource.com/64762
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-07-12 18:11:24 +00:00
Konstantin Shcheglov 5e17f099f0 Infer annotations only for the first VariableDeclarationJudgment of a variable declaration statement. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ic910a2d05be1bf86163f2546dc552100402a0a33
Reviewed-on: https://dart-review.googlesource.com/64668
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-07-12 17:42:48 +00:00
Konstantin Shcheglov 1c95390082 Store resolution for final fields that initialized multiple times. 
Change-Id: Iee57f4540ad2ffeb66498f061f0cca77e53320ab
Reviewed-on: https://dart-review.googlesource.com/64661
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-07-12 17:41:28 +00:00
Dmitry Stefantsov fad786769d [fasta] Reject generic function types in bounds of type variables 
Fixes #33423.

Bug: http://dartbug.com/33423
Change-Id: Iff2a23ef456ebc05fcce8ea804b478db313cac1e
Reviewed-on: https://dart-review.googlesource.com/64544
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-07-12 13:08:53 +00:00
Dmitry Stefantsov d3e241d14f [fasta] Clone missing default values of formals in forwarding stubs 
Fixes #31027.

For additional details see http://dartbug.com/33820.

Bug: http://dartbug.com/31027
Change-Id: I8eb3fb0c5d1bb6cdfc4115e3efaa5255cbd68e5b
Reviewed-on: https://dart-review.googlesource.com/64540
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-07-12 10:42:43 +00:00
Konstantin Shcheglov 2aea197aa8 Fix write into top-level variables of deferred libraries. 
This fixes language_2/deferred_global_test

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I13d41ce1c1d01821100e1af49ee7f4e59e320d01
Reviewed-on: https://dart-review.googlesource.com/64647
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-07-12 04:05:10 +00:00
Brian Wilkerson eb946bf26c Replace a use of templateUnspecified with templateExpectedFunctionBody 
Change-Id: I1b72211423043ffb244527b557218ef231c43856
Reviewed-on: https://dart-review.googlesource.com/64660
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-11 22:16:23 +00:00
Brian Wilkerson 23e3265476 Replace two uses of templateUnspecified with a more specific error 
Change-Id: Ic44e7d518ee658b46a0b688db4883d9cd9f61618
Reviewed-on: https://dart-review.googlesource.com/64641
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-07-11 20:56:43 +00:00
Konstantin Shcheglov 6c55957851 Store data for loadLibrary() invocation and tear-off. 
This is a partial fix for https://github.com/dart-lang/sdk/issues/33689

There are still problems with `prefix.field = 1` for assigning to
deferred fields, I will look into this later.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I6b12a1f359f3d8b2ed7a5d235f4f481c4c492470
Reviewed-on: https://dart-review.googlesource.com/64640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-07-11 19:45:16 +00:00
Paul Berry b42553ddaf Fix analyzer/FE integration of references to local function type parameters. 
Note that there are still a few cases that fail, involving references
to the type parameter from the parameter of a function type.  These
will be addressed in a follow-up CL.

Partially addresses #33722.

Change-Id: Ib67487e96572d0ff39af3878d74de6d3e99ea1e7
Reviewed-on: https://dart-review.googlesource.com/64580
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-07-11 15:52:02 +00:00
danrubel 166e3e12b3 Remove Scanner.useFasta 
This removes some of the code that tests the unused pre-fasta Scanner code.

Change-Id: I2d20d286e71516d6c2430a8b8e06158b53ea1a89
Reviewed-on: https://dart-review.googlesource.com/64420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-07-11 14:25:44 +00:00
Paul Berry ff98451995 Reorder members of Factory and related classes. 
Now that the nomenclature has settled down and there's low risk of
merge conflicts, it seems like a reasonable time to get these APIs
sorted so that methods are easier to find.

Fixes #33588.

Change-Id: Iedfa87346ecb335c83ffd7d52cc9f19504df9907
Reviewed-on: https://dart-review.googlesource.com/64402
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-07-11 12:29:47 +00:00
Jens Johansen 35589e03cc Don't create defensive copies in memory file system 
Follow-up to ac05595889.
This removes the defensive copies (except when adding a non-Utf8list),
resulting in another ~10 MB of savings.

Change-Id: I0d34270cfcdbcc16df0e1988302c5029488a759b
Reviewed-on: https://dart-review.googlesource.com/63951
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-07-10 09:29:30 +00:00