dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

3345 Commits

Author SHA1 Message Date
Konstantin Shcheglov 015d9eff49 Use ShadowEmptyStatement instead of EmptyStatement in blocks. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I8ab6f584d2cb1c94c6ae7c47ba000aaebe1db3e4
Reviewed-on: https://dart-review.googlesource.com/60829
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-06-19 16:21:43 +00:00
Paul Berry 029ff9361f Track which import is referenced by each prefix. 
This will be needed for analyzer integration.

Change-Id: I99118de5f44be929379eef6c76bd886e257fa0a7
Reviewed-on: https://dart-review.googlesource.com/60809
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-06-19 16:17:36 +00:00
Dmitry Stefantsov 6db5f38d4e [fasta] Don't generate noSuchMethod forwarders in abstract classes 
Bug: http://dartbug.com/33482
Change-Id: I4c9b2e9a43fdcd37238ede5814b2ad471f7b2c4d
Reviewed-on: https://dart-review.googlesource.com/60847
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-06-19 14:18:33 +00:00
Kevin Millikin 1c01aa7704 Convert some ShadowExpressions into inference judgments 
As a first step toward a new API, convert ThisExpression, Throw,
TypeLiteral, VariableAssignment, VariableGet, LoadLibrary, and
CheckLibraryIsLoaded.

Change-Id: I787d354ad6d8282a94504185390fab07c683d74d
Reviewed-on: https://dart-review.googlesource.com/60921
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-06-19 13:25:15 +00:00
Aske Simon Christensen 20fe2f0ada Indent error pointer correctly in the presence of tabs. 
Change-Id: I8e8aa9bcc70e9c4a0e951376f24db51aa51069b2
Reviewed-on: https://dart-review.googlesource.com/60426
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-06-19 11:18:33 +00:00
Martin Kustermann b172a42881 [VM] Catch errors for integer operations in kernel2kernel constant evaluator 
Issue https://github.com/dart-lang/sdk/issues/33481

Closes https://github.com/dart-lang/sdk/issues/33469

Change-Id: I7ca9825a0aa5f062732a759b4dd116e716a0d1b3
Reviewed-on: https://dart-review.googlesource.com/60580
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-06-19 10:28:05 +00:00
Peter von der Ahé 15821a28a3 Explicit type args in body_builder 
Change-Id: I9f9324b9766a970877c312f429a7873ae2359329
Reviewed-on: https://dart-review.googlesource.com/60428
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-06-19 09:35:13 +00:00
Peter von der Ahé 1f6925718b Add message for missing type arguments 
This message is ignored by default and Fasta uses this internally
to help migrate to Dart 2 and type errors in analyzer integration
at compile-time.

Change-Id: Ie0def14f09eb387fdae0486cd7a4bbed2536c64d
Reviewed-on: https://dart-review.googlesource.com/60427
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-06-19 09:35:13 +00:00
Konstantin Shcheglov f2f6ebf547 Convert ShadowAssertInitializer to AssertInitializerJudgment. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I7cf5138eacb91761fcec99808a729ecc31f5399e
Reviewed-on: https://dart-review.googlesource.com/60826
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-06-19 02:52:59 +00:00
Konstantin Shcheglov 3e6e2dd7f4 Convert ShadowAssertStatement to AssertStatementJudgment. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I58be3e6a5fd448c2b00afb194bb566c7d6987733
Reviewed-on: https://dart-review.googlesource.com/60807
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-06-19 01:55:59 +00:00
Konstantin Shcheglov 27fefd7bb3 Convert ShadowAwaitExpression to AwaitExpressionJudgment. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I1b2bd381aa29a58eab8f7c4434dc5b6151970d15
Reviewed-on: https://dart-review.googlesource.com/60806
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-06-19 00:58:59 +00:00
Brian Wilkerson dd1c54c442 Convert ShadowBoolLiteral to BoolLiteralJudgement 
Change-Id: I2cdf2a345126c2cdd05e7c06ffa2ad41a22e5502
Reviewed-on: https://dart-review.googlesource.com/60805
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-06-19 00:54:09 +00:00
Konstantin Shcheglov aba94f051e Convert ShadowAsExpression to AsJudgment. 
Change-Id: I27cb2903a4d018a54e47ff433803789f45b9c24b
Reviewed-on: https://dart-review.googlesource.com/60800
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-06-18 22:44:32 +00:00
Paul Berry 56cee22800 Build out the initial version of the Factory class (and derived classes). 
Still to be done: add the necessary arguments to plumb tokens and
subexpressions into the factory methods.

Change-Id: I99206aaca3430ad62726cb51fb818d9b820f4f96
Reviewed-on: https://dart-review.googlesource.com/60804
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-06-18 22:01:41 +00:00
danrubel c9af309cbf Fix fasta parsing of ?. in cascade expression 
... and fix more Analyzer fasta parser tests

Change-Id: I42e6f25784dbc62bca620b1ab522c07350f53aff
Reviewed-on: https://dart-review.googlesource.com/60721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-06-18 21:25:41 +00:00
Paul Berry e77158eb38 First steps toward generating analyzer/kernel ASTs during type inference. 
This CL makes the following changes:

- Adds a Factory interface (currently empty), and threads that through
  type inference logic.  In later CLs, this will be used by the infer
  methods to create ASTs as a side effect of type inference.  The
  interface is parameterized so that it can create either analyzer or
  kernel ASTs.

- Adds a KernelFactory implementation, to be used when creating kernel
  ASTs (also currently empty).

- Adds a ToplevelInferenceFactory implementation, to be used during
  top level type inference (when no ASTs need to be created).

- Renames ShadowExpression, ShadowInitializer, and ShadowStatement to
  ExpressionJudgment, InitializerJudgment, and StatementJudgment,
  respectively.  This reflects the fact that once we decouple the
  "shadow" hierarchy from the kernel AST, each shadow node will
  represent a type inference judgment.  The derived classes will be
  renamed in later CLs.

- Renames the methods _inferExpression, _inferInitializer, and
  _inferStatement to infer.

- Adds an inferredType field to each class derived from
  ExpressionJudgment.  In later CLs, this will allow us to change the
  infer methods so that they store the inferred type and return the
  AST (currently they return the inferred type).  For the moment, the
  inferredType field is set by the common method
  ShadowTypeInferrer.inferExpression.

Change-Id: Ibf7b7df2cc9754080c84b9ec5d1e2e2721569fa4
Reviewed-on: https://dart-review.googlesource.com/60620
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-06-18 19:29:52 +00:00
danrubel 88d12fda42 Parse throw on RHS of an assignment 
Change-Id: I4177dcee9eb2826474e43b43c6aa3820590e93d0
Reviewed-on: https://dart-review.googlesource.com/60600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-06-18 17:50:04 +00:00
Johnni Winther c84a9f46b2 Recompute ClassHierarchy after adding noSuchMethod forwarding stubs 
Change-Id: Idcd1ba9e43a917a526d0687be8e5b84a267042a2
Reviewed-on: https://dart-review.googlesource.com/60422
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-06-18 08:12:06 +00:00
Kevin Millikin e22706793d Treat objects with .call as "subtypes" of function types 
There were a pair of TODOs in constraint gathering in type inference,
where objects with .call methods should be considered as if they were
subtypes of function types.  Fix them.

This is a partial fix for
https://github.com/dart-lang/sdk/issues/33298 because it does not
yet handle the case of generic .call methods.

Bug: https://github.com/dart-lang/sdk/issues/33298
Change-Id: Ib9803db9a152cdc6f2108e717bb0934c38016a94
Reviewed-on: https://dart-review.googlesource.com/58206
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-06-18 07:10:26 +00:00
Mike Fairhurst e2d903c4dc Remove packages/ directory resolution from CFE 
Change-Id: I560941d08965a58b8a88e1b49c4d7d216389609e
Reviewed-on: https://dart-review.googlesource.com/60062
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-06-15 22:47:20 +00:00
Jacob MacDonald 541dd195bb Enable creating full kernel files in addition to outlines from the bazel worker for kernel. 
Change-Id: I2dc5ef10046fd210a1a7cd7db44a22fc47654e17
Reviewed-on: https://dart-review.googlesource.com/58920
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-06-15 16:24:24 +00:00
Peter von der Ahé b51d3d4146 Key string should be avoided 
Change-Id: I0708ac8bd7aa8c6993bb329b212b400a6f55cae9
Reviewed-on: https://dart-review.googlesource.com/60424
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-06-15 10:03:24 +00:00
Jens Johansen aeeb7baa96 Change error message to not use imperative tone 
Change-Id: I605bf097b80495dd627f0b25490d28fca8bc2e70
Reviewed-on: https://dart-review.googlesource.com/60423
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-06-15 09:49:44 +00:00
Jens Johansen ac039abc83 Add option to check if a dill is self-contained 
This CL adds an option to the dill loader (i.e. BinaryBuilder) to
enable performing a check of all canonical names. The theory is,
that if a dill is self-contained "every" (1) canonical name should
contain a reference to a node.

This check is (currently) disabled by default, but enabled
excplicitly in the incremental compiler when initializing from dill.
If the check fails a warning will be issued (and the dill wont be
used).

On my machine the check seems to take ~15 ms in all tested cases
(sdk, flutter test).

(1): Except for extra layer of URI of a library if the qualified
name is private.

Closes #32449.

Change-Id: I65c8fba647be3d5ba47f7ee16caef78cb2cfae07
Reviewed-on: https://dart-review.googlesource.com/51462
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-06-15 06:46:23 +00:00
Dan Rubel 53c2a6f9d5 Cleanup remaining unescape string call sites 
Change-Id: Iaf4ac9d9c48c6cca7bd2ada2d370e0253fcaa963
Reviewed-on: https://dart-review.googlesource.com/60361
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-06-15 00:38:13 +00:00
Dan Rubel c015e8d303 Improve invalid string literal error recovery 
Change-Id: Ic7d5d3f19e97a0004254377170bcc91efc7bfb08
Reviewed-on: https://dart-review.googlesource.com/60360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-06-14 22:53:34 +00:00
Kevin Millikin 2bc9025be3 Consider initializing formals during top-level type inference 
The previous implementation assumed that initializing formals without
type annotations could be inferred after the rest of top-level type
inference was completely done.  This is not necessarily the case
because inferred types for initializing formals depend on inferred
types for fields which in turn depend on inferred types for
constructors used in their initializers.

Fixes https://github.com/dart-lang/sdk/issues/32866

Change-Id: I9de0b865c740d7542e5f5ad3d62c4c47c4532266
Reviewed-on: https://dart-review.googlesource.com/60140
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-06-14 16:57:49 +00:00
Peter von der Ahé 99575f79ca Split ContextAwareGenerator and its subclasses 
This prepares the generators to be implemented by the analyzer.

Change-Id: I8b5a5b6e00d5ec7003f75b899be74c6c33a4585d
Reviewed-on: https://dart-review.googlesource.com/60244
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-06-14 14:14:14 +00:00
Sigmund Cherem c30ce41ae6 Add hook to use single-root in fasta scripts and make use of it when creating 
the dart2js platform files.

The main use-case right now is in compile-platform, but the way it is implemented
makes this available to any fasta tool.

This also adds resolveInputUri so we don't incorrectly treat supported URIs as file:* Uris.

Fixes https://github.com/dart-lang/sdk/issues/32633

Change-Id: I0ea3b1128352e72957b35823c6a1749ee418768b
Reviewed-on: https://dart-review.googlesource.com/56282
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-06-13 22:14:14 +00:00
Peter von der Ahé bd603ba3c6 Record dependencies via CompilerContext 
Change-Id: Ia53314aecb0f3162ef2cb8ec451681651aa30d42
Reviewed-on: https://dart-review.googlesource.com/58202
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-06-13 20:49:54 +00:00
danrubel 695aa1fc00 Improve recovery of missing method parameters 
... and consolidate insertion of synthetic parenthesis

Change-Id: I08a3ce04bd11fc6201862c9ee101ca9c8538c14c
Reviewed-on: https://dart-review.googlesource.com/60040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-06-13 17:41:20 +00:00
Peter von der Ahé 7d920950b7 Implement simple deprecation message 
Change-Id: I998830857241abb222c7b3cdb7ebda34db328aab
Reviewed-on: https://dart-review.googlesource.com/59087
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-06-13 13:03:26 +00:00
Aske Simon Christensen 08de1b30aa Error when a file is a part of more than one library 
Fixes https://github.com/dart-lang/sdk/issues/32999

Corresponding spec issue: https://github.com/dart-lang/sdk/issues/33225
Issue for co19 fix: https://github.com/dart-lang/co19/issues/149

The code contains a temporary hack that works around the co19 use.
This hack can be removed when the co19 fix rolls in.

Change-Id: I61b50c9142f4b215fc4d9258f1259e24ab4c052f
Reviewed-on: https://dart-review.googlesource.com/56521
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2018-06-13 12:55:20 +00:00
Peter von der Ahé 2c1fdc62c7 Address review comments 
Addressing commments from https://dart-review.googlesource.com/c/sdk/+/57508

Change-Id: Id6acd15b2e737df5e84f716f18b99a404a974359
Reviewed-on: https://dart-review.googlesource.com/57600
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-06-13 10:56:54 +00:00
Peter von der Ahé c8bc43debb Implement Severity rewriting 
Change-Id: I21fef5182e7138c1efc1af05f0ae6c79b6916d87
Reviewed-on: https://dart-review.googlesource.com/59086
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-06-13 08:12:34 +00:00
Peter von der Ahé 3d98cce456 Replace Severity.nit by Severity.ignored 
Change-Id: Ib249c2e383c25173bd25b965bdb0d67c9a487cb4
Reviewed-on: https://dart-review.googlesource.com/59085
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-06-13 08:12:34 +00:00
Peter von der Ahé 420b95aa06 Clean up imports 
Change-Id: I6c3c27986df906a4e571b3449314b39ae3ed53e4
Reviewed-on: https://dart-review.googlesource.com/59084
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-06-12 14:31:19 +00:00
Peter von der Ahé 2c72215203 Move typeVariablesCount to TypeDeclarationBuilder 
Also move checks and normalization to the wrapped builder.

Change-Id: Ica8da07bf9191b997b8e00ed0af8cc70a93f9216
Reviewed-on: https://dart-review.googlesource.com/59044
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-06-12 13:50:19 +00:00
Peter von der Ahé c8134f372e Format doubles in messages 
This simplifies including doubles in messages.

The new syntax is #num1%N.M where N is the minimum length of the
formatted number, and M is the fraction digits.

Change-Id: Ifcc12ab994363055e94ba90f7b8e6151923028fe
Reviewed-on: https://dart-review.googlesource.com/59041
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-06-12 12:46:49 +00:00
Dan Rubel 9cfe8b844e Improve nested expression recovery 
Change-Id: Icea54a2bfa1a6a5bf561d91b5a84bb2b4cccf8cd
Reviewed-on: https://dart-review.googlesource.com/58581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-06-11 16:28:29 +00:00
Aske Simon Christensen f20672e00a Parse name of factory as method name instead of constructor reference. 
Report an error when a factory constructor has type parameters.

Report a better error than the old "couldn't find constructor" or
"illegal method name" when the name of a constructor does not match
the name of the enclosing class.

Fixes https://github.com/dart-lang/sdk/issues/31196

Change-Id: Ie46a5b4cbe07ba05ce2936e1f8f9ca2cad0208f7
Reviewed-on: https://dart-review.googlesource.com/57620
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-06-11 09:55:24 +00:00
Aske Simon Christensen 5be73cd166 Make debug printing of function types more robust. 
Sometimes when printing stack states in the outline builder,
a formal in a function type is a FormalParameterBuilder,
and sometimes a formal or the return type is null.

Change-Id: I2bed0baae2a80e894e170a85744e382e763c8944
Reviewed-on: https://dart-review.googlesource.com/58207
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2018-06-06 10:28:00 +00:00
Peter von der Ahé 6054cb3e1f CompilerContext always expects a Future now 
This change is made because we were incorrectly calling
CompilerContext.clear *before* running the main compilation
task which is async.

Change-Id: I7181af33fe733e5bc653fa742b9e06782f4278d0
Reviewed-on: https://dart-review.googlesource.com/58201
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-06-06 09:35:31 +00:00
Dan Rubel fe21518df8 Improve literal list recovery 
Change-Id: Ie0e7934d139e84b96add2f0e56051295849ce1bc
Reviewed-on: https://dart-review.googlesource.com/58580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-06-06 01:44:39 +00:00
Dan Rubel daee781179 Revise beginTypeVariable event in event sequence 
This is the first CL in a series aimed at removing the need to reparse type variables in
https://github.com/dart-lang/sdk/blob/master/pkg/front_end/lib/src/fasta/kernel/body_builder.dart#L3669
and ultimately improving recovery by removing parseType.

* Move calls to listener.beginTypeVariable after parsing metadata and identifier
* Pass variable name via beginTypeVariable rather than via handleIdentifier
* Add additional check in test for issue 31846

Change-Id: I983b9d17675fc899c83df69fa1777059903e3f52
Reviewed-on: https://dart-review.googlesource.com/58300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-06-05 15:11:00 +00:00
Kevin Millikin 6ac6baae8e Record interfaceTargets for calls on dynamic receivers 
When calling Object methods on dynamic receivers, record the
interfaceTarget it Kernel.  Back ends will use this to treat the call
as a statically typed one.  This is half of the problem in
https://github.com/dart-lang/sdk/issues/33293

Bug: https://github.com/dart-lang/sdk/issues/33293
Change-Id: I8d05903e5b85370a4e697ad3afc494cbc14bcc6a
Reviewed-on: https://dart-review.googlesource.com/57820
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-06-04 09:47:21 +00:00
danrubel 2c44dc11c7 Improve type variable recovery 
Change-Id: I159508d07d28f1e2d02f5de66a67938b37bc82cd
Reviewed-on: https://dart-review.googlesource.com/57940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-06-01 18:29:13 +00:00
Aske Simon Christensen 4fb6395058 Report error when a constructor has type parameters. 
Fixes https://github.com/dart-lang/sdk/issues/30678
Fixes https://github.com/dart-lang/sdk/issues/33110

Change-Id: I7d3fcd56d408fefce7a0b43ffd68cc5427eb0940
Reviewed-on: https://dart-review.googlesource.com/57507
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-06-01 12:48:09 +00:00
Kevin Millikin 1d8bef0d89 Remove class TypeInferenceEngineImpl 
The abstract class TypeInferenceEngineImpl does not really serve any
purpose, so remove it.  If nothing else, it makes it easier to
understand what is going on and change things.

Change-Id: I9aabcb041b3fbc7d5b7b63dfef9effeb73a6bab8
Reviewed-on: https://dart-review.googlesource.com/57822
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-06-01 10:18:17 +00:00
Brian Wilkerson 2ad29cbd15 Remove unnecessary uses of toExpression 
Change-Id: I07933f647ee71c5357a599d06ce9268c0020cbd6
Reviewed-on: https://dart-review.googlesource.com/57707
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-05-31 21:03:46 +00:00