dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

6070 Commits

Author SHA1 Message Date
Konstantin Shcheglov 3ffe59e1e9 Fix for URIs of parts. 
R=brianwilkerson@google.com

Change-Id: I6442d06967d709398c4a1fcb85c4328e72ee8ade
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-08 17:59:51 +00:00
Konstantin Shcheglov f1f297e213 Build export elements and combinators. 
R=brianwilkerson@google.com

Change-Id: I11de7239bcc40ae89ff0ee1c70603aebdccace1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-08 17:33:24 +00:00
Konstantin Shcheglov 762acf00e8 Restore computing export scopes. 
R=brianwilkerson@google.com

Change-Id: I36d758694b85fd77ebc54974859648f864109425
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98863
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-08 17:12:58 +00:00
Konstantin Shcheglov aacc0b0709 Index more declarations and build more scopes. 
R=brianwilkerson@google.com

Change-Id: I57e0fdae77cee0be92c92c327f8b0d8b3b082da7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-08 16:41:29 +00:00
Konstantin Shcheglov 258d2f121b Rewrite more element model to using AST. 
Change-Id: Ic0e8c100806146182e3e1018d2d966260f93176f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98801
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-08 15:24:04 +00:00
Paul Berry fadae89a38 Remove unused imports 
Change-Id: Iafa759bf1ee42fe4324cb9380944592ba21849a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98860
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-08 14:09:04 +00:00
Brian Wilkerson 86b5304ccd Revert "Fix mustCallSuper for mixins and inherited interfaces:" 
This reverts commit 1ad11facec.

Reason for revert: The CL broke the flutter-analyze bot.

Original change's description:
> Fix mustCallSuper for mixins and inherited interfaces:
> 
> * If a method overrides a mixed in @mustCallSuper method, it should call super.
> * If a method overrides a method from a supertype, which itself overrides a
>   method from an interface, the first method should call super.
> 
> Fixes internal b/70374204.
> 
> Change-Id: I645de4a288a8c5ffff173e97692f8eb6fe38bdb5
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98443
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

TBR=brianwilkerson@google.com,srawlins@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I9339e6a8933f6d25b3bcbdbac0b6a1d304a3693b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98803
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-07 16:58:27 +00:00
Devon Carew 389ccc9000 when analyzing fuchsia workspaces, expect to find .fx-build-dir files 
Change-Id: I7ac5dac157d86d1d98db476734d8f51cd8364851
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-04-06 00:48:04 +00:00
Konstantin Shcheglov 73b931b6e6 Start reworking to use actual AST nodes created lazily. 
Change-Id: I94746fd27eb02b928f4983fe88bcf2a72f600aaf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-05 23:08:54 +00:00
Jenny Messerly da4ccd0855 [analyzer] fix #32918, eliminate type variables during const inference 
This brings Analyzer's type inference in line with the language spec.
Similar to CFE, the inference function now takes an isConst parameter,
which if set, tells it to eliminate type variables from the context
type.

Change-Id: Ied67bac39d73c9ecd7e0a482a0c8db77272637cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98707
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
 2019-04-05 19:30:54 +00:00
Keerti Parthasarathy 0e7bec7d2f Add validation for AndroidManifest.xml files 
Change-Id: Ieab8027eb81257d76cdda34b423bb554f968f021
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98040
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-05 19:30:34 +00:00
Sam Rawlins 1ad11facec Fix mustCallSuper for mixins and inherited interfaces: 
* If a method overrides a mixed in @mustCallSuper method, it should call super.
* If a method overrides a method from a supertype, which itself overrides a
  method from an interface, the first method should call super.

Fixes internal b/70374204.

Change-Id: I645de4a288a8c5ffff173e97692f8eb6fe38bdb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98443
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-05 16:14:24 +00:00
Paul Berry d14990b3ad Remove no-longer-needed override 
Change-Id: I7cda32a2b9f087e3fb2922dc938d3e17be4121de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98694
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-05 13:32:14 +00:00
Konstantin Shcheglov ddbeda075f Rework storing constructors and enum constants. 
I was adding default constructor to classes and found another problem
with shadowing exported declarations with local ones - we shadow
the class, but not its constructor. So, I'm changing it to keep
constructors and enum constants in corresponding parent declaratiosn.

R=brianwilkerson@google.com

Change-Id: I4e49b57f9fe1ac8bf611f241d2c279c746ad55ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-04 19:40:54 +00:00
Brian Wilkerson e58a8fade5 Fix typos in the diagnostic messages 
Change-Id: I65a11e52933c37a63cb9d0a14b1961a20e16271f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-04 13:47:40 +00:00
Brian Wilkerson 688475b1cd Fix bug in evaluation of == under constantUpdate2018 
Change-Id: Ie915a116365dc93e8e329c28e6c79ac0a79da2ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98611
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-04 12:28:50 +00:00
Brian Wilkerson da15746f4c Update the production of training data 
Change-Id: Ib9634c5e5bdd8c0097f55a9cf71054e2a2b6a5fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98287
Reviewed-by: Ari Aye <ariaye@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-03 22:36:01 +00:00
Konstantin Shcheglov 1dd6eaac56 Resolve default values. 
R=brianwilkerson@google.com

Change-Id: I9166b298624d469499b05992393e5674348dfef1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98602
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-03 17:15:46 +00:00
danrubel fe2d66006d improve type-before-factory error message 
Address comment in https://dart-review.googlesource.com/c/sdk/+/98449

Change-Id: I38e7cf04e2061dbd6c9b37cca713e8420a1e021d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98520
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-03 16:30:18 +00:00
Konstantin Shcheglov f32db1a453 Start adding type algebra. 
R=brianwilkerson@google.com

Change-Id: I8184a65733c679e4c025215354bd9f7ad081daef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/76588
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-03 16:07:23 +00:00
Konstantin Shcheglov cc0997f1bc Compute 'isSimplyBounded' for generic classes and typedefs. 
I also copied corresponding tests from summary to resynthesize tests,
so that AST linking can run them too.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I01d019cc57373f0dd05ab2f1467bd5528d1e2432
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98431
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-03 05:44:24 +00:00
Mike Fairhurst 5f03a9a07e Fix lints in summary generator: setter types, star-slash docs 
Change-Id: I808be84579c775c58b9a4b6d8f4ea10fc6fb29dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98458
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-02 23:48:31 +00:00
Konstantin Shcheglov 0d0f5916f7 Issue 36439. Fix for incomplete generic type alias, without function type. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/36439
Change-Id: I6a3c5be2f412ce7fb4e5b9ce3ad463158c878106
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98436
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-02 21:15:35 +00:00
Brian Wilkerson f6768b6fb3 Update the data version to prevent the use of outdated cached data 
Change-Id: Ie590959d2812b7e33854e8ad798cd43366f7bfa7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98450
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-02 16:55:41 +00:00
Brian Wilkerson dd7a6320e3 Rework the way Dartdoc template information is gathered 
Change-Id: Ia6ecde9cc317ae40e8876cdf39b49bd39a47b543
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98365
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-01 21:46:52 +00:00
Konstantin Shcheglov 66f16d3d5e Resynthesize import/export combinators. 
R=brianwilkerson@google.com

Change-Id: Ib37f1d3fe431e792fe63c92abd0be45d84af11b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98283
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-31 17:04:01 +00:00
Konstantin Shcheglov 4e3d1400d5 Resynthesize ImportElement.isDeferred from AST. 
R=brianwilkerson@google.com

Change-Id: I332fb8cfd6260ead322a1242b2340f4a9ccee269
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98285
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-31 16:46:23 +00:00
Konstantin Shcheglov 8a5901a7af Support for isCovariant in fields. 
R=brianwilkerson@google.com

Change-Id: Ie134ee454cef7b5cff69b52986ecd3f46ca1e485
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98284
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-31 16:45:10 +00:00
Konstantin Shcheglov 9113bb5855 Issue 36380. Increment DATA_VERSION. 
I suspect that the referenced issue was caused by producing and consuming
incompatible summaries from the cache.

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/36380
Change-Id: I41bd6b3ae8a07853bb702ce34724ed854f33e753
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98286
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-31 16:35:08 +00:00
Brian Wilkerson e6b0676f58 Change comment style in a few more files 
Change-Id: I2c7a3e2a01e9db61ea9ca5f6a1156d6d8ce34f5f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98282
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-31 15:28:53 +00:00
Konstantin Shcheglov c7dd9c1c23 Perform top-level inference using elements. 
This is still not a valid implementation, because for example it does
no inheritance inference, or ordering. But we need elements for
inheritance, so this change is required.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ia290a9034cbda753af60e74f6d9120d9c38bf203
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-29 23:59:33 +00:00
Brian Wilkerson 3642eddca1 Create an experiment flag for triple-shift and move existing support for the operator behind the new flag 
Change-Id: Ibff112644921618f8d21b0b1b8eb6332a590bfab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98305
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-29 21:51:40 +00:00
Konstantin Shcheglov dfbdf0a187 Support for function typed formal parameters. 
R=brianwilkerson@google.com

Change-Id: I3843c970ae94f6637aa8b4ba50e840a6ca979c83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98304
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-29 19:01:02 +00:00
Brian Wilkerson 0560014c79 Remove unused error codes 
Change-Id: I47daa6dab610af657ca781db5ca88438988c3c87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98162
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-29 15:37:26 +00:00
Konstantin Shcheglov e8b56268ef Resolve constructor initializers and redirections. 
R=brianwilkerson@google.com

Change-Id: I296fb2a7b47846481f99b5478a6cd4e383112c5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98264
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-29 15:31:55 +00:00
Konstantin Shcheglov 9b77e4c507 Include constructors into available suggestions. 
R=brianwilkerson@google.com

Change-Id: I44a9ad96f40ff1c5bd42f41bdf03defae7608360
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94980
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-29 01:26:39 +00:00
Brian Wilkerson edf470bf83 Initial sketch of dartdoc support 
Change-Id: I1250bfd56075d6575c0f268b4e335445b13b4605
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97443
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-28 20:52:29 +00:00
Konstantin Shcheglov 1b643e5c1f Support for mixins. 
R=brianwilkerson@google.com

Change-Id: I35e37863ed6ab68756669829f6ae8461e56485cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97782
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-28 19:31:13 +00:00
Brian Wilkerson d07e33e11f Convert more comments from block to line style 
Change-Id: Ib1b2b1f6858c3c7503fd7a701b9badb9cfbfe8d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98050
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-28 17:54:00 +00:00
Brian Wilkerson 926a6c0958 Convert more comments 
Change-Id: I6e198ee0809ee352038e2014a983d43b0c29101f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98048
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-28 17:52:05 +00:00
Brian Wilkerson 3364df5050 Fix a bug that led to a divide-by-zero exception 
Change-Id: Ia5ba4a2e24108d2017ea3ed2a8a2a56cdd9c110e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98042
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2019-03-27 23:41:19 +00:00
Mike Fairhurst 1bbd282d65 Make analyzer/tool/summary/generate.dart take an IDL path 
Change-Id: I919b6d92342076ed4420dcc4a5ee94853a35ed41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96240
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-27 16:08:47 +00:00
Brian Wilkerson 510d6f7789 Fix a bug in SDK constraint detection 
Change-Id: I18f15c7227a8c3f5d325be91606730444ba9b722
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97860
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-25 19:45:50 +00:00
Brian Wilkerson 5f0de26d48 Clean up the remaining copyright notices 
Change-Id: If099be4f71ba551df0dc3d69815ae6a9f55d1eba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97781
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-24 20:11:28 +00:00
Konstantin Shcheglov 09ee45b4e2 Support for import prefixes. 
R=brianwilkerson@google.com

Change-Id: Ic0da9a25fb0364a9342f2692237f08e8d00f83fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97760
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-24 19:01:38 +00:00
Konstantin Shcheglov c89642280c Infer types of fields from initializers. 
R=brianwilkerson@google.com

Change-Id: I4c76ec22802e226f51eef1235463221b35532f9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-24 18:06:37 +00:00
Konstantin Shcheglov 9f864100aa Write / read codeOffset and codeLength for elements. 
R=brianwilkerson@google.com

Change-Id: Id1d91a53ce2db797ffa3cac340056ca9d466221e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-24 18:02:18 +00:00
Konstantin Shcheglov 9d7a0113cc Add test parts, fix for indexing enums. 
R=brianwilkerson@google.com

Change-Id: Ie952e8f7a2ad62c6f17425ed78d07b17cde96e77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97687
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-23 19:03:03 +00:00
Konstantin Shcheglov 26d707041a Resolve metadata on directives. 
R=brianwilkerson@google.com

Change-Id: If462d705e7dad38fa1242d90235957d9c60edb81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97688
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-23 18:53:23 +00:00
Konstantin Shcheglov 2f22932149 Use dynamic type arguments for TypeName without explicit type arguments. 
Plus some other fixes for sync/async.

R=brianwilkerson@google.com

Change-Id: I4d21f6557ef009b5218683136443578d1bff0b01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-23 17:38:43 +00:00