dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

6070 Commits

Author SHA1 Message Date
Paul Berry 457a781bd7 Reland "Do not append ! to type names in tests that exercise NullabilitySuffix.none." 
This is a reland of 890d12fa47

Original change's description:
> Do not append `!` to type names in tests that exercise NullabilitySuffix.none.
> 
> Appending `!` is confusing because it suggests a non-nullable version
> of the type.  But the absence of a `?` or `*` suffix doesn't mean the
> type is non-nullable.  For type parameters, the type might or might
> permit null depending on how it is instantiated.
> 
> Change-Id: I3c98ddeb80816cc82e00e2692977e66c9fb51170
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99373
> Reviewed-by: Dan Rubel <danrubel@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Paul Berry <paulberry@google.com>

Change-Id: Ifbb3caea8881839e16ac959f962adc831b792ec6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99448
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-16 16:02:25 +00:00
Konstantin Shcheglov 2b4d27bf6f Fix test_unresolved_annotation_instanceCreation_argument_super. 
R=brianwilkerson@google.com

Change-Id: I6a70d9766fe90fc9eb4b7783a3c897c849a1652e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99445
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-16 15:54:24 +00:00
Paul Berry c3428c9342 Disallow UI-as-code in constants if constant-update-2018 is disabled. 
Analyzer unit tests exercising the behavior of UI-as-code had to be
replicated so that we could test the behavior both with and without
constant-update-2018.

Note that as of the writing of this CL, constant-update-2018 has been
enabled by default, so there is no immediate functional change.  The
change will take effect if we decide to back out constant-update-2018.

Change-Id: Iff50f4cb834805bec14638220671384c97dea39d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99443
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-16 15:45:44 +00:00
Paul Berry 2768cce4bf Revert "Do not append ! to type names in tests that exercise NullabilitySuffix.none." 
This reverts commit 890d12fa47.

Reason for revert: Bot failures

Original change's description:
> Do not append `!` to type names in tests that exercise NullabilitySuffix.none.
> 
> Appending `!` is confusing because it suggests a non-nullable version
> of the type.  But the absence of a `?` or `*` suffix doesn't mean the
> type is non-nullable.  For type parameters, the type might or might
> permit null depending on how it is instantiated.
> 
> Change-Id: I3c98ddeb80816cc82e00e2692977e66c9fb51170
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99373
> Reviewed-by: Dan Rubel <danrubel@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Paul Berry <paulberry@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com,danrubel@google.com,mfairhurst@google.com

Change-Id: I5fe26d9d668dde4072ec0e4e25b9865a047bb817
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99447
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-16 14:53:59 +00:00
Konstantin Shcheglov 8188e02661 Create ConstFieldElementImpl for final instance fields in classes with const constructors. 
R=brianwilkerson@google.com

Change-Id: Ie8590959e11b642951fae8fd39b93b75181034e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-16 14:16:46 +00:00
Konstantin Shcheglov 6761015e30 Fixes for unresolved and invalid URIs. 
R=brianwilkerson@google.com

Change-Id: Ief66dea3203187da90367984dc33f535748938d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-16 14:10:56 +00:00
Paul Berry 890d12fa47 Do not append ! to type names in tests that exercise NullabilitySuffix.none. 
Appending `!` is confusing because it suggests a non-nullable version
of the type.  But the absence of a `?` or `*` suffix doesn't mean the
type is non-nullable.  For type parameters, the type might or might
permit null depending on how it is instantiated.

Change-Id: I3c98ddeb80816cc82e00e2692977e66c9fb51170
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99373
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-16 13:29:32 +00:00
Paul Berry 2f77be6dc7 Fix overzealous rename. 
In 79974bb026 I accidentally renamed one
of the withNullability methods, causing it to become disconnected from
the method it was overriding.  This CL undoes the bogus rename.

Change-Id: I24655d76ef5c602e967a055e86d072a87435f3a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99480
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-16 13:22:42 +00:00
Paul Berry bd4576174e Remove the nullability variants of dynamic, bottom, and void. 
Dynamic and void are always nullable.  Bottom is never nullable.

Change-Id: I198dd6ccc84684ed05c578a5f80b1770d3f14b39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99276
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-15 22:04:21 +00:00
Paul Berry a82a35af71 Rework _checkForDeadNullCoalesce using isNonNullable. 
Change-Id: If55565d272af1be44e3326c3ec34889b3258323b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99367
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-15 22:04:21 +00:00
Brian Wilkerson fa5440a568 Fix a typo in the comments 
Change-Id: Ie67ca958622aef487322ad32d32d807f39cfe6f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99381
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-15 21:58:36 +00:00
Brian Wilkerson 77d096ca94 Add AST representation of the required keyword 
Change-Id: I7eededadfa7bf5648cbaadbbccb0ef65af9a839f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99371
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-15 21:56:16 +00:00
Paul Berry f315727b79 Add basic resolution semantics for null-assertion operator 
Change-Id: I69d0c577938a8991b98c44577556722bf54a1df8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99285
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-15 21:46:07 +00:00
Konstantin Shcheglov 369c9653c6 Store 'definingType' for next to raw Element references. 
R=brianwilkerson@google.com

Change-Id: Ieb21f9af030b65afb59491f50a5659c564dfc419
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99366
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-15 20:37:06 +00:00
Brian Wilkerson b9eb7c312c Add nullability testing methods to TypeSystem 
Change-Id: I6451468eafedddb75a7012f328d730836694bdd4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99380
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-15 20:32:05 +00:00
Konstantin Shcheglov 55ff0abde5 Rework building types for type annotations and declarations. 
It is possible that a TypeName is a typedef, for which we have not
built types for its return type and parameter types. So, we cannot
rely on the order of nodes in NodesToBuildType. We have to build types
recursively.

R=brianwilkerson@google.com

Change-Id: Idb865ed1723456ccaea49802ea5e869e544461d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-15 20:06:13 +00:00
Brian Wilkerson ae05bc6ec5 Add support for the type Never 
Change-Id: I174ab85c0010a900b4d84068a90ac27e76b0e80c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99363
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-15 19:24:25 +00:00
Paul Berry 79974bb026 Rename Nullability enum to avoid confusion with spec. 
The spec uses the terminology "nullable", "non-nullable", etc. to
refer to properties of types that differ subtly from their structure.
For example "Null" is considered nullable, even though it lacks a
trailing "?".  Since we were using the Nullability enum to denote a
purely structural property of types (whether they end in "?", "*", or
neither), this led to confusion.

So to avoid confusion, we rename the Nullability enum, and its
enumerated values, to clarify that it refers specifically to the
nullability suffixes and not to the property of being
nullable/non-nullable.

Change-Id: Ia34a500a3d2d724d30c66a410140ae11d6512f50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99275
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-15 16:50:14 +00:00
Brian Wilkerson 193458abaa Return the keyword from childEntities for import and export directives 
Change-Id: I92d04bb856d7798d141f871766ec417745dd5f13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-15 15:36:45 +00:00
Keerti Parthasarathy b997b59c09 Include manifest in the list of files to analyze 
Change-Id: I9b1c52ce085303e84b8882b0ccdc51c9555ce55c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2019-04-15 14:15:15 +00:00
Konstantin Shcheglov 3e6fd64a8a Dependencies based type inference with AST summaries. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I1513d54f6d6dbab70fa58af8d9c68a186c2a1ee3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99273
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-14 04:54:33 +00:00
Brian Wilkerson 0aa5547de1 Add missed tests and fix bug 
Change-Id: I7696207525a009860f813ddcb94528edbf12ac4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99244
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-13 20:39:13 +00:00
Paul Berry f3dbfee467 Fix the error message template for EXPERIMENT_NOT_ENABLED. 
Given an experiment named foo, it doesn't make sense to ask the user
to enable experiment --foo, since that's not the syntax for enabling
an experiment (the syntax is --enable-experiment=foo).  Changed to
'foo'.

Change-Id: I055461fb389a4338578fc7f260e252b8e3fe9a13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99286
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-13 16:19:23 +00:00
danrubel 2e7bd1359d parse dart language version comment 
This updates the parser to recognize a language version comment
of the form

// @dart = <major>.<minor>

as specified in
https://github.com/dart-lang/language/blob/master/accepted/future-releases/language-versioning/language-versioning.md#individual-library-language-version-override

Change-Id: I884620ac7da86025f5b408bcba8dd1f77e4c523c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99261
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-13 13:09:22 +00:00
Sam Rawlins e89850f95d Move STRICT_RAW_TYPE on constructors to INFERENCE_FAILURE_ON_INSTANCE_CREATION 
Bug: https://github.com/dart-lang/sdk/issues/33749 https://github.com/dart-lang/sdk/issues/36445
Change-Id: Ic34f0e07b1cc5cbbc265ab2c32cabc61d7901c0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99264
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-04-12 23:51:21 +00:00
Brian Wilkerson 0314d86af4 Add errors when a nullable type is used as a supertype 
Change-Id: I82471ba67dd74db6425bb2081bd761eb2b490333
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99284
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-12 21:13:21 +00:00
Konstantin Shcheglov 85f623374a Triage and fix some more tests. 
R=brianwilkerson@google.com

Change-Id: Ia5fcd1591532c3030eb2030ea483192b8c35fd05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99242
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-12 14:19:17 +00:00
Konstantin Shcheglov 5746227588 Support for configurations in import/export directives. 
R=brianwilkerson@google.com

Change-Id: I5dce86c0f8b20a3f06323783737b12469bf43067
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-12 14:14:28 +00:00
Aske Simon Christensen e9ca6a5335 Enable constant-update-2018 by default. 
Fixes https://github.com/dart-lang/sdk/issues/32517
Fixes https://github.com/dart-lang/sdk/issues/34189
Fixes https://github.com/dart-lang/sdk/issues/34192
Fixes https://github.com/dart-lang/sdk/issues/34205

Unskipping the skipped tests is tracked by
https://github.com/dart-lang/sdk/issues/36433 and
https://github.com/dart-lang/sdk/issues/36595.

Expectation files for front-end tests will need to be updated to make
front-end builders green. They are part of unapprovable suites.

Change-Id: I311f449af6feff5bf40740227a95aa06e0a9d84f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99169
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-04-12 13:30:15 +00:00
Brian Wilkerson c2eb9a9860 Add support to the element model for both lazy variables and required parameters 
Change-Id: I2733f26cc4ee1be28fc96bbf23402e34449ff030
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99241
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-12 12:41:48 +00:00
Konstantin Shcheglov 022400eecb Fix several small issues with AST based summaries. 
R=brianwilkerson@google.com

Change-Id: I716b55f2a656b56d4999547da03308dc11ec3b52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99190
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-12 00:50:06 +00:00
Konstantin Shcheglov e129b201e5 Fix for absent names of parameters in GenericFunctionType. 
R=brianwilkerson@google.com

Change-Id: I9a6444cc076b5d6a79c4ebf33fae9deef85e2049
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99189
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-11 21:29:12 +00:00
Konstantin Shcheglov ed280a98a2 Instantiate to bounds when resolving type names. 
R=brianwilkerson@google.com

Change-Id: I55ea6339b5b949f986f7e6becc60c0328496489e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99188
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-11 21:24:29 +00:00
Konstantin Shcheglov a91381ab07 Build local elements in initializer expressions, so support closures. 
R=brianwilkerson@google.com

Change-Id: Ic84841835ed4a24c3a58ed0ef3c3d1332e12e8f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99186
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-11 20:20:02 +00:00
Konstantin Shcheglov d4fee0a85e Issue 36576. Add returnType to constructor in available declarations. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/36576
Change-Id: I6acbf82bbaafc1ab5a1599cd415cdb11600064a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-11 18:59:43 +00:00
Konstantin Shcheglov 32f120c1e9 Resolve default values in AST summaries. 
R=brianwilkerson@google.com

Change-Id: I60bfb04a2616371c6079c7a5819f78ab13fd601b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99202
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-11 18:55:28 +00:00
Konstantin Shcheglov 7943e50cfd Compute simply bounded types. 
R=brianwilkerson@google.com

Change-Id: Ie992ccba43d2a5fca293c7791ee11875ca73c01f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99184
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-11 18:17:23 +00:00
Konstantin Shcheglov e104054059 Rework storing type parameters and function types. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ia2c71237cf0f7d9c31c7036522bb24a1aaead92f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99094
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-11 17:22:42 +00:00
Sam Rawlins b857d53e7e Re-work collection literal strict-raw-type to strict-inference 
Bug: https://github.com/dart-lang/sdk/issues/36445 https://github.com/dart-lang/sdk/issues/33749
Change-Id: I127d671840bfcfe3857225932164fa4098963715
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99085
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-11 16:20:06 +00:00
Konstantin Shcheglov 318967456c Resolve constructor initializers. 
R=brianwilkerson@google.com

Change-Id: I55101108af0e63f23d3af89a3cb23dc5e46e6392
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98877
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-11 06:07:43 +00:00
Konstantin Shcheglov 91c042c066 Implement isCovariant for fields. 
R=brianwilkerson@google.com

Change-Id: I31f9b60a9d17ecd73114827a417392d912523f94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98878
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-09 16:01:48 +00:00
Konstantin Shcheglov 06ed3f598c Resolve PrefixedIdentifier during linking. 
R=brianwilkerson@google.com

Change-Id: I2c3b82c748867697fdf5903ea5d29b2c6041a96a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98924
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-09 15:55:33 +00:00
Sam Rawlins f91de94d33 Add Element.hasOptionalTypeArgs; update strong_test_helper to use more 
modern mixins

* Remove AbstractStrongTest.enableNewAnalysisDriver; it is always true.
* Add Element.hasOptionalTypeArgs, which requires changing
  AbstractStrongTest to use PackageMixin and PackageMapUriResolver,
  instead of the custom _TestUriResolver.

Change-Id: Iecb6e37ed5894d42ad965022a8c52e3b5f625655
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-04-09 15:13:33 +00:00
Konstantin Shcheglov ca78eed3ea Issue 36529. Report Null typed spread in not-null-aware spreads. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/36529
Change-Id: I60c092a18b668605f53f3258f3d74c333e9d1427
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98923
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-09 01:53:49 +00:00
Paul Berry 241f3b253e Remove unused imports 
Change-Id: I1b81a060dc5821f291da2cc36e3c274f4f2f0498
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98873
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-09 00:33:19 +00:00
Konstantin Shcheglov 6e1baa60e0 Resolve metadata for other nodes. 
R=brianwilkerson@google.com

Change-Id: I86bec8e75ec24729ef7bf188bbfd3545a90c6a5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98907
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-08 23:16:29 +00:00
Brian Wilkerson 6d941f8099 Add manifest file error codes to master list of errors 
Change-Id: I5f7cc79f97f04c50f1e23ea71cf22fabd3d7cadd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98904
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-08 21:41:09 +00:00
Konstantin Shcheglov e9765499cc Support for name offset, code offset/length, documentation. 
R=brianwilkerson@google.com

Change-Id: I58671f9e9acc554e615382568d9c979cabb7c0c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98905
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-08 21:20:28 +00:00
Konstantin Shcheglov 29a6ad3beb Lazy AstBinaryReader is always lazy. 
We don't need another flag, moreover inter-dependencies between
type parameters require us always being lazy when we are reading any
resolved unit.

R=brianwilkerson@google.com

Change-Id: I5e2fcf547c2667ef6d2faa1827562b7a8e6c61f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98871
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-08 20:44:54 +00:00
Konstantin Shcheglov b23817105c Build types for function typed formal parameters. 
R=brianwilkerson@google.com

Change-Id: Ieff0ab7eee8bb3baaf016defb1ebcbeb65bf7df6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98902
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-08 19:21:38 +00:00