c89e71cd40
The default return type for []= is void.
...
R=brianwilkerson@google.com
Change-Id: I748ada4ee9a6f7f9c2693d959982305c5b9d1650
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100086
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 20:27:24 +00:00
3aef424c9c
Always add imported / exported files, even if they are parts.
...
R=brianwilkerson@google.com
Change-Id: I884e61711c61f8d664428f13d3c699a56ed76295
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100084
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 19:59:22 +00:00
e7a54a9759
Support for TokenType.GT_GT_GT
...
R=brianwilkerson@google.com
Change-Id: Ie02eb93757a4fe6e89eafab70027523e828d5208
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99968
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 19:45:13 +00:00
ec79fc2ff4
update AstBuilder to process "late" modifier
...
Change-Id: I97530583b059a39d502469079940ffc5b8d4db71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-22 19:34:33 +00:00
390ba6925d
Allow nnbd to be enabled in tests
...
Change-Id: Iafe7abc132c664b0b16109b3c5d6fd8a6ac3b0c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100083
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 19:11:08 +00:00
d1b675055c
Read all GenericFunctionType(s) and TypeParameter(s) is lazy AST before reading eager AST.
...
So, that all corresponding elements are available.
R=brianwilkerson@google.com
Change-Id: I844cc276fda574883a658cc9b150a0a74b13e63a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100120
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 18:55:16 +00:00
4a33d33297
Store FeatureSet in CompilationUnit.
...
Change-Id: I8c132b0ae93ee76adb5cf89f8a725db048b9e935
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100060
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 17:38:39 +00:00
08832508ec
Forward "late" modifier to parser listeners
...
... and update parser tests to use preNonNullable feature set
to address comments in https://dart-review.googlesource.com/c/sdk/+/99963
Change-Id: I3a3293d65805807b7b95e887f829f3f0080ae3b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99964
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-22 17:20:10 +00:00
6d9d95d938
Add GenericFunctionTypeImpl.declaredElement
...
R=brianwilkerson@google.com
Change-Id: I46db30d67722d4cecbff65d95fcecc0f683a13e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100081
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 16:59:21 +00:00
fd48001ace
Put NNBD modifiers behind a flag
...
Fix https://github.com/dart-lang/sdk/issues/36691
Change-Id: I48aa72eb6a4aa63d072089baaf99d249763095fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99963
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-22 15:31:09 +00:00
a9b1d9e33b
Splice resolved API nodes and unresolved function bodies.
...
After attempting to use DeclarationResolver to implement building
elements, I decided that this does not work well enough, and we need
a more specialized implementation. This also opens ways for interesting
optimizations in the future, e.g. we don't need to resolve any names in
APIs of nodes - they are already resolved summaries.
R=brianwilkerson@google.com
Change-Id: Ib448eb7334b469296ffb866ba27ae7edd0d4543a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-22 15:02:29 +00:00
d50232a3f5
Plumb new FeatureSet class into AstBuilder.
...
And change clients of parser and AstBuilder (within the SDK) to use
it.
Long term, it would be better to store the FeatureSet object directly
in the AstBuilder and remove the existing flags `enableNonNullable`,
`enableSpreadCollections`, `enableControlFlowCollections`, and
`enableControlFlowCollections`. However there are analyzer clients
that currently use these flags. So for now, we simply plumb in the
FeatureSet as a new way of setting AstBuilder flags. Once we've
updated clients to use FeatureSet, we'll publish a breaking version of
the analyzer that removes the old flag API.
Change-Id: I6d37177c40b1a1216956e95f473252aa218d10b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100000
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-22 13:38:59 +00:00
76f177a492
Use a non-null index for all features, even expired ones.
...
This ensures that the FeatureSet object can track the presence or
absence of expired features.
Change-Id: Ie6e213993792b8c3d6cf84ef01c464c16c274b85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-20 13:53:45 +00:00
680744d169
Fix version number strings to always include a patch number.
...
The version parser we use (Version.parse from package:pub_sumver)
doesn't support `major.minor` formatter version strings.
Change-Id: Ie6bf59d0f59d24d036c037d079494eb980e73212
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99886
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-19 22:44:31 +00:00
af0fa108da
Add support for required named parameters
...
Change-Id: Iebfd8da18c6f2158ed39043ab116e2670a7329c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99717
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-19 19:25:01 +00:00
63658b113c
Proposed new API for tracking feature opt in/out
...
Change-Id: I777094da1301b525cd92cab1f9bf49d2f70a911b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99784
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-19 18:20:41 +00:00
9e87c16677
Record TopLevelInferenceErrorKind.dependencyCycle in summary2.
...
R=brianwilkerson@google.com
Change-Id: I1869f31dd6163827026e8e9d54e8682cb9ab2405
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-19 15:45:34 +00:00
f8491950fe
Create List<TypeParameterElement>, not Impl.
...
Otherwise this Impl type gets propagated via toList(), and we get
a cast failure when attempt to assign TypeParameterMember element to
it. I'd like that we did not use TypeParameterMember at all, but
for now we do.
R=brianwilkerson@google.com
Change-Id: I03e1392fbd52d5a0fc7c257265d17d1cbd391edb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99718
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-18 20:15:26 +00:00
fa7485f28e
Build types for not simply bounded elements using dynamic type arguments.
...
R=brianwilkerson@google.com
Change-Id: Ia3c2d5193212a8cf58caad2323185e1ac9e31c9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99716
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-18 20:14:49 +00:00
2b9f968d2f
Convert engine.dart to triple-slash comment style
...
Change-Id: I5808862e2d9a8e0944f713d925cf9b526bc5cccc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99780
Commit-Queue: Paul Berry <paulberry@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-18 18:45:08 +00:00
20fde9a6a8
Don't overwrite inherited types of fields with types of initializers.
...
R=brianwilkerson@google.com
Change-Id: I0a92cc38e6f4bb8fe8f2102bf62f27c61ade1823
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99715
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-18 18:03:59 +00:00
e6e2a196a3
Issue 36667. Check for unresolved URI in getLibraryByUri().
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/36667
Change-Id: If35719b350c2f26edbb7cbe42f51af896aa41fe7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99713
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-18 18:02:38 +00:00
6ac38a926c
The synthetic default constructor should have reference.
...
We use ElementImpl.reference to store references to elements.
So, all elements must have one, even synthetic.
R=brianwilkerson@google.com
Change-Id: I29932449d97816108a6c1fca6db3fe7162baa1ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99781
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-18 17:44:10 +00:00
92729e0cd3
Remove UndefinedTypeImpl.
...
And corresponding DartType.isUndefined as well.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I85debe627e989b5a5671becf5d9dd16413562236
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99729
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-18 17:42:28 +00:00
cf77b82f52
[analyzer] handle youtube and animation dartdoc directives
...
Change-Id: I5bcad74803da2466c8a50160823c586f57e00ec1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99711
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2019-04-18 17:18:28 +00:00
6384f629c0
new conflicting-modifiers error code
...
This adds a new "conflicting modifiers" error code for new NNBD
modifier errors and replaces the existing "const and var" error
code with the new error code.
Change-Id: I1997bbb7f66e62d2de3c5042b6ea85861f2e00d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-18 16:44:08 +00:00
7b6b8f8c43
Restore 'parameters' and 'typeParameters' for ParameterElementImpl.
...
This partially reverts https://dart-review.googlesource.com/c/sdk/+/5000
which was done during moving toward integration with Kernel, which
we don't do anymore.
With summary2 the FunctionType of a function type parameter is purely
synthetic, without its original element. However parameters in
function typed parameters still exist as nodes, so they must have
elements.
R=brianwilkerson@google.com
Change-Id: I6689b05459f3989a20839346013c80a86ac8dc7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99709
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-18 14:10:18 +00:00
bc58bf598e
Add summary serialization support for nullability suffixes.
...
Resynthesis support will be added in a future CL.
Change-Id: I652da0c1ba60d8e41179e952294b4a4b45961347
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99702
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-18 12:11:08 +00:00
336fc9001c
Fix for getting type of a DefaultFormalParameter during building types.
...
R=brianwilkerson@google.com
Change-Id: Idce49baa00c9b100efd5622ecfc64ef8f85bcb78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99708
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-18 05:08:08 +00:00
e93c6b7ce1
Add AST representation of the late keyword
...
Change-Id: I0475065506488a0313c0aa6bc7f30d16f95d1405
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99730
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-18 01:56:18 +00:00
284a299543
Fix mustCallSuper for mixins; fixes #36492
...
This re-lands most of https://dart-review.googlesource.com/c/sdk/+/98443 .
This change does not include the "inherited interfaces" bit of that CL,
which some developers have objected to; we'll discuss.
Bug: https://github.com/dart-lang/sdk/issues/36492
Change-Id: Ibaa8ab87c749eae6359b739204c6f286b6818aa5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99727
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-04-17 22:59:11 +00:00
5a824581b7
Read directive annotations before returning offset.
...
AST is read lazily.
R=brianwilkerson@google.com
Change-Id: Ibba09fd28d0cf6c0b5d59b0bf437b09adf16c78f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99706
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-17 21:47:28 +00:00
703ccc974b
Support for TypeParameter metadata.
...
R=brianwilkerson@google.com
Change-Id: Id0d0b9018538986787832c8001c6aa43c6bec380
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99733
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-17 21:47:13 +00:00
242ed77040
Fix for FormalParameter without name.
...
R=brianwilkerson@google.com
Change-Id: I9dd957a9a55aef444f1e82a094dbf600a57074b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99732
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-17 21:46:46 +00:00
92dd37081d
Write / read Annotation element.
...
R=brianwilkerson@google.com
Change-Id: Ia1cf2fd7d397186094827245a3cf33a5892690aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99731
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-17 21:46:11 +00:00
b8a9711489
Update AstBuilder to handle "required" modifier
...
Change-Id: I68a3f0abd405119ccc52dc9263860129fff7453a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99486
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-17 21:19:51 +00:00
ca28e2c8ce
forward "required" modifier to parser listeners
...
... and have each report an error by default
Change-Id: If818a7bb207becbed95a97890632a1803917d285
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-17 21:19:51 +00:00
250d931ecc
When URI cannot be resolved, the library is null.
...
R=brianwilkerson@google.com
Change-Id: Icdba4cd1c23b88bdfc11bd9082a79738f3371a9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99726
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-17 20:27:56 +00:00
2491767a33
Use correct CompilationUnitElement for annotations.
...
R=brianwilkerson@google.com
Change-Id: Iad43c3f8cb02bcc165235e3832a569f4dd44c7a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99725
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-17 20:27:35 +00:00
4ef18fdb96
Fix nameOffset for Export/ImportElement.
...
R=brianwilkerson@google.com
Change-Id: If757d8ccbb0bdaed74c2d4268a507bd87854ab05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-17 20:27:18 +00:00
7873dbdc1d
Fix for duplicate declarations.
...
R=brianwilkerson@google.com
Change-Id: Ie08b441edc30027ec4c4509f6c77b97d4cf8242d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99723
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-17 20:27:01 +00:00
714a082a5d
Minimal integration of summary2 into AnalysisDriver.
...
There are also a couple of fixes for linking, to reduce the number
of failures.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I411ac34dd65bafd35adcbf22c1b78869ec0b5e24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99703
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-17 19:15:52 +00:00
b0c98d57fa
Add the new manifest error codes to error codes list
...
Change-Id: Iaea0edc3d0680c03dec32c5da74399e1b26a399c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2019-04-17 15:08:16 +00:00
ebdefa3f5f
add new "late" and "required" modifiers
...
Change-Id: Iec0acac1bb4280f31bd32297543eceb54f87f1ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99641
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-17 15:01:36 +00:00
8e73b3c006
Enable ui-as-code features.
...
Change-Id: I97781ffe5144c4b959cb3cb720e9cd06c22928ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99283
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-04-16 21:29:55 +00:00
e7f75e11ae
Add more checks for manifest
...
Change-Id: I1bdfa35fe6ae6d026a913abc95b209f0fe41e2fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99500
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-16 20:33:15 +00:00
4b7d256a06
Revert "Enable constant-update-2018 by default." and "Update .expect files in pkg/front_end after e9ca6a53"
...
This reverts commit e9ca6a5335d3e00fd35ehttps://dart-review.googlesource.com/c/sdk/+/99560
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2019-04-16 20:20:12 +00:00
73d99df7e0
Report when a potentially nullable type is used in an on clause
...
Change-Id: I6e9e779d5bb0f37cfd71d4d2dc38c1511c03d59f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99484
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-16 19:34:25 +00:00
80dd5ca3d4
new "modifier out of order" error code
...
This replaces the const-after-factory error code
with a more general modifier-out-of-order error code.
Change-Id: I71baf2c96656241475c344cb33b887d8e0d456fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99481
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-16 19:28:55 +00:00
cef1e31284
Rewrite AST for implicit instance creation.
...
R=brianwilkerson@google.com
Change-Id: I2fc7b75e2d64359c3bd79fdb613f03d01e8211a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99482
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-16 17:24:24 +00:00
Konstantin Shcheglov