d798e3e262
Issue 23477. Fix for Quick Fixes in overlay-only files.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23477
Review URL: https://codereview.chromium.org//1145443003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45826 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 20:47:03 +00:00
2c27356c32
Sort imports by package names, then by file paths.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1131523005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45822 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 20:00:44 +00:00
7344dcc35c
[WEB-16445] When create a missing imported library/part, add the edit once.
...
R=brianwilkerson@google.com
BUG= https://youtrack.jetbrains.com/issue/WEB-16445
Review URL: https://codereview.chromium.org//1147543002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45813 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 16:22:01 +00:00
f058a6ad33
Tweaks for using task model in Editor.
...
It works in general, bug currently it is buggy and slow.
Notes:
1. Implicit dependencies backfire.
If the cache size is not big enough and we end up flushing some CU, then recreating it, it looses its LibraryElement.
We need an explicit dependency on it.
2. If the cache size is not big enough, this still may cause an infinite analysis cycle.
3. We need to implement activating / deactivating cache partitions to change cache size.
4. Probably we need to set LineInfo into ChangeNotice always.
5. There are bugs in type hierarchy.
6. Semantic highlighting takes too long to display.
7. Overlay changes are not used.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1125303008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45811 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 15:04:50 +00:00
ee3263c22c
reduce rethrow keyword relevance
...
so that return is prioritized over rethrow
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1135243006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45809 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 02:35:23 +00:00
0bf3812043
Fix exception in code completion (issue 23439)
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//1138963005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45805 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 00:00:59 +00:00
3ffb42cd22
Sort enum declarations.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//1136413003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45801 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-14 22:42:16 +00:00
e73c0efc45
Fix server error messages
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1141773002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45775 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-13 20:05:45 +00:00
6e25226a0d
Issue 23444. Use ConstructorMember(s) for super constructor fixes.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23444
Review URL: https://codereview.chromium.org//1140963002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45765 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-13 16:13:09 +00:00
a0099fc922
suggest async for closures
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1135613004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45711 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 19:30:35 +00:00
4e3e55276a
suggest keywords for more expressions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1141443002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45708 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 19:17:44 +00:00
d2164273da
check for package lib exist before making package suggestions
...
BUG=dartbug.com/23428
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1128833003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45706 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 18:48:15 +00:00
81e474c43e
Clean up many generated constructors
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1131423002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45676 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-09 19:06:12 +00:00
9d88c5c476
pkg/analysis_server: don't explicitly import matcher - use exports from unittest
...
This will avoid breaks when the test package is checked in
Also remove exec bit from root files
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1138523004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45657 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 20:57:44 +00:00
de0cb1f374
Create a new home for Java code generated by analysis server.
...
This code used to be generated directly into
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated,
however now that editor is no longer part of this repository that
doesn't work anymore.
Fixes the test pkg/analysis_server/tool/spec/check_all_test.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//1132673003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45646 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 16:40:04 +00:00
654c4b4675
More renames
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1126353004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45592 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 13:19:04 +00:00
1124eaacd8
Rename EMPTY_ARRAY to EMPTY_LIST
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1127183003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45579 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-06 23:47:59 +00:00
4d0cce227d
Sort the containing method first in completions following super
...
BUG=dartbug.com/22850
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1121773003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45539 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-05 21:11:11 +00:00
b05fb8ba98
suggest only superclass elements for "super."
...
BUG=dartbug.com/23208
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1127643003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45535 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-05 19:09:51 +00:00
0ae83bf868
(TBR) fix the build
...
BUG=dartbug.com/23073
Review URL: https://codereview.chromium.org//1126703002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45512 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-04 21:49:54 +00:00
c464ba7dda
Use server.getContainingContext() in execution domain.
...
It works even for folders.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1126613004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45504 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-04 20:15:40 +00:00
be90dce1de
fix file uri suggestions on Windows
...
BUG=dartbug.com/23073
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1120113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45500 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-04 18:16:46 +00:00
2c96ad2af5
update relevance for named param suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1120023002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45499 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-04 18:13:41 +00:00
6368514b6d
improve import suggestion
...
BUG=dartbug.com/19941
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1113063005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45497 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-04 18:02:23 +00:00
ac3126da13
Fix exception in stack trace from issue 23348
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1113063007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45493 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-04 16:03:58 +00:00
ffd27806a1
More source utilities
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1117183004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45492 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-04 15:03:52 +00:00
b909e13241
Ignore synthetic tokens when search for AstNode.
...
This fixes the exception you saw during 'Extract Local' refactoring.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1117183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45481 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-03 20:29:38 +00:00
8a294a09ac
Add an option to enable the new task model
...
R=jwren@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//1119983004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45477 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-02 14:17:17 +00:00
2527d6b840
(TBR) fix the build
...
BUG=
Review URL: https://codereview.chromium.org//1118313002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45468 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-01 15:50:21 +00:00
e2d3e3b09f
suggest part file uris
...
BUG=dartbug.com/23073
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1118143004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45467 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-01 02:29:27 +00:00
f198c3485c
cleanup visitInheritedTypes signature
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1120893002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45465 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-01 02:25:56 +00:00
e6e1182a6d
add import file uri suggestions
...
BUG=dartbug.com/23073
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1117963002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45464 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-01 01:37:07 +00:00
85e1841e35
suggest keywords for switch statement and expressions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1118113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45463 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-01 01:35:35 +00:00
d741aaf58d
Add utilities for creating SourceChanges
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1110583002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45461 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-30 14:56:55 +00:00
af475ead16
restructure internal request to implement CompletionRequest API,
...
move performance tracking out of internal completion request,
and add resourceProvider to request
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1115843003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45455 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-30 05:09:03 +00:00
763fd171c9
cleanup imports
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1112183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45452 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-29 16:58:47 +00:00
ed2f434829
Issue 23337. Quick Fix for removing dead code.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23337
Review URL: https://codereview.chromium.org//1116593002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45447 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-29 04:52:24 +00:00
641ea327ec
Add standard files needed before we publish
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1094823004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45426 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-27 14:18:06 +00:00
0c90300719
Rename two more classes to prepare for the public API
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1087483006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45424 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-27 14:14:22 +00:00
7f280a6779
guard against non-existant package directory
...
BUG=dartbug.com/23073
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1055983003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45417 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 21:46:53 +00:00
a7fa3c85c2
suggest async/await
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1103643003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45415 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 21:39:57 +00:00
140fd9c601
fix for r45387 - canonicalize path to prevent "type X cannot be assigned to type X" warnings
...
BUG=dartbug.com/23073
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1102913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45412 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 20:28:43 +00:00
70a846ad6c
Update pubspecs and dependencies to get pkgbuild tests working.
...
This also removes the vendored copy of Angular, which was an outdated version of
an unstaffed branch.
R=pquitslund@google.com
Review URL: https://codereview.chromium.org//1058283006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45410 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 20:08:53 +00:00
ac3613e2bb
Re-apply change to move to plugin package
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1094083003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45408 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 18:54:24 +00:00
a565470b1f
Bump analysis_server dep on args to >=0.13.0.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1108553004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45402 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 17:09:07 +00:00
6237c8909f
add dart: and package: import uri suggestions
...
BUG=dartbug.com/23073
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1100393004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45398 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 12:51:52 +00:00
0cb3816eea
Fix for linked position offsets when insert directly before.
...
R=danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//1086273002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45394 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 04:51:12 +00:00
1fb5410c07
Issue 23271. Check target.staticElement for null.
...
Unable to reproduce and provide a test.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23271
Review URL: https://codereview.chromium.org//1098423002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45393 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 04:47:06 +00:00
127f7e2a0b
Update args to 0.13.0.
...
See also https://codereview.chromium.org/1094793005 .
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//1103803002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45389 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 23:42:54 +00:00
b5e86ba441
switch -package-root to use PackageMapUriResolver
...
This change allows future code completion mods to consistently use the
SourceFactory.packageMap method to build a list of package uri import
suggestions.
BUG=dartbug.com/23073
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1107583004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45387 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 23:06:13 +00:00
scheglov@google.com