dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

4090 Commits

Author SHA1 Message Date
Brian Wilkerson 15a0f755e8 Improve error messages for invalid requests 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1246573002 .
 2015-07-20 10:23:01 -07:00
Brian Wilkerson bc265ebe28 Implement support for watching directories containing implicitly analyzed files 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1244613004 .
 2015-07-20 09:04:37 -07:00
guillermooo 5eeaf9ac07 update documentation 2015-07-19 21:26:59 +02:00
guillermooo 856aee812a make indentation configurable for codegen tools 2015-07-19 21:16:15 +02:00
Brian Wilkerson 78fb9729fa Concrete implementation of completion request (from new API) 
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1242223002 .
 2015-07-19 08:37:47 -07:00
pq 05d4206929 Server .packages support. 
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1242023008 .
 2015-07-18 22:18:30 -07:00
Brian Wilkerson c884410865 Remove reference to as-yet-uncommitted file 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1227203011 .
 2015-07-17 14:38:21 -07:00
John McCutchan 87e4f68bf5 Drop try block 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1236933007 .
 2015-07-17 14:18:37 -07:00
John McCutchan 0300e2e9fd Make analysis_server use ignore patterns from .analysis_options file 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1234293003 .
 2015-07-17 14:10:37 -07:00
John McCutchan cb5335dc4a Add a PathFilter to each context in analysis_server 
BUG=
R=brianwilkerson@google.com, pquitslund@google.com

Review URL: https://codereview.chromium.org//1238173003 .
 2015-07-17 12:42:57 -07:00
Brian Wilkerson 23f96f1916 Renames to move closer to the new API 
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1240433008 .
 2015-07-17 12:20:02 -07:00
Brian Wilkerson 1dfef4bb0c Ensure that there is a stack trace when reporting a server error 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1232243004 .
 2015-07-16 10:36:10 -07:00
Paul Berry 2f6ebaa774 Only send "analysis.analyzedFiles" notification when the set of files changes. 
R=jwren@google.com

Review URL: https://codereview.chromium.org//1233003002 .
 2015-07-13 15:52:28 -07:00
Brian Wilkerson 2ffa8de794 Add notification of analyzed files 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1232393005 .
 2015-07-13 15:07:33 -07:00
Brian Wilkerson 41f74711e0 (TBR) Fix a broken test 
Review URL: https://codereview.chromium.org//1232913002 .
 2015-07-13 12:45:56 -07:00
Brian Wilkerson 0c6872acef Hook for overriding the ContextManager and some code clean-up (with more to follow) 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1223413003 .
 2015-07-13 10:20:13 -07:00
Brian Wilkerson 10b7db100f Revert "Update Analysis Server highlight API and implementation." 
This reverts commit 739847402b.

Rolling the wire protocol API version forward caused existing clients to break, so we're rolling it back until we can find a backward compatible way of adding the new functionality.

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1236433003 .
 2015-07-13 09:49:55 -07:00
Konstantin Shcheglov 3f99fc1744 Add test for 'getNavigation'. 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1229833004 .
 2015-07-13 07:46:07 -07:00
Konstantin Shcheglov d7c2f4550b Issue 23640. Implement 'analysis.getNavigation' request. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23640

Review URL: https://codereview.chromium.org//1232683003 .
 2015-07-10 15:31:25 -07:00
guillermooo 1383dd8684 typo 2015-07-09 13:52:12 -07:00
guillermooo d7d272de81 minor changes to comments and strings 2015-07-09 13:52:12 -07:00
Konstantin Shcheglov 739847402b Update Analysis Server highlight API and implementation. 
I think this is a good enough compromise between the existing and IDEA granilarity.

Eclipse plugin CL will follow.

(IN)VALID_STRING_ESCAPE are not implemented yet.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1227143003 .
 2015-07-09 11:19:44 -07:00
John McCutchan 6ecf960c5e Move SdkExtUriResolver from analysis_server to analyzer so it can be used in analyzer_cli 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1214823003 .
 2015-07-08 10:28:19 -07:00
John McCutchan 8e4a96d016 Fix SdkExtUriResolver.restoreAbsolute 
BUG=

Review URL: https://codereview.chromium.org//1228643003 .
 2015-07-08 10:00:18 -07:00
Brian Wilkerson 27f600058e Improve propagation in binary expressions 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1226823003 .
 2015-07-08 08:02:05 -07:00
John McCutchan 598336788d Add support for .sdkext file to analysis server 
- Add SdkExtUriResolver which is populated with any dependency provided sdk extensions.
- Adjust AnalysisServer._createSourceFactory to setup a SdkExtUriResolver whenever the roots are set.
- Add unit tests for SdkExtUriResolver.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1213613017 .
 2015-07-08 07:51:41 -07:00
Konstantin Shcheglov b62e8fbca9 New Quick Assist - 'Convert to field formal parameter'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1216463004 .
 2015-07-07 14:57:43 -07:00
Konstantin Shcheglov aa4efb8c6e One more fix for making removing overlays incremental changes. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1214853028 .
 2015-07-07 14:51:44 -07:00
Brian Wilkerson bdfc16a146 Hook for overriding the creation of a package resolver 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1214243005.
 2015-07-06 13:06:33 -07:00
Konstantin Shcheglov 7e194d8fb5 Change navigation regions generation for constructors. 
In IDEA we use navigation regions for resolution.
And so far all navigation regions are for separate identifiers.
This CL splits single regions like "new A.named()" into separate "A" and "named" regions.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1218183007.
 2015-07-06 11:27:19 -07:00
Konstantin Shcheglov 0bb5179b84 Quick Assist for converting field formal parameters into normal parameters and initializers. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1217593006.
 2015-07-06 11:19:30 -07:00
Paul Berry 9857471f8c Modify analysis server codegen check to tolerate Windows line endings. 
Now that the git repository config has been modified to use CR/LF on
Windows machines, our generated files contain different contents on
Windows machines than they do on Mac/Linux machines, so they were
failing the codegen check.  This CL updates the codegen check to
tolerate those differences.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1219493007.
 2015-07-01 11:12:26 -07:00
danrubel 1647483615 move performance measurement to benchmark/integration 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1219023006.
 2015-07-01 12:09:43 -04:00
danrubel d2bd01852f performance measurement improvements 
* report mean, 90th, 99th, and std-dev
* increase analysis wait time to 60 seconds
* add option for analysis server localhost diagnostics
* report running old vs new task model
* do not check if src dir exists so that scripts are more portable
* set clientRequestTime for each request
* ensure dir paths have trailing separators

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1221893003.
 2015-06-30 18:08:10 -04:00
Brian Wilkerson dd9fa13157 More GetHandler clean-up 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1221703003.
 2015-06-30 07:49:32 -07:00
Brian Wilkerson 0513859704 Re-implement the status page for the new task model 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1211243003.
 2015-06-29 12:20:19 -07:00
danrubel 13b601ffc5 watch for file system changes after context created 
Closes #23671

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1188663006.
 2015-06-29 12:24:29 -04:00
Paul Berry db6c95502a Work around naming conflict in analyzer's Resource class. 
Commit f8ce36df55 introduced an SDK
class called "Resource", causing warnings to appear in any files that
reference the analyzer class with the same name.  (Fortunately there
was no regression in functionality since the spec requires the name
conflict to be resolved in favor of the definition that is outside the
SDK).

As a short term workaround to avoid the warnings, we are explicitly
importing 'dart:core' and hiding the new Resource class.  In a future
CL, we plan to rework analyzer's Resource class in order to make some
changes necessary for ".packages" file support; when that happens we
will probably rename the class to avoid the name conflict.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1215753003.
 2015-06-26 13:00:44 -07:00
Dan Rubel a87e9386eb performance measurement: generate report 
* track/correlate responses
* separate req/resp from notifications
* track/report completion notifications
* add min/max/unexpected to report

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1202843010.
 2015-06-25 10:03:24 -04:00
Paul Berry 921a5229fa Make use of test_flushAstStructures in analysis server. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1203783004.
 2015-06-24 14:04:26 -07:00
pq bee94603a0 Warning fix. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1209633002.
 2015-06-24 09:35:30 -07:00
Dan Rubel aa91c7c436 performance measurement: mapFrom/To --> map 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1202803002.
 2015-06-23 19:35:15 -04:00
Dan Rubel 1ce49788ea performance measurement: add explicit temp source directory argument 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1201263002.
 2015-06-23 15:53:01 -04:00
danrubel e43c98a13c rework packageMapInfo dependency watching to avoid race condition 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1199083002.
 2015-06-22 19:19:09 -04:00
danrubel 679de372f4 gracefully degrade if package map input file cannot be watched 
BUG=

Review URL: https://codereview.chromium.org//1198423002.
 2015-06-22 17:07:12 -04:00
Konstantin Shcheglov 19a87506bc Fix for the server test. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1196213005.
 2015-06-22 10:03:06 -07:00
Konstantin Shcheglov e9c3b2d7b1 Move cache consistency validation into Analysis Server. 
This speeds up the add/analyze/remove/analyze cycle from 1600 ms to
1300 ms, i.e. on about 20%.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1195183002.
 2015-06-22 08:19:44 -07:00
danrubel d907a4265e (TBR) improve integration test failure message 
BUG=

Review URL: https://codereview.chromium.org//1194393002.
 2015-06-22 07:04:28 -04:00
danrubel f3a1297576 fix tests 
BUG=

Review URL: https://codereview.chromium.org//1191363003.
 2015-06-20 18:20:46 -04:00
Dan Rubel eb95064511 recompute package map when input file changes 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1180843011.
 2015-06-20 17:18:54 -04:00