pq
2fdcb1bd74
Promote diagnostic.getDiagnostics() ( #25061 ).
...
* removes rolling average support
* removes "experimental" tag
* bumps API version
Fixes #25061 .
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1509033003 .
2015-12-09 09:29:26 -08:00
Dan Rubel
e9a77de7dd
suggest yield and yeild* - fixes #24346
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1511553005 .
2015-12-09 12:03:12 -05:00
danrubel
87ac33a904
CombinatorContributor and LibraryMemberContributor - consolidate common behavior
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1516473002 .
2015-12-09 11:41:42 -05:00
danrubel
e03c395a8c
extract TypeMemberContributor from prefixed element contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1504223005 .
2015-12-09 07:38:20 -05:00
Konstantin Shcheglov
b05ae45575
Extract Local refactoring: provide a linked edit group for the name.
...
This will support in-place rename after extract in IDEA.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1502183007 .
2015-12-08 15:27:05 -08:00
danrubel
dcacf6145b
extract LibraryMemberContributor from prefixed element contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1507303002 .
2015-12-08 15:10:32 -05:00
danrubel
bc3f000893
fix uri contributor for Windows
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1513453002 .
2015-12-08 15:08:57 -05:00
danrubel
c66a5d3fb5
suggest async* and sync* - fixes 24554
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1509193003 .
2015-12-08 15:07:35 -05:00
Konstantin Shcheglov
72cf3cbe91
Remove unnecessary 'noSuchMethod' declarations.
...
Also format these file.
I don't like how the new formatter changed the code :-(
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1507813004 .
2015-12-08 11:39:37 -08:00
Paul Berry
4c28eb6f67
Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27
2015-12-08 10:16:29 -08:00
pq
1e4cea355f
Embedded option processing fixes ( #25115 ).
...
* Updates error filter and linter configuration to play nice with embedded options.
* Fixes embedded lint config (#25115 ).
* Improves support for (and tests of) options file deletions.
* Pulls in linter with untyped options support (needed for processing merged options).
Unblocks: https://github.com/flutter/flutter/issues/624 .
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1503353002 .
2015-12-07 16:18:47 -08:00
danrubel
088b50f8a9
extract StaticMemberContributor from PrefixedElementContributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1505703003 .
2015-12-07 17:15:14 -05:00
danrubel
20909182b0
add suggestion for partial named parameter - fixes #24758
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1504233002 .
2015-12-07 17:13:06 -05:00
Konstantin Shcheglov
aed5431106
Issue 24988. Parse source for sorting.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24988
Review URL: https://codereview.chromium.org/1507083002 .
2015-12-07 14:01:24 -08:00
Brian Wilkerson
c5f82b8376
Additional clean-up after moving to the new task model; a breaking change needed to allow a bug to be fixed
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1503203002 .
2015-12-07 12:02:42 -08:00
Brian Wilkerson
ea3ba0e31f
Remove deprecated code
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1502213002 .
2015-12-07 10:24:36 -08:00
danrubel
89168a1956
add completions in assert stmt - fixes #24888
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1509523002 .
2015-12-07 12:51:02 -05:00
Brian Wilkerson
1101a1e0e7
Add more (incomplete) diagnostic support to the status pages
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1503893002 .
2015-12-07 09:50:37 -08:00
danrubel
55a8740ba1
extract named constructor suggestions from prefixed element contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1507633002 .
2015-12-07 11:58:39 -05:00
Paul Berry
de3a1b22c8
Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27
2015-12-07 07:04:07 -08:00
danrubel
9dd5b25d50
extract field formal contributor from prefixed element contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1507513002 .
2015-12-07 08:05:00 -05:00
danrubel
79a8654e5f
(TBR) increase pumpEventQueue to finish analysis
...
Review URL: https://codereview.chromium.org/1508523002 .
2015-12-06 17:26:27 -05:00
danrubel
372cb6be58
fix combinator contributor
...
gracefully degrade given partially element information
better reporting of exceptions during testing
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1506623002 .
2015-12-06 15:34:19 -05:00
Paul Berry
4f654473ff
Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27
2015-12-06 08:41:24 -08:00
danrubel
53f777162e
(TBR) get completion tests passing
...
Review URL: https://codereview.chromium.org/1505443002 .
2015-12-04 20:55:09 -05:00
pq
80dfbafe28
Context-specific configuration status reporting.
...
* Fixes status page to show options per-context.
* Adds lints and error filter reporting.
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1495303002 .
2015-12-04 15:50:00 -08:00
Konstantin Shcheglov
2be2c5e55c
Fix for navigation reginos for instance creations with import prefixes.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1498163003 .
2015-12-04 14:24:09 -08:00
Dan Rubel
a5e4c81b7f
move combinator contributor to new task model
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1503463002 .
2015-12-04 15:48:21 -05:00
Konstantin Shcheglov
dd9ad7e015
Skip assignments and argument lists.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1496363002 .
2015-12-04 11:43:39 -08:00
Paul Berry
cd03a05caf
Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27
2015-12-04 09:06:41 -08:00
danrubel
9f033a9d94
convert uri contributor to use new task model
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1498733005 .
2015-12-04 07:49:31 -05:00
danrubel
7b5a756b0f
extract ReplacementRange for use in tests
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1499003002 .
2015-12-03 20:59:29 -05:00
Konstantin Shcheglov
767b57bafd
Extract Local refactoring: skip method names in invocations.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1498523005 .
2015-12-03 15:19:36 -08:00
danrubel
4379efb6b4
rework ArgListContributor to use new task model
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1500793003 .
2015-12-03 18:00:50 -05:00
Paul Berry
7d3c4743db
Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27
2015-12-03 14:22:24 -08:00
Brian Wilkerson
090459ca08
Report targets will null entries (prevents an NPE)
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1497083003 .
2015-12-03 13:46:48 -08:00
danrubel
6fd2fba704
hookup new CompletionContributorFactory
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1500723002 .
2015-12-03 13:34:35 -05:00
Brian Wilkerson
b9644af695
Remove the old task model
...
Review URL: https://codereview.chromium.org/1490233007 .
2015-12-03 10:14:06 -08:00
Konstantin Shcheglov
93072d7825
Include tokens of Function/MethodDeclaration into AST view.
...
It helped to identify the "The null object does not have a getter 'variable'" problem.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1493893006 .
2015-12-03 10:00:05 -08:00
danrubel
c2b70c9054
improve annotation argument completion - from https://github.com/dart-lang/sdk/pull/25099
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1497773002 .
2015-12-03 10:34:00 -05:00
danrubel
ac63bc8fe4
update completion extension point to use CompletionContributorFactory
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1495933002 .
2015-12-03 10:02:04 -05:00
danrubel
e1f6fc7c95
move dart completion contributor instantiation
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1497523004 .
2015-12-03 07:46:00 -05:00
Konstantin Shcheglov
5f49df1644
Issue 25095. Add 'Change X to Y type annotation' Quick Fix.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25095
Review URL: https://codereview.chromium.org/1492053004 .
2015-12-02 18:50:41 -08:00
pq
43f027fc05
Analysis request getReachableSources ( #24893 ).
...
Implements a new request to get reachable sources.
This solves a specific issue for flutter (e.g., inferring execution type by checking the transitive closure of reachabe sources for `dart:flutter`) but can be more generallly useful for other client-side smarts (e.g., "is this a web entry point?" or "is this a test?").
More context here: https://github.com/dart-lang/sdk/issues/24893
R=brianwilkerson@google.com , devoncarew@google.com
Review URL: https://codereview.chromium.org/1491013002 .
2015-12-02 13:26:35 -08:00
Brian Wilkerson
600fc17de1
Clean-up the registration of plugins
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1487953002 .
2015-12-02 13:25:28 -08:00
Konstantin Shcheglov
bf54a3bef6
Don't attempt to create a file for non-Dart imports.
...
This should help to fix the following exception:
Dart analysis server, SDK version 1.13.0-dev.7.12, server version 1.12.0, error: Exception from fix contributor: DefaultFixContributor
Bad state: No element
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1492843003 .
2015-12-02 09:28:58 -08:00
Konstantin Shcheglov
cfc8ee30b7
Fix for exception in FixProcessor._addFix_illegalAsyncReturnType.
...
This fixes the following reported exception.
Dart analysis server, SDK version 1.13.0, server version 1.12.0, error: Exception from fix contributor: DefaultFixContributor
The null object does not have a getter 'offset'.
NoSuchMethodError: method not found: 'offset'
Receiver: null
Arguments: []
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1487683006 .
2015-12-01 14:37:11 -08:00
Konstantin Shcheglov
50d9ec3161
Check types in '_addFix_createConstructorSuperExplicit'.
...
I was not able to reproduce the problem.
But this might fix the following exception.
Dart analysis server, SDK version 1.13.0, server version 1.12.0, error: Exception from fix contributor: DefaultFixContributor
type 'MethodInvocation' is not a subtype of type 'ConstructorDeclaration' in type cast.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1489823003 .
2015-12-01 13:40:46 -08:00
pq
c84ea322ff
Fix rolling averages in diagnostic status.
...
* updates sampler to return `num`s
* migrates status get_handler to one shared handler for diagnostics
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1490623002 .
2015-11-30 21:24:10 -08:00
Konstantin Shcheglov
5b2ad27b06
Issue 25048. Ignore inner analysis roots which are already managed by outer roots.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25048
Review URL: https://codereview.chromium.org/1487903002 .
2015-11-30 15:01:33 -08:00