748ad91b64
rework LocalLibraryContributor to resolve referenced units
...
This is similar reworking code completion import resolution
https://codereview.chromium.org/1693933002/
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1692273003 .
2016-02-13 23:07:51 -05:00
bcaedf2b7f
The exception occurs because the type can be set to null if the element is either a parameter or local variable element. This might be a change since the time this code was originally written.
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org/1688493002 .
2016-02-10 10:49:47 -08:00
3fc06a4aa7
abort completion request - fixes #24271
...
This CL aborts completion requests (returns empty list of completions)
if either a newer completion request is received
or the source changes after the completion request was received.
In addition, I wrapped calls to AnalysisFutureHelper computeAsync
in exception handlers so that it will be easier to track async exceptions
back to the code that requested the computations.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1685653002 .
2016-02-10 12:45:53 -05:00
bdd0d637fe
We need to perform analysis differently based on some option settings (such as strong mode), but there is currently a single SDK that is shared across all contexts no matter which option values are being used. This causes us to inconsistently analyze different portions of the SDK depending on which outer context was the first to request the analysis.
...
This is at least a first step toward solving this problem by allowing multiple SDKs to be created, one for each unique set of options.
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1686613002 .
2016-02-09 11:05:34 -08:00
fa08150ca6
Support for embedder dependency changes ( #25606 ).
...
Adds logic to detect when a library embedder is added as a dependency and reconfigures the `SourceFactory` appropriately.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1653733002 .
2016-02-09 09:39:59 -08:00
20d31ea8c3
Compute ElementImpl.hashCode using location.
...
We need this to ensure that Impl and Handle have the same hash.
This reduces number of shared test failures from 267 to 67 when using
SDK summaries.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/1677213003 .
2016-02-09 07:06:22 -08:00
c43622e897
Use ElementAnnotation as the ConstantEvaluationTarget for annotations.
...
Previously, we had a special class,
ConstantEvaluationTarget_Annotation, for this purpose. It held on to
a the AST node for the annotation. This was bad because it meant that
the presence of any ConstantEvaluationTarget_Annotation referring to a
given compilation unit would keep the entire compilation unit's AST in
memory.
Now we copy just the portions of the AST we need into
ElementAnnotation, just as we do for all other constant evaluation
targets. In addition to saving memory, this paves the way for
supporting annotations in summaries, by making it possible to compute
the constant value of an annotation without having to consult the full
AST.
Fixes #25285 .
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1665353002 .
2016-02-04 15:22:40 -08:00
9bec38cca9
Enumerate resolvers on context status page.
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1665343002 .
2016-02-04 14:29:31 -08:00
960b9c3409
Issue 25650. Generate unique parameter names when create a method or function.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25650
Review URL: https://codereview.chromium.org/1664423002 .
2016-02-04 13:59:27 -08:00
fb520065b8
Issue 25686. Add 'var' for untyped unimplemented fields.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25686
Review URL: https://codereview.chromium.org/1668273002 .
2016-02-04 13:32:49 -08:00
bc551cb308
Beef up analysis server integration test messages.
...
When an integration test fails, in can be difficult to figure out why,
especially if the test had to forcibly terminate the analysis server
process. These messages should help debug the problem.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1669473004 .
2016-02-04 12:48:21 -08:00
37767eff86
Hooks for injecting embedder resolver providers.
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1666573006 .
2016-02-04 11:03:43 -08:00
4239eadd74
WEB-20151. Include type arguments into type proposals.
...
R=brianwilkerson@google.com
BUG= https://youtrack.jetbrains.com/issue/WEB-20151
Review URL: https://codereview.chromium.org/1661763002 .
2016-02-02 18:36:11 -08:00
b0c06a5827
Issue 25616. Support for extracting methods with function-typed parameters.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25616
Review URL: https://codereview.chromium.org/1655353002 .
2016-02-02 14:32:02 -08:00
3ef79232ad
Add indication of resolver provider to the status page
...
R=jwren@google.com
Review URL: https://codereview.chromium.org/1653093002 .
2016-02-01 11:36:07 -08:00
86106d7a6d
Issue 25623. When adding the 'async' modifier, change the return type.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25623
Review URL: https://codereview.chromium.org/1652963003 .
2016-02-01 10:35:47 -08:00
bb73ff38bc
Fix build: _addFix_addAsync_asyncFor() does not return.
...
TBR
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1656693003 .
2016-02-01 08:49:25 -08:00
5b95009a6b
Move ResolverProvider to analyzer so that it can be shared
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1658663002 .
2016-02-01 08:12:29 -08:00
3f7a21bc0e
Issue 25622. Quick fix for 'async-for'.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25622
Review URL: https://codereview.chromium.org/1650853002 .
2016-02-01 08:03:55 -08:00
9b1fa223a8
Embedded libs key rename to defuse server landmine.
...
1.13 stable builds of the SDK contain a version of server that fails catastrophically when analyzing source that imports packages that define embedded libraries. Since we can't pragmatically require more recent SDKs for flutter development we have been prevented from landing embedded libs in the flutter engine. By renaming the key we use to identify contributed libraries, this change avoids the issue. Old versions of server will simply ignore the new key and new ones will process it properly. Win-win!
BUG=
R=danrubel@google.com
Review URL: https://codereview.chromium.org/1643023002 .
2016-01-29 09:52:04 -08:00
e7e52ae2c0
Issue 25542. If an element does not have its own documentation, use the documentation from the overridden superclass member or an implemented interface.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25542
Review URL: https://codereview.chromium.org/1632033002 .
2016-01-25 17:09:48 -08:00
205a2a9c28
Don't add sources to DartSdk contexts.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1625273003 .
2016-01-24 15:49:18 -08:00
201e980fd2
Rework recent changes to LineInfo to be backward compatible.
...
Commit 1ecd06d39cR=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1625783002 .
2016-01-23 17:33:20 -05:00
fe7a48d6c7
Isse 25404. When remove a method during inlining, remove also leading empty lines.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25404
Review URL: https://codereview.chromium.org/1628623002 .
2016-01-22 19:40:38 -08:00
5237561075
Issue 25404. 'Inline Method' should update implicit 'this' and class references.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25404
Review URL: https://codereview.chromium.org/1629533003 .
2016-01-22 17:21:57 -08:00
1ecd06d39c
Add a count of total lines to status performance page
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1622713002 .
2016-01-22 14:37:29 -08:00
9f451cb0dc
Issue 25538. Fix for type hierarchy and private class members.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25538
Review URL: https://codereview.chromium.org/1615093002 .
2016-01-21 10:56:05 -08:00
cba8d0d7c3
Issue 25538. Fix for 'analysis.implemented' notification and private members.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25538
Review URL: https://codereview.chromium.org/1615023002 .
2016-01-21 09:49:18 -08:00
5dc34340a1
Issue 25538. Fix for notification and private methods.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25538
Review URL: https://codereview.chromium.org/1610773003 .
2016-01-21 08:01:51 -08:00
b37e3b7ec1
(TBR) fix embedder tests on Windows
...
Review URL: https://codereview.chromium.org/1609003003 .
2016-01-19 16:24:01 -05:00
53b2815ad8
Ignore 'expr is' outside of a statement.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1609883002 .
2016-01-19 13:20:38 -08:00
1c5e2fd0fb
Use getResolvedCompilationUnit2() instead of resolveCompilationUnit2() in QuickAssist and QuickFix contributors.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1582613010 .
2016-01-15 12:15:45 -08:00
d8df717622
Add list length information to the status pages
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1588083003 .
2016-01-14 13:53:53 -08:00
730d962729
add an option to send the incremental resolver log to stderr
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1585563002 .
2016-01-13 12:55:13 -08:00
6ead1c4359
HttpServer start async fix ( #25394 ).
...
Background: https://github.com/dart-lang/sdk/issues/25394 .
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1573343003 .
2016-01-12 10:22:49 -08:00
2ae3026c43
add enableAsync to analysis option file flags
...
integrate enableAsync into analysis server
include enableAsync on context status page
update api spec to indicate that enableAsync is no longer deprecated
relys on landing https://codereview.chromium.org/1570183002/
fixes #25373
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1574523002 .
2016-01-08 20:48:07 -05:00
465bae9b8c
null namespace check - fixes #25331
...
Review URL: https://codereview.chromium.org/1554153002 .
2016-01-08 15:54:16 -05:00
7c5e03435b
Deprecate UNIT_TEST_GROUP and UNIT_TEST_TEST.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1570003002 .
2016-01-07 20:03:39 -08:00
9a2f5b298a
Initial .analysis_options files with couple of lints enabled.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1566743002 .
2016-01-06 09:14:18 -08:00
634e5a1d02
Refs #25328 Use a portable shebang
...
BSD systems don't place bash in /bin and a lot of the dart tools
hardcode a #!/bin/bash shebang that fails the 'all' target build
(not able to execute dart2js since the interpreter is not found).
Solve the issue by using #!/usr/bin/env as the shebang. For scripts
that need to pass arguments to bash modify the script to use the set
command as the first executed line of shell.
BUG=
R=whesse@google.com
Review URL: https://codereview.chromium.org/1552313002 .
2016-01-05 16:26:28 +01:00
e1c6faceb5
Issue 25316. Quick Fix for removing 'final' keyword.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25316
Review URL: https://codereview.chromium.org/1545323002 .
2015-12-27 13:19:41 -08:00
78ae012d2d
Issue 25313. Skip constructor names and named expressions.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25313
Review URL: https://codereview.chromium.org/1547113002 .
2015-12-27 12:05:05 -08:00
e13a49fdfa
(TBR) "fix" test_no_duplicate_notifications
...
Review URL: https://codereview.chromium.org/1542433002 .
2015-12-19 11:41:32 -05:00
e5bbeddf4d
completion performance measurement for local status page
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1536083002 .
2015-12-19 11:12:45 -05:00
43ee7b5bc9
move OpType into dart folder
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1523243006 .
2015-12-19 11:11:04 -05:00
99c3be6331
remove old completion API
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1536073002 .
2015-12-19 11:09:48 -05:00
48725225d3
stop caching state between completion requests
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1539943002 .
2015-12-18 10:53:16 -05:00
39d5abb662
remove internal streaming of results, remove obsolete test, cleanup unused code
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1538883003 .
2015-12-18 10:52:21 -05:00
1adabf4abc
remove extraneous classes and cleanup code
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1535643004 .
2015-12-18 08:53:39 -05:00
1f8eddcc21
Cache element docs (and add to completions) [ #23694 ].
...
This does away with the expensive call to `computeDocumentationComment` in favor of cached comments. Notably this makes adding doc content to code completion proposals performant (and so is done here). It should also make `dartdoc` *much* faster for doc generation since there are no more trips to disk to fetch comments for elements (still needed for source though).
For more on the desire for docs in completions see here: https://github.com/dart-lang/sdk/issues/23694
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1534043002 .
2015-12-17 21:07:42 -08:00
danrubel