0ee998b675
Replace 'throw fail()' with just 'fail()'.
...
I saw these new warnings after SDK update.
R=brianwilkerson@google.com
Change-Id: I0c8113404758918ee2edf3c3392d135f466a6da1
Reviewed-on: https://dart-review.googlesource.com/40420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-09 18:54:49 +00:00
a4ecc44c30
Completion protocol API for overrides.
...
Proposed API to allow IDEs to ask a suggestion for a displayText which may differ from the value to insert (the completion).
Also, adds a new OVERRIDE suggestion kind.
See: https://youtrack.jetbrains.com/issue/WEB-31130
Change-Id: Ic0644308d746ac7771bc27bc2ff2789444733af3
Reviewed-on: https://dart-review.googlesource.com/40101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-09 17:57:17 +00:00
59716fede1
New Quick Asists for Flutter: 'Replace with child' and 'Replace with children'.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/1283
Change-Id: Ic50de9739cdab5cd82649dcbd8370c5e728d2ee3
https://github.com/flutter/flutter-intellij/issues/1756
Reviewed-on: https://dart-review.googlesource.com/40240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2018-02-09 17:09:18 +00:00
330ad8d287
Fix for NPE when an argument does not correspond to a constructor parameter.
...
R=brianwilkerson@google.com
Change-Id: I97ba245398e4375e0e132cc3280db0357859e494
Reviewed-on: https://dart-review.googlesource.com/40104
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-08 21:38:57 +00:00
ffd67154f7
Add a new optional field - 'id' to SourceChange.
...
R=brianwilkerson@google.com
Change-Id: Ibe85415be35982327593ffd1187ec74b1d037463
Reviewed-on: https://dart-review.googlesource.com/40102
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-08 20:13:11 +00:00
87d73de98a
New Quick Assist 'Convert to StatefulWidget'.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/dart-lang/sdk/issues/31823
Change-Id: I0970a9f674f456cee20e96d4b3be3a4e3d577a8a
Reviewed-on: https://dart-review.googlesource.com/39921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-08 17:39:34 +00:00
07ceae4aea
Get libraries from the cache, the unit, or new.
...
Maybe later extract it into a caching wrapper around AnalysisSession?
R=brianwilkerson@google.com
Change-Id: I0f4c962467c6622bc558f7d9abd318024aec7945
Reviewed-on: https://dart-review.googlesource.com/39920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-08 05:05:40 +00:00
39448ff521
Improve creation of overriding methods (issues 30730 and 30759)
...
Change-Id: I96a06f6ad2646d4590804c2e5d8d7f6ab95dbd74
Reviewed-on: https://dart-review.googlesource.com/39844
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-07 22:16:00 +00:00
f3242f8533
Fix for some cases of indentation in 'Move widget up/down'.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/Dart-Code/Dart-Code/issues/495
Change-Id: I62c8374a1b7a578886bad1fec5a7c8eaf83cf231
Reviewed-on: https://dart-review.googlesource.com/39841
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-07 20:08:19 +00:00
6f78471687
New methods on Iterable, List, Set, Queue, Map.
...
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.
Change-Id: I7a12fea533d42b0fc8357086649df38ad01f3cdd
Reviewed-on: https://dart-review.googlesource.com/39140
Commit-Queue: Leaf Petersen <leafp@google.com >
Reviewed-by: William Hesse <whesse@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2018-02-07 06:12:53 +00:00
c9c9e10432
New quick assist to put selected widget(s) into new Column/Row.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: Idba133a70c3c8bfe8f88c7a58afbe909617d4292
Reviewed-on: https://dart-review.googlesource.com/39340
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-06 22:02:13 +00:00
cfa159ceb3
Wrap any Flutter widget expressions, not just instance creations.
...
Relanding https://dart-review.googlesource.com/c/sdk/+/38922 with all
changes.
Change-Id: I40b533521f420eccf2f4f86cf9e722ab498636e2
Reviewed-on: https://dart-review.googlesource.com/39201
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-06 18:20:13 +00:00
1d95d50192
Revert "Wrap any Flutter widget expressions, not just instance creations."
...
This reverts commit 9356382e6bbrianwilkerson@google.com , devoncarew@google.com
>
> Change-Id: Idc233251a3f5a62e47a0899c27f524537a3497d3
> Reviewed-on: https://dart-review.googlesource.com/38922
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
TBR=devoncarew@google.com ,scheglov@google.com ,brianwilkerson@google.com
Change-Id: I0b7c75802e328bc3ae7fdc4c2be6fab663bac570
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/39200
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-06 17:36:13 +00:00
9356382e6b
Wrap any Flutter widget expressions, not just instance creations.
...
So, we can wrap references to widgets, e.g. variables.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: Idc233251a3f5a62e47a0899c27f524537a3497d3
Reviewed-on: https://dart-review.googlesource.com/38922
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-06 17:35:34 +00:00
a0cfe5aa65
Fix more issues related to optional new and const
...
Change-Id: I0c1302c9b0505694853175f2b756c134e0caba19
Reviewed-on: https://dart-review.googlesource.com/38900
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
2018-02-06 16:10:53 +00:00
9c35cff5cd
Revert "New methods on Iterable, List, Set, Queue, Map."
...
This reverts commit 0b59f24f97https://luci-milo.appspot.com/buildbot/client.dart/dart2js-linux-d8-minified-1-5-be/9751
Original change's description:
> New methods on Iterable, List, Set, Queue, Map.
> Changes signature of Iterable.singleWhere.
> Makes LinkedHashMap no longer be a HashMap.
>
> Change-Id: Ibd7e56e1ac03cb9fb10d19d1328d452fcd06d89f
> Reviewed-on: https://dart-review.googlesource.com/32541
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
> Reviewed-by: Leaf Petersen <leafp@google.com >
TBR=lrn@google.com ,leafp@google.com
Change-Id: Iab904f5885a5213ae2e16ef496eed0b6843185f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/39060
Reviewed-by: William Hesse <whesse@google.com >
2018-02-06 13:32:19 +00:00
0b59f24f97
New methods on Iterable, List, Set, Queue, Map.
...
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.
Change-Id: Ibd7e56e1ac03cb9fb10d19d1328d452fcd06d89f
Reviewed-on: https://dart-review.googlesource.com/32541
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2018-02-06 11:17:46 +00:00
fb9b24a8cc
Shorted MethodInvocation as outline labels.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I9056b9116ad50b2d9cddc38895e17d53c010d934
Reviewed-on: https://dart-review.googlesource.com/38921
Reviewed-by: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-06 01:27:56 +00:00
60473b9ff9
Produce 'Convert into async function body' only when on a function header.
...
Practically everywhere aside the function body itself, because bodies
can be pretty long.
R=brianwilkerson@google.com
Change-Id: Ia3bbf4c196ce44a2972654512624b8171b394585
Reviewed-on: https://dart-review.googlesource.com/38880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-05 22:20:55 +00:00
8871ffbae1
Include generic label into Flutter outlines.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I98f96b38839bf339080144f2dc1f4f8dc9f3126f
Reviewed-on: https://dart-review.googlesource.com/38840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-05 20:46:27 +00:00
c16575c1f2
Issue 30884. Index MethodInvocation type arguments.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/30884
Change-Id: I0597d56d72fbff804ecf1a2f435815d02678eba6
Reviewed-on: https://dart-review.googlesource.com/38784
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-05 19:34:46 +00:00
740a0e751e
Rework part of DartChangeBuilder to deal better with type parameters (issue 31199)
...
Change-Id: I1946e6070c0dcffaa02f61b9c7f857168a050a27
Reviewed-on: https://dart-review.googlesource.com/38483
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-02-05 18:21:36 +00:00
1399a5f511
Sort required named params in protocol element parameter list.
...
See: https://github.com/flutter/flutter/issues/10219
I'm VERY open to other approaches. If you deem this too quick and dirty, consider it a conversation starter! :)
I was also a bit unsure of where best to test this so by all means let me know if it should go elsewhere.
Change-Id: Ic4a271d9db7597ae7ee72f5b60728968202f954e
Reviewed-on: https://dart-review.googlesource.com/38346
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-05 17:38:25 +00:00
c492dc1084
Add a test for issue 30884
...
Change-Id: I79c999965aa4dcdc49b94ea09f7863e75f2dc07e
Reviewed-on: https://dart-review.googlesource.com/38484
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-05 17:12:27 +00:00
65e6697cf8
Add 'Add padding' quick assist.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I03ed7ec1c25dd8e9ee7b115d95f24baeee016251
Reviewed-on: https://dart-review.googlesource.com/38341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-02 21:26:39 +00:00
fd6b8f772b
Increase analysis server version to 1.18.5.
...
The version hasn't been increased since the server started accepting overlays for HTML files (for angular plugin) so this is to allow editors to know for sure that the server supports them.
Closes #32034
https://github.com/dart-lang/sdk/pull/32034
GitOrigin-RevId: 82bef7be897a2fe30e1a01724c5284d6615d9a4a
Change-Id: Id5e8a12cd9a895cd1122ddf764d93fd6f7459aed
Reviewed-on: https://dart-review.googlesource.com/38260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-02 16:56:15 +00:00
fba13af5a9
Finish updating OverrideContributor to use DartChangeBuilder
...
Change-Id: Ib3190e6825994c9e727fb80a319cfc04be943b76
Reviewed-on: https://dart-review.googlesource.com/38143
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-02 16:19:37 +00:00
860a624410
New Quick Assist to wrap with Center.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I729501ba128d2b287e0731fa63c84864f7435d3c
Reviewed-on: https://dart-review.googlesource.com/38167
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-01 23:21:34 +00:00
0ff7348c7b
Switch tests to use Flutter package mock that more closely resembles the actual package structure.
...
So, we can test that "Wrap with Center" works when we ask for Center
in package:flutter/widgets.dart
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I3446f5cf97c1d6f2e68686de6561d894b5e95620
Reviewed-on: https://dart-review.googlesource.com/38162
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-01 22:12:06 +00:00
b0e5ff1a76
Add a test for a field rename that potentially conflicts with a parameter with null visible range.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/31497
Change-Id: I8293612a3dde1f794e871cf7b5a9384db3574c91
Reviewed-on: https://dart-review.googlesource.com/38100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-01 18:47:38 +00:00
0916cca7d2
Do not convert return type of enclosing function when adding async to nested closure (issue 30901)
...
Change-Id: I8293b7784f71d4ff7846a0cca6efbfa69847b7da
Reviewed-on: https://dart-review.googlesource.com/37646
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-01-30 21:57:10 +00:00
0bca64f57e
First draft on API change for support for implicit new and const in the InstanceCreationExpressionImpl class.
...
Change-Id: Id8df09456689a400957fec15b9f32b8f4f10bab1
Reviewed-on: https://dart-review.googlesource.com/37642
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2018-01-30 20:07:49 +00:00
0091dc986e
Add an assist to convert from sync function body to async
...
Change-Id: I2531c47354c76b7c4c2b16151abdcd135db21954
Reviewed-on: https://dart-review.googlesource.com/37221
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-01-29 18:07:13 +00:00
1c99838190
add quickfix for prefer_const_declarations
...
Closes #31993
https://github.com/dart-lang/sdk/pull/31993
GitOrigin-RevId: d1f51397639405d05e64022c5e41659d51c7d65c
Change-Id: Iefcf9556bd5f63b01f60df5437761bf277de4fd3
Reviewed-on: https://dart-review.googlesource.com/37301
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-01-29 16:49:23 +00:00
b44989cd57
Fix exception (issue 31922)
...
Change-Id: Id2d64ec1f92611e44b3c6e22c94efd1711b1a30e
Reviewed-on: https://dart-review.googlesource.com/37083
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-01-27 15:58:20 +00:00
8fbcf977e5
Replace license in generated files.
...
R=devoncarew@google.com
Change-Id: I7511c8da329eba760698a48abc0f8db16038b9ea
Reviewed-on: https://dart-review.googlesource.com/37127
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-01-27 03:18:18 +00:00
cb7e85a26d
Support void as a Top type, with as few other changes as possible.
...
Change-Id: Ife337e28fa86f9b98cdabf48a01a4e2f608aa4b8
Reviewed-on: https://dart-review.googlesource.com/35520
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2018-01-26 22:42:08 +00:00
f771476eec
Record variable name in FlutterOutline, fix for named attributes.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: Ie91b21f464eaa43d811d51e50f7a6b479406f9da
Reviewed-on: https://dart-review.googlesource.com/36980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-01-26 17:54:45 +00:00
32cfb6a9e3
Implement wrapping Widget into some single-child container.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: If6f393c0eb80ba2fb670eda19ff7dfde845e2f73
Reviewed-on: https://dart-review.googlesource.com/36780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-01-25 22:21:11 +00:00
6393a247fc
Add support for boolean/integer attributes.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I574931e558d45370c33a1d7626e17b5fb5e60480
Reviewed-on: https://dart-review.googlesource.com/36561
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-01-24 05:49:35 +00:00
402af4db46
Add a new experimental 'flutter' domain and move FLUTTER_OUTLINE there.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I8f829f10a630e38c5a3f1638d077e37832a08daa
Reviewed-on: https://dart-review.googlesource.com/36320
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-01-23 00:57:55 +00:00
19e6dfe2a9
Send FLUTTER_OUTLINE notification.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I6ba95137eee91ad52cc66b3cd0205411fd0aeaf5
Reviewed-on: https://dart-review.googlesource.com/36180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-01-22 05:26:59 +00:00
07367d05cd
Basic implementation of FlutterOutlineComputer.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I22c96c2a35c086814aace13f0121cc0361f3386f
Reviewed-on: https://dart-review.googlesource.com/36140
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-01-21 18:12:58 +00:00
0ef2f87f1c
Escape file overlay text before inserting it in the diagnostics pages (issue 31906)
...
Change-Id: I7e0f1b6724e624ef8c91b7a526d5e52332ce0fd5
Reviewed-on: https://dart-review.googlesource.com/35811
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-01-20 19:45:36 +00:00
4aadf7cf47
Provide additional information about plugins (issue 31951)
...
Change-Id: I2ba49e12471ae8747d83da25f4bfa912badac39e
Reviewed-on: https://dart-review.googlesource.com/36120
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-01-20 19:04:28 +00:00
a971aa8472
Add basic Flutter outline subscription/notification to the protocol.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I50d7e4507c58854b4f2afc6048285c68ee873b8b
Reviewed-on: https://dart-review.googlesource.com/36024
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-01-19 23:22:17 +00:00
74fc14dad7
Update args deps in analysis_server pubspec
...
Change-Id: I10090757fa7b6d776b9ab6948cdaee60ef4129c4
Reviewed-on: https://dart-review.googlesource.com/35802
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Zach Anderson <zra@google.com >
2018-01-18 22:16:44 +00:00
787d395389
Update code completion to suggest covariant
...
In addition to updating code completion, this also
addresses comments in https://dart-review.googlesource.com/c/sdk/+/34520
* Change expect to assert `}` where expect is unnecessary
* Extract skipToLastModifier utility method
* Fix spelling
Change-Id: I6a0446d77fac995da3e4d1d2f682f75d584b275f
Reviewed-on: https://dart-review.googlesource.com/34960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-01-17 03:30:23 +00:00
f99d3628d1
FrontEndCompiler that computes all information about many libraries at once.
...
Before we used a hack to request resolution information for a single
library as needed, and requested kernels separately. This was hugely
inefficient (but faster to implement as a steel thread). We had then
recompile large library cycles many times, and take just one library.
Before: 480 seconds to compile analyzer (ouch!).
Now: 16 seconds (30 times faster).
Without --previewDart2: 14 seconds.
I will check why it is still slower later.
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Ic3d47684daa74c53f0336523e17b656f26328acf
Reviewed-on: https://dart-review.googlesource.com/33144
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2018-01-09 07:05:54 +00:00
cd878bc433
Create the new flag --use-cfe in the analyzer, analysis server and analyzer_cli and migrate the old behavior of --preview-dart-2 to --use-cfe. The --preview-dart-2 flag is now a no-op, with functionality coming soon.
...
See https://github.com/dart-lang/sdk/issues/31640
Change-Id: I2db2e7ef6a324cbd5d369b807e331495fed167df
Reviewed-on: https://dart-review.googlesource.com/33121
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2018-01-08 22:37:05 +00:00
Konstantin Shcheglov