d66e6b1c6e
Fix refactoring tests on Windows
...
This hand-built JSON fails on Windows because the paths being inserted
only have a single slash ("C:\test.dart") but in the real results the
JSON is encoded correctly and hhas two paths.
This works around the issue by JSON-encoding the filename but really the
whole object should be serialised to JSON properly.
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I8aa418e8e3e6377ed01fe3bbecc3242f3a012629
Reviewed-on: https://dart-review.googlesource.com/42742
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-21 18:49:12 +00:00
358a8502fd
Fix UriContributorTests on Windows
...
See #32226 .
Change-Id: I685b0b5875001a56af5c3cf623fe9bca7261b478
Reviewed-on: https://dart-review.googlesource.com/42740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-21 17:56:59 +00:00
f1cdf5f9be
Fix up plugin/protocol_dart_test.dart for Windows paths
...
See #32226 .
Change-Id: I37362ba86188616dd1f0fd6623a62e05ee825454
Reviewed-on: https://dart-review.googlesource.com/42702
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-21 17:39:09 +00:00
20578644c0
Fix all remaining broken FixProcessorTest tests on Windows
...
See #32226 .
Change-Id: Idc80d0ac7441e1db8c0213093b9b79d4b3e70315
Reviewed-on: https://dart-review.googlesource.com/42700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-21 17:19:19 +00:00
be30b62e3d
Remove the Kernel type inference listener
...
We have decided to move to a different API for Fasta/Analyzer
integration, one that doesn't involve compiling to Kernel or observing
type inference. The listener API will become broken, so let's just
remove it before that happens.
We lose the ability to trace type inference so let's restore that
ability next. The analyzer's resolution storer is not used, but that
code has been left. The resolution applier will no longer work
without the resolution storer, so those tests have been disabled.
Change-Id: If9ac5aba2d5de7788d8a65f7fa8410599e636d21
Reviewed-on: https://dart-review.googlesource.com/42400
Commit-Queue: Kevin Millikin <kmillikin@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2018-02-21 16:28:07 +00:00
fa82626405
Implement 'search.getDeclarations'.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/29510
Change-Id: I8bf18a15bdc7a761614849cdb32ad9361238289b
Reviewed-on: https://dart-review.googlesource.com/42586
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-21 15:54:33 +00:00
40e3f9addc
Convert paths for mock SDK libraries to fix tests on Windows
...
The other lines on this method are calling `provider.convertPath` around their paths but these ones do not, which is causing almost all analysis server tests to fail on Windows (for me - I can't explain them not
failing builds). This causes the hard-coded paths like `/lib/core/core.dart` to be fixed up to `C:\lib\core\core.dart` which is what the server is looking for (because at the other end the paths *have* been fixed up).
See #32226 .
Closes #32230
https://github.com/dart-lang/sdk/pull/32230
GitOrigin-RevId: 1adeee23f8ac8efc8acf61caf5f769e4ec44c030
Change-Id: Id9bf195967db0912c6f4b67bd79d504e627b8aab
Reviewed-on: https://dart-review.googlesource.com/42300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-20 18:55:38 +00:00
ed88a91f62
Generate an import fix when an undefined function might be a constructor invocation
...
Change-Id: I1cc98cb14d66db6b241e2a5b008f45881c41d13b
Reviewed-on: https://dart-review.googlesource.com/42340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-19 22:03:22 +00:00
ded8dd2ad3
Don't add explicit 'new' when previewDart2.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/dart-lang/sdk/issues/32175
Change-Id: I05c5845a6e511698833045f99716231974e57b61
Reviewed-on: https://dart-review.googlesource.com/42320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-19 19:51:44 +00:00
8fa5567edb
API for search.getElementDeclarations.
...
The goal is to provide clients (specifically VS Code) with API that
is fast, and can search top-level and class member declarations.
I'm not sure whether we want ElementKind, it has kinds that we will
not use, e.g. I don't think we will return local variables or
parameters.
It would be probably still a lot of information, maybe we should use
single string table in response?
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/29510
Change-Id: Ie31bb398a08d462c1cb08c7d82c4443c0c09932a
Reviewed-on: https://dart-review.googlesource.com/42105
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-17 04:27:52 +00:00
b48c12a000
Use the selection computed by the builder in the override contributor
...
Change-Id: I85b7700bc137388d878c66282660df0d4b8d95af
Reviewed-on: https://dart-review.googlesource.com/42100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-16 20:52:52 +00:00
a412f24e41
Add tests for highlighting implicit instance creation.
...
And in general run analysis server tests with `previewDart2 = true`.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I063d667e96a46d60d3b10aa1a87b4c7a7d2252e5
Reviewed-on: https://dart-review.googlesource.com/42101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-16 20:52:01 +00:00
b17ac68b60
Add <Widget> type arguments for wrapping with Column/Row.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I6e8ee33c453e552965d14ecb95391eb55b7b0bc6
Reviewed-on: https://dart-review.googlesource.com/42025
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-16 18:45:17 +00:00
6790cc30ef
Highlight class names in instance creations as constructors.
...
This is needed for better highlighting optional new/const. I think the
main reason is that 'new' is highlighed and we knew that this is a
new instance creation. Constructors are also highlighed in the default
color scheme. But class names are not. So, to make code look colorful
again, we need to highlight class names in instance creations.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I8fde0b4aa5243e94d7ba575a74d52d31d3b665bb
Reviewed-on: https://dart-review.googlesource.com/42021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-16 17:50:27 +00:00
0501c740ac
Member overrides invoke the overridden member and the display label uses ellipses
...
Change-Id: I9cb2db1514a8a2798cb3ec69d3d71047573a8dd4
Reviewed-on: https://dart-review.googlesource.com/41903
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2018-02-16 14:12:27 +00:00
3dd7eae4c8
Add @required prefix to required params.
...
See: https://github.com/flutter/flutter/issues/10219
Change-Id: If8bd55b5a3557f8c49430079b790727f7ba25217
Reviewed-on: https://dart-review.googlesource.com/41924
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-16 00:13:30 +00:00
4039224d5c
Don't set the exit position for Flutter Quick Assists.
...
We decided that we don't want to move caret under the user.
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/dart-lang/sdk/issues/32184
Change-Id: I86199bb060fbbbb8e521572d046b3fcdef80f74d
Reviewed-on: https://dart-review.googlesource.com/41920
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2018-02-15 23:54:06 +00:00
7d0877dbf6
Remove unused methods in assist/fix tests.
...
R=brianwilkerson@google.com
Change-Id: I6aa5ef067bb3cee4cbd8ffc01bf60bf0637f773e
Reviewed-on: https://dart-review.googlesource.com/41880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-15 19:13:35 +00:00
1e999ed9fe
It is OK to inline Column with a single item in 'children' into a 'child'.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: Ifa2a300b2735ab635bbaeeee08ce21ad8a7db9b7
Reviewed-on: https://dart-review.googlesource.com/41901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-15 18:25:57 +00:00
95f336a667
Don't suggest imports of private libraries from other packages.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/1661
Change-Id: I5e458e8815d4f8df3e2f22bdfdc21c7203cefde0
Reviewed-on: https://dart-review.googlesource.com/41620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-15 17:11:56 +00:00
85973b9a54
Simplify analysis server's excluded file handling
...
Change-Id: I30bc19e7c185cb3dffbe5b84d0bd3f7b5b6f585b
Reviewed-on: https://dart-review.googlesource.com/41562
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2018-02-14 22:25:54 +00:00
425e07d721
If selection in 'Extract Method' does not cover any node, extract the smallest covering expression.
...
Two comments.
1. We need also to change the Dart plugin for IntelliJ to not select
the whole line when selection if empty. The whole line is almost
never a good choice for Flutter.
2. This is not fully consistent with "Extract Lolal" where we give the
client the list of possible expressions to extract and the user can
then choose. Here we use just the smallest one. If we want to make
it consistent, we will need to enchance the protocol and the plugin.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I87a752234d9c825d78a6d787d2b21d1b252166c2
Reviewed-on: https://dart-review.googlesource.com/41520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-14 20:43:13 +00:00
be4040214c
Enable @override completion contributions.
...
See: https://github.com/flutter/flutter-intellij/issues/1110
Change-Id: Iaddb5e9818f737889a484f562febcb4ca72d1017
Reviewed-on: https://dart-review.googlesource.com/41483
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-14 20:23:59 +00:00
b5cb793fbd
Convert unresolved 'children:' into 'child:'.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I3ea3f8a8be2e942a3fd00060519a7dbfeae6fb36
Reviewed-on: https://dart-review.googlesource.com/41481
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-14 20:23:43 +00:00
4232ac99e8
Fix for surround-with linked edit positions.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/32106
Change-Id: Ia899171aa38dd1283b72cdd100a0f5b678e9b565
Reviewed-on: https://dart-review.googlesource.com/41420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-14 18:55:33 +00:00
7579c58fad
Rename 'Add widget padding' to 'Add padding'.
...
Change-Id: I9483e4ed3abe5ccad000b04ed7fe1098ac977e90
Reviewed-on: https://dart-review.googlesource.com/41320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-02-14 16:50:53 +00:00
421db9c69c
Re-land "Implement proper checking for callability of Function class."
...
(was reverted in https://dart-review.googlesource.com/c/sdk/+/40980
due to an analyzer bot breakage)
Original commit message:
Implement proper checking for callability of Function class.
There was some old (incorrect) logic for doing this, behind the flag
enableStrictCallChecks. This flag has been removed, since the new
behavior is now standard in Dart 2.0.
Fixes #31509
Change-Id: Ice5cf38bbc648badf7f2563ff930b69f9a799635
Reviewed-on: https://dart-review.googlesource.com/41120
Reviewed-by: Jonas Termansen <sortie@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-02-14 11:30:23 +00:00
4749057586
Don't suggest converting unresolved 'child:' to 'children:'.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/841
Change-Id: Ib16b8a1e28e18cec9fd30a2f7d364355ce70b757
Reviewed-on: https://dart-review.googlesource.com/41060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-13 23:30:51 +00:00
51eb30dbba
New Quick Assists 'Move widget down/up'.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/1638
Change-Id: I84dd60d30409fde430bb9ba3eb794c3c404d66b1
Reviewed-on: https://dart-review.googlesource.com/41023
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-13 23:01:41 +00:00
f2e063c35e
Selection range calculation for override completions.
...
Change-Id: If3a56c6b5274d5615742ded1ab213918331f4a0c
Reviewed-on: https://dart-review.googlesource.com/41021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-13 22:44:13 +00:00
83840eef9b
Suggest 'Convert to children:' only when on 'child:'.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/dart-lang/sdk/issues/32135#issuecomment-365367458
Change-Id: I3891409c1fc1ae9cc4cc8731c1c452be9cba66ea
Reviewed-on: https://dart-review.googlesource.com/40960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-13 21:49:19 +00:00
ff6347e448
Rename 'Replace with children' to 'Remove widget'.
...
R=devoncarew@google.com
Bug: https://github.com/dart-lang/sdk/issues/32135#issuecomment-365377923
Change-Id: I9da2c04590a32a28d109d7722df137e1a31712d1
Reviewed-on: https://dart-review.googlesource.com/40961
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2018-02-13 20:10:19 +00:00
35aea15097
Revert "Implement proper checking for callability of Function class."
...
This reverts commit 6837dafcc3Fixes #31509
>
> Change-Id: I4a6da34a4b85ea8409f6e0d14c377a586546056a
> Reviewed-on: https://dart-review.googlesource.com/40509
> Commit-Queue: Paul Berry <paulberry@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
> Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
TBR=paulberry@google.com ,scheglov@google.com ,brianwilkerson@google.com ,mfairhurst@google.com
Change-Id: Ib631ad16bc5e937ff914127d1c5330f3fcaff2c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/40980
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-02-13 19:56:35 +00:00
35221ce1fc
Override completion displayText implementation.
...
Change-Id: If19ccb00145ec4befec2be575af48709f122b511
Reviewed-on: https://dart-review.googlesource.com/40510
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-13 19:15:26 +00:00
fdeadfd7e9
Don't suggest to center the Center widget.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/dart-lang/sdk/issues/32135
Change-Id: Ic6ab36a2ad5ac9b7737383700a0513feee4f3946
Reviewed-on: https://dart-review.googlesource.com/40920
Reviewed-by: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-13 18:46:44 +00:00
2cd992663e
Sort assists and fixes by relevance and then by name.
...
We used to get away with sorting just by relevance because the order
of assists and fixes was correct. I think it is time to switch to
sorting. I still would like to keep 'Surround with XXX' ordered in
a specific way, so I'm changing relevance for these assists.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I77f77ec732d70b31c32164759a3ac62dc790e469
Reviewed-on: https://dart-review.googlesource.com/40880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-13 18:18:59 +00:00
6837dafcc3
Implement proper checking for callability of Function class.
...
There was some old (incorrect) logic for doing this, behind the flag
enableStrictCallChecks. This flag has been removed, since the new
behavior is now standard in Dart 2.0.
Fixes #31509
Change-Id: I4a6da34a4b85ea8409f6e0d14c377a586546056a
Reviewed-on: https://dart-review.googlesource.com/40509
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2018-02-13 14:19:08 +00:00
850ec64864
Add a fix to make const instance fields static (issue 32128)
...
Change-Id: I1ca5cbf95f28ed36133bd562d3b7ce6a58d19ce6
Reviewed-on: https://dart-review.googlesource.com/40640
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-02-12 23:40:08 +00:00
19500670b9
Rename Flutter assist constants to better reflect what they are doing.
...
Particularly that "reparent" is "wrap", and "move up/down" is "swap".
R=brianwilkerson@google.com
Change-Id: Ie6fcaa178e41a161061f05b81a8b1cff506b0714
Reviewed-on: https://dart-review.googlesource.com/40620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-12 22:26:29 +00:00
c1d5d843af
Add identifiers for Quick Assists.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I07cd18ae38f98793f960a2c7bd971527eaa6d7d6
Reviewed-on: https://dart-review.googlesource.com/40140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-12 20:56:09 +00:00
223eeb2ebe
Always shorten function expressions, list/map literals, multiline values.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/1762
Change-Id: I742ac6cb0ebbdde78f1326c5e07775d94e335d42
Reviewed-on: https://dart-review.googlesource.com/40560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-12 19:15:05 +00:00
356064c716
Add an assist to convert from an in-line function type to a generic function type
...
Change-Id: I1277283df593c96f37c90a90f923ded12cb331a2
Reviewed-on: https://dart-review.googlesource.com/40503
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-02-12 16:58:32 +00:00
7cffd55c41
Don't suggest anything right after double or integer literals.
...
R=brianwilkerson@google.com , danrubel@google.com
Change-Id: Ib8b9091daedb1e1921ae3c454e83a5b96d94a71a
Reviewed-on: https://dart-review.googlesource.com/40471
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2018-02-12 01:18:35 +00:00
456890cd2c
Enable completion in AssertInitializer.
...
R=brianwilkerson@google.com , danrubel@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/1101
Change-Id: Id17a701cac0e98afc373cf89089916cf5f983cff
Reviewed-on: https://dart-review.googlesource.com/40472
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-12 01:01:31 +00:00
ad11e5d615
Re-generate Server APIs.
...
Previous change only updated the plugin; this catches up server.
Follow-up from: https://github.com/dart-lang/sdk/commit/bea00e5bb346918cb316febf2434c70176edf649
Change-Id: Iae2ec340ffe528d76c53198322d691320f507852
Reviewed-on: https://dart-review.googlesource.com/40501
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-11 18:28:27 +00:00
06614a7b19
Proposed API for optionally building override cc displayText.
...
Change-Id: Ic3ea3317da1220c7d396348ae93e40ab672ecc59
Reviewed-on: https://dart-review.googlesource.com/40500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-11 18:01:13 +00:00
3ed7f2601f
Pass the --preview-dart-2 flag to the analysis server.
...
Change-Id: I3b63a63ea26e09cd4e5b84c3933f0f4f6ddc2440
Reviewed-on: https://dart-review.googlesource.com/40465
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-02-09 21:02:39 +00:00
befb4f943a
Check that the declaration with unimplemented members is ClassDeclaration (not ClassTypeAlias).
...
Another exception from logs.
R=brianwilkerson@google.com
Change-Id: I87ee5a7ad9c7171b23714a23f8ee861688bbf331
Reviewed-on: https://dart-review.googlesource.com/40467
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-09 20:41:39 +00:00
94d8d6bf3b
Remove unnecessary cast and wrapping Future.
...
R=brianwilkerson@google.com
Change-Id: I7b164019e55274c58f13fc67d0dc92e47f01aad7
Reviewed-on: https://dart-review.googlesource.com/40466
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-09 20:25:19 +00:00
49686f7ffa
Don't insert a trailing comma after a missing required argument, when there is on already.
...
R=brianwilkerson@google.com
Change-Id: I47819c9d2698880f793de2e3c056e1112b1b8f57
Reviewed-on: https://dart-review.googlesource.com/40402
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-09 19:01:49 +00:00
Danny Tuppeny