Commit Graph

2966 Commits

Author SHA1 Message Date
Konstantin Shcheglov 594fe93422 Support for NAVIGATION/OCCURRENCES notifications for any source (such as HTML).
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1343283004 .
2015-09-17 12:37:36 -07:00
danrubel b96b1cfc5d Add defaultCompletionSorter allowing sorting to be overridden - fixes #24339
I will convert CompletionSorter to use the new completion API in a subsequent CL.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1353913002 .
2015-09-17 14:59:48 -04:00
Konstantin Shcheglov 75600fc162 Report UNRESOLVED_INSTANCE_MEMBER_REFERENCE for dynamicVar.member references.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1345943006 .
2015-09-17 10:37:04 -07:00
Brian Wilkerson 1a6daab9d1 Wrap the http server start-up in an exception handler
R=devoncarew@google.com

Review URL: https://codereview.chromium.org//1349263002 .
2015-09-17 10:15:38 -07:00
Konstantin Shcheglov a01281370b Fix for dynamic instance field reference highlighting.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1349223002 .
2015-09-17 09:25:22 -07:00
Konstantin Shcheglov d71bda7c05 Highlight library identifiers as LIBRARY_NAME.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1352843002 .
2015-09-17 09:24:14 -07:00
Brian Wilkerson b233ab26ad Remove unused setter from ServerStarter and un-deprecate a used setter
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1341343002 .
2015-09-15 09:38:56 -07:00
Konstantin Shcheglov cf88943a10 Issue 24338. Don't propose creating a local class for prefixed identifiers.
Importing with prefix would take more time than I'd like to spend now.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1336323003 .
2015-09-14 08:17:18 -07:00
Konstantin Shcheglov e4b7c93961 Merge occurrences.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1338153002 .
2015-09-14 08:10:02 -07:00
Konstantin Shcheglov ef2fc0d778 Add OCCURRENCES_CONTRIBUTOR_EXTENSION_POINT_ID.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1337143002 .
2015-09-11 13:59:28 -07:00
pq 5441e21750 Fixed server plugin status reporting.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1336733003 .
2015-09-11 08:55:15 -07:00
Lasse R.H. Nielsen 931e41777e Merge pull request #24236 from a14n/use-const
use const constructors of Utf8* at several places
2015-09-11 12:26:27 +02:00
Konstantin Shcheglov d13a9ec666 Rename NavigationHolder to NavigationCollector.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1307663007 .
2015-09-09 13:27:24 -07:00
Konstantin Shcheglov cfc52cfbbf Make NavigationOperation a MergeableOperation.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1327173002 .
2015-09-09 11:01:01 -07:00
Konstantin Shcheglov 0e6eec7968 Make navigation notification operation Source based, without Dart knowledge.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1307143004 .
2015-09-09 10:02:12 -07:00
Brian Wilkerson 42d1d4532d Reformat code to minimize churn
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1310263003 .
2015-09-09 08:19:18 -07:00
Konstantin Shcheglov c67b274852 Explicitly document that NavigationRegion.targets cannot be empty.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1328273002 .
2015-09-08 13:16:43 -07:00
Paul Berry b39928e01d Ignore non-existent analysis roots.
Fixes #24242.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//1316753003 .
2015-09-08 05:36:30 -07:00
Konstantin Shcheglov f0cbf430e0 Issue 24298. Fix for 'async' function body conversion.
R=paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/24298

Review URL: https://codereview.chromium.org//1324323004 .
2015-09-04 21:39:28 -07:00
Konstantin Shcheglov 9263610196 Sort navigation regions after gathering results from all of the contributors.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1323243008 .
2015-09-04 17:06:44 -07:00
Konstantin Shcheglov dfd09f3f66 Extension point for AnalysisResultListener(s).
The plan is that plugins will listen for computed results. For example the Angular
plugin will listen for DART_TEMPLATES and once it sees one, it will schedule
sending the navigation notification, because now the other extension - NavigationContributor
can produce its navigation regions.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1303343008 .
2015-09-04 09:56:27 -07:00
Konstantin Shcheglov 13d5a4744d Support for 'superOnly' in 'search.getTypeHierarchy'.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1322323005 .
2015-09-03 14:29:48 -07:00
Konstantin Shcheglov 58f5005cb1 Add the optional 'superOnly' request parameter for 'search.getTypeHierarchy'.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1325543006 .
2015-09-03 13:03:01 -07:00
Konstantin Shcheglov e090ff872e Issue 24277. Use node's offset as the source range start for the first unit node in Outline.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24277

Review URL: https://codereview.chromium.org//1325143003 .
2015-09-02 17:55:15 -07:00
Konstantin Shcheglov bb6a4b2fd8 Better message for Rename refactoring changes.
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1319663008 .
2015-09-02 15:14:05 -07:00
Konstantin Shcheglov b15a031276 Navigation extension point.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1303033010 .
2015-09-01 13:06:25 -07:00
danrubel 07184f6cdd rename ImportUriContributor to UriContributor
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1329463002 .
2015-09-01 11:11:36 -04:00
danrubel 773c3cf9d1 improve import uri completions - fixes #24000
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1325583002 .
2015-08-31 15:21:34 -04:00
Alexandre Ardhuin 0784fc3134 use const constructors of Utf8* 2015-08-29 22:44:28 +02:00
Dan Rubel c0fe214c47 show all available import completion suggestions - fixes #23955
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1317023002 .
2015-08-26 17:37:01 -04:00
Dan Rubel bd95b13b90 improve keyword suggestions - fixes #24016
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1303233008 .
2015-08-26 17:34:57 -04:00
Brian Wilkerson c3b12a65ba Add a task to partially resolve a compilation unit
R=leafp@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1321523002 .
2015-08-26 11:22:03 -07:00
Dan Rubel f61faa2fbd exclude instance suggestions in static context - fixes #22932
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1319753002 .
2015-08-26 14:00:03 -04:00
Brian Wilkerson 271bc1f776 Convert completion API to be future based
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1318543002 .
2015-08-25 11:01:13 -07:00
Brian Wilkerson 4bd6b4b048 Fix display of parameter lists in servers Element structure (issue 24194)
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1313113002 .
2015-08-25 09:23:26 -07:00
Konstantin Shcheglov aea1e572a1 Sort top-level constants before other top-level variables.
R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//1306083003 .
2015-08-21 12:19:48 -07:00
Paul Berry 03a156c891 Plumb "enableSuperMixins" option through analysis server (implements DEP 34).
Partially addresses #23772.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1301533003 .
2015-08-20 09:47:26 -07:00
Konstantin Shcheglov 7e99b8696e Support for analysis.setPriorityFiles for files in SDK.
R=brianwilkerson@google.com
BUG= https://github.com/dart-atom/dartlang/issues/215

Review URL: https://codereview.chromium.org//1289643003 .
2015-08-17 10:48:38 -07:00
danrubel 9af696a4f7 suggest prefixed constructors - fixes #23210
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1291283002 .
2015-08-14 20:33:12 -04:00
John McCutchan 67a7aeaf12 Add _sdkext support back to analysis server
BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1295463003 .
2015-08-13 12:24:37 -07:00
Konstantin Shcheglov 7ab954efb5 Remove debug output in getNavigation().
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1288163003 .
2015-08-12 14:02:07 -07:00
Konstantin Shcheglov e9d2f739ad More tweaks in attempt to debug the reason of failing getNavigation() tests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1284933002 .
2015-08-11 11:13:48 -07:00
Konstantin Shcheglov e6702099e6 Add debug output for getNavigation().
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1276883004 .
2015-08-11 09:15:28 -07:00
Konstantin Shcheglov 089f84f6cd Keep only unique overridden elements.
If the implemented interfaces don't declare an element, keep only a single copy of the element - from the superclass.

In Dart Editor we use any element, but in in IDEA we show all of them, and we don't want to have duplicates.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1273003005 .
2015-08-10 16:13:43 -07:00
Brian Wilkerson 97225c3a21 Possible fix for Windows bot failures
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1275503003 .
2015-08-10 13:10:08 -07:00
Paul Berry f3f52d4b59 Fix regression in import fixups introduced by .packages support.
With the introduction of support for ".packages" files, analysis
server now uses a slightly different code path for translating the
Source objects from imported package files into "package:" URI's.
Previously it used PackageUriResolver.resolveAbsolute(); now it uses
ResourceUriResolver.resolveAbsolute(), and then translates the
resulting file: URI to a package: URI uring the .packages file.

The old code path used Source.fullName (the file path) to locate the
file in the filesystem; the new code path uses Source.uri.  This
causes problems because when figuring out the correct import statement
to insert, the analysis server creates a bogus Source object whose uri
field is null.  As a result, import fixups were getting relative paths
like "../../../../.pub-cache/..." rather than package imports, which
is clearly wrong.

As a short term non-invasive fix, we set Source.uri in the bogus
Source object, so that the new codepath is able to find the path of
the imported file.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1281313002 .
2015-08-10 12:14:26 -07:00
Konstantin Shcheglov c48cc7b913 Check for reset during 'await' in refactoring manager.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1281983002 .
2015-08-10 11:19:03 -07:00
danrubel 07d94ad596 fix completion after dot-keyword - fixes #23882
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1273773005 .
2015-08-10 11:11:51 -04:00
danrubel 3bbf03ba7b suggest "in" in for statement
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1285573003 .
2015-08-10 10:43:27 -04:00
danrubel f79d02ddd0 remove complex keyword suggestions - fixes #23978
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1280313002 .
2015-08-10 10:09:18 -04:00