cbea0dedf9
Issue 24714. Check other libraries that define unresolved class.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24714
Review URL: https://codereview.chromium.org/1413973007 .
2015-10-26 11:32:59 -07:00
15c9636924
Backed out validator registration.
...
Net-net: this bakes in an (unsafe in tests) assumption that the options plugin has been contributed and registered.
Backing out pending a revisit.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1411313005 .
2015-10-26 09:46:09 -07:00
68dc36a3e7
OptionsValidator plugin extension and linter service.
...
* Adds a new extension point to allow for contributing OptionsValidators.
* Adds a new linter 'service' to server that contributes a lint-aware validator.
You'll notice that the warning code I added is NOT in `errors.dart`. I did that in anticipation of plugin-specifc warnings living elsewhere. If that's not the right angle, happy to un-do!
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1418333002 .
2015-10-26 08:50:55 -07:00
289bd0a056
[Atom] Issue 424. Fix for 'getNavigation' and index expressions.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-atom/dartlang/issues/424
Review URL: https://codereview.chromium.org/1402353009 .
2015-10-25 11:29:54 -07:00
c43f292dd9
Remove IMPORT_EXPORT_SOURCE_CLOSURE and IS_CLIENT results.
...
This improves warm VM analysis time (i.e. 99% of all analyzis that happens in IDEs) from 7200 ms to 6600 ms.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1417143003 .
2015-10-24 08:35:26 -07:00
df580cf0ea
WorkItem detail diagnostics.
...
R=keertip@google.com
Review URL: https://codereview.chromium.org/1418323002 .
2015-10-23 14:48:24 -07:00
c133bf9467
add work item info to context status page
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1415503006 .
2015-10-23 13:27:10 -07:00
33e6b737e8
enable analysis server cmdline instrumentation log file option
...
this change allows instrumentation to be logged to a file that is specified on the command line when analysis server is started for both internal and external builds of the analysis server
R=lukechurch@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1413563009 .
2015-10-23 15:47:09 -04:00
5bd191ee12
fix import uri completion exception - fixes #24709
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1418123004 .
2015-10-23 14:55:20 -04:00
d12abed5d7
Last performed task diagnostics.
...
Adds a new block of status that reports the last 10 performed tasks.
For example:
<p>Recent Tasks</p>
GatherUsedLocalElementsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart
GatherUsedImportedElementsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart
GenerateHintsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart
GenerateLintsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart
VerifyUnitTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart
LibraryUnitErrorsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart
DartErrorsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart
LibraryErrorsReadyTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart
GetContentTask for source /Users/pquitslund/src/git/clones/analyzer_cli/.analysis_options
GenerateOptionsErrorsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/.analysis_options
R=brianwilkerson@google.com , keertip@google.com
Review URL: https://codereview.chromium.org/1420783004 .
2015-10-23 10:31:26 -07:00
07acac8b8e
Compute and display tasks input timings.
...
It's not perfectly useful - it computes just cumulative timings.
So, it includes not just time for extracting and gathering inputs, but also actual time to compute them.
But it is still useful to compare between runs after changes to tasks inputs, because computing time
should be the same, so the difference is this extracting/gathering time.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1406983007 .
2015-10-23 09:38:24 -07:00
f45c8bc917
add logging code to track unexpected situation - fixes #24630
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1412423006 .
2015-10-22 13:06:58 -04:00
6726ac5ccd
fix completion exception - fixes #24630
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1418093003 .
2015-10-22 10:14:02 -04:00
4e5938f373
Completion exceptions are never fatal.
...
Actually only some methods of the 'edit' domain are potentially fatal.
Alternative solutions:
1. Don't make anything fatal.
2. Add areExceptionsFatal to RequestHandler.
3. Let every domain to decide whether exceptions in some method or none of them are fatal.
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org/1404353007 .
2015-10-21 20:26:46 -07:00
f18a0209fb
Fix for 'Assign to Local Variable' in closures.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1415253002 .
2015-10-21 13:20:22 -07:00
6c85fe785a
Analysis Options error notifications.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1411013003 .
2015-10-21 09:59:19 -07:00
c7907e7800
Support for searching files by import/export/part URIs and library identifiers.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1417483006 .
2015-10-20 08:52:02 -07:00
5f71b2e7cd
Check that AnalysisContext is not null.
...
I guess this happens when a "resolved" CompilationUnit is not actially resolved.
I don't know why we get such units, but I saw this situation twice in IDEA.
So, probably we need to fix at least throwing NPE here.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1418513002 .
2015-10-19 13:27:50 -07:00
5e9ea82aa4
Issue 24612. Skip excluded folder during contexts creation.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24612
Review URL: https://codereview.chromium.org/1411393003 .
2015-10-19 13:17:11 -07:00
ea947094ae
Fix for suggesting methods as a *name* of a local variable declaration.
...
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org/1417603002 .
2015-10-19 12:29:22 -07:00
efc1d4b224
Ignore contexts in folders named 'packages' or starting with dot.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24614
Review URL: https://codereview.chromium.org/1415713002 .
2015-10-19 11:59:11 -07:00
e0636b183c
Make IndexableObjectKind parameterized.
...
LMK if this is a bad change.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1413563004 .
2015-10-19 10:13:43 -07:00
f80bd4203d
Index Dart CompilationUnit(s) with the correct context.
...
We should use the context that they belong to, not the context that we got them through.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1410983003 .
2015-10-19 09:59:58 -07:00
140a4f5891
Register .analysis_options files for analysis.
...
Some oportunistic constant cleanup as well (follow-up from: https://codereview.chromium.org/1399893004/ ).
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1412213003 .
2015-10-19 09:46:54 -07:00
27eb09033f
Clean up wording of client usage expectations
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org/1409353002 .
2015-10-19 07:46:49 -07:00
3b198ed6ae
Disable completion of formal parameter names as *types*.
...
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org/1414653002 .
2015-10-18 13:28:12 -07:00
af4fbdd952
Index library/part file references from import/export/part containing files.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1407863004 .
2015-10-18 10:24:53 -07:00
67576340b0
Declare IndexableObject.file instead of Source.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1409203002 .
2015-10-16 14:43:49 -07:00
adb8ebd0e6
Remove obsolete flag to enable package support
...
R=pquitslund@google.com
Review URL: https://codereview.chromium.org/1411833002 .
2015-10-16 13:43:00 -07:00
3825cf0cd4
Add an experimental domain
...
R=paulberry@google.com , pquitslund@google.com
Review URL: https://codereview.chromium.org/1412683002 .
2015-10-16 12:56:13 -07:00
ce6614f2dc
Disable completion in comment text.
...
It drives me nuts when I try to type some text and IDEA replaces my words with some random identifies.
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org/1410893002 .
2015-10-16 10:38:47 -07:00
a30bcd7b97
Issue 24599. Fix for requesting navigation for directives.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24599
Review URL: https://codereview.chromium.org/1405033002 .
2015-10-15 10:54:06 -07:00
cae05d6bd4
Context invalidation on option changes (Implements #24574 ).
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1399893004 .
2015-10-14 20:42:50 -07:00
6bce9b2373
One extension manager (to bind them all).
...
TL;DR Moves all plugin registration to AE's extension manager.
The rub is that plugin registration wasn't happening right which cropped up in integration testing. Included is a test that verifies that options are getting properly threaded through to the linter. (This test failed when we had two Extension Managers.)
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1398033004 .
2015-10-13 16:37:42 -07:00
e5f3bb163b
AS strong-mode .analysis_options awareness.
...
R=brianwilkerson@google.com , leafp@google.com
Review URL: https://codereview.chromium.org/1403983002 .
2015-10-13 13:22:49 -07:00
4ca8a3f19b
Strong mode checker integration. This integrates jmesserly's CL, and adds a task for computing strong mode errors and an annotated unit.
...
BUG=
R=brianwilkerson@google.com , jmesserly@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1396273004 .
2015-10-13 10:16:35 -07:00
9913f33522
Stop looking for overrides once the pivot element reached.
...
See also https://github.com/dart-lang/sdk/issues/21804 for the original motivation.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1396053003 .
2015-10-13 08:24:16 -07:00
586a1f359a
Fix for renaming (an invalid) ClassElement invocation.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1385403007 .
2015-10-12 12:21:12 -07:00
2bbb40d0e2
Warn about conflict before renamed class member and enclosing class name.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1398213004 .
2015-10-12 12:10:12 -07:00
307438d582
Return 'null' rename refactoring in case of a null element.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1397403002 .
2015-10-12 10:44:31 -07:00
78da03cd97
Extract protocol_dart.dart APIs.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1398333002 .
2015-10-12 06:58:34 -07:00
9ad256cf18
Move the wire protocol support into the public API
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1398293002 .
2015-10-11 07:34:28 -07:00
695256d586
Linter hookup into AS.
...
Note the TODO to fix the extension manager interaction hijinx. Really we should ensure that we are only using the one in engine. At the moment, it's easy to get this wrong (as the initialization heroics herein testify).
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1392683003 .
2015-10-09 13:40:07 -07:00
8f4c63c92b
Restructure the public API for server
...
R=danrubel@google.com , paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1392253002 .
2015-10-09 07:57:00 -07:00
abfa9bf46a
Move getCamelWords() to the strings.dart file.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1394933003 .
2015-10-08 21:31:27 -07:00
d6d2e6f3c6
Options plugin initialization fix.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1400473004 .
2015-10-08 14:52:42 -07:00
e292918cff
Back out options plugin notifications.
...
Pending investigation of AbstractContextManagerTest failures.
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1393383002 .
2015-10-08 12:53:43 -07:00
b4091099be
Fix DAS, use all the Analyzer plugins.
...
R=pquitslund@google.com
BUG=
Review URL: https://codereview.chromium.org/1398803002 .
2015-10-08 12:35:21 -07:00
e19f10fbec
Add context to OptionsProcessor callback API.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1392143002 .
2015-10-08 10:47:06 -07:00
307612582b
Show UsedLocalElements and parts ASTs on the status pages.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1392173002 .
2015-10-07 21:41:17 -07:00
Konstantin Shcheglov