dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

2966 Commits

Author SHA1 Message Date
Brian Wilkerson 870d9196ee Add dependency information to the status pages 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1392863003 .
 2015-10-07 16:58:19 -07:00
Leaf Petersen 651221bb82 Resolve ordering issues. 
This CL changes the way that the task model does strong mode inference to use the strongly connected components in the import/export graph.  Library cycles are computed and inference is staged by forcing each stage of inference to happen across an entire library cycle at once, and to force all external dependencies of a library cycle to have completed inference before inference for the library cycle can begin.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1386023002 .
 2015-10-07 16:14:35 -07:00
Konstantin Shcheglov 63d8b70fce Add 'Add != null' quick fix. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24518

Review URL: https://codereview.chromium.org/1393953002 .
 2015-10-07 10:18:23 -07:00
pq fe76c6f3c4 Lint support for the new task model. 
Related bug: https://github.com/dart-lang/analyzer_cli/issues/64

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1385293002 .
 2015-10-06 16:45:45 -07:00
Paul Berry b76da2d61e Turn on the new task model by default in analysis server. 
The previous option for enabling the task
model ("--enable-new-task-model") is replaced with an option for
disabling it ("--disable-new-task-model").

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1390843002 .
 2015-10-06 13:49:52 -07:00
danrubel d14a963546 only send final completion notification 
This shaves 1 ms off the average completion notification response time

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1389473002 .
 2015-10-06 14:21:29 -04:00
Dan Rubel a96541b369 fix call to get current source - fixes #24509 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1385213002 .
 2015-10-06 13:36:28 -04:00
Konstantin Shcheglov b107dec41a Spec change: include covering expressions into Extract Local protocol. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1388783003 .
 2015-10-05 14:44:32 -07:00
Brian Wilkerson 8e523195e6 Move refactoring APIs into provisional 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1387703003 .
 2015-10-05 12:51:57 -07:00
Brian Wilkerson 7bbd8c66a5 Move completion APIs to private location 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1383313002 .
 2015-10-05 11:57:35 -07:00
pq 8697392367 AnalysisError hasFix attr (Implements #23874). 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1385523002 .
 2015-10-05 09:46:17 -07:00
Brian Wilkerson 04c5a5f199 Clean up hints 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1382403002 .
 2015-10-05 09:20:44 -07:00
Konstantin Shcheglov 147581cf34 Remove the 'name' and 'length' getters from IndexableObject. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1378843003 .
 2015-10-05 07:27:50 -07:00
Konstantin Shcheglov 0e7f4b5717 Fix hover documentation for parameters. 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1384583007 .
 2015-10-05 07:04:20 -07:00
Konstantin Shcheglov e6053aa135 Rollback https://codereview.chromium.org/1380223003 
TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1390463002 .
 2015-10-04 17:07:10 -07:00
Konstantin Shcheglov 1af7b154af Issue 23694. Include 'docSummary' and 'docComplete' into CompletionSuggestion. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23694

Review URL: https://codereview.chromium.org/1380223003 .
 2015-10-04 16:16:45 -07:00
Konstantin Shcheglov c06ad0db30 Issue 24420. Don't allow renaming in pub packages. 
There are no ideal solution for this.
But all our users want it somehow.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24420

Review URL: https://codereview.chromium.org/1380253003 .
 2015-10-02 13:09:55 -07:00
danrubel 04e21a2a7c Completions with exact prefix should be prioritized - fixes #23099 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1369033002 .
 2015-10-02 15:12:23 -04:00
danrubel 6e441f62e8 only suggest rethrow inside catch block - fixes #24214 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1360123003 .
 2015-10-02 15:10:14 -04:00
Konstantin Shcheglov 62fd9ac787 Issue 24487. Annotations with constructor resolution should produce navigation reginos to constructors. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24487

Review URL: https://codereview.chromium.org/1378713004 .
 2015-10-02 10:44:58 -07:00
danrubel 8eef458f9c add completion after export - fixes #24400 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1368173004 .
 2015-10-02 13:00:06 -04:00
danrubel a24ae72e74 suggest argument name completions for annotations - fixes #24296 and fixes #24259 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1362353003 .
 2015-10-02 12:54:22 -04:00
Konstantin Shcheglov 03e379de7a Compute Outline.kind/libraryName actually. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24279

Review URL: https://codereview.chromium.org/1380103005 .
 2015-10-01 13:09:38 -07:00
Konstantin Shcheglov 9d48af9ee3 Specification change for the 'libraryName' and 'partOfLibraryName' fields in Outline. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1375163003 .
 2015-10-01 09:53:20 -07:00
Konstantin Shcheglov 7beaf28f32 Always include Object and its members into 'inherited'. 
Analyzing them honestly is too expensive.

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//1375313004 .
 2015-09-30 18:23:53 -07:00
Konstantin Shcheglov db4e79b74d Issue 24459. Fix for 'Create Method' QF in different unit. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24459

Review URL: https://codereview.chromium.org//1375043004 .
 2015-09-29 21:29:07 -07:00
Paul Berry f9aebddc67 Ignore added files in hidden directories. 
In commit 6ddc37a5cc, the ContextManager
was modified to disable analysis of files in hidden directories,
provided those files existed prior to the creation of the context.
This CL extends the fix to apply also to files that are added after
context creation.

Fixes #24212.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1372173004 .
 2015-09-28 14:10:32 -07:00
Konstantin Shcheglov 5bc38481a7 Report a fatal error on attempt to rename an element declared in SDK. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1377623002 .
 2015-09-28 14:00:13 -07:00
danrubel 6cd9e0da71 Do not suggest static fields in constructor initializer - fixes #24256 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1365403002 .
 2015-09-26 11:59:15 +02:00
Konstantin Shcheglov 6bab7d9cbc Use Element.nameLength where possible. 
...or don't use it when there is a better alternative.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1372673003 .
 2015-09-25 15:03:46 -07:00
Konstantin Shcheglov 3924b15d85 Remove ElementLocator.locateWithOffset altogether. 
It was needed only for the old Angular implementation support, which
overlayed its own Element subclasses into normal Dart AST, for example
for string literals - names of components.

As we don't support this anymore, there is no need for the method.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1370833002 .
 2015-09-25 14:57:15 -07:00
Konstantin Shcheglov 4f8649f1b3 Issue 24442. Fix for renaming library names with spaces. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24442

Review URL: https://codereview.chromium.org//1370793003 .
 2015-09-25 13:55:13 -07:00
Konstantin Shcheglov 83f94a2114 Add navigation region for 'library' directives. 
Dart Editor uses presence of a navigation region as a sign that there is something that can be renamed, and enables the Rename action.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1373593002 .
 2015-09-25 12:35:51 -07:00
Konstantin Shcheglov df827a06ae The 'analysis.implemented' notification implementation. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1368793003 .
 2015-09-25 12:33:02 -07:00
Konstantin Shcheglov da29a447c4 New analysis.implemented notification specification. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1372623004 .
 2015-09-25 09:57:29 -07:00
Konstantin Shcheglov 805f6ec3ba Record HAS_ANCESTOR relations into index. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1371463002 .
 2015-09-24 16:21:09 -07:00
pq d869088ea3 Error handling for bad .analysis_options files. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1364813003 .
 2015-09-23 13:27:19 -07:00
Konstantin Shcheglov 6899986bfe Use TypeSystem in the 'Extract Method' refactoring. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1364803003 .
 2015-09-23 10:28:50 -07:00
Konstantin Shcheglov 5fd8b38737 Tweak navigation for 'part of' directives. 
This makes it consistent with import/export/part directives, where only URIs are navigation sources.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1365663002 .
 2015-09-23 10:14:49 -07:00
Konstantin Shcheglov 4aa6466ccb Use IndexContributor(s) in LocalIndex. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1359113002 .
 2015-09-23 08:17:33 -07:00
Brian Wilkerson 7aa459affd Add more performance data 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1363653005 .
 2015-09-23 07:44:44 -07:00
pq d2f4a19fa6 Import cleanup. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1364583002 .
 2015-09-22 17:06:55 -07:00
Konstantin Shcheglov 531f1d1e5b Extract Dart specific node management into DartUnitIndexObjectManager. 
We want to be able to index not just CompilationUnitElement(s), but also
for example results of Angular resolution, which while are based on resolved
CompilationUnit(s), are not ready together with it, so should live in separate
split index nodes.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1359023002 .
 2015-09-22 12:26:41 -07:00
Brian Wilkerson 163ad75127 Fix status pages when running new task model 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1351243003 .
 2015-09-22 11:03:56 -07:00
Konstantin Shcheglov f67bc2f546 Replace NameElement with IndexableName. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1347943006 .
 2015-09-21 12:02:34 -07:00
Konstantin Shcheglov bd51946e6f Remove old translated code from DAS. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1355173002 .
 2015-09-21 10:43:35 -07:00
danrubel d6051a53a0 refactor ContributionSorter to use new API 
move CompletionTarget to public API
modify DartCompletionRequest to return completion target

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1347283005 .
 2015-09-18 16:03:22 -04:00
danrubel 9ad1bf1f0e rename inherited_computer to inherited_contributor (TBR) 
Review URL: https://codereview.chromium.org//1357003002 .
 2015-09-18 15:56:59 -04:00
danrubel 3d05453793 add inherited_computer.dart (TBR) 
Review URL: https://codereview.chromium.org//1346813005 .
 2015-09-18 15:46:56 -04:00
Brian Wilkerson f4b1879180 Add a completion for inherited methods 
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1338173002 .
 2015-09-18 08:59:56 -07:00