Alan Knight
8831fb876e
Deprecate new internal Dartium/JsInterop APIs that are public
...
BUG=
Review URL: https://codereview.chromium.org/1428593002 .
2015-10-27 10:55:12 -07:00
Terry L. Lucas
d796048fcc
Fixed improper construction of custom elements.
...
Was a too aggressive on upgrading a custom element. If a JS object is a custom element never construct using the actual custom class in wrap_jso only allocate the TemplateElement or HtmlElement and let the upgrader or createdCallback do the upgrading. This was causing timing issues with nested custom elements that were data bound.
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1417363003 .
2015-10-22 16:35:46 -07:00
Alan Knight
a9362610ee
Hide internal methods like wrap_jso from the dart:html public interface
...
Issue https://github.com/dart-lang/sdk/issues/24602
R=terry@google.com
Review URL: https://codereview.chromium.org/1409743003 .
2015-10-19 11:28:53 -07:00
Alan Knight
1a1820bbe3
Move make_dart_rectangle to html_common
...
BUG=
Review URL: https://codereview.chromium.org/1402233002 .
2015-10-14 14:06:24 -07:00
Terry L. Lucas
e562934def
More tests now pass and fixed custom elements to only work in default html and svg namespace
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1392063003 .
2015-10-14 11:44:01 -07:00
Terry L. Lucas
4653701a76
Fixed native element extension, custom events, _VMUpgrader, and data binding.
...
Enabled tests that exercise this areas.
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1391143006 .
2015-10-14 10:03:56 -07:00
Terry L. Lucas
6f1d12c78e
Re-enabled code to aggressively upgrade on wrap_jso
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1396413002 .
2015-10-12 16:00:58 -07:00
Alan Knight
88b456d529
Make the check for calling super.created not sensitive to line delimiters
...
BUG=
Review URL: https://codereview.chromium.org/1399133003 .
2015-10-12 14:40:30 -07:00
Terry L. Lucas
ad8ed17bb8
Fixed wrap_jso recursive calls - now rely on Utils_constructor_create to call setDartHtmlWrapper prior to calling the created constructor.
...
TBR=jacobr@google.com ,alanknight@google.com
Review URL: https://codereview.chromium.org/1401233002 .
2015-10-12 13:56:27 -07:00
Terry L. Lucas
5e8a506677
Extension support
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1401063003 .
2015-10-12 10:09:42 -07:00
Terry L. Lucas
5c04f8a13c
Disable bad test and don't allow registerElement of direct class in dart:html or dart:svg
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1397323002 .
2015-10-12 03:17:21 -07:00
Terry L. Lucas
6227b207e6
Fixed to allow only HtmlElement in registerElement
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1403683002 .
2015-10-11 20:53:50 -07:00
Terry L. Lucas
b6503c7f74
Added for registerElement checking
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1401703002 .
2015-10-11 18:57:59 -07:00
Terry L. Lucas
4f9771f4e1
Fixed JS custom elements and temporarily mark polymer test as failing
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1402693002 .
2015-10-10 16:50:10 -07:00
Terry L. Lucas
888d458e90
Fixed upgrading and data binding
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1403623002 .
2015-10-09 17:03:53 -07:00
Terry L. Lucas
82fdf816b9
Added Alan's CL 1398603003 and augmented with upgrade for HtmlElement and HTMLElement
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1400843002 .
2015-10-09 09:38:37 -07:00
Terry L. Lucas
78658b3a88
Hide the accessors for bad custom element upgrade
...
TBR=alanknight@google.com ,jacobr@google.com
Review URL: https://codereview.chromium.org/1397793002 .
2015-10-08 10:27:51 -07:00
Alan Knight
c92a2450b4
Switch dart:html objects not to be NativeFieldWrapper subclasses with JsInterop
...
BUG=
Review URL: https://codereview.chromium.org/1392723003 .
2015-10-07 17:42:39 -07:00
Terry L. Lucas
c9b553aad1
Fixed upgrade failures to only throw once not on each wrap_jso
...
R=alanknight@google.com
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1395723002 .
2015-10-07 14:37:24 -07:00
Jacob Richman
1f9516ba0b
Fix some build breaks.
...
Fix test breaks
Roll dep forward to fix windows build.
Dartium typed js interop work dart repo side of the change. Also tries to get
BUG=
Review URL: https://codereview.chromium.org/1390113003 .
2015-10-07 13:47:12 -07:00
Jacob Richman
8d793ca758
Dartium typed js interop work dart repo side of the change. Also tries to get
...
BUG=
Review URL: https://codereview.chromium.org/1391353002 .
2015-10-07 11:44:50 -07:00
Alan Knight
9ad57e7aa3
Fix Crypto.getRandomValues to modify its argument, fix tests
...
BUG=
Review URL: https://codereview.chromium.org/1387273002 .
2015-10-07 09:11:14 -07:00
Terry L. Lucas
ff5d07a4e9
Fixed few more issues with upgrader and custom event identitiy
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1391273002 .
2015-10-07 08:53:31 -07:00
Terry L. Lucas
f867fb0218
Fixed element upgrading for polymer
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1382383003 .
2015-10-06 13:11:23 -07:00
Terry L. Lucas
ecfad36ac7
Fixed custom elements to work in Polymer
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1389683002 .
2015-10-05 08:55:52 -07:00
Alan Knight
110b579b8a
wrap_jso should wrap JsArray as well, not always call wrap on its contents
...
BUG=
Committed: https://github.com/dart-lang/sdk/commit/f0e52e4e9175c10739645b6a1f72d551f6b9fd06
Review URL: https://codereview.chromium.org/1383903002 .
2015-10-02 12:48:06 -07:00
Alan Knight
da7d6379cc
Revert "wrap_jso should wrap JsArray as well, not always call wrap on its contents"
...
This reverts commit f0e52e4e91 .
BUG=
Review URL: https://codereview.chromium.org/1378183003 .
2015-10-01 17:51:51 -07:00
Alan Knight
f0e52e4e91
wrap_jso should wrap JsArray as well, not always call wrap on its contents
...
BUG=
Review URL: https://codereview.chromium.org/1383903002 .
2015-10-01 16:22:17 -07:00
Alan Knight
eafe9d6b60
Make the dartWrapper access on JsObject private and provide top-level functions for it
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org/1369263004 .
2015-10-01 15:10:48 -07:00
Alan Knight
07b2ddd401
Preserve identity of Dart wrappers on DOM objects
...
BUG=
Review URL: https://codereview.chromium.org/1380963003 .
2015-10-01 14:04:01 -07:00
Alan Knight
59bd28d8cf
Revert "Preserve identity on wrap_jso hack. Has known failures"
...
This reverts commit e65577e4aa .
BUG=
Review URL: https://codereview.chromium.org//1380603004 .
2015-09-30 17:50:54 -07:00
Alan Knight
e65577e4aa
Preserve identity on wrap_jso hack. Has known failures
...
BUG=
Review URL: https://codereview.chromium.org//1382483003 .
2015-09-30 13:39:03 -07:00
Alan Knight
8f8d9e7180
Revert "Cache all wrap_jso results so we preserve identity"
...
This reverts commit fd52ed572f .
BUG=
Review URL: https://codereview.chromium.org//1374683004 .
2015-09-29 17:18:03 -07:00
Alan Knight
fd52ed572f
Cache all wrap_jso results so we preserve identity
...
BUG=
Review URL: https://codereview.chromium.org//1376083002 .
2015-09-29 16:41:38 -07:00
Terry L. Lucas
138888e566
Need to handle skipping mixins in a CustomElement
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1368383002 .
2015-09-28 07:29:14 -07:00
Terry L. Lucas
40fed74848
Fixed checking for more complex inheritance
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1374543002 .
2015-09-27 21:09:34 -07:00
Terry L. Lucas
3ce007e910
Fixed a bunch of failure cases for custom elements
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1373563004 .
2015-09-25 15:12:08 -07:00
Alan Knight
1b80b9013e
Make sure we short-circuit the second corruption test, it might be crashing firefox
...
BUG=
Review URL: https://codereview.chromium.org//1371543002 .
2015-09-24 16:45:08 -07:00
Terry L. Lucas
54282ccd72
Update to handle expections in custom element's created constructor
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1370513003 .
2015-09-24 13:17:35 -07:00
Alan Knight
5b6401e900
Move JS calls out of Dartium code
...
BUG=
Review URL: https://codereview.chromium.org//1369573004 .
2015-09-24 12:36:18 -07:00
Alan Knight
8f35656f9b
Fix node_validator xss tests for IE and Firefox
...
BUG=
Review URL: https://codereview.chromium.org//1365093003 .
2015-09-24 10:43:08 -07:00
Alan Knight
0568fa8679
Omit extra argument to createElement/NS if null
...
BUG=
Review URL: https://codereview.chromium.org//1345413004 .
2015-09-22 09:28:38 -07:00
Alan Knight
aebb870b13
Start using the dart2js type conversions in Dartium as well.
...
BUG=
Review URL: https://codereview.chromium.org//1349293006 .
2015-09-18 12:44:36 -07:00
Terry L. Lucas
bcf8dfe1f1
Merge mistake removed annotations for dart2js; re-added.
...
TBR=sra@google.com
Review URL: https://codereview.chromium.org//1350063004 .
2015-09-18 07:25:33 -07:00
Johnni Winther
ecb1e33a7f
Report hint on unmatched show and hide combinators.
...
BUG=
R=karlklose@google.com
Review URL: https://codereview.chromium.org//1346133002 .
2015-09-17 12:33:17 +02:00
Terry L. Lucas
fc8682ceac
Fixed another dart2js code emitting error and enabled tests that now work
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1346203002 .
2015-09-16 08:19:15 -07:00
Terry L. Lucas
7b322c246c
Dartium JS Enabled take 2
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1348173002 .
2015-09-16 07:13:53 -07:00
Terry L. Lucas
09c804aa78
Revert "Dartium JS Interop enabled."
...
This reverts commit 403bd1698d .
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1345083002 .
2015-09-15 19:44:26 -07:00
Terry L. Lucas
403bd1698d
Dartium JS Interop enabled.
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1349493003 .
2015-09-15 17:36:47 -07:00
Terry L. Lucas
9b0d2582fc
Revert "Dartium w/ JsInterop enabled"
...
This reverts commit 346af54711 .
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1330163010 .
2015-09-09 17:33:24 -07:00