736007062a
Revert "Enforce token syntax for CssClassSet arguments"
...
TBR=terry@google.com
BUG=
Review URL: https://codereview.chromium.org//1096433006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45306 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 01:14:32 +00:00
a1850bb69a
Enforce token syntax for CssClassSet arguments
...
Committed: https://code.google.com/p/dart/source/detail?r=45265
Reverted: https://code.google.com/p/dart/source/detail?r=45266
R=terry@google.com
Committed: https://code.google.com/p/dart/source/detail?r=45301
Review URL: https://codereview.chromium.org//1077203004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45303 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 00:37:10 +00:00
ec484da9f6
Revert "Enforce token syntax for CssClassSet arguments"
...
Review URL: https://codereview.chromium.org//1098073003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45302 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 00:25:54 +00:00
01d3e99f18
Enforce token syntax for CssClassSet arguments
...
Committed: https://code.google.com/p/dart/source/detail?r=45265
Reverted: https://code.google.com/p/dart/source/detail?r=45266
R=terry@google.com
Review URL: https://codereview.chromium.org//1077203004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45301 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 23:44:11 +00:00
1b2296c2be
getElementsByName returns HtmlCollection on IE
...
Review URL: https://codereview.chromium.org//1093243002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45299 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 22:23:08 +00:00
55372e4678
t # Enter a description of the change.
...
Revert "getElementsByName returns HtmlCollection on IE"
TBR=terry@google.com
BUG=
Review URL: https://codereview.chromium.org//1098953002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45298 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 21:48:30 +00:00
44ea26b4fb
getElementsByName returns HtmlCollection on IE
...
This CL will be committed and reverted to sniff out test status changes (some very small tests will start passing)
TBR=terry@google.com
Review URL: https://codereview.chromium.org//1093243002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45295 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 20:16:24 +00:00
efc7d09945
Enforce token syntax for CssClassSet arguments
...
Committed: https://code.google.com/p/dart/source/detail?r=45265
Review URL: https://codereview.chromium.org//1077203004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45266 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-18 01:58:20 +00:00
08676965c4
Enforce token syntax for CssClassSet arguments
...
Review URL: https://codereview.chromium.org//1077203004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45265 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-18 01:53:21 +00:00
47a1aea03c
Remove fallback attempt to set outerHtml when removing corrupt nodes, it won't work anyway
...
BUG=
Review URL: https://codereview.chromium.org//1057963003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45041 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 22:43:20 +00:00
b13d4f5742
Check for DOM clobbering attacks in sanitizing/node validation
...
BUG=
Review URL: https://codereview.chromium.org//1077813002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45028 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 19:47:34 +00:00
e1e22c00f2
Fix node validation for SVG foreignobject tag
...
BUG=
Review URL: https://codereview.chromium.org//1072893002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45019 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 17:24:03 +00:00
d795a89017
"Reverting 44988"
...
BUG=
Review URL: https://codereview.chromium.org//1078583002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44990 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 00:56:10 +00:00
ad6bff9089
Fix issues with foreignobject sanitizing
...
BUG=
Review URL: https://codereview.chromium.org//1075693002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44988 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 00:06:27 +00:00
0b1fb9cda5
Generate fast-path CssStyleDeclaration properties from browser info
...
We can tell all our suported browsers have style.backgroundColor so we can avoid the detection and vendor prefix logic.
R=alanknight@google.com
Review URL: https://codereview.chromium.org//966803004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44973 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-08 16:18:36 +00:00
9b2d7cae44
CssStyleDeclaration performance work
...
Cache browser prefix detection to avoid repeated camelCasing.
Remove IE9 compatibility code.
R=alanknight@google.com
Review URL: https://codereview.chromium.org//1064783002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44951 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 21:34:20 +00:00
6d9f24b919
Make SVGValidator reject foreignobject tags, not just their contents. Fixes Firefox inconsistency
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org//1063213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44949 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 20:59:02 +00:00
a2d5aef265
Update node_validator_test for IE11
...
BUG=
Review URL: https://codereview.chromium.org//1068573003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44941 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 17:56:33 +00:00
f8fb9710ee
Revert trial commit of "CssStyleDeclaration performance work"
...
If all goes well, will be recommited after code review.
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1062973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44932 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 01:52:05 +00:00
440f677b46
CssStyleDeclaration performance work
...
Cache browser prefix detection to avoid repeated camelCasing.
Remove IE9 compatibility code.
Review URL: https://codereview.chromium.org//1064783002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44931 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 01:22:54 +00:00
2956fd8739
- Fork implementation for Dartium and dart2js. Dartium is working fine.
...
- dart2js version uses Element.classList (DomTokenList) for 4x speedup.
- Fix bug where document.querySelectorAll(...).classes.add('x') fails for SVG elements.
- Add test for above.
For later:
- Identify a polyfill for IE SVGElements (they don't have classList)
- Simplify CssClassSet further to exploit uniform availability of classList. This should give another performance boost by enabling inlining.
R=alanknight@google.com
Committed: https://code.google.com/p/dart/source/detail?r=44888
Committed: https://code.google.com/p/dart/source/detail?r=44897
Review URL: https://codereview.chromium.org//1054863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44898 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-03 23:00:28 +00:00
3080315805
- Fork implementation for Dartium and dart2js. Dartium is working fine.
...
- dart2js version uses Element.classList (DomTokenList) for 4x speedup.
- Fix bug where document.querySelectorAll(...).classes.add('x') fails for SVG elements.
- Add test for above.
For later:
- Identify a polyfill for IE SVGElements (they don't have classList)
- Simplify CssClassSet further to exploit uniform availability of classList. This should give another performance boost by enabling inlining.
R=alanknight@google.com
Committed: https://code.google.com/p/dart/source/detail?r=44888
Review URL: https://codereview.chromium.org//1054863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44897 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-03 22:38:56 +00:00
ade70628de
- Fork implementation for Dartium and dart2js. Dartium is working fine.
...
- dart2js version uses Element.classList (DomTokenList) for 4x speedup.
- Fix bug where document.querySelectorAll(...).classes.add('x') fails for SVG elements.
- Add test for above.
For later:
- Identify a polyfill for IE SVGElements (they don't have classList)
- Simplify CssClassSet further to exploit uniform availability of classList. This should give another performance boost by enabling inlining.
R=alanknight@google.com
Review URL: https://codereview.chromium.org//1054863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44888 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-03 20:48:10 +00:00
2e42929db9
Don't cache SVG CssClassSet
...
Separate dart apps loaded into the same page will fight.
Review URL: https://codereview.chromium.org//1057193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44878 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-03 02:31:42 +00:00
09249173ad
Add alternate name for RtcIceCandidateEvent
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org//1038913003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44713 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-26 17:34:49 +00:00
5397482fcc
Make dartj2s do type conversions on constructor arguments
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org//1023363002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44688 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 17:39:49 +00:00
b44058a0d2
Make Element.animate work in dart2js Chrome
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org//1014843004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44642 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 18:26:06 +00:00
580cb00cbb
Added more diag info
...
Reviewers=vsm@google.com ,alanknight@google.com
R=alanknight@google.com
Review URL: https://codereview.chromium.org//1022483002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44562 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-18 19:22:53 +00:00
46a24513a3
Add MediaSource.supported, annotations for supported browsers, and a minimal test
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org//990383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44472 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 17:31:42 +00:00
5d2f7f8ae8
Fix notification
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org//1002953005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44471 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 17:21:31 +00:00
5c84e1b473
Added --examine to produce analysis of IDL files
...
Reviewers=vsm@google.com ,alan@google.com
R=vsm@google.com
Review URL: https://codereview.chromium.org//1001983003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44467 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 15:53:55 +00:00
8c7e1a75d1
Revert "Element.style is not null"
...
Need to investigate:
FAILED: dart2js-chrome release_ia32 co19/LayoutTests/fast/xsl/default-html_t01
Expected: RuntimeError
Actual: Pass
Review URL: https://codereview.chromium.org//971033004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44222 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-04 05:24:57 +00:00
c363abff4a
Element.style is not null
...
BUG=
Review URL: https://codereview.chromium.org//960503006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44220 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-04 03:54:22 +00:00
0babe95cba
Fix usage of renamed parameter in EventSource
...
BUG=
Review URL: https://codereview.chromium.org//974553002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44146 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 20:15:27 +00:00
1fd8fe6e9c
Change EventSource parameter from title to url, to match idl
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org//958393002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44138 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 18:44:56 +00:00
68c6b252e4
Fixed tests for DOMPoint support for dart2js.
...
TBR=asiva@google.com ,vsm@google.com
Review URL: https://codereview.chromium.org//968613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44115 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-01 18:01:53 +00:00
e0fff4e457
Changes to support roll 39 IDLs
...
Reviewers=vsm@google.com ,asiva@google.com
Review URL: https://codereview.chromium.org//952133004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44099 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-27 18:10:08 +00:00
4e08f82170
Re-enable printing and timers in Dartium isolates (again)
...
BUG=
Review URL: https://codereview.chromium.org//957333003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44066 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 18:26:17 +00:00
b097d978a7
"Reverting 44050"
...
BUG=
Review URL: https://codereview.chromium.org//958073002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44053 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 16:04:55 +00:00
ecfdd56df7
Re-enable printing and timers in Dartium isolates
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//948933004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44050 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 15:55:29 +00:00
f5ee0ccdf3
Do not allow abstract classes to be registered as custom elements
...
BUG=20813
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//943043005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44007 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-24 22:57:59 +00:00
904433bd7c
Revert "Annotate dart:html constructor expressions with precise non-nullable types."
...
Need to fix some html/element_types_test cases.
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//904663005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43579 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-07 00:35:32 +00:00
f74e57786d
Annotate dart:html constructor expressions with precise non-nullable types.
...
This addresses issue http://dartbug.com/22264
R=alanknight@google.com
Review URL: https://codereview.chromium.org//896723009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43578 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 23:24:19 +00:00
60bae5bb5d
Cleanup method signatures that were incorrect due to a lack of understanding about how Dart generics work.
...
BUG=
R=alanknight@google.com , terry@google.com
Review URL: https://codereview.chromium.org//896293003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43562 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:15:49 +00:00
8bed532218
Tweak toString() for better type inference
...
These changes ensure dart2js can infer toString() returns a non-null String on some of our samples.
One tactic is to always write toString method for which all returned expressions are a an interpolation (or literal), or a call to StringBuffer.toString.
R=alanknight@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//895813002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43534 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 00:24:51 +00:00
69e76a7b28
Clamp scrollX, scrollY, pageXOffset, and pageYOffset from double to int
...
TBR=vsm@google.com ,asiva@google.com
Review URL: https://codereview.chromium.org//898993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43477 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 16:59:12 +00:00
b68a69329f
Add type annotations to some dart:html closures
...
This helps code quality when the types can be trusted or verified.
R=jacobr@google.com
Review URL: https://codereview.chromium.org//891583002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43349 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-30 23:08:39 +00:00
604106c107
Add webkitAudioPannerNode as an optional name
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org//873803002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43149 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 20:27:23 +00:00
721034fa84
BUG=
...
R=alanknight@google.com
Review URL: https://codereview.chromium.org//863713003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43029 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 23:04:27 +00:00
7a46d4232b
Simplify _FrozenElementList
...
There is no need to filter the NodeList since it can contain only Elements.
R=jacobr@google.com
Review URL: https://codereview.chromium.org//802603002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42306 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 01:40:31 +00:00
sra@google.com