Commit Graph

1657 Commits

Author SHA1 Message Date
Harry Terkelsen 1745ba77f5 fix all instances of "the the"
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1980573003 .
2016-05-13 12:38:25 -07:00
Alan Knight c5acca2ff0 Check for the case where previousNode fails in sanitization. Can happen with object tags
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1825373004 .
2016-04-28 12:51:40 -07:00
Jacob Richman 6ef4eae35f Remove as checks bloating sample dart apps by 4K
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1923143002 .
2016-04-27 08:53:48 -07:00
Alan Knight dad1a74d2e Oops, movementX/Y are private. Fix template
BUG=

Review URL: https://codereview.chromium.org/1916203002 .
2016-04-25 13:26:14 -07:00
Alan Knight 5542568adc Fix MouseEvent.movement to not use old webkit prefix
BUG=

Review URL: https://codereview.chromium.org/1921823002 .
2016-04-25 12:35:03 -07:00
Terry Lucas 8f7b8a9d87 Update to new Webkit additions for custom elements
TBR=jacobr@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org/1914643002 .
2016-04-22 12:53:36 -07:00
Jacob Richman 7fdce7a2f0 Use _downcast and _cast instead of "as" to reduce dart2js output size.
BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org/1914583002 .
2016-04-22 11:09:01 -07:00
Jacob Richman 819ed4bb60 Fix strong mode errors in SVG
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1903893003 .
2016-04-21 12:45:08 -07:00
Jacob Richman 25b88eabe5 Fix indexed_db strong mode warnings.
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1903973002 .
2016-04-21 10:03:53 -07:00
Jacob Richman 9ffe1c2450 Make querySelectorAll a generic method so that checked mode behavior is consistent with existing behavior and strong mode behavior is strong for the case of List<InputElement> elems = document.querySelector("input");
BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org/1904903003 .
2016-04-21 09:54:18 -07:00
Jacob Richman 777e1a386e Revert "Remove the generics from _FrozenElementList: causes checked mode failures"
This reverts commit 7824ac771b.

BUG=

Review URL: https://codereview.chromium.org/1909613003 .
2016-04-20 18:50:11 -07:00
Jacob Richman b546d05362 TBR. Add back fix to the misleading types for onError. Otherwise, html/worker_test/functional fails due to the browser itself throwing an event of type Error that is not an ErrorEvent.
BUG=

Review URL: https://codereview.chromium.org/1908603002 .
2016-04-20 10:41:56 -07:00
Jacob Richman 068252e721 Revert changes to event signatures as they broke one co19 test and this change isn't required due to relaxation in types in EventStreamProvider.dart
BUG=

Review URL: https://codereview.chromium.org/1903033002 .
2016-04-19 16:42:16 -07:00
Jacob Richman 864b64fd5e Strong html
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1894713002 .
2016-04-19 15:08:45 -07:00
Alan Knight 810faa31b9 Don't add a non-null check in dart2js for a nullable parameter (seeWebGl.texImage2D)
BUG=

Review URL: https://codereview.chromium.org/1885943002 .
2016-04-16 16:26:14 -07:00
Alan Knight 7824ac771b Remove the generics from _FrozenElementList: causes checked mode failures
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1891543005 .
2016-04-14 15:14:40 -07:00
Terry Lucas 74ddf84ffd Remove MutationEvent bad entries in both removed list and renamed list
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1890983002 .
2016-04-14 13:49:42 -07:00
Alan Knight 48d73a66e0 Fix MutationEvent class name
BUG=

Review URL: https://codereview.chromium.org/1888693004 .
2016-04-14 09:56:07 -07:00
Alan Knight a718c8dac9 Fix a few strong mode errors in dart:html
BUG=
R=jacobr@google.com

Committed: https://github.com/dart-lang/sdk/commit/65fe0a5383c7d09efb1dd958a7a30ec5c4d1c847

Review URL: https://codereview.chromium.org/1876363006 .
2016-04-13 15:13:31 -07:00
Alan Knight 3fd7e32b65 Revert "Fix a few strong mode errors in dart:html"
This reverts commit 65fe0a5383.

BUG=

Review URL: https://codereview.chromium.org/1879253004 .
2016-04-13 14:56:42 -07:00
Alan Knight 65fe0a5383 Fix a few strong mode errors in dart:html
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1876363006 .
2016-04-13 14:41:10 -07:00
Jacob Richman 08c171d3e5 Revert "Revert "Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects.""
Fix missing case that was breaking co19 tests.
This reverts commit 688eeb555c.

BUG=

Review URL: https://codereview.chromium.org/1883513004 .
2016-04-12 17:16:06 -07:00
Jacob Richman 688eeb555c Revert "Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects."
This reverts commit f382890e1a.
Reverting while tests are fixed.

BUG=

Review URL: https://codereview.chromium.org/1879093002 .
2016-04-12 11:28:05 -07:00
Jacob Richman f382890e1a Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects.
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1873933002 .
2016-04-12 10:23:32 -07:00
Jacob Richman 1536c671f5 Add support for switching library from the chrome devtools console.
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1865803004 .
2016-04-07 11:14:47 -07:00
Terry Lucas c95b9875ef Fix registerElement for HTMLElement prototype should not change it's m_type
TBR=jacobr@google.com

Review URL: https://codereview.chromium.org/1857343002 .
2016-04-05 11:59:28 -07:00
Alan Knight 0f5c249f22 Fix webgl methods, properly this time
BUG=

Review URL: https://codereview.chromium.org/1846803002 .
2016-03-31 09:45:32 -07:00
Jacob Richman 3cb280c5e1 Fast path Location.hash as some apps call it 10000+ times a frame.
BUG=

Review URL: https://codereview.chromium.org/1847543003 .
2016-03-31 09:04:10 -07:00
Jacob Richman c65854d2e4 Optimize dartium dart:html bindings so real world application performance is acceptable. Improves dart:html performance by 2X-30X for microbenchmarks. Real world improvement is typically 2X-3X.
BUG=

Review URL: https://codereview.chromium.org/1832713002 .
2016-03-29 18:32:52 -07:00
Terry Lucas 10e70db01c Speed up interop patch file creation.
Made a number of optimizations to reduce load time from 8 secs to 1 sec.  The changes involved:

- No longer dynamically generate patch files on startup for dart:* libraries (created from WebKits IDL e.g., html, svg, web_audio, web_gl, indexed_db, web_sql).  Instead create a cache of patch files.

- Comparison of @JS refelctedType not by library and symbol name comparison.

- In addition, a VM mirror change see CL https://codereview.chromium.org/1834673003/ gives us the remaining speedup.

This cache of interop patch files, for Dartium only, requires a manual re-gen after go.sh run is:

> cd tools/dom/scripts
> run go.sh

The steps after (for Dartium) are:

1.  build Dartium
2.  cd tools/dartium
3.  run generate_patches.sh
4.  build Dartium

R=jacobr@google.com, alanknight@google.com

Review URL: https://codereview.chromium.org/1833373002 .
2016-03-28 08:20:13 -07:00
Alan Knight ab55f22334 Fix WebGL tex[Sub]Image2D/buffer[Sub]Data, restored Typed/Untyped aliases
BUG=

Review URL: https://codereview.chromium.org/1831033002 .
2016-03-24 10:20:11 -07:00
Alan Knight 4fe809c211 Add @creates annotation to VttCue members
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1811213002 .
2016-03-18 07:35:35 -07:00
Alan Knight 051451d7e6 Trying to fix SQLResultSetRowList's subscript operator to do type conversion
BUG=

Review URL: https://codereview.chromium.org/1779023002 .
2016-03-09 14:02:30 -08:00
Alan Knight 1f9395fb30 Add back CssCharsetRule for Safari support
BUG=

Review URL: https://codereview.chromium.org/1777683002 .
2016-03-08 14:40:57 -08:00
Terry Lucas af562187bc Chrome moved clipboardData from Event to ClipboardEvent for security clipboard can only be accessed during a onCut/onCopy/onPaste event.
The polyfill class KeyEvent can no longer access clipboardData without listening for the cut, copy or paste event.

TBR=alanknight@google.com,sigmund@google.com

Review URL: https://codereview.chromium.org/1775923002 .
2016-03-08 05:24:02 -08:00
Terry Lucas 5d77c0e83c More UIEvent attribute movement in 45 roll.
TBR=alanknight@google.com,sigmund@google.com

Review URL: https://codereview.chromium.org/1771113002 .
2016-03-07 16:12:28 -08:00
Terry Lucas 5c3728b067 Fix for KeyEvent,KeyboardEvent and UIEvent changes in roll 45
TBR=jacobr@google.com,alanknight@google.com,sigmund@google.com

Review URL: https://codereview.chromium.org/1754523006 .
2016-03-07 07:51:50 -08:00
Terry Lucas a552c24089 Match version of idl_parser and WebCore so go.sh can be run from a Dart only enlistment.
Needed to pull in the tools/idl_parser code for a Dart enlistment populated during a gclient sync.

Added .gitingore to not ignore tools/idl_parse

TBR=jacobr@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org/1768853002 .
2016-03-06 15:10:36 -08:00
Terry Lucas c510dc9831 Fixed typedef used globally in IDLs
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1763063003 .
2016-03-05 07:34:51 -08:00
Alan Knight 83e2e2dbb2 Change scripts to avoid generating things that bloat the compiled code
BUG=

Review URL: https://codereview.chromium.org/1763213002 .
2016-03-04 15:08:48 -08:00
Kasper Lund 96be0c49fb Revert "Change scripts to avoid generating things that bloat the compiled code"
This reverts commit 4f3abbd5ef.
2016-03-04 10:06:07 +01:00
Alan Knight 4f3abbd5ef Change scripts to avoid generating things that bloat the compiled code
BUG=

Review URL: https://codereview.chromium.org/1759303003 .
2016-03-03 17:39:50 -08:00
Jacob Richman c66635cc9f Basline of dart2js w/ regen'd sdk/libs
BUG=

Review URL: https://codereview.chromium.org/1762063002 .
2016-03-03 13:42:10 -08:00
Terry Lucas 4f3b4097fd Fixed dart2js compilation problem
TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1762763002 .
2016-03-03 11:08:24 -08:00
Terry Lucas 3f0bb621a8 Revert "Changes to tests and status file for the 45 roll w/ regenderated sdk/libs"
This reverts commit 8d12df1e77.

TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1763753002 .
2016-03-03 09:41:01 -08:00
Terry Lucas 23d5f671ae Revert "Fixed dart2js compilation and udpate obsolete analyzer for co19"
This reverts commit 439b59b1fc.

TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1753903005 .
2016-03-03 09:37:53 -08:00
Terry Lucas 439b59b1fc Fixed dart2js compilation and udpate obsolete analyzer for co19
TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1757293002 .
2016-03-03 06:23:31 -08:00
Terry Lucas 8d12df1e77 Changes to tests and status file for the 45 roll w/ regenderated sdk/libs
TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1746623002 .
2016-03-03 05:33:46 -08:00
Terry Lucas d094857c12 Fixed createImageData and added RequestAnimationFrameCallback for compat
TBR=jacobr@google.com

Committed: https://github.com/dart-lang/sdk/commit/b524161f8f9bc8c3a122047d604f7eec9507411b

Review URL: https://codereview.chromium.org/1753813005 .
2016-03-02 13:23:22 -08:00
Terry Lucas e1a33e9981 Moved ChromiumSubscribeUniform to web_gl
Fixed to return null if dictionary returned form blink is null
Cleanup up logging/error reporting

TBR=alanknight@google.com,jacobr@google.com

Committed: https://github.com/dart-lang/sdk/commit/01f6e4ed0f8882001e5a308cc8e36dcb62e9b5bc

Review URL: https://codereview.chromium.org/1752983003 .
2016-03-02 08:15:45 -08:00