dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1657 Commits

Author SHA1 Message Date
Alan Knight 95930806c9 Add dynamic declaration to CssRectangle width/height setters 
BUG=
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2868483002 .
 2017-05-05 13:34:23 -07:00
Nate Bosch bbc65073fa Clarify units for timeout 
This is indicated in the linked MDN doc, but we should not make readers
go looking.

Also fix a typo.

BUG=https://github.com/dart-lang/sdk/issues/29428
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2832353003 .
 2017-05-05 10:11:03 -07:00
Alan Knight cedd8a6854 Format dart:html and related generated files on output 
BUG=
R=jacobr@google.com, terry@google.com

Review URL: https://codereview.chromium.org/2858323003 .
 2017-05-05 10:09:00 -07:00
Stephen Adams ea2c9cba39 dart2js_html: Fix for issue 29538 - some returned lists may be null 
Annotate querySelectorAll as not-null to recover code quality.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2857143003 .
 2017-05-03 14:26:38 -07:00
Erik Corry aa6353b6da Dart SDK Spelling b, c, and d. 
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2850783002 .
 2017-05-01 08:28:10 +02:00
Erik Corry 4b9bba55b4 Stoppp using trippple consonants 
R=ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2833073002 .
 2017-04-21 17:50:13 +02:00
Jacob Richman 119b2d58ce Format all files under tools and utils directory. 
BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2827793002 .
 2017-04-20 09:08:31 -07:00
Stephen Adams 14c7c3c556 Redo "Refined types for most HtmlElement factory constructors" 
Fix: ShadowElement is not always present.

Original:
Committed: https://github.com/dart-lang/sdk/commit/b7b12b564a3e1811ccfca3e28fe30dde685f6633
Reverted:  https://github.com/dart-lang/sdk/commit/963df1e3e1a3bac0013d191d2b02898bbebefa9d

BUG=

Review-Url: https://codereview.chromium.org/2718713003 .
 2017-02-24 14:28:58 -08:00
Stephen Adams 963df1e3e1 Revert "Refined types for most HtmlElement factory constructors" 
Need to fix ShadowElement

TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2710323004 .
 2017-02-24 14:15:37 -08:00
Stephen Adams b7b12b564a Refined types for most HtmlElement factory constructors 
The body of new DivElement() is marked as returning a DivElement, instead of inferred to return Element.
The more precise receiver type allows svg polyfills to be excluded, allowsing the HtmlElement methods to be identified as the single target and inlined.

This tends to improve the code generated for idioms like

    new DivElement()..classes.add('foo')

    var e1 = new DivElement();
    e1.children.add(e2);

BUG=
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2705213003 .
 2017-02-24 11:23:06 -08:00
Alan Knight de05077537 Revert "Add Selection.toString() calling the native method" 
This reverts commit 01e6e00499.

BUG=

Review URL: https://codereview.chromium.org/2678593002 .
 2017-02-03 17:02:06 -08:00
Alan Knight b1552f9ef9 Revert "Re-submit Range.toString() and test status changes" 
This reverts commit 95d409e3ed.

BUG=

Review URL: https://codereview.chromium.org/2678543002 .
 2017-02-03 13:05:18 -08:00
Alan Knight 01e6e00499 Add Selection.toString() calling the native method 
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org/2669103003 .
 2017-02-03 10:24:18 -08:00
Alan Knight 95d409e3ed Re-submit Range.toString() and test status changes 
https://codereview.chromium.org/2632363002
https://github.com/dart-lang/sdk/pull/28376

R=whesse@google.com

Review URL: https://codereview.chromium.org/2672843003 .
 2017-02-03 09:55:59 -08:00
Alan Knight 05e80e9cfc Regenerate html files after b42dbe524c 
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org/2670203002 .
 2017-02-02 12:54:56 -08:00
Asger Feldthaus 8701dbf147 Revert "added Range.toString() to dart:html (#28376)" +1 more 
Revert "dart2js status updates after Range.toString was added to dart:html"

This reverts commit 226a7e7177.
This reverts commit c279a951f4.

The test

  co19/LayoutTests/fast/filesystem/file-writer-abort-continue_t01

broke after the inital commit. The second commit being reverted
is one that updated the status files for tests that now pass.

BUG=
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2635033004 .
 2017-01-17 17:21:46 +01:00
Kulshekhar Kabra b42dbe524c Add documentation for a method (#28209) 
* Add documentation for a method

Adds docs for the `getPropertyValue` method of the `CssStyleDeclaration` class in the `html` package

* Remove unneeded extra line
 2017-01-16 09:18:27 +01:00
Lex Berezhny 226a7e7177 added Range.toString() to dart:html (#28376) 
* added Range.toString() to dart:html

* added Range.toString to impl_range.darttemplate as well
 2017-01-13 14:13:07 -08:00
Terry Lucas 4b497fb319 Fixed checked mode error for resolvePackageUri. 
TBR=asiva@google.com

Review-Url: https://codereview.chromium.org/2626643003 .
 2017-01-10 09:00:16 -08:00
Terry Lucas 559ae993d1 Added VMLibraryHooks setup for Dartium to support resolvePackageUri. 
BUG=25594
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2611353002 .
 2017-01-10 07:25:10 -08:00
Leaf Petersen 7ab0daeedf Make EventStreamSubscription DDC safe. 
EventStreamSubscription.listen does a cast which is only working in
DDC because we're ignoring the failure.  This wraps the listener to
check the argument rather than casting the function.  Also picks up a
few misc changes to the main SDK that hadn't been merged into DDC.

BUG=
R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2609633002 .
 2017-01-09 04:13:36 -08:00
Stephen Adams 20a9824605 Force inlining for _ElementCssClassSet.add() / .remove() 
BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2614593002 .
 2017-01-03 17:23:00 -08:00
Jacob Richman 3659aaf181 Fix bug in Blob creation from workers. 
Fixes https://github.com/dart-lang/sdk/issues/28155

BUG=

Review-Url: https://codereview.chromium.org/2592813003 .
 2016-12-21 08:45:48 -08:00
Jacob Richman 7f26211c26 Correct handling of cross-frame functions in ddc. 
Misc fixes of dart:js support on ddc.
Work around issue with Blob constructor on ddc.
Fix incorrect dart:js test on dart2js (fixes https://github.com/dart-lang/sdk/issues/26197)

BUG=
R=alanknight@google.com, leafp@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2587203002 .
 2016-12-19 15:00:55 -08:00
Sigmund Cherem d89dab56b5 Fix IE11 issue: this complements the CL I sent last week. It turns out that 
there are two places where we do this check. This is why the test that I added
appears to be failing in the bots.

BUG=
R=jakemac@google.com

Review URL: https://codereview.chromium.org/2504883002 .
 2016-11-16 08:38:24 -08:00
Sigmund Cherem 008da86c03 Support extending TemplateElement in IE11 + webcomponents-lite.js 
Addresses issue reported in the polymer repo: https://github.com/dart-lang/polymer-dart/issues/682

R=jakemac@google.com, sra@google.com

Review URL: https://codereview.chromium.org/2493703004 .
 2016-11-14 07:32:09 -08:00
Jan-Hendrik Dolling 89560c68a0 change "the the" to the 2016-10-28 21:47:50 +02:00
Stephen Adams c9c3c203c1 Minor tweaks to dart:html for better dart2js codegen 
- Allow 'document' to be reused (GVN-ed).
- Allow inlining of 'new Comment'.
- 'new Text' and 'new Comment' have no effects.

BUG=
R=alanknight@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/2422293002 .
 2016-10-17 13:35:17 -07:00
Alan Knight 42f8ab2d6a Fix dataTransferItemList indexing 
BUG=

Review URL: https://codereview.chromium.org/2326113002 .
 2016-09-09 12:28:59 -07:00
Alan Knight 43cb6a4c59 Replace Maps library tour link in Storage template with current URL. 
BUG=#27150
R=alanknight@google.com

Review URL: https://codereview.chromium.org/2277103002 .
 2016-08-26 12:34:53 -07:00
Harry Terkelsen 1d749a2fec record that Gamepad.buttons creates GamepadButtons 
This also extends the html generator to be able to generate List implementations with nullable element types

Fixes https://github.com/dart-lang/sdk/issues/27073

R=sra@google.com, terry@google.com

Review URL: https://codereview.chromium.org/2242203002 .
 2016-08-16 13:56:32 -07:00
Jacob Richman 36c9514f04 Use Point<num> in dart:html for strong mode 
Strong mode is (as of recently) inferring a stricter type (e.g., Point<double>) and causing breaking changes.

patch from issue 2211493003 at patchset 1 (http://crrev.com/2211493003#ps1)

BUG=

Review URL: https://codereview.chromium.org/2211563002 .
 2016-08-03 14:09:10 -07:00
Harry Terkelsen faaff39aa9 Record that MediaStream creates MediaStreamTracks 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/2168473002 .
 2016-07-19 17:00:04 -07:00
William Hesse bde8d3efc6 Revert "Don't call _ensureRequestAnimationFrame in Dartium." 
This reverts commit bf8eeef6a0.

Revert "Fix animationFrameRequest for dartium."

This reverts commit 3daaf3849f.

BUG=https://github.com/dart-lang/sdk/issues/26906

Review URL: https://codereview.chromium.org/2159183003 .
 2016-07-19 13:56:36 +02:00
Alan Knight 30b489578d Revert "Reapply zone tasks." 
This reverts commit 6a7c037aa6.

BUG=

Review URL: https://codereview.chromium.org/2162643002 .
 2016-07-18 13:12:36 -07:00
Terry Lucas 2b1816c869 Added switch to disable generating cached_patches.dart file (Dartium only). 
The switch --no-cached-patches to be used by Dart enlistment (non-Dartium) and need to
re-gen the sdk/lib files using:

    ./go.sh --no-cached-patches

R=alanknight@google.com

Review URL: https://codereview.chromium.org/2154863002 .
 2016-07-18 05:45:33 -07:00
Alan Knight e610d803b1 Update test status for webgl extension tests, fix one typo in extension name 
BUG=

Review URL: https://codereview.chromium.org/2152393002 .
 2016-07-15 15:00:15 -07:00
Alan Knight b9316f9882 Recognize WEBGL extensions on Firefox (copy with regenerated files) 
Both of the following objects need to map to Dart type 'AngleInstancedArrays'

    [object ANGLEInstancedArrays]
    [object ANGLE_instanced_arrays]

Fixes https://github.com/dart-lang/sdk/issues/26850

BUG=

patch from issue 2147093002 at patchset 1 (http://crrev.com/2147093002#ps1)

R=sra@google.com

Review URL: https://codereview.chromium.org/2150003002 .
 2016-07-15 12:48:22 -07:00
Florian Loitsch badabcc53a Don't use => on void functions. 
Fixes #26740
BUG= http://dartbug.com/26740
R=sra@google.com

Review URL: https://codereview.chromium.org/2118633002 .
 2016-07-11 14:20:12 +02:00
Florian Loitsch bf8eeef6a0 Don't call _ensureRequestAnimationFrame in Dartium. 
Review URL: https://codereview.chromium.org/2117103004 .
 2016-07-05 19:50:49 +02:00
Florian Loitsch 3daaf3849f Fix animationFrameRequest for dartium. 
Review URL: https://codereview.chromium.org/2124863002 .
 2016-07-05 19:22:27 +02:00
Florian Loitsch 6a7c037aa6 Reapply zone tasks. 
This reverts commit 34d3c37233.

Committed: https://github.com/dart-lang/sdk/commit/f746f8f77e93fd93cb4ff3b4ed644c96a432947a

R=lrn@google.com

Review URL: https://codereview.chromium.org/2119243002 .

Reverted: https://github.com/dart-lang/sdk/commit/dae392291595fa394d601d2d0baa77b66d85533f
 2016-07-05 17:33:09 +02:00
Florian Loitsch dae3922915 Revert "Reapply zone tasks." 
This reverts commit f746f8f77e.

Review URL: https://codereview.chromium.org/2123593002 .
 2016-07-04 21:58:15 +02:00
Florian Loitsch f746f8f77e Reapply zone tasks. 
This reverts commit 34d3c37233.

Review URL: https://codereview.chromium.org/2119243002 .
 2016-07-04 19:55:58 +02:00
Florian Loitsch 34d3c37233 Revert zone tasks. 
Revert "Add tasks to zones."

This reverts commit 85cccde717.

Revert "Make Dom events run through zone tasks."

This reverts commit 6d1f6b2af6.

Revert "Add zone task support for request-anim."

This reverts commit 726b9f8dc7.

Revert "Add zone task support to http-requests."

This reverts commit b40cfcb57f.

Revert "Update status file for jsshell."

This reverts commit 5e05ee9b5f.

Review URL: https://codereview.chromium.org/2120063002 .
 2016-07-01 22:36:52 -07:00
Florian Loitsch b40cfcb57f Add zone task support to http-requests. 
R=alanknight@google.com, lrn@google.com

Review URL: https://codereview.chromium.org/2042033002 .
 2016-07-01 19:44:19 -07:00
Florian Loitsch 726b9f8dc7 Add zone task support for request-anim. 
R=lrn@google.com

Review URL: https://codereview.chromium.org/2039963003 .
 2016-07-01 19:43:36 -07:00
Florian Loitsch 6d1f6b2af6 Make Dom events run through zone tasks. 
R=jacobr@google.com, lrn@google.com

Review URL: https://codereview.chromium.org/2022263002 .
 2016-07-01 19:43:06 -07:00
Jacob Richman fd58be1816 Add back in pure_interfaces list that turned out to still be needed. The checked in generated code matches this cl. 
BUG=

Review URL: https://codereview.chromium.org/2005143004 .
 2016-05-24 10:25:31 -07:00
Jacob Richman f26e522f84 Strip unused functionality from dart:html and fix strong mode errors. Switch from blacklisting pure interfaces to determining pure interfaces from the idl and whitelisting impure interfaces we need for dart2js. 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1987073002 .
 2016-05-18 12:49:09 -07:00