Commit Graph

1657 Commits

Author SHA1 Message Date
blois@google.com a7c9ce28d7 Fixing Element.shadowRoot JS type annotation
Getter was annotated as never returning null, but in fact can return null.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//24125002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27455 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 22:20:16 +00:00
rmacnak@google.com 2a87dc5402 Give each binding class an id to be used as an index into a cache of handles on the corresponding Dart classes.
BUG=
R=asiva@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//23819035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27452 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 21:55:30 +00:00
jacobr@google.com 9d5d4c0ea8 Dart helper methods to support the Dart REPL
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//23647013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27436 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 17:03:20 +00:00
blois@google.com d312cbbd08 Exposing document.createElement
As part of removing all $dom_ APIs, making this one public. There are valid scenarios for creating elements in other documents.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//24084004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27415 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 00:00:39 +00:00
sigmund@google.com 6b27fc46fb Fix docs_test. I just learned that when updating docs under html we also need to
run:
   python tools/dom/dom.py docs

R=efortuna@google.com

Review URL: https://codereview.chromium.org//23754012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27404 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 21:07:43 +00:00
blois@google.com b904bf81ba Revert "Revert "Tag extensions""
Original CL is the first patch, changes follow. Includes fixes for Chrome test failures and Firefox type check issues.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23442011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27313 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-09 22:03:43 +00:00
blois@google.com 647d73af0f Fix for CSS URIs not parsing correctly with innerHTML
Chrome has a bug (https://code.google.com/p/chromium/issues/detail?id=229142) where CSS URIs are not converting correctly when an element is parsed in one document then moved to another document. This uses a base element to set the baseURI of the parse document so it doesn't need to be converted on clone.

BUG=13147
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23903020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27305 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-09 19:06:27 +00:00
asiva@google.com 4d8651f8af 1. Make direct calls to _nativeIndexedGetter in "get last" "get first" "get single" instead of calling the "[]" operator. This avoids one additional native call to the length method for each call to "last" "first" or "single"
2. Fix templateloader to deal with nested 'if' conditions

R=vsm@google.com

Review URL: https://codereview.chromium.org//23534050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27270 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 23:22:31 +00:00
blois@google.com fefb7a4b0d Optimization for Element.innerHtml
Basically we were creating a new range every time HTML needs to be parsed, which is unnecessary and turns out to be quite expensive.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23460019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27259 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 19:13:48 +00:00
blois@google.com dbf675d60d Adding conversion support for JSON XHR requests.
This has been a half-supported feature for Chrome for a while, but popular elsewhere. Appears that recent Dartium behavior broke, so adding a test, but still need to fix Dartium.

BUG=13069
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23454012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27215 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 22:02:22 +00:00
blois@google.com 43d28b5ffd Fixing visibilityState APIs in Dart
The event was not being exposed because it does not appear in the IDL and the associated property was not working cross-platform.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23987002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27206 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 18:01:46 +00:00
blois@google.com 871fbc9189 Fixing Element.shadowRoot to work with webkitShadowRoot
Chrome 31 changed it to shadowRoot, need to support the prefixed version as well.

BUG=13061
R=jacobr@google.com

Review URL: https://codereview.chromium.org//23576013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27203 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 17:47:37 +00:00
blois@google.com afd3921b76 Fixing JS size regression from Blink roll.
BUG=
R=jacobr@google.com, sra@google.com

Review URL: https://codereview.chromium.org//23481010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27163 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 22:37:48 +00:00
mcampione@google.com fe2adfdb62 Edited one-liner for SVG. Also regenerated indexeddb doc and httprequest.
BUG=
R=sethladd@google.com

Review URL: https://codereview.chromium.org//23866005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27150 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 20:32:53 +00:00
efortuna@google.com 9f52a2969c Added back childNodes and getAttribute and setAttribute.
This is a quick check to verify that it was this CL:
https://codereview.chromium.org/23189014/ was the cause of the performance
regression. If it is, I have some ideas of potential performance improvements
going forward that we should investigate, and I'll also investigate why I wasn't
getting this performance behavior on my machine locally. Either way, expect at
least one additional change on these APIs going forward.

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23808005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27139 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 19:34:39 +00:00
blois@google.com b14e379d94 Cleaning up a bunch of DOM generation tables
Many unused keys and missing events, etc.

BUG=
R=efortuna@google.com, jacobr@google.com

Review URL: https://codereview.chromium.org//23889005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27137 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 18:30:54 +00:00
blois@google.com e0b7d07337 Fixing Indexed DB from latest Blink roll
Primarily changes to support syntax from:
https://codereview.chromium.org//23788007
https://codereview.chromium.org//23523008

BUG=12948
R=jacobr@google.com

Review URL: https://codereview.chromium.org//23461018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27084 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 23:35:41 +00:00
mcampione@google.com d9be5f5afb added library-level description for dart:indexed_db
BUG=
R=blois@google.com, kathyw@google.com, sethladd@google.com

Review URL: https://codereview.chromium.org//23681003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27076 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 20:24:56 +00:00
blois@google.com 128a95f0a4 Fixing wheel event on Dart2js
Proper fix of doing the new constructor were thwarted by inconsistencies between latest Chrome and stable branch.

TBR
BUG=

Review URL: https://codereview.chromium.org//23837003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26960 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 23:56:10 +00:00
jacobr@google.com f59872ee07 Missed one template from the previous CL to unbreak indexed_db.
Remove invalid calls to the _count method. This is a short term fix to make the build green.  Blois will be submitting the correct fix.

BUG=

Review URL: https://codereview.chromium.org//23523008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26958 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 23:12:59 +00:00
jacobr@google.com 792918a7de Remove invalid calls to the _count method. This is a short term fix to make the build green. Blois will be submitting the correct fix.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23788007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26956 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 23:01:13 +00:00
blois@google.com 0bea9648e1 Fixing console.
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org//23496029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26955 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 22:32:32 +00:00
jacobr@google.com c9378836aa Remove obsolete manually defined _deltaX and _deltaY members.
BUG=

Review URL: https://codereview.chromium.org//23532023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26949 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 21:37:09 +00:00
jacobr@google.com 013e3bb062 Dart binding changes to along with Blink merge 155942-156717
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23829002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26948 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 21:24:02 +00:00
blois@google.com 6570db562c Revert "Basic functionality is working with JS native support and polyfill, still some issues with dart2js typechecking."
This reverts commit r26935. Failing in FF checked on type extension and IE9 on synchronous constructor upgrading, need to investigate.

TBR
BUG=

Review URL: https://codereview.chromium.org//23567006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26938 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 19:37:23 +00:00
blois@google.com 8fe0dd796d Fixing mouse clicks on IE11 Preview
The previous fix works for RTM but not the current version.

TBR
BUG=

Review URL: https://codereview.chromium.org//23483025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26937 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 19:27:38 +00:00
blois@google.com 5607d75eca Basic functionality is working with JS native support and polyfill, still some issues with dart2js typechecking.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23190026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26935 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 19:08:19 +00:00
efortuna@google.com 47dcd084f3 Removing more dom_ methods (dom_getAttribute and dom_setAttribute.).
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23189014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26928 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 17:18:40 +00:00
ngeoffray@google.com 944aca6de7 HTML types that don't have [] do not implement JavaScriptIndexingBehavior, that is, the items cannot be accessed through [] in JavaScript.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//23499007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26911 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 13:27:27 +00:00
blois@google.com 205058d856 Adding an easy way to allow inline style attributes through sanitization
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//23793004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26899 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 01:05:30 +00:00
blois@google.com 5eade2a0e6 Fixing mouse events on IE11.
IE11 is passing PointerEvents in place of MouseEvents.

BUG=12744
R=sra@google.com

Review URL: https://codereview.chromium.org//23479008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26890 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-29 19:52:21 +00:00
blois@google.com 78487899af Attempting to fix IE9 XHR cross domain flakiness.
Appears to be related to http://social.msdn.microsoft.com/Forums/ie/en-US/30ef3add-767c-4436-b8a9-f1ca19b4812e/ie9-rtm-xdomainrequest-issued-requests-may-abort-if-all-event-handlers-not-specified

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23441013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26875 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-29 16:30:16 +00:00
mcampione@google.com 3106bb15a0 Added one-liner and "other resources" for dart:html library description
BUG=
R=blois@google.com, efortuna@google.com, kathyw@google.com

Review URL: https://codereview.chromium.org//23437008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26870 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-29 14:27:54 +00:00
blois@google.com 87e39090a1 Exposing native doubles as doubles when they are read-only or method return values.
This keeps num for parameters of operations and fields which are settable. Requested because some DOM APIs (such as Performance.now) don't really make sense returning ints.

BUG=11133
R=vsm@google.com

Review URL: https://codereview.chromium.org//21555003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26817 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 21:07:13 +00:00
blois@google.com 694f960486 Adding warning message when HTML contents get sanitized away.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23511007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26807 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 18:05:18 +00:00
blois@google.com c47eae035f Fixing createFragment on IE9 Table elements
Basically IE9 does not support innerHTML on table elements, so need to go one level up and wrap everything in a <table> tag.

Another issue is that IE9 does not support creating body elements or the matches call when the element is not in the document, updated the test to account for these.

BUG=12830
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23646003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26806 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 18:03:12 +00:00
floitsch@google.com 74da0c7286 Remove usage of dart:json.
R=jmesserly@google.com, lrn@google.com, nweiz@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//23596007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26789 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 14:05:11 +00:00
blois@google.com b576296c39 Fix for IE9 html/htmlcollection test with Safe HTML
Issue is that IE9 uses uppercase attribute name when it's a boolean attribute, so was getting stripped.

BUG=

Review URL: https://codereview.chromium.org//23661002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26759 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 01:33:57 +00:00
blois@google.com 93c361dd36 This is an updated version of https://codereview.chromium.org/16374007/
Original submission is the first patch, fixes are the second.

There were two issues with the original-
  - Issue with URI sanitization where relative URIs on IE were being dropped.
  - Analyzer issue on missing members for CustomElement.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23525003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26757 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 01:03:01 +00:00
blois@google.com a85f2a8d4c Changing onCreated callback to created.
Brings it in-line with the browser's createdCallback and Polymer's created. Avoid conflict with event names.

Dartium changes are https://codereview.chromium.org/23494005

BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org//23451006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26754 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 23:51:42 +00:00
blois@google.com 7c393eb095 Adding support for cross-origin requests on IE9.
BUG=12728
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23640003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26752 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 23:27:59 +00:00
blois@google.com 24e9f22c90 Revert "First rev of Safe DOM"
This reverts commit 26681.

Some IE issues with URL validation that I need to investigate further.

BUG=

Review URL: https://codereview.chromium.org//23523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26682 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 02:18:48 +00:00
blois@google.com 63ecf1a3fd First rev of Safe DOM
BUG=
R=jacobr@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org//16374007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26681 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 01:48:13 +00:00
blois@google.com 6fc3035bc3 Adding API to remove send ports from Window.
BUG=11658
R=vsm@google.com

Review URL: https://codereview.chromium.org//22263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26679 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 00:44:37 +00:00
blois@google.com fc0158645a Bringing back CanvasElement.toDataUrl docs.
BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23332021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26669 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 21:33:02 +00:00
efortuna@google.com 788716ff03 Remove keyIdentifier from KeyboardEvent factory constructor.
The new abilitity to specify a keycode/charcode/keyIdentifier will be allowed in
our custom KeyEvent implementation coming in a subsequent CL.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23004009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26656 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 16:43:55 +00:00
efortuna@google.com 92d2bd8c28 Fix api for dart2js tests that failed.
BUG=

Review URL: https://codereview.chromium.org//23060041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26606 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 19:15:33 +00:00
efortuna@google.com 90873051ad Making almost all dom_ methods private. Exceptions will be addressed in a later CL.
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23055008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 18:25:40 +00:00
vsm@google.com f1f2431bef Platform.upgradeCustomElements for Dartium
Using this as a workaround for 12642.

R=blois@google.com

Review URL: https://codereview.chromium.org//22891020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26602 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 16:12:08 +00:00
jacobr@google.com 05f9ed2189 Re-enable NodeIterator
A matching Dartium CL does the heavy lifting.
BUG=

Review URL: https://codereview.chromium.org//22859044

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26502 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 01:41:06 +00:00