blois@google.com
c2f5471669
Removing Element.createdCallback
...
This was a placeholder for before dart2js converted to the constructor, can now be removed.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//26592009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28465 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 16:59:19 +00:00
efortuna@google.com
95c3be5481
Made index_db Cursor.next behavior consistent between JS and vm.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//26703006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28431 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 23:45:59 +00:00
efortuna@google.com
a8f1004971
Add "matchingTarget" function to Event, which is the Element that matched the CSS value selector.
...
Bug fix for https://code.google.com/p/dart/issues/detail?id=12931
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//26722002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28430 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 23:43:20 +00:00
efortuna@google.com
4a96ec62b6
Dartium KeyEvent fix.
...
BUG=
Review URL: https://codereview.chromium.org//26561004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28377 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 20:31:22 +00:00
efortuna@google.com
67a56ef1f2
Fix KeyEvent (factory) constructor in Dartium.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//26247006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28376 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 19:43:14 +00:00
efortuna@google.com
79d6ca8285
Reapply KeyEvent improvements.
...
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//26279008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28370 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 18:10:24 +00:00
blois@google.com
108dec86bd
Fixing Node.clone not returning upgraded custom elements.
...
This was an issue for Polymer as the templates are cloned with shallow clones.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//25719003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28363 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 16:02:49 +00:00
asiva@google.com
33b96c8696
Pass in domData as a parameter to unwrapDartWrapper.
...
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//26051003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28353 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 03:25:48 +00:00
efortuna@google.com
9c5078b378
"Reverting 28321"
...
BUG=
Review URL: https://codereview.chromium.org//26334002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28323 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-07 20:11:16 +00:00
efortuna@google.com
c5fe58c61c
Fully polyfill KeyEvent so that you can programmatically create your own "keyboard" events.
...
Added some test cases as well.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//23455033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28321 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-07 19:40:17 +00:00
efortuna@google.com
a131ab528c
Add scrollIntoViewIfNeeded on Dartium.
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//26077002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28310 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-07 16:34:30 +00:00
lrn@google.com
e3713a08d4
Make List.shuffle take an optional Random object to use.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//25931003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28305 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-07 12:07:30 +00:00
sra@google.com
4a7f956118
Call .created constructor on dart2js custom elements
...
R=blois@google.com
Review URL: https://codereview.chromium.org//26089002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28294 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-05 00:55:23 +00:00
efortuna@google.com
eaa854b258
Move Rectangle and Point into dart:math.
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//25808002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28272 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 17:47:39 +00:00
jacobr@google.com
a58c78b821
Support defining console variables with var consoleVar = someValue syntax
...
rename $var to $consoleVariables
move detection of JS console logic to .dart code from .js code
See https://codereview.chromium.org/24989007/ for the matching Blink change.
BUG=
R=blois@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//25570002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28243 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 20:40:14 +00:00
hausner@google.com
e4a1692469
Fix Microtask.dart
...
Change illegal const instance field into final field. Fix dartium build.
Review URL: https://codereview.chromium.org//25925002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28239 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 19:52:52 +00:00
asiva@google.com
19a260904e
Generate a library ID instead of a library name, so that the ID can be used
...
to get the library handles from the cache (avoids having to lookup everytime)
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//25626002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28226 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 16:21:17 +00:00
lrn@google.com
55a8a72ca6
Add List.shuffle().
...
Will add tests too.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//24740003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28206 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 11:09:01 +00:00
vsm@google.com
8480c79e54
Remove spawnDomIsolate code
...
This is more or less a straight remove of code. By disabling print and timers on background isolates in Dartium, we can get rid of the last vestiges of spawnDom*.
R=asiva@google.com
Review URL: https://codereview.chromium.org//25536007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28191 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 03:20:00 +00:00
efortuna@google.com
0b53b15b7d
"Reverting 28184"
...
TBR=blois
BUG=
Review URL: https://codereview.chromium.org//25785003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28186 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 22:13:16 +00:00
efortuna@google.com
837c6b6ee3
Move Point and Rect over to dart:math, to be re-exported by dart:html.
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//25623002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28184 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 21:54:02 +00:00
blois@google.com
c801e99a65
Adding custom element lifecycle processing to all attribute modifiers.
...
This is needed for the custom element attributeChanged lifecycle event. It appears to be the same thing that V8 is currently doing.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//25666008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28179 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 19:48:10 +00:00
blois@google.com
05bb03642d
Implementing CustomElement's attributeChanged callback in dart2js.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//25325004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28168 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 15:57:56 +00:00
blois@google.com
1aa8a7be0e
Adding Element.created constructor and .created constructors to all subclasses. Also ensuring generative constructor for all superclasses.
...
This is for post-construction custom element creation.
Element.created is public, then the base classes of that get private ._created constructors.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//24653006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28120 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 21:26:06 +00:00
blois@google.com
1cd1624b46
Fixing File API test.
...
This started failing from a chrome roll, and is now half-failing on the bots as the Chrome version upgrades. Appears that the EntryArray type was removed, so this adds it back.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//25603002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28118 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 21:09:57 +00:00
rmacnak@google.com
5f8eca4fc3
Remove NPObject from generated dart:html for Dartium.
...
R=asiva@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//25405002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28117 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 20:51:31 +00:00
efortuna@google.com
d5212a6ac0
Make OptionElement construtor arguments named optional parameters.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//25585002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28115 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 20:33:49 +00:00
efortuna@google.com
d06cbc3f28
Adjust HTTP Request docs.
...
BUG=
Review URL: https://codereview.chromium.org//25027005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28025 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-27 20:49:33 +00:00
floitsch@google.com
2b550970e6
Run DOM callbacks in the zone they are coming from.
...
This CL is an adapted version of: https://chromiumcodereview.appspot.com/23054006/
R=blois@google.com
Review URL: https://codereview.chromium.org//24509004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27961 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-26 16:50:25 +00:00
blois@google.com
b73395196c
Fixing docs generation
...
From dartium revision, inlined createElement, so it's no longer getting this doc comment.
Also, this was recently made public as there are valid use cases for it, so the comment was misleading.
TBR
BUG=
Review URL: https://codereview.chromium.org//24571003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27923 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 23:29:15 +00:00
blois@google.com
354c4dd5ad
Revert "Revert "Start of dartium custom element lifecycle event support.""
...
Primary changes are that a fast-path has been added for the single-argument Document.createElement and the systemnative.py changes were split out to CL https://codereview.chromium.org/24661002/ .
This is dependent on https://codereview.chromium.org/24677002/
First patch is the original, second is the updates.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//24491003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27921 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 23:15:09 +00:00
efortuna@google.com
c8fde9aa01
Fixed more HttpRequest documentation.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//24670002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27912 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 21:03:00 +00:00
blois@google.com
f4734449cd
Emitting CustomElementCallbackDispatcher for all APIs impacting custom element lifecycle
...
This is part of getting custom element lifecycles working in Dart and follows the same model that V8 is using. Basically it ensures that the lifecycle events are processed after any operations which may have custom element side-effects.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//24661002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27910 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 20:34:33 +00:00
efortuna@google.com
63f0ac715d
Adjust _chrome library name to point to correct file (_chrome.dart instead of chrome.dart).
...
BUG=
R=dgrove@google.com
Review URL: https://codereview.chromium.org//24438009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27909 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 20:31:46 +00:00
efortuna@google.com
f45e68f435
Adjusted HttpRequest documentation to discourage using open and send in simple cases.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//24428003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27901 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 18:20:25 +00:00
efortuna@google.com
3854434797
Removed position and totalSize because HttpRequestProgressEvent has other fields that do the same thing.
...
Turns out position and totalSize were on Firefox 3 and earlier, but we don't
have to worry about backwards compatibility that far.
https://developer.mozilla.org/es/docs/XMLHttpRequest/Usar_XMLHttpRequest
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//24427003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27900 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 18:03:20 +00:00
blois@google.com
3fd115d5e3
Revert "Start of dartium custom element lifecycle event support."
...
This reverts commit 27718 to see if it gets performance back down.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//24479002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27897 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 17:56:53 +00:00
dgrove@google.com
dcd741bd99
Move dart:chrome to dart:_chrome.
...
Turn off doc generation for dart:_chrome.
R=efortuna@google.com
Review URL: https://codereview.chromium.org//23654055
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27861 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 23:52:16 +00:00
efortuna@google.com
9c59a54913
"Reverting 27844"
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//24408004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27848 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 20:25:16 +00:00
efortuna@google.com
b7c5067cbc
Try caching attribute map to try to improve performance.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//24267028
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27844 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 19:52:06 +00:00
blois@google.com
209e413a5c
Retry of custom element lifecycle events.
...
First patch is the original, changes were:
- Shadow DOM upgrade landed as separate CL
- CustomElement polyfill wasn't always firing WebComponentsLoaded event (causing timeouts on FF and IE), fixed polyfill.
- Dartium test exclusions were not working
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//23498053
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27841 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 19:14:16 +00:00
asiva@google.com
928894a58c
- Added Dart_GetNativeIsolateData so that the bindings code can access the IsolateCurrentData
...
where possible without having to invoke Isolate::Current()
- Modified lookupWrapper to accept DartDOMData as a parameter so that the return to Dart functions
won't invoke Isolate::Current()
Some Dromaeo numbers before this change:
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr getAttribute runs-per-second 1162.2
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr element_property_access runs-per-second 1255.6
after this change:
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr getAttribute runs-per-second 1237.6
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr element_property_access runs-per-second 1385.4
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//24376005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27789 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-23 23:53:39 +00:00
blois@google.com
6def065afd
Revert "Dart2js support for custom element lifecycle events"
...
This reverts commit 27729. Shadow DOM polyfill appears to have regressed some tests and some issues are coming up with the browser controller.
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//24251016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27730 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-21 00:46:48 +00:00
blois@google.com
fb8f32bcc4
Dart2js support for custom element lifecycle events
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//24096027
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27729 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-20 23:49:12 +00:00
blois@google.com
34f58a8209
Start of dartium custom element lifecycle event support.
...
These are the Dart repo changes paired with https://codereview.chromium.org/24294002/
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//23817006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27718 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-20 18:40:11 +00:00
asiva@google.com
ca128dea70
- Modify toDart to first do a simple lookup in the appropriate table before going down the templatized
...
morass of switch statements
- Add a returnToDart function so that the WeakPersistent Handle returned from a lookup/create of the wrapper
could be returned as is without the need to call Dart_handleFromWeakPersistentHandle
- Use Dart_SetDoubleReturnValue for doubles
some DromaeoDartium numbers before this change:
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(div) runs-per-second 84240.6
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-traverse nextSibling runs-per-second 207.91683326669332
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(*) runs-per-second 69599.2
some DromaeoDartium numbers after this change:
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(div) runs-per-second 104252.4
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-traverse nextSibling runs-per-second 366.8
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(*) runs-per-second 94922.6
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//23681014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27710 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-20 16:25:12 +00:00
whesse@google.com
c41a588dc0
Disable 20s unittest timeout for docs_test and dartdoc_test.
...
Thes tests have started occationally timing out on the pub_linux buildbot.
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//23465028
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27658 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-19 13:25:36 +00:00
vsm@google.com
e0a30046ef
Remove spawnDomFunction from dart:html
...
Note, spawnDomFunction is still used under the hood in Dartium to
implement Timers and printing in background isolates. I don't think
this is necessary, but I'll clean up in a separate CL once we decide
what we're doing with background isolates.
R=blois@google.com
Review URL: https://codereview.chromium.org//23868034
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27577 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-17 17:26:58 +00:00
jacobr@google.com
d9b198f2bf
Cleanup bugs in wrapExpressionAsClosure Fix bug in how setters were handled and filter out 'this' from local variables list.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//23514061
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27576 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-17 17:08:40 +00:00
blois@google.com
5f2320dea7
Making Document, Element and Window documentable via @DocsEditable
...
TBR
BUG=13291
Review URL: https://codereview.chromium.org//23591046
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27503 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-13 21:23:07 +00:00