Commit Graph

1657 Commits

Author SHA1 Message Date
jacobr@google.com c274135947 Revert "Revert breaking CL"
This reverts commit 582a7848d7ad11fe981257598124431e36a9c982.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//35513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29014 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:15:03 +00:00
efortuna@google.com f4e40d6d9a Make getLineDash return [] instead of null if it has not yet been set.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//27983005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29013 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 17:40:58 +00:00
blois@google.com c1a11e55d5 Adding validation that Custom element constructor has zero args
BUG=13800
R=vsm@google.com

Review URL: https://codereview.chromium.org//30283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29011 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 17:20:46 +00:00
blois@google.com cf9be8e65b Tightening up custom element registration for dart2js
BUG=14093
R=sra@google.com

Review URL: https://codereview.chromium.org//34203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29007 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 16:40:56 +00:00
blois@google.com 980834fe33 Validating that types which require extendsTag actually provide it
BUG=14292
R=vsm@google.com

Review URL: https://codereview.chromium.org//32703006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29004 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 16:14:17 +00:00
vsm@google.com e92900f914 Revert breaking CL
Revert "Companion to https://codereview.chromium.org/33973002 Generate correct source locations for Dart log messages."

TBR=jacobr@google.com
BUG=

Review URL: https://codereview.chromium.org//32643009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28981 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 04:30:23 +00:00
jacobr@google.com c74e0cec97 Companion to https://codereview.chromium.org/33973002 Generate correct source locations for Dart log messages.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//33993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28976 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 00:46:02 +00:00
efortuna@google.com 250b113caf Mark jQuery methods as experimental.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//33433005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28967 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 23:09:17 +00:00
efortuna@google.com 7da21ce566 Allow all events to be accessed via on[foo] instead of just onFoo
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//29843004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28966 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 23:07:18 +00:00
amouravski@google.com 0177ed7ae4 CanvasRenderingContext2D.fillText now works correctly with null maxWidth.
BUG=13369
R=efortuna@google.com

Review URL: https://codereview.chromium.org//29273005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28963 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 22:09:07 +00:00
efortuna@google.com 8e4205db3a Reapply remove upgradeCustomElement methods.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//33593003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28960 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 21:55:40 +00:00
efortuna@google.com 37989cf2ce "Reverting 28947"
TBR
BUG=

Review URL: https://codereview.chromium.org//33643002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28949 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 20:48:18 +00:00
efortuna@google.com 3a4a3ba95f Remove Platform.upgrateCustomElements.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//31993005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28947 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 20:21:28 +00:00
jacobr@google.com 5ee178076a A few API changes:
Remove Callback in favor of directly using closures or JsFunction.withThis().
Move jsify() to a named constructor on JsObject.
 - Throw on types other than Map and Iterable.
 - Handle cycles
Add JsObject.fromDartObject() which force a transferrable native to be proxied.

Still to do: Reach a conclusion on Serializable

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//27514003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28902 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-19 04:36:10 +00:00
blois@google.com e7aef33a2c Fixing custom element type extensions in Dartium to have correct native type ID
This is in support of the recent change to write the native type ID to the Dart wrappers

Dart changes for https://codereview.chromium.org/27769002/

BUG=14190
R=vsm@google.com

Review URL: https://codereview.chromium.org//29033003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28899 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 23:43:45 +00:00
efortuna@google.com 4f06435c24 Make AudioContext work in iOS 7.
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//29583004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28877 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 20:37:09 +00:00
kevmoo@j832.com cf134382a1 Set.add returns true if item has been added, otherwise false
BUG= https://code.google.com/p/dart/issues/detail?id=3546
R=floitsch@google.com

Review URL: https://codereview.chromium.org//26280002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28863 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 17:24:24 +00:00
efortuna@google.com 9c2f329e56 Remove defaultSelected property.
BUG=https://code.google.com/p/dart/issues/detail?id=4958
R=blois@google.com

Review URL: https://codereview.chromium.org//27516011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28832 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 22:38:47 +00:00
blois@google.com ee30fc06fb Converting Polymer and TemplateElement to use deprecated Node.document
Because Polymer dart2js tests actually execute dart, the bots are red because the corresponding changes haven't made it into Dartium.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//27773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28830 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 22:04:11 +00:00
asiva@google.com ab61301521 Generate a class table of all the IDL classes in the database. This table is used
to access the C++ class hierachy information to do a proper subtype of check.

The new subtype of check improves the following benchmarks
Dromaeo-drt dom-modify appendChild runs-per-second from 889.0 to 1575.0
Dromaeo-drt dom-modify insertBefore runs-per-second from 592.4075924075925 to 1298.0

The generated class table is as follows:
enum {
    _HistoryCrossFrameClassId = 0,
    _LocationCrossFrameClassId,
    _DOMWindowCrossFrameClassId,
    _DateTimeClassId,
    // New types that are not auto-generated should be added here.

    ANGLEInstancedArraysClassId,
    AbstractWorkerClassId,
    ....
    ....
};
typedef struct {
    const char* class_name;
    int library_id;
    int base_class_id;
    bool is_node;
    bool is_active;
    bool is_event;
} _Classinfo;
typedef _Classinfo _DartWebkitClassInfo[NumWebkitClassIds];

_DartWebkitClassInfo DartWebkitClassInfo = {
    { "_HistoryCrossFrame", DartHtmlLibraryId, -1, false, false, false },
    { "_LocationCrossFrame", DartHtmlLibraryId, -1, false, false, false },
    { "_DOMWindowCrossFrame", DartHtmlLibraryId, -1, false, false, true },
    { "DateTime", DartCoreLibraryId, -1, false, false, false },
    // New types that are not auto-generated should be added here.

    { "AngleInstancedArrays", DartWebGlLibraryId, -1, false, false, false, },
    { "AbstractWorker", DartHtmlLibraryId, -1, false, false, false, },
    .....
    .....
};

R=rmacnak@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//27358002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28821 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 20:27:30 +00:00
blois@google.com 358392883c Adding ElementEventStream.capture
Also making Element.on[] return an ElementStream.

BUG=13214
R=efortuna@google.com

Review URL: https://codereview.chromium.org//26135004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28819 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 20:19:46 +00:00
blois@google.com 89802cee42 Updating CustomElement lifecycle scope logic
More closely following what V8 is doing in:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.pm&l=1725

Primary issue was that this was being emitted in too many places (getters and attributes which didn't need it).

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//25675008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28818 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 20:13:14 +00:00
blois@google.com a86bee09de Fix for events not firing on sanitized elements
Issue was that the events weren't being raised when the elements were in documents without views.

BUG=14184
R=efortuna@google.com

Review URL: https://codereview.chromium.org//26557004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28817 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 19:58:14 +00:00
blois@google.com cb304c5ea7 Adding HttpRequest.responseHeaders
The code is mostly from Closure's getResponseHeaders function, with modifications to make the keys case-insensitive (following jQuery's model).

BUG=13584
R=efortuna@google.com

Review URL: https://codereview.chromium.org//26893008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28812 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 18:11:00 +00:00
blois@google.com e3b35dabb6 Renaming Node.document back to Node.ownerDocument
With custom elements, the document instance variable creates an odd conflict with the document global.

BUG=14099
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//27602002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28810 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 17:55:38 +00:00
blois@google.com 0c4f4dce36 Fixing dart2js size regression from CustomElement.detail
The annotation for CustomEvent.detail was being dropped.
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//26115003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28807 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 17:36:58 +00:00
floitsch@google.com af06e8ba5a Fix scheduleImmediate in Dartium.
BUG= http://dartbug.com/14146
R=blois@google.com

Review URL: https://codereview.chromium.org//27543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28792 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 08:59:32 +00:00
blois@google.com 679c9ed699 Fixing mirrors on Window, Document and Element
BUG=13654
R=efortuna@google.com

Review URL: https://codereview.chromium.org//27429002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28772 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 01:27:20 +00:00
blois@google.com 7aa71c22cf Removing dart2js's extends tag inference
Since this is now required in the spec and Dartium, no longer need this lookup code for dart2js.

BUG=13839
R=efortuna@google.com

Review URL: https://codereview.chromium.org//27063005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28771 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 01:23:11 +00:00
blois@google.com ef3ab25c69 Fixing double-completing indexed DB transactions
Basically when an error occurs, aborted occurs as well, causing an error because the future was being completed more than once.

BUG=11405
R=efortuna@google.com

Review URL: https://codereview.chromium.org//26789008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28770 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 01:07:17 +00:00
blois@google.com 333054ee75 Supporting non-SSVs in CustomEvent.detail
BUG=12641
R=vsm@google.com

Review URL: https://codereview.chromium.org//27308006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28758 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 23:09:33 +00:00
ajohnsen@google.com 762ac7f511 Add support for micro-tasks in Dartium.
We are using the MutationObserver to schedule immediate events.

BUG=
R=blois@google.com, floitsch@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//25722010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28715 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 09:16:22 +00:00
blois@google.com 19655e4e6b Revert "Revert "Removing setImmediate and hiding WindowTimers interface""
Issue was that requestAnimationFrame got removed from Dartium during a merge conflict :(

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//27441002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28700 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:50:49 +00:00
efortuna@google.com 951dca71cb Deprecate query and queryAll, also add back querySelector and querySelectorAll.
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org//27223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28699 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:44:47 +00:00
blois@google.com 8e255ada0f Revert "Removing setImmediate and hiding WindowTimers interface"
This reverts commit 28690.

TBR
BUG=

Review URL: https://codereview.chromium.org//27440002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28696 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:16:59 +00:00
blois@google.com 303710040b Removing setImmediate and hiding WindowTimers interface
These timing APIs are all redundant with dart:async and those versions should be used instead.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//26534005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28690 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 23:52:09 +00:00
blois@google.com 4c06ef7fb8 Dartium build issue w/ mutation observers
Last fix for mutation observers had a typo in Dartium (wish I could build both from the same enlistment!).

TBR
BUG=

Review URL: https://codereview.chromium.org//26539014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28683 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 21:06:54 +00:00
blois@google.com ea5d14dd91 MutationObserver changes for zones (again)
Missed that the _wrap only takes one arg, added the two arg version. Unfortunately the tests for this are around upgrading and is really flaky (often passing on my machine).

TBR
BUG=

Review URL: https://codereview.chromium.org//27403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28680 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 20:39:14 +00:00
blois@google.com 4e01232e26 Fixing MutationObserver constructor from zones change
TBR
BUG=

Review URL: https://codereview.chromium.org//26442003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28679 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 19:59:45 +00:00
blois@google.com 9baacafa7a Making all callbacks use zones (take 2)
Changes: fixed parameter ordering for RTCPeerConnection.getStats and fixed error for StorageInfo.

Revert "Revert "Making all callbacks use zones""

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//27240004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28674 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 19:07:22 +00:00
sra@google.com c66099f078 Tighter native type annotations for some elements returning Lists
We need to be more careful with type annotations on native elements now that some classes implement List<dynamic>.

R=blois@google.com

Review URL: https://codereview.chromium.org//26971005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28626 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 01:45:17 +00:00
efortuna@google.com c40372622f Update docs so that responseText returns empty String on failure.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//27263003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28625 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 01:00:47 +00:00
efortuna@google.com 035e04fb2d Making all base class DOM types throw as well (to prevent a default constructor for DOM types that are not constructable).
BUG=https://code.google.com/p/dart/issues/detail?id=11620
R=blois@google.com

Review URL: https://codereview.chromium.org//27033009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28615 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 21:58:46 +00:00
blois@google.com e1d441b22f Revert "Making all callbacks use zones"
This reverts commit 28607, running into analyzer issues.

TBR
BUG=

Review URL: https://codereview.chromium.org//27232003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28609 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 20:23:11 +00:00
blois@google.com 84a3415e82 Making all callbacks use zones
This was primarily converting APIs to use Futures, all appear to be new ones since we did the last pass.

MutationObserver and Window.requestAnimationFrame had to be fixed manually.

BUG=
R=efortuna@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org//27082002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28607 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 19:49:17 +00:00
blois@google.com 5a06040888 Dart changes for https://codereview.chromium.org/26571005/
Ensuring that custom elements have correct super classes.

BUG=

Review URL: https://codereview.chromium.org//27222003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28603 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 19:29:42 +00:00
blois@google.com f51dad91fd Untyping List types
Making all DOM lists implement List rather than List<T>. This is primarily for NodeList which is used in cases where it's just a list of Elements and allows us to assign it to List<Element> without type checks.

BUG=
R=sra@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//27227002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28597 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 18:36:59 +00:00
blois@google.com 0ae3c96faf Removing explicit custom element upgrade for Dartium
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//27048002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28556 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 21:13:56 +00:00
floitsch@google.com 8882916b21 Update dom streams with new signatures.
Review URL: https://codereview.chromium.org//27036002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28517 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 14:44:52 +00:00
efortuna@google.com ef9419dc95 Convert keys in dataSet to camelCase instead of dasherized.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//26917002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28482 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 21:42:13 +00:00