Commit Graph

2501 Commits

Author SHA1 Message Date
sgjesse@google.com a2875d1768 Fix bug in caching of chunked transfer encoding in HTTP headers
R=ajohnsen@google.com
BUG=http://dartbug.com/20335

Review URL: https://codereview.chromium.org//460653002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39116 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 06:39:12 +00:00
koda@google.com df87039699 Avoid linear search for function lookup.
R=iposva@google.com

Review URL: https://codereview.chromium.org//421913010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39101 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 19:27:59 +00:00
koda@google.com e2546942c3 Move service library test into observatory package.
This depends on https://codereview.chromium.org/434883002/

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//445023003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38985 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 13:24:55 +00:00
whesse@google.com 19beb61abc Update mips test status.
R=ricow@google.com

Review URL: https://codereview.chromium.org//439283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38861 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-04 15:19:10 +00:00
hausner@google.com 4258c115b4 Handle load errors in deferred code
IO errors on the URL of a deferred library are forwarded to the Future
that handles the deferred load. Syntax errors and finalization errors
are lethal, killing the isolate.

Review URL: https://codereview.chromium.org//419103003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38800 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-31 21:09:33 +00:00
johnmccutchan@google.com 2e59674838 Initial backend for metrics in Observatory.
Two types of metrics:

* Counter - a measured value
* Gauge - A measured value with a min and max

Follow up CLs for the backend:

* Support for internal VM metrics (implemented in C++ but visible over the service).

Follow up CLs for the frontend:

* Query list of metrics
* Get latest value of a metric
* Collect values over time and graph them.

I'd like some feedback on the API and the data reported.

R=koda@google.com

Review URL: https://codereview.chromium.org//409213004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38793 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-31 18:27:38 +00:00
koda@google.com 573b104181 Update service lib test status to Fail due to Windows symlink issue.
TBR=johnmccutchan@google.com
BUG=dart:20298

Review URL: https://codereview.chromium.org//437553003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38790 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-31 17:33:28 +00:00
koda@google.com 337cd2f153 First unit test using service lib.
Add symlink to allow using observatory package from tests.
Add simple test of allocation stats.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//436463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38788 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-31 16:35:58 +00:00
mlippautz@google.com 47c8f8b3e2 Reland transformation of async functions.
Reland https://codereview.chromium.org/362153002/

Additions:
 * Fixes for parsing async "keyword".
 * Further tests.

BUG=
R=hausner@google.com

Review URL: https://codereview.chromium.org//423213005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38715 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-29 23:50:33 +00:00
mlippautz@google.com be3e426f27 Revert async changes.
Revert "Transform functions marked as async"
This reverts commit 79cbaaf60143babcb29bb0ed74a0da87fd998c39.

Revert "Fix snapshot test"
This reverts commit ee892aa105daccc74c734eb18934814b76a415bb.

BUG=

Review URL: https://codereview.chromium.org//428993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38690 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-29 18:42:53 +00:00
mlippautz@google.com d5298cafad Fix snapshot test
https://code.google.com/p/dart/source/detail?r=38681

changed size of kind tags in function, thus breaking this test

BUG=

Review URL: https://codereview.chromium.org//427823003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38683 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-29 17:37:37 +00:00
srdjan@google.com 79f2ca4896 Fix issue 20190: Mark Uint32/Int32 typed data load to produce a Mint always on 32-bit architectures, but also to have a deopt_id associates in case we may be able to optimize it to allow Smi as result. No deopt-id needs to be provided/allocated on 64-bit architectures.
R=vegorov@google.com

Review URL: https://codereview.chromium.org//414163003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38635 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-28 18:11:54 +00:00
ajohnsen@google.com eb06b64766 Use toFilePath when extracting the path, in platform_test.
BUG=

Review URL: https://codereview.chromium.org//423863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38618 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-28 13:06:04 +00:00
ajohnsen@google.com d56b11bf59 Compute absolute script path at isolate startup.
BUG=https://code.google.com/p/dart/issues/detail?id=20119
R=whesse@google.com

Review URL: https://codereview.chromium.org//423843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38616 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-28 12:31:29 +00:00
koda@google.com 1cdcb12b4e Add VM class for Map/LinkedHashMap.
Introduces a new internal class for the most common case, the default Map.

Passes all functionality tests.
Slow: Dart side simply calls into runtime for now.
Hidden behind "--use_internal_hash_map".

Add copies of hash map tests to exercise this implementation.

R=asiva@google.com

Review URL: https://codereview.chromium.org//380333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38588 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-25 20:04:11 +00:00
srdjan@google.com 6cd21978f6 Add test for issue 20190.
R=hausner@google.com

Review URL: https://codereview.chromium.org//420503003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38554 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-24 21:28:47 +00:00
asiva@google.com a323a9c9db The dart version of typeddata library has changed to be compatible with the dart2js implementation
(typeddata does not implement ByteBuffer anymore).
Added new Dart API functions to account for this change.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//392043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38351 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-17 22:08:07 +00:00
koda@google.com c645b0ab71 Object ids in snapshots are assigned sequentially, and can in many cases be omitted by the writer and inferred by the reader. The exceptions are the classes that are serialized in two steps (arrays and user-level Dart instances), where the second step must include the id.
For standalone, makes full snapshot 5% smaller, and startup ~1.5% faster when measured on a Nexus 10.

R=zra@google.com

Review URL: https://codereview.chromium.org//387993007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38261 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-15 21:47:00 +00:00
rmacnak@google.com bfd342fd8a Remove MirroredCompilationError from the VM.
Regenerate snapshot test due to removed symbol.

BUG=http://dartbug.com/16562
R=regis@google.com

Review URL: https://codereview.chromium.org//389573007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38202 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-14 18:00:04 +00:00
vegorov@google.com 00daaa6106 Don't assign safepoint at the definition to the definition's live-range.
This avoids treating spill slot associated with the definition live during GC as
it will only be filled in after definition's code is fully executed.

Additionally this makes output register dead for GC inside the definiton itself
which is something we used to guarantee manually by removing it from the
live_registers set before calling on the slow path.

BUG=
R=fschneider@google.com

Review URL: https://codereview.chromium.org//375693004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38059 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-08 14:12:00 +00:00
sgjesse@google.com 8213dd365b Add option to HttpClient to turn of auto uncompression
R=ajohnsen@google.com
BUG=http://dartbug.com/19769

Review URL: https://codereview.chromium.org//370743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38012 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 12:59:37 +00:00
ajohnsen@google.com 877d4c2138 Validate headers when added to HttpHeaders.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//364313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38009 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 11:04:03 +00:00
lrn@google.com 085d99b079 Add typed data view creation functions on ByteBuffer.
This provides a better model and better separation for typed data.

Currently the only thing you can do with a ByteBuffer is pass
it as argument to a typed data .view factory method, which then
uses internal-only functionality to create the view.

With this change, the functionality of creating the view,
and understanding the internals of the ByteBuffer, is put on the
ByteBuffer class itself.

The view constructors on the typed data classes are retained, but
they just forward to the buffer's method. This provides backwards
compatibility and familiarity.

This change allows mocking the ByteData object. There is no hidden
connection between the constructor and the buffer that other objects
can't implement.

The change is non-breaking - it only adds methods to ByteBuffer, and
there have been absolutely no reason to extend ByteBuffer until now,
because it won't work anyway.

R=asiva@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//364833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37974 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 07:48:57 +00:00
koda@google.com 7dfd991f9f Resubmit r37716: Hash tables templates, wrapping Array.
(Patch Set 1 is identical to r37716; Patch Set 2 renames some typedefs to avoid confusing MSVC)

Highly customizable to support various internal uses as well as the basis for user-level classes.

Use in Library's resolved names cache.

Next step is to add new instance classes for the user-level maps/sets (akin to GrowableObjectArray).

TBR=asiva@google.com

Review URL: https://codereview.chromium.org//348313005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37800 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-27 22:34:00 +00:00
koda@google.com 486a4527a5 Revert r37716 due to Windows compilation errors.
TBR=asiva@google.com

Review URL: https://codereview.chromium.org//353553007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37719 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-26 01:45:48 +00:00
koda@google.com 5ef8d94639 Hash tables templates, wrapping Array.
Highly customizable to support various internal uses as well as the basis for user-level classes.

Use in Library's resolved names cache.

Next step is to add new instance classes for the user-level maps/sets (akin to GrowableObjectArray).

R=asiva@google.com

Review URL: https://codereview.chromium.org//304253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37716 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-26 00:51:02 +00:00
mlippautz@google.com f3a187c63e Reland: Fix tools/full-coverage.dart script and add standalone test.
Test checks coverage data of a given script and differentiates between:
* no coverage data
* no hits (IC=0)
* some hits (IC>0)

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//355453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37627 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 22:27:26 +00:00
zra@google.com 2ab7fa6c72 Omits size bits when writing RawObject tags to a snapshot.
Makes snapshot ~30KB smaller.

R=asiva@google.com

Review URL: https://codereview.chromium.org//349293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37626 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 22:18:04 +00:00
mlippautz@google.com b5582cb430 Revert "Fix tools/full-coverage.dart script and add standalone test."
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//343263003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37573 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-21 01:07:51 +00:00
mlippautz@google.com 1c63c09102 Fix tools/full-coverage.dart script and add standalone test.
Test checks coverage data of a given script and differentiates between:
* no coverage data
* no hits (IC=0)
* some hits (IC>0)

BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org//348473004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37571 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-20 23:25:05 +00:00
regis@google.com 8cf0d1034e Ensure that a javascript compatibility warning results in a
JavascriptCompatibilityError being thrown in all cases when --warning_as_error
is specified.
Prior to this change, some javascript compatibility warnings resulted in a
compile time error.
Change expectations accordingly in tests.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//347873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37515 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 20:57:41 +00:00
lrn@google.com c719cb2b33 Mark standalone/io/skip_dart2js_compilations_test as failing on Win.
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//329993005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37490 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 12:40:11 +00:00
lrn@google.com 736db44293 New Uri.parse and validation.
Ensures that the resulting URI is valid.
Escapes invalid characters except the gen-delim group of delimites, where
escapes are allowed.

R=ajohnsen@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//335373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37479 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 09:05:07 +00:00
johnmccutchan@google.com 85c2f8fd45 Regenerate issue 14236
BUG=

Review URL: https://codereview.chromium.org//337383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37399 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 14:54:19 +00:00
johnmccutchan@google.com 03854e0e8c Make TypedList not implement ByteBuffer.
BUG=https://code.google.com/p/dart/issues/detail?id=10136
R=asiva@google.com, iposva@google.com

Review URL: https://codereview.chromium.org//339763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37397 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 14:34:45 +00:00
srdjan@google.com 8f2dc961d0 Save ICData of unoptimized code in the function, thus preserving it across repated unoptimized compilations.
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//335173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37378 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-16 22:24:05 +00:00
lrn@google.com 31eeb6caf2 Revert "New, more validating, parser for URI." and follow-up patches.
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//337033003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37359 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-16 12:32:35 +00:00
whesse@google.com f391b07ccf Improve test_runner_test.
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//332153004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37350 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-16 09:19:23 +00:00
lrn@google.com c7d98e335b New, more validating, parser for URI.
BUG= https://code.google.com/p/dart/issues/detail?id=16081
R=ajohnsen@google.com, fschneider@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//321543003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37346 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-16 07:00:22 +00:00
zra@google.com c46103f74a Updates snapshot test for last commit.
Review URL: https://codereview.chromium.org//330163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37288 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-12 20:37:54 +00:00
srdjan@google.com 4ac409739e Reduce snapshot size by not writing null values for function code fields.
R=iposva@google.com

Review URL: https://codereview.chromium.org//333453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37243 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-11 20:11:47 +00:00
iposva@google.com 5d56c66f30 - Missing file.
Review URL: https://codereview.chromium.org//327993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37209 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 22:57:11 +00:00
ajohnsen@google.com b908de9ec0 Add HttpServerConnection to Observatory.
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//302173007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37166 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 07:33:37 +00:00
ajohnsen@google.com 8719f3834b Add Observatory test of io.
Initially a single test of a HttpServer. More will follow.

This also fixes the case where we don't 'block' when binding to a
ServerSocket. We should not close until the socket is explicitly closed.

BUG=
R=johnmccutchan@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//311153003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37164 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 07:13:52 +00:00
regis@google.com 3617cf8077 Share ic data between unoptimized and optimized static calls.
This prevents duplicated javascript compatibility warnings.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//322633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37103 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 21:47:51 +00:00
regis@google.com eef5589182 Add javascript compatibility warnings for integer values and integral double
values that are not identical, but equal.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//317793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37017 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-04 23:14:03 +00:00
regis@google.com 139187ae5f Add javascript compatibility warnings for strings that are not identical, but
equal. The vm does not canonicalize all strings as javascript does.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//312693008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37013 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-04 20:47:54 +00:00
turnidge@google.com 40d6a1de87 Observatory now uses websockets to communicate with the vm.
- Added WebSocketVM class.

- Changed the vmservice websocket request format from:
     path: ['this', 'is', 'the', 'old]
  to:
     request: 'this/is/the/new'

- Updated tests.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//305603004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36894 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-02 19:56:03 +00:00
ajohnsen@google.com 4daef42a37 Enable throttleing of HttpClient per host, with default being 6.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//311513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36861 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-02 10:38:02 +00:00
ajohnsen@google.com e6137e4d1e When a connection is upgraded, don't return it as idle.
Instead we now simply close the socket and return a 'done' stream
subscription, if the user listened to the response. The only way to get
data from a 'upgraded' response, is now by actually doing a detach.

BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//308923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36858 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-02 08:17:38 +00:00