Commit Graph

2501 Commits

Author SHA1 Message Date
whesse@google.com 9b1a6aa809 Add mips failures to status files.
BUG=dartbug.com/17440
R=kustermann@google.com

Review URL: https://codereview.chromium.org//203313005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33811 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 16:20:36 +00:00
whesse@google.com 62c79adbd0 Add entries for ContentShellOnAndroid runtime to status files.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//203373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33807 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 14:47:56 +00:00
iposva@google.com e375116014 - Update status file to reflect fixed tests.
Review URL: https://codereview.chromium.org//202593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33779 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 21:37:01 +00:00
turnidge@google.com 7fbb7cd5dc Rework library and class view pages.
Add expression evaluation support for libraries and classes.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//199363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33755 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 17:43:07 +00:00
whesse@google.com bc124036fa Fix SecureSocket tests to look up localhost only once, where possible.
This is needed because 0.01% of the time, macos will return an IPv6 address for localhost, instead of IPv4, or vice versa.

BUG=dartbug.com/12837
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//201993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33750 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 16:15:19 +00:00
sgjesse@google.com 6a8e27ca96 Add fixed content type values for commonly used content types
This add fixed ContentType instances for:

  text/plain; charset=utf-8
  text/html; charset=utf-8
  application/json; charset=utf-8
  application/octet-stream

R=ajohnsen@google.com
BUG=

Review URL: https://codereview.chromium.org//195893019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33744 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 13:27:54 +00:00
ajohnsen@google.com 8fc417a717 Add validation to construction of Cookie objects.
BUG=https://code.google.com/p/dart/issues/detail?id=17135
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//196723020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33741 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 12:39:16 +00:00
whesse@google.com 1544954a72 Add supression for content shell crash to status file.
BUG=dartbug.com/17525
R=ricow@google.com

Review URL: https://codereview.chromium.org//201733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33738 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 11:19:30 +00:00
ajohnsen@google.com 09a4f24413 Add exitCode getter counterpart to the existing setter in dart:io.
BUG=https://code.google.com/p/dart/issues/detail?id=16217
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//200233002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33737 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 10:40:19 +00:00
whesse@google.com 94bb9fe991 Add ContentShellOnAndroid to co19 and standalone status files.
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//200223007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33700 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 15:38:24 +00:00
ricow@google.com 753ce1d869 Remove suppression for standalone/vmservice/isolate_echo_test
This was due to a output mismatch on the cross compiled output (as in a left over old version being used)

I will mark issue 17431 as fixed

Review URL: https://codereview.chromium.org//200013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33686 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 07:59:13 +00:00
efortuna@google.com 91fcfad0ec Fix analyzer. Don't analyze a file that's not there.
BUG=

Review URL: https://codereview.chromium.org//198103010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33671 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 22:56:00 +00:00
whesse@google.com 6aa0e46095 Adjust test status files for MIPS architecture.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//198843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33648 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 11:51:03 +00:00
whesse@google.com 04fc336f32 Update mips test status files for new mips build slaves.
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//196133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33585 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 16:21:15 +00:00
iposva@google.com fdec365035 - Mark failing test (dartbug.com/17431).
Review URL: https://codereview.chromium.org//196793007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33574 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 13:50:49 +00:00
johnmccutchan@google.com 115caa8fe2 Fix service test breakage
BUG=

Review URL: https://codereview.chromium.org//195613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33545 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-11 18:38:03 +00:00
rmacnak@google.com 57dd1321d1 Reapply "Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors."
Regenerate snapshot test due to change in the size of Namespace. Relate the types source mirror libraries dependencies to the runtime library dependencies.

BUG=http://dartbug.com/10360

Review URL: https://codereview.chromium.org//189843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33441 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 19:00:20 +00:00
turnidge@google.com 058510ebd0 Handle collected objects and expired handles more gracefully.
Prints <collected> or <expired>.

Added tooltips to explain these to users.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//177473004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33386 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 17:38:16 +00:00
ajohnsen@google.com 685ad13179 Avoid unnecessary future in the HTTP stack, after latest cleanup.
Also move _writeHeaders into _HttpOutgoing, so all outgoing logic is located there.

BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//187443004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33326 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-05 11:43:04 +00:00
ajohnsen@google.com ce266f9435 Merge all http-outgoing transfomers into _HttpOutgoing, including simpler(better) buffering.
This speeds up the system by:
- Using a simpler buffering mechanism, where we fill up a 8kb buffer, pass it on, and allocating a new.
- Avoiding up to 4 streams for each stream added to the http-outgoing. We now only create one extra stream.

BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//185543004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33272 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 13:58:46 +00:00
ajohnsen@google.com fc5af7b7b4 Add InternetAddress:rawAddress, to return the raw address as a list of bytes.
BUG=https://code.google.com/p/dart/issues/detail?id=17137
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//180163005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33235 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 18:33:56 +00:00
ajohnsen@google.com 3f135836fe Use actual length of dictionary, and not size of a pointer, in zlib.
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//185773004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33213 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 13:12:23 +00:00
ajohnsen@google.com d6d130abc9 Don't match directly on gzip output of empty message, as it's not strictly specified.
Fixes test failure on Windows.

BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//183763021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33211 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 12:25:25 +00:00
ajohnsen@google.com a22e98f539 [ZLIB] Add support for windowBits, memLevel, raw
BUG=159367

**BC breaks:**
All public (API) classes that used to be const are not const any more. This allow checking the validity of input parameters in the constructor body.
- ZLibCodec,
- GZipCodec,
- ZLibEncoder,
- ZLibDecoder
The globals codecs GZIP and ZLIB are now final we should be ok (the class contain only final properties, ie no state).

What should be done:
(- finer grained exceptions, -> later change)
(- Handle the flush modes but probably in an other patch as the updates might be more complex.)

Done:

Patch Set #1
- add some more docs,
- support for memLevel.

Patch Set #2:
- implement dictionaries (todo: fix mem management),
- integrate review feedback,
- fix CC,
- rebased on master

Patch Set #4:
- support for strategy,
- add some checks (ie checking the level, memLevel, ...) this could imply adding a constructor body (Codecs, Coders) but this would force making the const non const and break BC, thoughts ?
- Add ZLIB constants Dart side.
- Refactor the tests and test only some levels rather all which was unit testing rather more than the extension. It saves some test time.

Patch Set #8:
- fix mem management for dictionaries,

R=ajohnsen@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//130513003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33206 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 11:43:09 +00:00
efortuna@google.com 9d53b1d682 Replace run_selenium.py with Dart script that uses the browser controller for performance tests.
BUG=
R=kustermann@google.com, ricow@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//178223008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33171 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-28 21:06:28 +00:00
ajohnsen@google.com 65f653a7cb Write custom URI-parser, to avoid using regexp.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//167703010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32966 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-24 14:36:31 +00:00
iposva@google.com f2a6f1b4b6 Another round of cleanups for http://www.dartbug.com/15922
- Address warnings about 64-bit to 32-bit conversions.

R=ajohnsen@google.com, asiva@google.com

Review URL: https://codereview.chromium.org//169893003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32831 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 23:35:55 +00:00
ajohnsen@google.com b15ec57f4f Clean up usage of streams in http-parser.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//171403003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32790 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 13:27:47 +00:00
ajohnsen@google.com 140fddd06e Make event-handlers edge-triggered and move socket-state to Dart.
This eliminates to pause/resume calls made in the previous one-shot based model.

BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//169383003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32780 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 09:44:26 +00:00
floitsch@google.com e5f54a2e5c internet_address_test started working.
Review URL: https://codereview.chromium.org//169173006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32729 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-17 16:41:38 +00:00
sgjesse@google.com f0bddc920e Allow HTTP response without reason phrase
Turns out some HTTP servers does not adhere to the spec when sending
response messages. This issue was found with the AppEngine
dev_appserver which does not send a reason phrase for some requests.

R=ajohnsen@google.com
BUG=http://dartbug.com/16756

Review URL: https://codereview.chromium.org//169723003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32727 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-17 14:54:24 +00:00
kustermann@google.com 19e74c6272 Added tools/status_clean.dart script
This script supports two commands:
  deflake:
    This command will go through all status file entries and check if the actual
    testoutcomes we've observed on our buildbots match the status file entries.

    If we have tests marked as flaky which are in fact not flaky, it will write
    a *.status.deflaked file which contains the fixes to the status file.

  fix:
    This command will go through all status files and ensures that all the
    status file lines correspond to existing tests.

    If we have lines that refer to non-existent tests, it will write a
    *.status.fixed file which contains the fixes to the status file.

R=whesse@google.com

Review URL: https://codereview.chromium.org//143453012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32694 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-14 12:21:37 +00:00
ajohnsen@google.com ba527b81f8 Add signal test for each supported signal.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//163273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32648 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 12:08:12 +00:00
kustermann@google.com 1626736d2c Remove flaky markers from status file for tests that are not flaky.
R=ricow@google.com

Review URL: https://codereview.chromium.org//135243005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32553 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-11 11:55:55 +00:00
sgjesse@google.com e8c1b76526 Change RawSocket.secureServer and RawSoccket.secure to fail on paused subscriptions
R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//158773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32499 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-10 13:43:28 +00:00
ajohnsen@google.com 05d70400d6 Send error-event if socket is marked for error.
BUG=http://code.google.com/p/dart/issues/detail?id=16544
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//143473006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32358 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-06 14:37:21 +00:00
sgjesse@google.com 4521b54617 Change FileStat static methods to return NOT_FOUND instead for throwing
R=ajohnsen@google.com
BUG=http://dartbug.com/16558

Review URL: https://codereview.chromium.org//156633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32352 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-06 11:27:42 +00:00
ajohnsen@google.com b39955232b Skip bad cookies in http headers.
BUG=https://code.google.com/p/dart/issues/detail?id=16540
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//151123003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32313 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-05 08:31:41 +00:00
sgjesse@google.com 79d13dd819 Mark standalone/io/web_socket_error_test as flakey
R=ajohnsen@google.com
BUG=

Review URL: https://codereview.chromium.org//153993008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32312 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-05 08:19:19 +00:00
ajohnsen@google.com eba430a424 Allow paths up to 32767 characters on Windows (so '\\?\' can be used).
BUG=https://code.google.com/p/dart/issues/detail?id=16264
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//145623011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32308 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-05 07:28:02 +00:00
floitsch@google.com 9f1ebd7f55 Mark issue14236 test as RuntimeError in addition to crash.
Review URL: https://codereview.chromium.org//151903004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32233 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-01 02:22:25 +00:00
hausner@google.com f9089a3ca5 Find all compiled copies of a function when setting breakpoint
Fixes a bug where the debugger did not find a compiled implicit
closure if the non-closureized version had not been compiled yet,
thus failing to set a breakpoint.

R=regis@google.com

Review URL: https://codereview.chromium.org//149853004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32165 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 18:08:02 +00:00
turnidge@google.com b891e78325 Post-meetup feature extravaganza.
Remodel the top-level isolate summary page.

Add variables to stack frames in the stack trace.

Stop putting small integers and bools in the object id ring.

Rework how we pass down null references (and null-like references like
uninitialized values).

Collect all isolate timers by default.

Change the lifetime of IsolateSpawnState so that we can refer to it
later to know how an isolate started up.  Stop pretending that
IsolateSpawnState is a void*.  Clean up vestigial IsolateStartData.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//145323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32128 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 18:40:12 +00:00
hausner@google.com ab1aee6587 Mark debugger test as failed if debug target crashes
Fixes issue 13721

R=zra@google.com

Review URL: https://codereview.chromium.org//148613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32039 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-27 22:59:26 +00:00
hausner@google.com dff049ab71 Don’t call toString from debugger
Debugger no longer calls toString on objects. It continues to do so
on known basic types like numbers, booleans, strings. This is necessary
because toString() may have side effects. See issue 16229 for example.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//146833007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32003 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-24 23:14:15 +00:00
hausner@google.com 812467f0f6 Fix several little buglets with stepping
No need to halt on single step if there is a breakpoint on the
same location. While looking at the resulting test failures, I
discovered that the step_in_equals test was not at all testing
what it was meant to test. It happened to pass because of a
related bug in the parser. Decided to abandon that test and
instead check that we can break at == even if one of the operands
is null.

Added ability to match line numbers in the debugger tests.

R=regis@google.com

Review URL: https://codereview.chromium.org//135843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31898 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 21:15:17 +00:00
lrn@google.com 9357caa547 Revert "Make VM TypedList not implement ByteBuffer."
Html transferable test fails to send buffer as buffer.

Review URL: https://codereview.chromium.org//137783019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31875 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 11:48:07 +00:00
lrn@google.com c2f6609181 Make VM TypedList not implement ByteBuffer.
BUG= http://dartbug.com/10136
R=asiva@google.com, sra@google.com

Review URL: https://codereview.chromium.org//138033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31873 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 10:18:41 +00:00
ajohnsen@google.com 0fb8d20dd7 Fix link test.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//133273006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31776 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-14 09:01:53 +00:00
ajohnsen@google.com d2d43a6192 Fix http_requested_uri_test for Win/Mac.
BUG=

Review URL: https://codereview.chromium.org//131173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31647 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-09 08:43:49 +00:00