615d1a01ac
Reland "Introduce optional 'bool shared' parameter to ServerSocket.bind() ..."
...
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//913753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43678 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 10:01:20 +00:00
8c24d57e15
Update test status for slow ASAN bot.
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//916473003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43664 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 19:58:35 +00:00
8e7752f56b
Fix bug in processing of latent breakpoints
...
Debugger hangs when encountering a url that has no match
in any of the loaded libraries.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//872643008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43662 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 19:11:56 +00:00
2a3a3e3fd7
Fix timeout in test
...
The server socket could be closed before all connections was handled
causing fewer calls to asyncEnd than to asyncStart and timeout.
Now the test waits with closing the server socket until all expected
connections have been made.
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//915523004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43647 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 14:29:30 +00:00
7b7ac3620a
Add support to specify the source address for socket connect
...
BUG=http://dartbug.com/22253
R=kustermann@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//908873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43638 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 11:56:51 +00:00
3e993231d1
Add support for user info on ws: and wss: URLs
...
BUG=http://dartbug.com/22152
R=kustermann@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//897323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43586 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 09:17:55 +00:00
10595e509d
Make standalone tests not dependent on current working directory.
...
This also simplifies DartOptions - could we simply remove it, the only usage is the arguments test which could simply call the vm on another file, and validate the output?
R=iposva@google.com , sgjesse@google.com
BUG=
Review URL: https://codereview.chromium.org//899243002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43511 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 16:29:39 +00:00
4b4d0a672a
Ensure that asyncStart is called before starting an async operation in test
...
R=ricow@google.com
BUG=http://dartbug.com/222280
Review URL: https://codereview.chromium.org//897253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43496 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 08:07:59 +00:00
1d6231bacd
Revert "Introduce optional 'bool shared' parameter to ServerSocket.bind() ..."
...
Review URL: https://codereview.chromium.org//896213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43476 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 16:00:21 +00:00
3c6c29fee9
Introduce optional 'bool shared' parameter to ServerSocket.bind() ...
...
R=sgjesse@google.com , wibling@google.com
Review URL: https://codereview.chromium.org//879353003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43467 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 13:41:41 +00:00
833e5d9aee
Add support for killing a process with a given PID to dart:io
...
R=lrn@google.com , kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//895623002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43455 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 08:20:33 +00:00
57ea35671c
Add getClassList RPC
...
BUG=
Review URL: https://codereview.chromium.org//895093002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43414 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 17:59:45 +00:00
9aa4805e21
Add an option for starting a detached process with stdio connected
...
R=lrn@google.com , kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//890633002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43393 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 13:38:38 +00:00
e65e6fab9d
Begin migrating the vm service from a rest-style interface to a json-rpc style interface.
...
BUG=
Review URL: https://codereview.chromium.org//823403004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43370 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:15:40 +00:00
62adbb7ab0
Let Uint16List.setRange detect a String.codeUnits object, and copy directly from the string.
...
R=vegorov@google.com
Review URL: https://codereview.chromium.org//856053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43327 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-30 09:46:04 +00:00
172baa03ff
Service isolate rework take 2
...
Review URL: https://codereview.chromium.org//889443002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43306 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 18:31:27 +00:00
b64811d039
Test addlatexhash_test: fix missed renamed variable.
...
BUG=
R=eernst@google.com
Review URL: https://codereview.chromium.org//877253004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43244 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 16:00:26 +00:00
e446ff200a
Make addlatexhash_test clean up its temp directories.
...
BUG=
R=eernst@google.com
Review URL: https://codereview.chromium.org//883793002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43242 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 13:41:46 +00:00
db271b0477
Revert r43217, r43215, r43208, r43207, and r43202.
...
Reverting because of some isolate spawn issues (on Windows, and pub bots).
Review URL: https://codereview.chromium.org//867113003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43219 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 22:56:18 +00:00
66aa470fc6
* Create vm-service isolate at Dart_Initialize time.
...
* Remove Service create callback.
* Simplify creation of service isolate.
* Creation is done on thread pool.
* Use vm-service isolate for loading in standalone embedder.
* Remove import of dart:io from builtin library.
performance changes:
no service isolate:
$ ./tools/test.py -m release
Test configuration: none_vm_release_ia32
[01:27 | 100% | +12363 | - 0]
$ ./tools/test.py -m release
Test configuration: none_vm_release_ia32
[01:27 | 100% | +12363 | - 0]
always start service isolate (as a thread pool task):
$ ./tools/test.py -m release
Test configuration: none_vm_release_ia32
[01:45 | 100% | +12363 | - 0]
$ ./tools/test.py -m release
Test configuration: none_vm_release_ia32
[01:44 | 100% | +12363 | - 0]
service does I/O (calls to Dart_LoadScript block until service is running):
$ ./tools/test.py -m release
Test configuration: none_vm_release_ia32
[01:55 | 100% | +12363 | - 0]
$ ./tools/test.py -m release
Test configuration: none_vm_release_ia32
[01:55 | 100% | +12363 | - 0]
R=asiva@google.com
Review URL: https://codereview.chromium.org//584023004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43202 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 19:45:48 +00:00
e4a3000c7a
Skip OOM tests in broswer until we can make them trigger reliably there.
...
The VM options are not being passed in the browser.
TBR=whesse@google.com
Review URL: https://codereview.chromium.org//871863003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43114 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 17:42:27 +00:00
8b6d5b1ada
Remove default heap size limit and add separate limit for externals.
...
Review URL: https://codereview.chromium.org//864843002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43111 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 16:32:20 +00:00
f6a10fbdf1
Add support for starting a detached process
...
BUG=http://dartbug.com/20970
R=kustermann@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//798743004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43070 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 11:49:39 +00:00
3f939748cb
Fix issue with Link.target and Link.targetSync failing on some file systems
...
Don't rely on information from lstat64 for the size of the link target. Get
the actual length from just reading the link target.
BUG=http://dartbug.com/21987
R=kustermann@google.com
Review URL: https://codereview.chromium.org//860343002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43066 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 10:27:11 +00:00
67badc8d74
Fix incorrect handling of closing stderr on Windows
...
BUG=http://dartbug.com/22088
R=kustermann@google.com
Review URL: https://codereview.chromium.org//854633005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43060 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 09:25:17 +00:00
ab2d914ae3
Avoid extra duplication of substrings during string.replaceAll.
...
R=asiva@google.com , zerny@google.com
Review URL: https://codereview.chromium.org//858543002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43059 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 08:27:42 +00:00
2fb0bb020b
Reapply "Mark all private functions in dart: libraries as invisible (*sniff*). Previously these functions were only marked invisible if they were also native, a constructor, or on a black list."
...
Broken assumption in Dartium fixed in blink r188698.
R=hausner@google.com
Review URL: https://codereview.chromium.org//862093003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43053 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 20:44:04 +00:00
ed88ac7f0c
Revert "Mark all private functions in dart: libraries as invisible (*sniff*). Previously these functions were only marked invisible if they were also native, a constructor, or on a black list."
...
Broke Dartium.
TBR=hausner@google.com
Review URL: https://codereview.chromium.org//863773002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43026 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 20:56:59 +00:00
045bd762d7
Mark all private functions in dart: libraries as invisible (*sniff*). Previously these functions were only marked invisible if they were also native, a constructor, or on a black list.
...
An invisible function is hidden from stack traces, will not be enumerated
by mirrors, and cannot be directly invoked by mirrors. Note that private
classes remain accessible.
Fix a few internal dart:io functions that should be private.
Fix bug where mirrors would enumerate top-level invisible functions.
Mark observatory test that was using such private functions through
mirrors as failing.
BUG=http://dartbug.com/15274
R=hausner@google.com
Review URL: https://codereview.chromium.org//816353012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43019 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 18:32:19 +00:00
5d67ac0f2e
Update status file
...
TBR=lrn@google.com
BUG=http://dartbug.com/22088
Review URL: https://codereview.chromium.org//861573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42977 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-19 08:14:08 +00:00
027f0fe387
Update status file
...
Test standalone/io/stdout_stderr_non_blocking_test fails on Windows
R=whesse@google.com
BUG=
Review URL: https://codereview.chromium.org//857573003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42958 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 14:17:47 +00:00
30ae29f4f2
Reapply revert of "Make stdout/stderr async"
...
This re-applies r42909 which was reverted in r42910 with a few fixes.
TBR=ajohnsen@google.com
BUG=
Review URL: https://codereview.chromium.org//851253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42953 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 13:35:37 +00:00
c831cdf97f
Revert "Revert "Make stdout/stderr async""
...
This reverts commit r42909
TBR=ricow@google.com
BUG=
Review URL: https://codereview.chromium.org//850333002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42910 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 14:33:35 +00:00
bc1be9c45f
Revert "Make stdout/stderr async"
...
This makes writes to the stdout and stderr IOSinks in dart:io blocking again.
To get the non-blocking behaviour the getter "nonBlocking" will return an
IOSink with real non-blocking behaviour.
Updated the class exposed for stderr to also support checking for whether it
is connected to a terminal and checking the terminal size.
R=ajohnsen@google.com , iposva@google.com
BUG=
Review URL: https://codereview.chromium.org//807833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42909 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 14:18:16 +00:00
247ff772d6
Update status files, replace "dartbug.com" with "Issue ".
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//845793004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42900 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 10:27:11 +00:00
aae3e42f82
Allow additional headers for WebSocket connect
...
The WebSocket.connect now takes an Map of headers to add to the
initial handshake request.
BUG=http://dartbug.com/15855
R=kustermann@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//839063005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42870 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 13:43:43 +00:00
218e366f89
Add support for file locking
...
This adds support for file locking in dart:io.
BUG=http://dartbug.com/17045
R=kustermann@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//833623004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42733 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 13:06:37 +00:00
f96ae9969e
Support breakpoints in deferred libraries
...
This CL introduces latent breakpoints, which are bp in urls that are
not yet loaded. When the VM loads additional scripts through deferred
libraries, latent breakpoints get set.
R=iposva@google.com
Review URL: https://codereview.chromium.org//808643004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42510 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-19 16:35:37 +00:00
9fcfaa8468
Support remaping of pair location inside materializations for slow paths.
...
Move remaping logic into Location::RemapForSlowPath to ensure that it is shared and will not get out of sync again.
BUG=http://dartbug.com/21887
R=fschneider@google.com
Review URL: https://codereview.chromium.org//811823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42396 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 15:18:51 +00:00
9a54ccd905
Fix debugging of async code
...
Make sure the debugger finds the closure function containing the body
of async functions, but not the synthetic function that generates the
future.
Change the way the debugger sets one-time breakpoints. Instead of
compiling the function and instrumenting all safe-points, set a
breakpoint marked as “one-shot” at the beginning of the function
and wait until the function is compiled. Then, once it fires, it
gets automatically deleted.
Finally, be smarter how we resolve breakpoints in compiled code.
The compiler rearranges code in await expressions, which tripped
up the debugger. This change makes sure we select the lowest compiled
code address only within the line containing the requested breakpoint
position.
R=iposva@google.com
Review URL: https://codereview.chromium.org//805573003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42368 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-15 18:20:20 +00:00
56defa8060
Write-barrier verification on ARM.
...
Add and use methods on Assembler for writing and verifying object fields.
Enable tests in verified_mem mode for simarm.
Also generalize and use InitializeFieldsNoBarrierUnrolled in one more place.
R=iposva@google.com
Review URL: https://codereview.chromium.org//730343005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42208 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 16:15:33 +00:00
953c735532
Enable more tests on MIPS.
...
R=zra@google.com
Review URL: https://codereview.chromium.org//778223002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42149 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-05 21:40:05 +00:00
e20569cf8b
Reenable a few previously slow tests on MIPS.
...
R=zra@google.com
Review URL: https://codereview.chromium.org//781123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42141 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-05 19:32:39 +00:00
1757888022
Implement mint unboxing on MIPS.
...
R=zra@google.com
Review URL: https://codereview.chromium.org//777943003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42138 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-05 18:27:37 +00:00
2323df0dab
Import tools/testing/dart/path.dart in tests that used to get this through utils.dart
...
Review URL: https://codereview.chromium.org//780503004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42111 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-04 16:23:45 +00:00
efced8d511
Fix HTTP IPv6 test
...
Use the loopback address ::1 to connect from the client. Using the
IPv6 any address does not work on our Windows bots. This is also how the
IPv6 socket tests connect.
R=ricow@google.com
BUG=
Review URL: https://codereview.chromium.org//759223002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41981 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-26 08:53:07 +00:00
4740a77b0e
Handle IPv6 addresses for HTTP client requests
...
The Host header was not set correctly for HTTP requests when an IPv6 address
was used. The square brackets surrounding the address was missing.
BUG=http://dartbug.com/21698
R=lrn@google.com
Review URL: https://codereview.chromium.org//755883007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41980 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-26 07:30:26 +00:00
b6d8a272a5
Make the ConsoleSink call methos argument optional.
...
R=iposva@google.com
BUG=
Review URL: https://codereview.chromium.org//739153002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41842 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 07:51:33 +00:00
fde4d2882c
Add missing verified write on x64; extend test coverage
...
On x64, StoreInstanceField and StoreIndexed sometimes used Assembler::StoreObject to store constants directly into heap objects. This method is unaware of the write barrier. Fix this by adding a write-barrier-aware method, like we already have on ia32.
Generally, we should consider distinguishing more clearly between stack stores and heap stores, for instance by adding HeapAddress/StackAddress types.
R=iposva@google.com
Review URL: https://codereview.chromium.org//738453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41808 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-18 16:35:59 +00:00
9c3fdfb467
Fix console test for Windows
...
TBR=iposva@google.com
BUG=
Review URL: https://codereview.chromium.org//736733002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41804 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-18 14:38:06 +00:00
kustermann@google.com