Commit Graph

2501 Commits

Author SHA1 Message Date
Kevin Moore d5e8d7723d fix windows bots with Platform.executable test
Review URL: https://codereview.chromium.org//1152333005
2015-05-25 11:26:46 -07:00
Kevin Moore a59d9491d9 fixing status files for Platform.executable test
TBR=sgjesse@google.com,

Review URL: https://codereview.chromium.org//1152983002
2015-05-24 23:49:20 -07:00
Kevin Moore 55d5d791a2 TBR: add status updates for last CL 2015-05-24 22:45:48 -07:00
Kevin Moore e9e806b56b TEMPORARY - Validate fix for 16994 with some caveats
Review URL: https://codereview.chromium.org//1147413005
2015-05-24 22:38:31 -07:00
Kevin Moore a11ad2e223 Revert "TEMPORARY - Validate fix for 16994 with some caveats"
This reverts commit 52f9548d58.

BUG=

Review URL: https://codereview.chromium.org//1159623002
2015-05-24 20:35:29 -07:00
Kevin Moore 52f9548d58 TEMPORARY - Validate fix for 16994 with some caveats
Review URL: https://codereview.chromium.org//1160513002
2015-05-24 20:00:08 -07:00
Karl Klose 36d3e0d0e6 Update cps-ir test expectations.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1152133003
2015-05-22 09:58:58 +02:00
Søren Gjesse e03ab17437 Make Platform.executable return the fully qualified path of the executable
BUG=http://dartbug.com/16994
R=kustermann@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//1145053002
2015-05-20 13:14:51 +02:00
Asger Feldthaus ccee558a5b dart2js cps: Access to lazily initialized fields.
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1136843006
2015-05-19 10:05:09 +02:00
koda@google.com 59f829484c Skip verbose_gc_to_bmu_test on Dartium etc.
TBR=iposva@google.com

Review URL: https://codereview.chromium.org//1133863005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45789 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-14 17:44:12 +00:00
koda@google.com 9b4219332b Tool to compute BMU plots from GC logs.
R=iposva@google.com

Review URL: https://codereview.chromium.org//1133243004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45786 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-14 16:42:53 +00:00
karlklose@google.com 9b32c9e673 Implement raw list checks.
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1123343008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45762 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-13 11:58:45 +00:00
asgerf@google.com f5f1eb643d dart2js cps: Introduce GetStatic/SetStatic.
The GetStatic is used for reading static fields and tearing off
static methods.

Invoking a static getter/setter (not from a field) is still an
InvokeStatic, which IMO is the way it should remain.

BUG=
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45735

Reverted: https://code.google.com/p/dart/source/detail?r=45737

Review URL: https://codereview.chromium.org//1134063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45738 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 14:19:40 +00:00
asgerf@google.com 961c805398 Revert "dart2js cps: Introduce GetStatic/SetStatic."
This reverts commit 28e4518df87c72cb8e23fe6d73b7750ad0f2183a.

TBR=karlklose@google.com

BUG=

Review URL: https://codereview.chromium.org//1136523008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45737 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 13:53:15 +00:00
asgerf@google.com 2c90643171 dart2js cps: Introduce GetStatic/SetStatic.
The GetStatic is used for reading static fields and tearing off
static methods.

Invoking a static getter/setter (not from a field) is still an
InvokeStatic, which IMO is the way it should remain.

BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1134063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45735 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 13:35:49 +00:00
sgjesse@google.com 6a4e6571f4 Add handling of HTTP '100 Continue' intermediate response
The '100 Continue' intermediate response is just ignored, as there
is currently no API for the client to wait to this.

BUG=http://dartbug.com/23413
R=kustermann@google.com

Review URL: https://codereview.chromium.org//1128873011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45685 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 13:48:15 +00:00
karlklose@google.com 0eaa4d4717 cps-ir: Support compilation of methods that use interceptor calling convention.
This is a modified version of sra@'s CL https://codereview.chromium.org/1020243002/ with kmillikin@'s comments addressed.

R=sigurdm@google.com, kmillikin@google.com

Review URL: https://codereview.chromium.org//1109403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45680 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 12:38:14 +00:00
sgjesse@google.com 197f336534 Make sure to process WebSocket frames when closing a WebSocket
On a WebSocket the actual listening on the stream is causing the
processing of inbound frames to start. If the connection is closed
without ever being listened on, then a close frame from the other end
will not be processed.  In this case the timeout of waiting for a
close from the other end will always be hit.

If you are _only_ using the WebSocket connection in one direction it
seems a bit artificial to have to listen on the stream to even process
the close frame.

This change will make sure the stream is listened to when closing a
WebSocket.

This is a breaking change. Before you could close and then
listen. With this change that sequence will throw on the listen. This
is reflected in the changes that was needed for the tests.

R=kustermann@google.com, lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//1133673006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45679 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 09:32:39 +00:00
ricow@google.com e92f697236 Remove dart2dart support from testing scripts and status files
I will leave it to the dart2js people to remove the support from the dart2js tools (there is also a bunch of comments still in code, do a git grep)

R=kustermann@google.com, floitsch@google.com, kmillikin@google.com
BUG=

Review URL: https://codereview.chromium.org//1126363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45588 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 11:29:55 +00:00
karlklose@google.com 6abb79a95b cps-ir: Implement type tests for interface types without type arguments.
R=sigurdm@google.com, kmillikin@google.com

Review URL: https://codereview.chromium.org//1110813005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45484 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-04 07:58:38 +00:00
asiva@google.com 49d1dc7252 Address issue 13719, cleanup the status file to reflect reality.
R=regis@google.com

Review URL: https://codereview.chromium.org//1085363005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45383 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 20:42:28 +00:00
kmillikin@google.com 4f7c1d3d54 Clean up handling of constants in the CPS backend.
Before: constant-valued expressions were usually compiled by the JS constant
compiler task, which surprisingly produces a Dart (not JS) constant.

After: use the already computed constant value of a constant-valued
expression.  This is looked up in one of two ways depending on whether the
expression is an identifier or not.  For primitive constants (Booleans,
doubles, integers, strings, and null) simply construct them as they have not
had a value computed.

Also, fix a variety of small bugs.  In some case the fix is disabling an
incorrect code path and bailing out of the compiler.

BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1057483004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45335 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 10:59:03 +00:00
sgjesse@google.com 170be8d7d1 Process outstanding events before making a new HTTP client request
This re-applies r45127, which was reverted in r45129. The revert was due
to a failing test which is re-written here to perform the separate steps
in a deterministic order.

Original change description:

This fixes the issue of using a HTTP client connection from the
connection pool which was closed and where the close indication has
already been received by the event handler.

This specifically fixes the 'pub get' issue where a long running
constraint resolver would end with the error "Connection closed before
full header was received"

Retrying GET methods when the connection is closed after succesfuly
sending (parts of) the request is still missing.

R=lrn@google.com

BUG=http://dartbug.com/21798

Review URL: https://codereview.chromium.org//1055943004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45313 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 12:14:55 +00:00
karlklose@google.com 7dd2608820 Adjust test expectations for dart2js-cps-ir.
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1092013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45236 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-17 11:45:51 +00:00
kmillikin@google.com 00e4ba52ea CPS implementation of throw and rethrow.
Throw and rethrow are implemented as CPS expressions in tail position.

The CPS translation assumes that all expressions translate to a primitive
that is the value of the expression, and throw is an expression in Dart.
For simplicity of the translation, a non-tail throw Primitive is sometimes
used as a placeholder during the translation and removed immediately
afterward.

Both throw and rethrow are represented in the Tree IR.  In the Dart backend,
throw translates to throw and rethrow translates to rethrow.  In the JS
backend, throw translates to JS throw of a wrapped value.  Rethrow is not
currently implemented for the JS backend, it bails out of the compiler.

R=asgerf@google.com
BUG=

Review URL: https://codereview.chromium.org//1092023002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45235 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-17 11:15:45 +00:00
lrn@google.com d8dbb4a60f Add Uri.directory constructor.
Make Directory.uri getter use the new constructor.
This also fixes that the uri getter doesn't work correctly on Windows.

Add uri getter on file system entity.

BUG= http://dartbug.com/17065
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1089183004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45227 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-17 08:56:03 +00:00
lrn@google.com 8cf32dc1a1 Add uri getter on file system entity.
BUG= http://dartbug.com/20362
Also:
BUG= http://dartbug.com/19428
BUG= http://dartbug.com/17065
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1083393004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45226 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-17 07:31:26 +00:00
zra@google.com 86bfd7cb30 Adds a simarmv5te build and test target.
Also:
- Removes command line flags to choose simulated arm version.
  I think we should use build targets instead, like in this change,
  to make building and testing more obvious.
- Skips pkg tests on all simulators.

R=regis@google.com, ricow@google.com

Review URL: https://codereview.chromium.org//1077823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45181 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-15 20:44:43 +00:00
karlklose@google.com d839c64766 Establish test expectations for dart2js running with the CPS based backend.
R=ricow@google.com

Review URL: https://codereview.chromium.org//1089113003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45162 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-15 11:44:02 +00:00
sgjesse@google.com c6e632bcdb Be more lean when parsing HTTP headers
Allow only LF instaed of CRLF when parsing headers. Sometimes old or
hacked up clients will send the headers like this.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//1078683002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44998 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 11:15:29 +00:00
koda@google.com b4a53727f4 Add regression test for Map compaction issue.
Original fix for the issue:
https://code.google.com/p/dart/source/detail?r=44671

R=kustermann@google.com

Review URL: https://codereview.chromium.org//1010743005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44702 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 22:26:12 +00:00
fschneider@google.com 76f5627abd Compile implicit closures as dispatchers instead of duplicating the original method's code.
This saves space in unoptimized code for implicit closures. In optimized code the
original method's code will often be inlined into the implicit closure dispatcher so that
there won't be a performance impact.

The static case just calls the original method. For implicit instance closures, the
this-parameter is loaded from the context and passed to the original method.


The coverage test is affected since the dispatcher has the original method's token position
associated with it. This means that the line with the method declaration is considered to
have executable code. Setting the token position to 0 (Scanner::kNoSourcePos) does not work
because it coincides with the first line (and first token) in the script.

R=hausner@google.com

Review URL: https://codereview.chromium.org//1024563004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44655 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-24 09:33:36 +00:00
sgjesse@google.com 48584debbd Make Socket address and port getters available after the socket is closed
There getters are used for generating eddor messages.

TBR=ajohnsen@google.com
BUG=

Review URL: https://codereview.chromium.org//985533003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44359 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-10 08:54:22 +00:00
whesse@google.com 6e539eab53 Fix error where upgrading a closed socket to secure will hang.
BUG=dartbug.com/22658
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//990893002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44324 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 16:08:09 +00:00
sgjesse@google.com 1d808d071b Fixed a number of bugs on RawSocket and Socket
The checking of the closed state was not present when dealing
with the properties port, remotePort, address and remoteAddress
on RawSocket and Socket. Then now all throw SocketException when
the RawSocket or Socket is closed.

* Calling port on a RawSocket would return the port even if it
  was closed

* Calling remotePort, address and remoteAddress did not check for
  OSError

* Calling remotePort, address and remoteAddress on a closed
  RawSocket caused syscalls using the already closed fd, which
  might also have been re-allocated already.

* Calling port, remotePort, address and remoteAddress on a closed
  Socket caused null pointer exception

R=ajohnsen@google.com

Correctly check for errors when getting remote address and port

BUG=

Review URL: https://codereview.chromium.org//984403004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44319 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 13:33:28 +00:00
whesse@google.com 07d40f4fe8 Update status for macos RawSecureSocket test that times out.
A high priority bug is filed to fix this issue.
BUG=dartbug.com/22658
R=kustermann@google.com

Review URL: https://codereview.chromium.org//979923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44244 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-04 18:28:41 +00:00
whesse@google.com 1d928984a3 Recommit "Fix issues with Socket shutdown.""
This recommits revision r44178, which was reverted in r44180, with changes to
fix the issues with Process.stdin.  It also adds a test for issue 22636, duplicate READ_CLOSED message.

Changes from r44187
Test tests/standalone/io/issue_22636_test.dart added.
Line "native.closedReadEventSent = true;" added to _RawSocket._writePipe() in runtime/bin/socket_patch.dart.

BUG=http://dartbug.com/22636
BUG=http://dartbug.com/22637
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//980593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44236 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-04 14:37:34 +00:00
whesse@google.com bbfd19ca02 Revert "Fix issues with Socket shutdown."
This reverts commit r44178, because it makes 10 tests about process stderr
and stdin fail with timeouts.
Original CL: https://codereview.chromium.org/975723002/

BUG=dartbug.com/22637
BUG=dartbug.com/22636
R=kustermann@google.com

Review URL: https://codereview.chromium.org//974953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44180 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-03 16:51:57 +00:00
whesse@google.com 7d15c8182a Fix issues with Socket shutdown.
BUG=dartbug.com/22637
BUG=dartbug.com/22636

Review URL: https://codereview.chromium.org//975723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44178 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-03 16:19:23 +00:00
whesse@google.com 454a7263ef Update test status for mips tests.
BUG=dartbug.com/22597
R=ricow@google.com

Review URL: https://codereview.chromium.org//962153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44086 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-27 10:37:56 +00:00
sgjesse@google.com 854959e09c Fix broken test of platform version
The version check regexp expected that additional info was stripped. The
dartdoc for Platform.version says that the version is what is before the
first space if any.

R=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//953323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44021 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-25 11:46:09 +00:00
kevmoo@google.com be8aca929d Move more tests to SkipByDesign
R=whesse@google.com

Review URL: https://codereview.chromium.org//932493004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43977 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-23 21:31:12 +00:00
whesse@google.com 6aaacf2f20 Add detailed error message to socket_source_address_test.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//947133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43954 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-23 13:16:03 +00:00
fschneider@google.com 2442d5e047 VM: Fix a bug with local variable values when breaking at a variable declaration.
This fixes the case When breaking at a declaration 'var a;'

BUG=dartbug.com/22353
R=hausner@google.com

Review URL: https://codereview.chromium.org//936283005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43882 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 17:11:07 +00:00
fschneider@google.com aefdc04fa8 VM: Fix issue with local variable values reported by the debugger.
I added a function to test if a variable is visible or not to the
debugger tests.

BUG=dartbug.com/22353
TEST=standalone/debugger/local_variables_test
R=hausner@google.com

Review URL: https://codereview.chromium.org//933253003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43850 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 18:48:00 +00:00
kevmoo@google.com 4cc4e28411 status files: trying out new SkipSlow flag
and selectively used SkipByDesign in more places

R=whesse@google.com

Review URL: https://codereview.chromium.org//928523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43815 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 17:21:39 +00:00
sgjesse@google.com 8cd4d4d425 Add the shared flag to HttpServer as well
Also mark the ServerSocketReference and friends as deprecated and to
be removed in Dart 1.10

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//925403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43809 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 13:14:49 +00:00
sgjesse@google.com 47236d71e5 Fix checked mode test
TBR=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//920823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43727 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 14:20:38 +00:00
sgjesse@google.com 59f8932c9d Update documentation for Platform.version
Add test that Platform.version does start with a valid semver string.

BUG=http://dartbug/22244
R=ricow@google.com

Review URL: https://codereview.chromium.org//921733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43723 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 13:35:56 +00:00
kustermann@google.com aeba7a23b1 Fix race condition in tests/standalone/io/file_test
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//920473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43683 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 14:32:55 +00:00