dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

793 Commits

Author SHA1 Message Date
Terry Lucas 9816fce289 Fixed to use catchError instead of try/catch. 
TBR=sra@google.com

Change-Id: Id3633654d1d9106be0f1169a5452731bafbd8732
Reviewed-on: https://dart-review.googlesource.com/56290
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2018-05-23 18:48:34 +00:00
Alexander Markov 4fb0c60938 [vm/kernel] Set active class when evaluating Dart annotations 
Without active class, kernel reader is not able to finalize types
and fails to parse type literals.

Fixes https://github.com/dart-lang/sdk/issues/33173

Change-Id: Iefe7f33a371f3d4f892f21f8ea0060d70887186c
Reviewed-on: https://dart-review.googlesource.com/56242
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-05-23 16:17:55 +00:00
Terry Lucas e62f37f396 Tighten failure and success of test. 
TBR=sra@google.com

Change-Id: Id56baa1f1079ad3433d2402f0eb5749fdcf08c06
Reviewed-on: https://dart-review.googlesource.com/56289
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-05-23 14:38:55 +00:00
Terry Lucas 2a7188523e Fixed status 
TBR=sra@google.com

Change-Id: Ie8f1d0e19bdde301aa995376727035f807d5d222
Reviewed-on: https://dart-review.googlesource.com/56288
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2018-05-23 07:52:55 +00:00
Terry Lucas cf87b84f7d Support Promise to Future for both DDC and dart2js. 
APIs in the newer Chrome IDLs support more JS style promises. The Dart web libraries now hookup those promises and return a Dart Future.
Additionally, a new type maplike is exposed in the IDL this is exposed too.

Change-Id: I44175877eb95f4d910586d42c0139fb182483f82
Reviewed-on: https://dart-review.googlesource.com/49800
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-05-23 04:08:14 +00:00
Kevin Millikin 7ff8adcec9 Fix an incorrect dart:mirrors test 
The class defined by an anonymous mixin application is always
abstract.  If it were not, then it would be a Dart 2 static error that
it does not provide implementations of any of the abstract members of
the mixed-in class.  For example:

  class S {}
  abstract class M {
    int f();
  }
  abstract class C extends S with M {}

The class defined by `S with M` must be abstract because it does not
provide an implementation of `f`.

Change-Id: I3a990d7db4c5cb3c2dc83f4f12e4fd1eba68f876
Reviewed-on: https://dart-review.googlesource.com/56107
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2018-05-22 13:56:41 +00:00
Johnni Winther 54331b1c4b Delete elements.dart and resolution_types.dart 
Change-Id: Ib50dabdbeec72ebf443e85b51b818d9ed0602b4f
Reviewed-on: https://dart-review.googlesource.com/55221
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-05-16 09:54:18 +00:00
Martin Kustermann 2dc8f3f0b0 [VM] Mark crashing test in status file 
This test was removed from the status file in 87fb51fa8c (after
landing dd3ec65af)

Issue https://github.com/dart-lang/sdk/issues/33128

Change-Id: I77e4a4f303d6a248a87a9a9739e883d2a68fafc6
Reviewed-on: https://dart-review.googlesource.com/55241
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-05-15 15:54:47 +00:00
Ryan Macnak 87fb51fa8c [test] Mark isolate_complex_messages_test as fixed in Dart 2. 
Fixed by dd3ec65af8.

Change-Id: Ia877330109b74b29fd5a52a755b2910511885de8
Reviewed-on: https://dart-review.googlesource.com/55024
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-05-14 23:12:50 +00:00
Ryan Macnak 1e28b8987d [vm] Reify even more generics in the mirrors implementation to appease Dart 2. 
Bug: https://github.com/dart-lang/sdk/issues/33091
Bug: https://github.com/dart-lang/sdk/issues/33098
Change-Id: Ibecce1274b9bda47e387d109a29a5af4d53adb7f
Reviewed-on: https://dart-review.googlesource.com/54704
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2018-05-11 19:18:49 +00:00
Sigmund Cherem b894a69c80 Fix status file: make bots green 
TBR=sra@google.com

Change-Id: I85432f4ccf739c3f9c69c60cb76cdeeaddd49cec
Reviewed-on: https://dart-review.googlesource.com/54623
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-05-10 17:51:34 +00:00
Sigmund Cherem c25a9fd46b Remove support for dart:isolate in dart2js. 
Change-Id: I1216a0ac91d8a1d13b441809596e1a8b5e51bb34
Reviewed-on: https://dart-review.googlesource.com/54526
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-05-10 01:20:17 +00:00
Sigmund Cherem 3ec1b929e3 Remove dependencies on isolates. 
This starts removing support for isolates. I've kept around the
isolate library for now, but I stopped injecting the isolate logic
unless you directly access an isolate API.

Concrete changes:

* Timer no longer uses the event queue: this was only used in worker
isolates, soon to be removed.

* Checking for whether the code is run within a worker is not dependent
   on initializing the isolates global state. This was important to allow
   deferred-loading to work without the isolate logic.

* Workers no longer track pending async calls correctly. This may make it possible
   to terminate worker isolates early, again this wont be relevant shortly.

Bug: https://github.com/dart-lang/sdk/issues/32684
Change-Id: I05025418e05c3641ba1a3bc34ea75ca558a28fbd
Reviewed-on: https://dart-review.googlesource.com/54160
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-05-09 16:36:26 +00:00
Kevin Millikin 8dbe716085 Remove the unused GenericCovariantInterface bit 
None of the back ends are using it and it imposes a cost to have to
compute it and try to preserve it.

Change-Id: I217e1191b535829021fa11f2698cadd8d4baf1c8
Reviewed-on: https://dart-review.googlesource.com/54383
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-05-09 15:04:43 +00:00
Martin Kustermann 24224ced5b [VM] Update status file, test became much slower after strong-mode changes to mirrors implementation 
Issue https://github.com/dart-lang/sdk/issues/33057

Change-Id: I02785f43fd16f4396de770972a4e64d64500ea80
Reviewed-on: https://dart-review.googlesource.com/54404
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-05-09 13:33:03 +00:00
Jenny Messerly e10f0717d2 fix test status for a few tests changed in 3002e47e 
In particular:
super_call4_test/01
mirrors/deferred_constraints_constants_test

Change-Id: I8b0a32c4ce760e757f94d0d82b0b3123c55c3551
Reviewed-on: https://dart-review.googlesource.com/54163
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2018-05-08 01:04:47 +00:00
Jenny Messerly 3002e47e36 cleanup language_2 and corelib_2 tests that import dart:mirrors 
Preserves tests that didn't really need mirrors, and moves tests for
mirror functionality into lib_2/mirrors tests.

Change-Id: Ie16dee1a4b508e3f14da53499f57c5dae2d1e513
Reviewed-on: https://dart-review.googlesource.com/49624
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-05-07 23:50:56 +00:00
Ryan Macnak 2f458c4c48 [vm] Reify more generics in the mirrors implementation to appease Dart 2. 
Bug: https://github.com/dart-lang/sdk/issues/32889
Change-Id: Ic115a2db257eb1a70a82e727890fef8695ec8bc2
Reviewed-on: https://dart-review.googlesource.com/53693
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-05-04 00:34:54 +00:00
Dmitry Stefantsov 5af05d407d [fasta] Report type argument number mismatch during outline building 
Change-Id: I1c1f22f3117ccbfc8620b3b0459bc96ed1ad1bdf
Reviewed-on: https://dart-review.googlesource.com/51128
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-04-30 13:01:15 +00:00
Jenny Messerly bd76221d58 fix #31489, JS interop to prototype getter in dartdevk 
Change-Id: I6a3e1e25e0113bfcc49de19f250c23027ea3a69f
Reviewed-on: https://dart-review.googlesource.com/52865
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-04-27 00:17:29 +00:00
Janice Collins 1afe71c08a Enable preview-dart-2 as default for analyzer. 
Based on https://dart-review.googlesource.com/c/sdk/+/52340, but adds
the necessary plumbing through the test system to pass through
negations to strong and preview-dart-2.  Also adds support for those
negations to the analyzer.

Change-Id: I9793ff28bb593d25bbb0a2ed8736b5b53e0a62d8
Reviewed-on: https://dart-review.googlesource.com/52461
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-26 17:01:12 +00:00
Brian Wilkerson 9e9b50d19d Improve error messages for annotations involving undefined names (issue 27788) 
Change-Id: Iccfcb73b7671f50353b57a81817dec013b997a53
Reviewed-on: https://dart-review.googlesource.com/52640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-25 17:48:49 +00:00
Keerti Parthasarathy 9eb09d825b Revert "Create _nullFuture and _falseFuture in the root zone." 
This reverts commit 9bb085a1c6 due to
test failure in google3.

Change-Id: I63940e62bd97c83bc432db99b44c991e6c1e025e
Reviewed-on: https://dart-review.googlesource.com/52422
Reviewed-by: Dan Grove <dgrove@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2018-04-24 20:45:38 +00:00
Lasse R.H. Nielsen fab5bef194 More upper-case constants found. 
Change-Id: Ibce257b802d398612ad03e1d53014b82f9b9c54f
Reviewed-on: https://dart-review.googlesource.com/51881
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2018-04-19 15:08:18 +00:00
Lasse R.H. Nielsen 2eeea7bc30 Remove more usages of upper-case constants in SDK 
Change-Id: I4e54ed7eba5f2af7852faba2cffae12f28e618cf
Reviewed-on: https://dart-review.googlesource.com/51844
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2018-04-19 13:31:57 +00:00
Lasse R.H. Nielsen 973a1a0219 Remove uses of upper-case constants in remaining SDK code. 
This includes Fasta, tools and observatory, so the checked-in SDK must
have the lower-case constants.

Change-Id: I8380ad041ad058f7d02ae19caccfecd434d13d75
Reviewed-on: https://dart-review.googlesource.com/50201
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-04-16 16:11:57 +00:00
Aske Simon Christensen 2fb94418cd Mark mirrors test crashing. 
Bug: https://github.com/dart-lang/sdk/issues/32879
Change-Id: I66633e44d1a8a46aa54b6309b94603887fdfb16e
Reviewed-on: https://dart-review.googlesource.com/51130
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-04-13 16:55:00 +00:00
Aske Simon Christensen 51a2f96a71 Always call writeAnnotationList to write annotations. 
This fixes an issue where an (illegal) annotation contained a
variable declaration, but the variable indexer was not set up.

Closes https://github.com/dart-lang/sdk/issues/32800

Change-Id: I50e828256e1ec0d14004aa38eaab2dce93ca7112
Reviewed-on: https://dart-review.googlesource.com/50942
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-04-13 12:41:17 +00:00
Jenny Messerly 8613938e33 fix DDK to track mock setters correctly. 
Also fix nosuchmethod_forwarding_arguments_test to work in dart4web compilers

Change-Id: If19bf74561c716845e24862c2400e0ab5cfc135c
Reviewed-on: https://dart-review.googlesource.com/48891
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-04-13 00:27:26 +00:00
Terry Lucas 79bfbf5a34 These tests now pass. 
TBR=sra@google.com

Change-Id: Ibd761b6ba6118f7f56732816379a71cea56457df
Reviewed-on: https://dart-review.googlesource.com/50621
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2018-04-11 00:19:51 +00:00
Alexander Thomas 3851591642 [infra] Keep comments intact when updating status files. 
* Preserve empty lines in the file header.
* Add empty entry to the tool's newly created sections.
* Remove extra empty line at the end of the file.

Change-Id: I271583774d5f5497025a9d85bcadf8b0b9e39e81
Reviewed-on: https://dart-review.googlesource.com/37600
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-04-10 19:03:21 +00:00
Lasse R.H. Nielsen 9bb085a1c6 Create _nullFuture and _falseFuture in the root zone. 
Avoids issues where they are lazily created in a different current zone and that zone messes with, for example, schedule microtask, which the future uses to schedule invocations of its callbacks.

Change-Id: I6697ca469426472523089fcf7ca44312b9c6ff5f
Reviewed-on: https://dart-review.googlesource.com/49509
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2018-04-06 16:10:52 +00:00
Terry Lucas 3e6b8717fe Fixed GamePadList not working in DDC and hide MessagePort.start operation. 
Fixes https://github.com/dart-lang/sdk/issues/31029

R=vsm@google.com

Change-Id: I757538eec1ebcf42204e7de0807a48a4757f3faf
Reviewed-on: https://dart-review.googlesource.com/49740
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-04-05 15:13:17 +00:00
Régis Crelier bd6e66c538 [VM runtime] Ignore 'implements Function' in strong mode type tests (fixes #32154). 
Change-Id: I7d53594e6ffaef616b3384e073e2240a8ca7017c
Reviewed-on: https://dart-review.googlesource.com/49080
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2018-04-04 17:52:55 +00:00
Dmitry Stefantsov 59d859645e [fasta] Do new/const insertion in simple cases 
Bug: http://dartbug.com/32553
Change-Id: I58e201ffd5019a5a65c0ac188aaab363225b5296
Reviewed-on: https://dart-review.googlesource.com/48481
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-30 18:35:05 +00:00
Jenny Messerly bed5debbeb Callable object support in Analyzer and DDC. 
Fixes #32156
Fixes #32157
Fixes #32426

This also fixes `implements Function` so it has no effect in Dart 2
(it is ignored for the purposes of subtyping.)

Change-Id: Ibec9c77cd516b8b97fef68a579998598d0acf8c6
Reviewed-on: https://dart-review.googlesource.com/45141
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-03-30 18:14:55 +00:00
Terry Lucas 49558b9c4c Fixed MessageChannel receiveing messages on ports. 
Removed pkg browser from tests.

Fixes https://github.com/dart-lang/sdk/issues/26351
Fixes https://github.com/dart-lang/sdk/issues/32631

R=kevmoo@google.com

Change-Id: Ib0ef5f933d38b2f748cca1f82de8bcf01702df4d
Reviewed-on: https://dart-review.googlesource.com/48742
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-03-30 17:16:15 +00:00
Ben Konyi 42581e4fa6 [VM] Added '--enable-asserts' to the top-level help message. 
Change-Id: I91b22cc1563b7c5217f21032109d948a5bb78b57
Reviewed-on: https://dart-review.googlesource.com/48456
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2018-03-28 18:54:00 +00:00
Terry Lucas bc75856e54 Update getClientRects, removed xtab, removed bogus entry in dom.json, 
expose ServiceWorker, removed query and queryAll from in dart:html,
added constructor to MessageChannel and removed getCssCanvasContext.

Fixed all tests using query and queryAll.

Fixes https://github.com/dart-lang/sdk/issues/25664
Fixes https://github.com/dart-lang/sdk/issues/26349
Fixes https://github.com/dart-lang/sdk/issues/32323
Fixes https://github.com/dart-lang/sdk/issues/32659
Fixes https://github.com/dart-lang/sdk/issues/32675

R=kevmoo@google.com

Change-Id: I687471e80b8fe9c7040673113f424dbaab7c64d4
Reviewed-on: https://dart-review.googlesource.com/48381
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-03-27 20:45:33 +00:00
Terry Lucas 17a778c9cb Changed AudioScheduledSourceNode.start to start2. 
Fixes https://github.com/dart-lang/sdk/issues/32624

TBR=kevmoo@google.com

Change-Id: Ied9494a4b9695ae08ff2ef63c43759ea7951e9fa
Reviewed-on: https://dart-review.googlesource.com/47760
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-03-22 13:18:37 +00:00
Erik Ernst 8493f68271 Adjusted status for lib_2/async/future_or_type_test.dart 
In response to redness for the dartanalyzer after landing
7c05f1e608.

Change-Id: I9fdc606fd30e43144d3f75d67b42820c1e7c0487
Reviewed-on: https://dart-review.googlesource.com/47460
Reviewed-by: Erik Ernst <eernst@google.com>
 2018-03-21 12:17:45 +00:00
Lasse Reichstein Holst Nielsen 7c05f1e608 Add more tests for FutureOr used as a type. 
Change-Id: I53a569eeee04f54fe2ac55009a25a806356d9880
Reviewed-on: https://dart-review.googlesource.com/36440
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2018-03-21 10:49:09 +00:00
Terry Lucas 86b1646475 webSQL is not suported by Firefox fixed test supported should of true should not be expected. 
TBR=alanknight@google.com

Change-Id: Ie6fc9e2db90994ac866637dc12ac5d496f6a627a
Reviewed-on: https://dart-review.googlesource.com/47280
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-20 17:06:25 +00:00
Terry Lucas 3d34f4d4fe Updated CHANGELOG with Chrome 63 roll changes and fixed status file test now passes. 
TBR=whesse@google.com

Change-Id: Ie48a6023cc3c0abecb8347b1a2f3ce774d42681a
Reviewed-on: https://dart-review.googlesource.com/47243
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-20 15:14:38 +00:00
Terry Lucas 581c512345 Fixed DOMRectList not having a prototype field. 
TBR=vsm@google.com

Change-Id: I6cbc38bbb2123b914d5b5511774425c403e614ed
Reviewed-on: https://dart-review.googlesource.com/47183
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-03-20 01:08:47 +00:00
Terry Lucas 2c902f359f Not quite the full test name. 
TBR=whesse@google.com

Change-Id: Idf5568b9c9504ffcf082e7df1d7bd37bd314504f
Reviewed-on: https://dart-review.googlesource.com/47140
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-19 18:25:14 +00:00
Terry Lucas 1b5b2225f0 Few more to mark off. 
TBR=whesse@google.com

Change-Id: I4381b766757d1d365378f1aefa9875d6a55fb726
Reviewed-on: https://dart-review.googlesource.com/47101
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-19 16:41:52 +00:00
Terry Lucas afa27982e4 Marked the failing tests in the right status file. 
TBR=whesse@google.com

Change-Id: I7eda272cc69e2be8784c85b0045c0d04197924f8
Reviewed-on: https://dart-review.googlesource.com/47063
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-19 15:53:00 +00:00
Terry Lucas ea392fee27 TouchEvents now supported on Safari 
TBR=sigmund@google.com

Change-Id: If485b39afeb0ce389c98d90ebe8a7ea6359e0fba
Reviewed-on: https://dart-review.googlesource.com/46950
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-18 14:40:03 +00:00
Terry Lucas 9c0ba9992d Aded expected failure to status file. 
TBR=sigmund@google.com

Change-Id: I4e7ede394441038deee6eb973a4b3d7ba1e4623d
Reviewed-on: https://dart-review.googlesource.com/46949
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-18 14:28:38 +00:00