Commit Graph

793 Commits

Author SHA1 Message Date
Terry Lucas 60469482f1 Move ClientRect members to DOMRect.
TBR=sigmund@google.com,sra@google.com

Change-Id: I424b087830954329f4399f6b169f572196a4f658
Reviewed-on: https://dart-review.googlesource.com/46948
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-18 13:27:46 +00:00
Terry Lucas ef6273cba0 Dart Web Libraries re-generated based on Chrome 63 WebIDLs.
This is a migration of 13 Chrome release about 1.5 years of Chrome releases.
Update PYTHON scripts for cleaner and easier rolling.

Here's a doc on the changes that might affect Dart users:
https://docs.google.com/document/d/1Kj0nk3SueO3JKub8im7z3znu9j5oiI7vf49ejZrMxuE/edit#

Change-Id: I768fbd09b04fe6884af36ac102d5813f67bae426
Reviewed-on: https://dart-review.googlesource.com/24501
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-18 09:41:04 +00:00
Sigmund Cherem d6294bc6b5 Round 6 of status updates: remaining issues in d8, safari, ie11, ff (hopefully)
TBR=efortuna@google.com

Change-Id: Id84ed1a13646a27015d3aa20ad0d3c0c7d08522c
Reviewed-on: https://dart-review.googlesource.com/46564
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-14 19:25:29 +00:00
Sigmund Cherem af1f26fd48 Status fixes round 5: chrome mac & windows
TBR=efortuna@google.com

Change-Id: I69db60955cd22aca48981bb84a2637a28c385cc4
Reviewed-on: https://dart-review.googlesource.com/46422
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-14 16:16:34 +00:00
Sigmund Cherem 1bad507517 Status fixes round 4: minified+checked d8, and chrome csp
TBR=efortuna@google.com

Change-Id: I98fd69ca11b962a9eb665c0de9d5ecb49626a891
Reviewed-on: https://dart-review.googlesource.com/46421
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-14 07:11:29 +00:00
Sigmund Cherem 9c9497bda0 Status updates round 3: chrome-faststarup, ff, ff-faststartup
TBR=efortuna@google.com

Change-Id: I06b535f7273c3ac85173bf4f0286e02d09897c8e
Reviewed-on: https://dart-review.googlesource.com/46420
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-03-14 06:16:19 +00:00
Sigmund Cherem 537057cd2d Round 2: fast-startup minified
TBR=efortuna@google.com

Change-Id: Id8d74e93304ed92fd50afbb1820d9ad05e3abf02
Reviewed-on: https://dart-review.googlesource.com/46402
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-14 05:17:49 +00:00
Sigmund Cherem 1b13c73062 Round 1 of .status fixes: to cover d8 bots
TBR=efortuna@google.com

Change-Id: I93e86104760e6e41ea32fbae311535a46a72e4c8
Reviewed-on: https://dart-review.googlesource.com/46386
Reviewed-by: Emily Fortuna <efortuna@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-14 01:53:58 +00:00
Dmitry Stefantsov f8995da6aa Report a compile-time error on magic const
When inferring const or new for expressions that aren't required to be const,
Fasta always choses new. That's not correct, and this is a short-term work
around to avoid introducing a breaking change in the future. The plan is to
implement this feature correctly, but that will require more time than we have
right now.

Originally submitted by ahe@google.com.  Added: status file fixes.

Change-Id: I2d70bd2488de6b69fcd5546c1f4654dfbbb30b7f
Reviewed-on: https://dart-review.googlesource.com/46340
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
2018-03-13 19:07:12 +00:00
Lasse Reichstein Holst Nielsen 414a3318ea Add jsonDecode, jsonEncode, base64Decode, base64Encode, base64UrlEncode functions.
Change-Id: Ic65ada3b107cc8e6c3459459c4bea389feef2168
Reviewed-on: https://dart-review.googlesource.com/23664
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-03-12 09:16:27 +00:00
Jenny Messerly 76a672e8ea mark lib_2/html/fileapi_entry_test flaky on ddc+mac
Change-Id: Ie501f972829f85f3fb3e1a0072d874bf4a2652a3
Reviewed-on: https://dart-review.googlesource.com/45753
Reviewed-by: Jenny Messerly <jmesserly@google.com>
2018-03-09 02:03:34 +00:00
Sigmund Cherem 16e8194147 Prepare additional lib, html, samples statuses: this embeds of d8-hostcheck results
TBR=sra@google.com

Change-Id: I4a86f3d51629bbd7dd36825f8c2d993b386ea8e0
Reviewed-on: https://dart-review.googlesource.com/45745
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-03-08 21:10:37 +00:00
Lasse Reichstein Holst Nielsen b3c12d4e3a Dart 2 Libraries Wave 3
Add `typeArguments` to Invocation.
Add constructors to Invocation, making it less necessary for users to create their own implementations.
Add tests.
Add Symbol.unaryMinus and Symbol.empty constants.

Change-Id: I70cb3265f9413617cf57fce1297e393a29eeb26a
Reviewed-on: https://dart-review.googlesource.com/40741
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-03-08 16:36:07 +00:00
Sigmund Cherem 4c58384b50 Prepare html, isolate, lib, and lib_2 status files to turn on CFE on dart2js by default
TBR=sra@google.com

Change-Id: I4ed72f27eb21477bf281df5039a53d0eb703b8ac
Reviewed-on: https://dart-review.googlesource.com/45581
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-08 01:04:05 +00:00
Sigmund Cherem e8018bfdea Mark tests as flaky
TBR=efortuna@google.com

Change-Id: I3cb7153665609c0f02b1246e558857e20d09e100
Reviewed-on: https://dart-review.googlesource.com/45527
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-07 19:08:12 +00:00
Paul Berry 440b58d644 Start running analyzer tests with --preview-dart-2.
The changes to the CQ bot should take effect immediately.  The changes
to the other bots will take effect once those bots are switched over
to use the test matrix.

Change-Id: Ibfe59817a11f730fd1847cdc60b3244b4a71a480
Reviewed-on: https://dart-review.googlesource.com/45300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2018-03-07 15:04:33 +00:00
Peter von der Ahé 94aa20dd07 Update status for $compiler == fasta
Change-Id: I5d073d1c678dc313e79193074c6491085c093596
Reviewed-on: https://dart-review.googlesource.com/45381
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
2018-03-07 10:32:33 +00:00
Sigmund Cherem 9ed595b4b3 Use $fasta instead of $dart2js_with_kernel in our status files.
Note: $fasta is true when passing --dart2js-with-kernel. This change will make it
easier to flip the default: the plan is that $fasta will be true by default
later on, and passing --dart2js-old-frontend will make it false.

TBR=sra@google.com

Change-Id: Ib917d55b2d14db954c56513af057dd9a37b9c825
Reviewed-on: https://dart-review.googlesource.com/44601
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-01 21:02:18 +00:00
Dmitry Stefantsov e7830a9f7b Add a flag to Procedures indicating that it's a redirecting factory
Fixes #32282

Bug: http://dartbug.com/32282
Change-Id: Iee8535b053ced415e3047e990a0940d859faa86a
Reviewed-on: https://dart-review.googlesource.com/43440
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
2018-02-27 10:42:07 +00:00
William Hesse 77cd4a9d2d Update HTML worker test status on Chrome with CSP (content security protocol)
BUG: dartbug.com/32261
Change-Id: I08949cddbfe7bc39e98c132ecc6e64e7cb3561b8
TBR: eernst@google.com
Reviewed-on: https://dart-review.googlesource.com/43669
Reviewed-by: Erik Ernst <eernst@google.com>
2018-02-26 12:30:38 +00:00
Terry Lucas 53d020339e Updated status files.
TBR=vsm@google.com

Change-Id: I9c2e7060e4e2058eabb49f55ce7b34e301b9be82
Reviewed-on: https://dart-review.googlesource.com/43623
Reviewed-by: Terry Lucas <terry@google.com>
2018-02-25 23:30:27 +00:00
Terry Lucas ba5c32ce06 Updated status files for bot run.
TBR=vsm@google.com

Change-Id: I5170832aa59f7430de2d00917d76050d6e341124
Reviewed-on: https://dart-review.googlesource.com/43622
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-02-25 21:22:13 +00:00
Terry Lucas fbf0113aa6 Fixed tests to successfully run with the DDC.
TBR=vsm@google.com

Change-Id: I38c1ec16cb27dc3a46bb62ae129d9daa9cc4e9be
Reviewed-on: https://dart-review.googlesource.com/43621
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-02-25 18:43:33 +00:00
Terry Lucas 9f09ef0af3 - Fixed callback signatures with indexed_db open method to expose VersionChangeEvent and
Event type parameters instead of dynamic.
- Fixed missing interceptor in dart2js for MutationEvent (even though its deprecated
and should not be used).  The MutationEvent is created when a node is deleted. Enabled
Dart MutationEvent class generation.
- Fixed/re-enabled all indexed_db tests to run and pass successfully.

Stephen please take a look - target in VersionChangeEvent is a final field, per your suggestion,
instead of a getter.  The MutationEvent is returned in the browser and without the MutationEvent
Dart class the error:

     Uncaught TypeError: t1.get$target is not a function


R=vsm@google.com,gabrielchow@google.com,sra@google.com

Change-Id: Ic36aea8c33b4263a32ff9d047ba3e6b979e03b10
Reviewed-on: https://dart-review.googlesource.com/41569
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-02-23 14:29:45 +00:00
Dmitry Stefantsov e95e199fd5 Update status for a failing test for dart2js on safari
Bug: http://dartbug.com/32286
Change-Id: Iea76641e46a557e7180099a344549719afe61698
Reviewed-on: https://dart-review.googlesource.com/43343
Reviewed-by: William Hesse <whesse@google.com>
2018-02-23 09:56:21 +00:00
Stephen Adams 24b7429b02 Install JS-interop properties on JavaScriptObject
Fixes #26838

Change-Id: Id4a16431e94a50fd0e962301ef23eb4a31a8d5cf
Reviewed-on: https://dart-review.googlesource.com/42585
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
2018-02-23 00:31:52 +00:00
Alexander Aprelev ffad1d2287 Update dartkp status files.
This is follow-up to ec7029daf6.

Change-Id: I8aee1bc0002290ca5f6d91b87149b67ebb4943c2
Reviewed-on: https://dart-review.googlesource.com/43241
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Siva Chandra <sivachandra@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-02-22 23:35:47 +00:00
Alexander Aprelev ec7029daf6 Workaround deferred library limitation.
Introduce no-op LoadLibrary, CheckLibraryIsLoaded into kernel_binary_flowgraph.cc

Bug: https://github.com/dart-lang/sdk/issues/32245
Change-Id: If93a4d717844dcb8a5d45d0237660ec764a6f738
Reviewed-on: https://dart-review.googlesource.com/42461
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
2018-02-22 20:34:39 +00:00
Lasse R.H. Nielsen 9ec9a4c8da Move new tests from tests/isolate to tests/lib_2/isolate.
Fix test expectations.
Improve test (overly complex).
Mark tests/isolate as immutable to the presubmit script (like other migrated Dart 1 test directories).

(Gardening)

Change-Id: Iec59c59ca992b3dacafbf82176e4e8bd8c5bd3c5
Reviewed-on: https://dart-review.googlesource.com/42945
Reviewed-by: William Hesse <whesse@google.com>
2018-02-22 10:03:23 +00:00
Erik Ernst 924c614f4f Adjusted status of two tests
Gardening, adjusted status of these tests for csp-minified bot:
lib_2/html/worker_test/functional/functional
lib_2/html/no_linked_scripts_htmltest

Change-Id: I817d74255b15c29af4067c75ddd61738f7f44c61
Reviewed-on: https://dart-review.googlesource.com/42641
Reviewed-by: Erik Ernst <eernst@google.com>
2018-02-21 10:10:09 +00:00
Leaf Petersen f1a0257167 Fix Status files
Change-Id: I069eabb22a80af6cffd393807df624885b729856
Reviewed-on: https://dart-review.googlesource.com/42160
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-02-17 01:44:25 +00:00
Leaf Petersen 3d6ad7b3a2 Remove fuzzy arrows except on assignability
Change-Id: I00ffa8f6f85cede8badd4d7082da4603f998956c
Reviewed-on: https://dart-review.googlesource.com/40470
Reviewed-by: Jenny Messerly <jmesserly@google.com>
2018-02-17 00:30:56 +00:00
Lasse R.H. Nielsen 0fb1c5bc7b Mark test as failing on analyzer.
Change-Id: I7ebe8f4cbdafbf6b93fb3af2950c956c18790c6f
Reviewed-on: https://dart-review.googlesource.com/41680
Reviewed-by: Erik Ernst <eernst@google.com>
2018-02-15 11:32:59 +00:00
Sigmund Cherem 4436877ab2 More changes to make bots happy
R=efortuna@google.com

Change-Id: If0407436d204d9668a0ed13bf5fe2d36a0e041a9
Reviewed-on: https://dart-review.googlesource.com/41563
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
2018-02-14 23:09:34 +00:00
kmillikin b019045393 Front-end implementation of mixin type inference.
Infer missing type arguments to generic mixin classes in mixin
applications based on mixin supertype constraints.  The implementation
directly follows the draft feature specification at
https://dart-review.googlesource.com/c/sdk/+/38940.

Bug: https://github.com/dart-lang/sdk/issues/31984
Change-Id: I7caba037b1b0e73c44f71aaa958f3ff3e8f3c1f0
Reviewed-on: https://dart-review.googlesource.com/40661
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-02-14 22:43:24 +00:00
Sigmund Cherem 50db95f69b Fixes for CSP: status lines and some test fixes.
These failures started showing up when we switched to use chrome instead of DRT
for CSP tests.

Change-Id: I53b70ce18eaef73e720e10fdac05245953131f7c
Reviewed-on: https://dart-review.googlesource.com/41480
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-02-14 21:54:53 +00:00
Régis Crelier 3d756ec4ab [VM runtime] In strong mode, restrict subtyping rules of callable instances (fixes #32154).
Update kernel status files.

Change-Id: I2bf6097b5229d80cc90baed92fd8dcc750667b23
Reviewed-on: https://dart-review.googlesource.com/41482
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-02-14 21:48:27 +00:00
Jens Johansen 4083ff54e7 [gardening] Status files for kernel optimization_counter_threshold bot
Change-Id: I12334bfcec3e31aea753dd815ccb15695f0db5a3
Reviewed-on: https://dart-review.googlesource.com/40780
Reviewed-by: Jens Johansen <jensj@google.com>
2018-02-13 12:40:34 +00:00
Jens Johansen 4fac2530de [gardening] kernel/windows status file updates #1
Bugs #32137 and #32138.

Change-Id: If91591170b342794120076fe6af269e8020d3796
Reviewed-on: https://dart-review.googlesource.com/40744
Reviewed-by: Jens Johansen <jensj@google.com>
2018-02-13 11:58:15 +00:00
Zachary Anderson 23fe39e89f [dart:typed_data] Adds unmodifiable list views
On Fuchsia, we need external typed data arrays that are backed by
read-only regions of memory. Today, writes to these typed data
lists crash the process. This change allows us to wrap the
external typed data in unmodifiable views so that an exception
is thrown instead of crashing.

related #32028

Change-Id: I94dc5e1771b73480cb0eb21799215c090000fd5f
Reviewed-on: https://dart-review.googlesource.com/40201
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-02-12 16:30:51 +00:00
Lasse R.H. Nielsen 0d5ce913c9 Add cast/retype to Stream, StreamTransformer and Converter.
Switch default for StreamController.addStream cancelOnError parameter to false.
Add orElse named argument to Stream.{first,last}Where.
First step in renaming the argument from defaultValue to orElse.

Change-Id: I22039c1f6933664ebc287c71e802799a64776f08
Reviewed-on: https://dart-review.googlesource.com/34822
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-02-09 14:09:39 +00:00
Jenny Messerly 5ef7920d84 fix DDC explicit field initialization to null
This was unintentionally regressed during a fix to field init order. It
does not typically show up in Dart code because undefined and null are
both handled, but it can break JS interop.

Change-Id: I771895826ee09bb6c5e2f9b016eb7673caf61cd1
Reviewed-on: https://dart-review.googlesource.com/40202
Reviewed-by: Vijay Menon <vsm@google.com>
2018-02-09 02:48:07 +00:00
William Hesse bc148d44e2 Correct name of lib_2/async/periodic_timer4_test in status file
TBR=lrn@google.com

Change-Id: Ife80122754aa7e69bd98d6dab289a6a2aa9df7f3
Reviewed-on: https://dart-review.googlesource.com/40222
Reviewed-by: William Hesse <whesse@google.com>
2018-02-09 01:50:04 +00:00
William Hesse baaab3968f Mark new periodic_timer4_test as flaky on chrome and ff with all compilers
It is failing on chrome with dartdevc as well

TBR: lrn@google.com
Bug: https://github.com/dart-lang/sdk/issues/32094
Change-Id: I8c6c4734ef4d125fd0e17cba550f2fbd401a69c0
Reviewed-on: https://dart-review.googlesource.com/40221
Reviewed-by: William Hesse <whesse@google.com>
2018-02-09 01:19:56 +00:00
William Hesse be2e6c4f82 Update status for new dartk and dartkp builders
Change-Id: Ie5ed3cade049d1d7831440adece520dd09ad13d7
Reviewed-on: https://dart-review.googlesource.com/39985
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-02-08 16:52:56 +00:00
Lasse Reichstein Holst Nielsen bc27d2355b Mark periodic_timer4 test failing on jsshell
Change-Id: Ica5c86a8bff4ed94a65763437af404600f3eb629
Reviewed-on: https://dart-review.googlesource.com/39984
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-02-08 16:16:52 +00:00
Dmitry Stefantsov 47fbe76d03 Avoid patching with redirecting factories in vm-related patches
Change-Id: Id45696a38b281b1b75a9a0e26d89216388a4ec19
Reviewed-on: https://dart-review.googlesource.com/39942
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-02-08 14:11:50 +00:00
Lasse R.H. Nielsen bdc6e9c862 Add ticks counter to Timer.
Change-Id: Ie5ed28fa8b7ef9c6aea97331267cf3c717b17099
Reviewed-on: https://dart-review.googlesource.com/21342
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-02-08 10:16:00 +00:00
Peter von der Ahé 8815bbe90e Update status files for $compiler == fasta
Change-Id: I09761d12b98864d9a9abcc7abe6f046e45951715
Reviewed-on: https://dart-review.googlesource.com/36642
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
2018-02-07 15:38:09 +00:00
Lasse R.H. Nielsen 6f78471687 New methods on Iterable, List, Set, Queue, Map.
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.

Change-Id: I7a12fea533d42b0fc8357086649df38ad01f3cdd
Reviewed-on: https://dart-review.googlesource.com/39140
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-02-07 06:12:53 +00:00