Commit Graph

793 Commits

Author SHA1 Message Date
Florian Loitsch 4443c34512 Migrate dart:convert tests from test block 188.
Change-Id: I99e796a6793ab76c0f9d0c7c37377a97bb5102fd
Reviewed-on: https://dart-review.googlesource.com/3061
Reviewed-by: Erik Ernst <eernst@google.com>
2017-09-08 14:39:47 +00:00
Florian Loitsch 518e1bb60e Clean status file.
Change-Id: I74c7f4d026f52a89aa8665a891a8a1ba1a9f164e
Reviewed-on: https://dart-review.googlesource.com/4500
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-09-08 13:58:55 +00:00
Florian Loitsch 6f748c50c4 Migrate test block 187.
Change-Id: Ie396e72abc33885128f786609f8927624d68aa1b
Reviewed-on: https://dart-review.googlesource.com/3060
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
2017-09-08 13:43:31 +00:00
Jakob Roland Andersen 31d5dc1986 Migrate test batch 231 to Dart 2.0
Bug:
Change-Id: I8a5659dfd76baa3b16e3570e410c262c14e3ded1
Reviewed-on: https://dart-review.googlesource.com/4021
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-09-08 12:59:34 +00:00
Florian Loitsch 7c83d5ced6 Migrate test block 186.
Change-Id: I5ff48ecdcba4b12280ecf76c53a6cc7f12dabfbf
Reviewed-on: https://dart-review.googlesource.com/3005
Reviewed-by: Erik Ernst <eernst@google.com>
2017-09-08 10:18:50 +00:00
Jakob Roland Andersen 05f0ce4aa9 Migrate test batch 227 to Dart 2.0
Bug:
Change-Id: I34c57e58c08c1137c1bf517953dd204fa351aa09
Reviewed-on: https://dart-review.googlesource.com/3882
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-09-08 09:57:16 +00:00
Jakob Roland Andersen 0a3ed33abd Reland "Migrate test batch 226 to Dart 2.0"
This is a reland of 77a7ca98a2
Original change's description:
> Migrate test batch 226 to Dart 2.0
> 
> Specifically skipped formatting these files, since there are tests that depend
> on non-standard source formatting.
> 
> Bug:
> Change-Id: I3058984458a9c63b239ed8714828ec42d33316c5
> Reviewed-on: https://dart-review.googlesource.com/3440
> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>

Change-Id: I083c07c08333909aaf5bce763601445ff9f0413f
Reviewed-on: https://dart-review.googlesource.com/3920
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2017-09-08 09:28:18 +00:00
Florian Loitsch 99c9b7eb5b Fix typed_data_list_test.
Change-Id: I730c90d4a10a20920118d6a78711d9f0c5bf9e55
Reviewed-on: https://dart-review.googlesource.com/4320
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
2017-09-08 09:09:32 +00:00
Jakob Roland Andersen 103bc1a556 Migrate test batch 236 to Dart 2.0
Bug:
Change-Id: Iab2897892892925efb96f5da5175ec35d084661b
Reviewed-on: https://dart-review.googlesource.com/3240
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2017-09-08 07:58:53 +00:00
Florian Loitsch c28724220a Use const Symbol instead of new Symbol.
Otherwise minified tests don't work.

Change-Id: I27e9877f0eb539014e4533346e005dc6ef61c317
Reviewed-on: https://dart-review.googlesource.com/4020
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-09-07 14:03:32 +00:00
Florian Loitsch bf8d86f4fd Migrate test block 182.
Change-Id: I4834e2661f3cf78d95919db2cfcec1293c780925
Reviewed-on: https://dart-review.googlesource.com/3062
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
2017-09-07 12:53:45 +00:00
Jakob Roland Andersen b4835cce26 Revert "Migrate test batch 226 to Dart 2.0"
This reverts commit 77a7ca98a2.

Reason for revert: Migrated a test file that's still being used by the unmigrated tests.

Original change's description:
> Migrate test batch 226 to Dart 2.0
> 
> Specifically skipped formatting these files, since there are tests that depend
> on non-standard source formatting.
> 
> Bug:
> Change-Id: I3058984458a9c63b239ed8714828ec42d33316c5
> Reviewed-on: https://dart-review.googlesource.com/3440
> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>

TBR=jakobr@google.com,lrn@google.com

Change-Id: If4d0b44f81cfadf290bf72b23765fa85a6580937
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/3900
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
2017-09-07 09:34:28 +00:00
Jakob Roland Andersen 77a7ca98a2 Migrate test batch 226 to Dart 2.0
Specifically skipped formatting these files, since there are tests that depend
on non-standard source formatting.

Bug:
Change-Id: I3058984458a9c63b239ed8714828ec42d33316c5
Reviewed-on: https://dart-review.googlesource.com/3440
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2017-09-07 09:15:44 +00:00
Florian Loitsch 051f0f1267 Added new entries to the .gitattributes file.
Also updated the tests so that we don't forget in the future.

Change-Id: I0a998af306a0b6fa54b3c86cf164fdfe1f76340d
Reviewed-on: https://dart-review.googlesource.com/3624
Reviewed-by: William Hesse <whesse@google.com>
2017-09-06 18:05:57 +00:00
Florian Loitsch bdbcad0458 Migrate test block 185.
Change-Id: I9ab6bddaeed00dd9364066fae3df9bb4f681203d
Reviewed-on: https://dart-review.googlesource.com/3004
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
2017-09-06 14:06:20 +00:00
Florian Loitsch 176b277f5d Fix encoding_test.
Change-Id: I5d47366d62a44dd8ba6c56a65bb6c744e56407ea
Reviewed-on: https://dart-review.googlesource.com/3480
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
2017-09-06 12:19:50 +00:00
Jakob Roland Andersen 4f3da72603 Migrate test batch 235 to Dart 2.0
Bug:
Change-Id: I4a27ef006833a6e7bcd6c2206c40cc748a6892ba
Reviewed-on: https://dart-review.googlesource.com/3007
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2017-09-06 09:15:34 +00:00
Florian Loitsch 6d09d02a64 Migrate test block 184.
Change-Id: Id6b51f0367e886b0c81d9899423a9525f2cd6a60
Reviewed-on: https://dart-review.googlesource.com/3040
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
2017-09-06 08:48:51 +00:00
Florian Loitsch 57adc7b9ad Migrate test block 183.
Change-Id: I86ccd460e1041b74e3960e95dbf67de35d33a782
Reviewed-on: https://dart-review.googlesource.com/3002
Reviewed-by: Erik Ernst <eernst@google.com>
2017-09-05 17:00:56 +00:00
Jakob Roland Andersen 3a436c798f Migrate test batch 234 to Dart 2.0
Bug:
Change-Id: I4bb8200a8d9e8ee3835e3989b741aeb35b38478d
Reviewed-on: https://dart-review.googlesource.com/3008
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2017-09-05 13:30:00 +00:00
Jakob Roland Andersen 299acb4f45 Migrate test block 237 to Dart 2.0
Bug:
Change-Id: I27a2f435ad222e1b7efc24f10143c70fcf66217a
Reviewed-on: https://dart-review.googlesource.com/3121
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2017-09-05 09:56:52 +00:00
Ben Konyi adfc7a6b72 Migrated test lock 217 to Dart 2.0.
Fairly simple block, with only minor changes made to lib_2/mirrors tests
needed for strong mode compliance.

BUG=

Review-Url: https://codereview.chromium.org/2997283003 .
2017-08-31 07:47:36 -07:00
Ben Konyi 143ea83cf3 Migrated test block 220 to Dart 2.0.
No changes to tests.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/3001373002 .
2017-08-31 07:16:58 -07:00
Ben Konyi 002ebba6f4 Migrated test block 216 to Dart 2.0.
No changes made to this block.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2995343002 .
2017-08-31 07:02:53 -07:00
Ben Konyi 301650d4a2 Marked mirrors/mirrors_test as Crash in lib_2_kernel.status.
TBR=jcollins@google.com,rnystrom@google.com
BUG=

Review-Url: https://codereview.chromium.org/3004933002 .
2017-08-30 13:00:00 -07:00
Ben Konyi 07d16559f2 Made helpers strong-mode clean for Dart 2.0 migration.
BUG=

Review-Url: https://codereview.chromium.org/3006863002 .
2017-08-30 09:51:39 -07:00
Ben Konyi 64105ee014 Migrated test block 219 to Dart 2.0.
No major changes. Some tests that rely on noSuchMethod needed to have
some 'var's changed to 'dynamic's.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/3003123002 .
2017-08-30 07:51:59 -07:00
Ben Konyi a7a97e41ed Migrated test block 218 to Dart 2.0.
Fairly simple block, with changes made to some mirrors tests to make
them strong-mode clean. Modified test script to also accept
*_app_jit.status files.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2999373002 .
2017-08-30 07:29:11 -07:00
Ben Konyi e897f75c74 Fixed strong mode error in slow_consumer3_test introduced as part of Dart 2.0 migration (test block 171).
TBR=rnystrom@google.com,jcollins@google.com
BUG=

Review-Url: https://codereview.chromium.org/3004903002 .
2017-08-30 07:06:11 -07:00
Ben Konyi d08e59e09c Migrated test block 171 to Dart 2.0.
R=rnystrom@google.com

Moved schedule_microtask[2,3,5]_test off of package:test to
package:async_helper and package:expect.
Review-Url: https://codereview.chromium.org/3001793002 .
2017-08-30 06:46:35 -07:00
Ben Konyi eb8b398163 Changed void -> dynamic return type to fix issue caused by poor merge decision.
TBR=rnystrom@google.com
BUG=

Review-Url: https://codereview.chromium.org/3012563002 .
2017-08-29 16:45:25 -07:00
Ben Konyi 0ea752b5bf Relanding test block 170 migration.
"Migrated test block 170 to Dart 2.0.""

This reverts commit 201df65b50201f023a1db5bb26bea7b8976c3b32.

Review-Url: https://codereview.chromium.org/3005813002 .
2017-08-29 16:22:07 -07:00
Ben Konyi e8b337f08f Revert "Migrated test block 170 to Dart 2.0."
This reverts commit 6e6b0cadea9adbb48556384fac52b17c2ac15443.
2017-08-29 15:37:15 -07:00
Ben Konyi a7b19c1b47 Migrated test block 170 to Dart 2.0.
Updated status file to account for strange failure in package:test when
running multiple_timer_test on dartdevc.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2995013002 .
2017-08-29 15:25:42 -07:00
Vyacheslav Egorov ab83ea939f Fix lib_2/async/future_test.dart multitest.
It was broken by migration in 42d354c91d.

BUG=
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/3012433002 .
2017-08-28 13:34:52 +02:00
Lasse R.H. Nielsen c8b6c19314 Revert "Add ticks counter to Timer."
Tests broken in DDC

Review-Url: https://codereview.chromium.org/3011503002 .
2017-08-28 13:14:09 +02:00
Lasse R.H. Nielsen 39c8f64ea3 Add ticks counter to Timer.
Avoid VM scheduling multiple timer events if it gets delayed. This doesn't
scale for processes that are suspended for extended amounts of time.

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/3003853002 .
2017-08-28 12:57:45 +02:00
Ben Konyi 7e798f4a20 Updating status file to fix DDC build.
TBR=rnystrom@google.com
BUG=

Review-Url: https://codereview.chromium.org/2998163002 .
2017-08-21 02:00:34 -07:00
Ben Konyi 42d354c91d Migrated test block 168 to Dart 2.0.
This block felt trickier than others, mostly due to random errors that I
wasn't able to find a cause for. Tests that I'm uncertain about are:
-first_regression_test
-future_timeout_test
-future_or_bad_type_test/implements

These all have status entries to prevent failures, but I think these
tests need another set of eyes.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2999943002 .
2017-08-21 00:59:34 -07:00
Ben Konyi 55612ef10c Migrated test block 167 to Dart 2.0.
No manual work required for this block.

BUG=
R=jcollins@google.com

Review-Url: https://codereview.chromium.org/2993213003 .
2017-08-17 12:42:36 -07:00
Bob Nystrom 489c96ac2e Re-land beginning Dart 2.0 test migration.
This is similar to:

47985d6dbd
452d2d0840
7af2d86ed3

Except that it also fixes the status for dart2analyzer.

R=jcollins@google.com

Review-Url: https://codereview.chromium.org/2980213002 .
2017-07-17 12:40:18 -07:00
Alexander Aprelev 9882d494db "Set up directories.." commit below broke the buildbot tests, two others are collateral damage.
Revert "Precompiler doesn't report Dart 2.0 static type errors yet."

This reverts commit 7af2d86ed3.

Revert "Move absstract_exact_selector back into the language tests. (#30169)"

This reverts commit 452d2d0840.

Revert "Set up directories for migrated Dart 2.0 tests and migrate a couple. (#30149)"

This reverts commit 47985d6dbd.

R=zra@google.com

BUG:dartbug.com/30171
Review-Url: https://codereview.chromium.org/2979073002 .
2017-07-14 14:43:55 -07:00
Bob Nystrom 47985d6dbd Set up directories for migrated Dart 2.0 tests and migrate a couple. (#30149)
* Set up directories for migrated Dart 2.0 tests and migrate a couple.

- Create new "_2" directories where tests that have been validated as
  ready for Dart 2.0 will end up.
- Create empty status files for each directory.
- Add those directories to the set of default selectors you get when you
  run test.py. This gets the VM bots running them.
- Get the DDC bots running those suites.
- Move abstract_exact_selector_test over to dart2js since it's a
  dart2js-specific regression test and not an actual language test.
- Migrate corelib/apply_test.dart.
- Delete abstract_beats_arguments[2]_test.dart since that code is
  statically wrong in 2.0 and can't be run.

This doesn't get the dart2js bots running the new suites. I'll email
the relevant folks to get help with that.

* Resurrect abstract_beats_arguments_test.dart.

It usefully checked that an implementation reports an warning (now
error) if you construct an abstract class.

Also added support to test.dart to mark a test as expecting to
generate a compile error in the test itself. That way, the status file
reflects what is *wrong* about the current status, not what is *right*.

* Change static error syntax to match front_end notation.

* Migrate abstract_getter_test.
2017-07-14 10:27:37 -07:00