dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

793 Commits

Author SHA1 Message Date
Leaf Petersen 85ca7df7e2 Avoid fuzzy arrows when parsing json. 
Change the types on the json decoding reviver to avoid fuzzy arrow
checks.

Bug:
Change-Id: I3ca52d7676b6305c398f128d370bc9859fd65820
Reviewed-on: https://dart-review.googlesource.com/21564
Reviewed-by: Vijay Menon <vsm@google.com>
 2017-11-17 20:37:07 +00:00
Alexander Markov a211134136 [Tests] Update _2 tests for Dart 2.0 fixed-size integers 
Also, --limit-ints-to-64-bits is enabled when running tests in _2 test
suites.

This is the re-landing of 92ebd8aefa with
fixes:

* Revert changes in pkg/dev_compiler/test/browser/language_tests.js
  and tests/language/language_dart2js.status as they describe
  'language' test suite, not 'language_2'

* Correct tests/standalone_2/io/fuzz_support.dart as file_fuzz test was
  timing out on Windows and failing on android/arm.

Closes https://github.com/dart-lang/sdk/issues/31396

Change-Id: If9ca77fca300ddc605f17a7be39d1707e9724e25
Reviewed-on: https://dart-review.googlesource.com/21700
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2017-11-17 20:28:06 +00:00
Sigmund Cherem af814e27db Normalize lib_2 status files. 
All entries affecting dartk* are in lib_2_kernel.status

Change-Id: I10fda8747a514aabffcf6ecffd62db3b32df59a8
Reviewed-on: https://dart-review.googlesource.com/21561
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-11-17 01:14:38 +00:00
Alexander Markov 22218e9b9e Revert "[Tests] Update _2 tests for Dart 2.0 fixed-size integers" 
This reverts commit 92ebd8aefa.

Reason: various failures on buildbots.
Change-Id: I03e877e240fdb010d1288baebc124a3e364d1025
Reviewed-on: https://dart-review.googlesource.com/21565
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2017-11-17 00:52:17 +00:00
William Hesse 50eb1eccec Update status files for Firefox Quantum (57.0) 
Bug:
Change-Id: I1d7a017409e8ff10791f897eea9295a89f8ac8ca
R=mkroghj@google.com
Reviewed-on: https://dart-review.googlesource.com/21542
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
 2017-11-17 00:00:09 +00:00
Alexander Markov 92ebd8aefa [Tests] Update _2 tests for Dart 2.0 fixed-size integers 
Also, --limit-ints-to-64-bits is enabled when running tests in _2 test
suites.

Change-Id: I0b75e5e6e7af78adb29401d77ff55e735781ab73
Reviewed-on: https://dart-review.googlesource.com/20960
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2017-11-16 22:40:11 +00:00
Vyacheslav Egorov e834248640 [gardening] Restore status lines removed by accident 
Bug:
Change-Id: I230a003c5300e5f4e7f5586e0582ec5c16fc6268
Reviewed-on: https://dart-review.googlesource.com/21348
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-11-16 11:51:21 +00:00
Stephen Adams 3836c70a81 Redo "js_runtime: Use browser's TextDecoder for UTF8 decoding" 
Bug:
Change-Id: I40903bcdc1502e15cbf84298b43ba04ae8a8ecaf
Reviewed-on: https://dart-review.googlesource.com/21383
Reviewed-by: Stephen Adams <sra@google.com>
 2017-11-16 04:59:26 +00:00
Stephen Adams 5e06165d6b Revert "js_runtime: Use browser's TextDecoder for UTF8 decoding" 
This reverts commit 5f15867a47.

The recent renaming of constants had caused a lot of pain with this CL.

TBR=lrn@google.com

Bug:
Change-Id: I67a78fa09e15e95ea44fe18d9847fcfd9c61e043
Reviewed-on: https://dart-review.googlesource.com/21382
Reviewed-by: Stephen Adams <sra@google.com>
 2017-11-16 04:52:40 +00:00
Stephen Adams 5f15867a47 js_runtime: Use browser's TextDecoder for UTF8 decoding 
Change-Id: I85a8e774595784883281b1cc40ee75ae8de7d1d9
Reviewed-on: https://dart-review.googlesource.com/3303
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-16 04:22:22 +00:00
Ben Konyi 064d49c9a8 [Gardening] Marking issue23244_test and isolate/compile_time_error_test/none as Crash for app_jit. See issue #31376. 
Bug:
Change-Id: I95997e5cb53112c5e78c2199c7c95db3bf7766ee
Reviewed-on: https://dart-review.googlesource.com/21285
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-11-15 22:56:38 +00:00
Lasse R.H. Nielsen b93820ec94 Mark two app_jit/vm tests as failing. 
See issue #31376.

Change-Id: I6615847f9ac48abe46d00272784c008d1f63cb98
Reviewed-on: https://dart-review.googlesource.com/21040
Reviewed-by: Erik Corry <erikcorry@google.com>
 2017-11-15 11:03:35 +00:00
Lasse R.H. Nielsen 0b58c4bd10 Change some constant declarations to lowerCase. 
Retain the old values.

Reapply of https://dart-review.googlesource.com/c/sdk/+/20680 with fixes
for VM method fingerprints.

Change-Id: Ie14e7ccc3194d5561983348e6b6752728913ff4d
Reviewed-on: https://dart-review.googlesource.com/20664
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-14 12:59:14 +00:00
Lasse R.H. Nielsen e61fc07b58 Revert "Change some constant declarations to lowerCase." 
This reverts commit c048cfb178.

Reason for revert: VM code fingerprints needs update.

Original change's description:
> Change some constant declarations to lowerCase.
> 
> Retain the old values.
> 
> Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
> Reviewed-on: https://dart-review.googlesource.com/11520
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Florian Loitsch <floitsch@google.com>

TBR=lrn@google.com,floitsch@google.com

Change-Id: I095e8198304ca4e59b39d30b0fdf0af4945e5231
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/20680
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-14 11:23:08 +00:00
Lasse R.H. Nielsen c048cfb178 Change some constant declarations to lowerCase. 
Retain the old values.

Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
Reviewed-on: https://dart-review.googlesource.com/11520
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-11-14 11:13:04 +00:00
Alexander Markov 0a4b151dc4 [Test tool] Pass --strong to dart_bootstrap, disable experimental opts 
In '-c dartkp --strong' mode test tool should pass --strong option to
dart_bootstrap. Otherwise it uses non-strong vm_platform.dill instead
of vm_platform_strong.dill.

Also, experimental strong-mode based optimizations are disabled for now.

Closes https://github.com/dart-lang/sdk/issues/31348
Closes https://github.com/dart-lang/sdk/issues/31335

Change-Id: I2188b9165ae4daa0510e4e566393810b8165291e
Reviewed-on: https://dart-review.googlesource.com/20304
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2017-11-11 01:46:01 +00:00
Vyacheslav Egorov 2b88fa0132 [gardening] Update dartkp-debug status files. 
R=kustermann@google.com

Bug:
Change-Id: Ifc35f8a9b2ccf2fa095a4da510111b04c1ea883e
Reviewed-on: https://dart-review.googlesource.com/20061
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-11-10 13:35:13 +00:00
Vyacheslav Egorov fd78da5059 [gardening] Update dartkp status files. 
Bug:
Change-Id: I51746bfa10bc10acc90c176ef98cf6da081a42d9
Reviewed-on: https://dart-review.googlesource.com/19568
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-11-09 16:26:01 +00:00
Jens Johansen 66bf1a5fbd [kernel, VM] ReportError on unsupported tag instead of crashing 
Closes #31296.

Bug:
Change-Id: I1bcdd60d25fde7d99e71ce0e42efcd78916a3409
Reviewed-on: https://dart-review.googlesource.com/19186
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-11-09 13:25:07 +00:00
Emily Fortuna ef68e359a2 Deal with JS-interop default argument values. 
Bug:
Change-Id: I9f0c26f8716473b445922aac43248b717ce45bb3
Reviewed-on: https://dart-review.googlesource.com/19120
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2017-11-08 23:24:01 +00:00
Lasse R.H. Nielsen adcb6a7399 Make main invocation not fail strong-mode type checking. 
Bug: http://dartbug.com/31270
Change-Id: Id6ad2a429d5dc44b437a0fdd8fb4889d3dccf194
Reviewed-on: https://dart-review.googlesource.com/18480
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-11-03 16:06:00 +00:00
Jacob Richman 8b221d13a4 Fix ddc debugger_test Fix regression in custom formatters due to change in metadata signatures to use Object.__proto__ instead of a null __proto__. 
Bug:
Change-Id: I68fdb980e777b7c3f335fd6b57181134e3159cc3
Reviewed-on: https://dart-review.googlesource.com/17060
Commit-Queue: Jacob Richman <jacobr@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-31 19:45:27 +00:00
Martin Kustermann 84dbb6e0b6 [VM] Do eager rehashing of [LinkedHashMap]s in order to avoid checking on every access 
This improves 
  * JIT performance by around 14% 
  * precompiled performance by around 2%
on a simple map microbenchmark.

Change-Id: I623e2a715a709f89f2514ae30fbb504ee2e31661
Reviewed-on: https://dart-review.googlesource.com/17165
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-10-31 13:42:15 +00:00
Sigmund Cherem a8d13565cd Add support for deferred loading in fasta 
Change-Id: I2a5489b618210935b4b21c583aba9738a5e3f645
Reviewed-on: https://dart-review.googlesource.com/13441
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-10-26 23:22:48 +00:00
Sigmund Cherem 5d2613d632 Status updates for vm-kernel in strong mode 
Change-Id: I93a4429822f374741b0211e755ed9d5b1b43fe23
Reviewed-on: https://dart-review.googlesource.com/16623
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2017-10-25 20:25:49 +00:00
Sigmund Cherem e2e3934b62 Add status entries for dartk and dartkp in strong mode 
This is an initial step and some entries say "Pass", which indicates
that the test was marked earlier in some other (more general) section and that
we should split that section.

Change-Id: I0417d55dcdec352f730c298bb155d112eb341711
Reviewed-on: https://dart-review.googlesource.com/16322
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2017-10-24 21:49:19 +00:00
Samir Jindel 6b64aa8943 [kernel] Always disable reified generic functions in the Kernel FE. 
Currently, we have some tests that run with reified generic functions ON and
some with it OFF. However, this causes inconsistencies when running the Kernel
FE from snapshot in the VM, since the VM requires that the flag be consistent
with the snapshot. Our solution is to turn the reified generic functions flag
into a per-isolate flag, which is always disabled in the Kernel FE's isolate.

Bug:
Change-Id: Ia91e9f0ff5fc059edf4bdbd79ef14abb288b4a49
Reviewed-on: https://dart-review.googlesource.com/16020
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-10-24 15:21:28 +00:00
Janice Collins ad3efd8717 Migrate leftovers in lib/async to Dart 2.0. 
Bug:
Change-Id: I57ceb6a807fd63691028f2c5542f4446f748dda2
Reviewed-on: https://dart-review.googlesource.com/14882
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-20 16:41:18 +00:00
Konstantin Shcheglov 3fedd483f3 Parse metadata for import/export directives and resynthesize in Analyzer. 
R=ahe@google.com, paulberry@google.com, sigmund@google.com

Bug: https://github.com/dart-lang/sdk/issues/30284
Change-Id: I57af6f4d58b6de39f13b9656af25f0be6949cf79
Reviewed-on: https://dart-review.googlesource.com/14363
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-10-19 16:35:17 +00:00
Konstantin Shcheglov 1079e6c518 Skip DDC tests that fail on Linux. 
Bug: https://github.com/dart-lang/sdk/issues/31144
Change-Id: I2c65e363d62a4de12578dc216d27fb30c9c80b2d
Reviewed-on: https://dart-review.googlesource.com/15004
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-10-18 23:22:15 +00:00
Régis Crelier 0d976d1014 Update kernel status file for lib_2 now that --reify-generic-functions is passed. 
Change-Id: I8a5af7e4ebcbdd82506799929a90d4a61d86c8b7
Reviewed-on: https://dart-review.googlesource.com/15003
Reviewed-by: Régis Crelier <regis@google.com>
 2017-10-18 22:35:42 +00:00
William Hesse 601e822ce9 Update status for Chrome 62 stable 
Bug:
Change-Id: I3c554583dbd9fabc01664e21d86248768db551a4
R=mkroghj@google.com
Reviewed-on: https://dart-review.googlesource.com/14765
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
 2017-10-18 12:02:56 +00:00
Bob Nystrom 07b9df22ac Use the Expect.throws___() helper methods throughout tests. 
No behavioral changes, just getting rid of a lot of redundant closures
and helper functions.

Change-Id: I55c52c2cc9e5505bb64203c31aad8d76847f8eeb
Reviewed-on: https://dart-review.googlesource.com/14320
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2017-10-17 23:37:15 +00:00
Vyacheslav Egorov 826b48ee8a [VM] Clean up typing violations in the numerics implementation. 
Bug: https://github.com/dart-lang/sdk/issues/31052
Change-Id: I93d7bca2ff627431f1a316bb01a5dada1b5f2354
Reviewed-on: https://dart-review.googlesource.com/14522
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2017-10-17 21:00:24 +00:00
Konstantin Shcheglov 1e6c488ef5 Parse annotations for library directives. 
R=ahe@google.com, paulberry@google.com, sigmund@google.com

Bug: https://github.com/dart-lang/sdk/issues/30284
Change-Id: I9354e114eb2d603543a964030482af7ac9198760
Reviewed-on: https://dart-review.googlesource.com/12802
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-10-16 17:35:06 +00:00
Alexander Markov dd2d586a30 [Test status] exclude html/* tests from dartkp configuration 
Change-Id: I3684b3fc87f91465076c6ca70804a47c6053d9a6
Reviewed-on: https://dart-review.googlesource.com/13840
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2017-10-13 17:53:23 +00:00
William Hesse 6d1e43630f Update status for migrated tests 
Bug:
Change-Id: I2ba85715f5fa375b12009df7e0094c4032f29071
R=mkroghj@google.com
Reviewed-on: https://dart-review.googlesource.com/13500
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
 2017-10-12 11:22:13 +00:00
Ben Konyi 41bda23a77 Migrated test block 214 to Dart 2.0. 
wrapping_collections_test was modified since JSNative is deprecated and
was causing the test to fail ('class js has no getter for JSNative').

Bug:
Change-Id: Icc8951bce4be1152984b66769676080f89e5f1f7
Reviewed-on: https://dart-review.googlesource.com/9420
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-11 20:22:31 +00:00
Terry Lucas b8bd1f2b70 Updated status failures. 
TBR=rnystrom@google.com

Change-Id: Ia0d08f66e8865b1183341c864300189c80859665
Reviewed-on: https://dart-review.googlesource.com/13220
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-10-11 18:22:00 +00:00
William Hesse 10820c74ff Update statuses for migrated tests on safari and content_shell 
Bug:
Change-Id: I30e772845940112ccb49c5f8e5071d66624dd6f7
Reviewed-on: https://dart-review.googlesource.com/13042
Reviewed-by: William Hesse <whesse@google.com>
 2017-10-11 15:19:52 +00:00
Terry Lucas 213830e122 Migrated Block 188 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I3a450b04becaef007cc81fda1dbca1fda58b3d19
Reviewed-on: https://dart-review.googlesource.com/12361
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-11 14:42:22 +00:00
William Hesse 15c1a15e6c Update status for tests that fail on firefox after migration 
Bug:
Change-Id: Ia7de36399d44f6aeda826399df20cec6cecc3ec4
TBR=mkroghj@google.com
Reviewed-on: https://dart-review.googlesource.com/12980
Reviewed-by: William Hesse <whesse@google.com>
 2017-10-11 14:05:38 +00:00
Vyacheslav Egorov 3f9a4966e7 [VM] Fix typing issues in the typed_data.dart 
Bug: https://github.com/dart-lang/sdk/issues/31052
Change-Id: I6bc0454c8c27432ee6206267c04d114d47835046
Reviewed-on: https://dart-review.googlesource.com/12660
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2017-10-11 10:29:05 +00:00
Bob Nystrom 433036122f More dart2js status fixes. 
Change-Id: Ic0d1fe2ca05db1c0cd55ad043006f07b89fb8587
Reviewed-on: https://dart-review.googlesource.com/12882
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-10 23:44:12 +00:00
Bob Nystrom 17cd1a9f90 More status file fixes. 
Change-Id: Ia40ab1e7cf736b9e82d58ef80b2abdfa20801d09
Reviewed-on: https://dart-review.googlesource.com/12844
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-10 21:47:39 +00:00
Bob Nystrom 04dbe5794b Fix status of some dart2js and DDC tests. 
Change-Id: Iae1367f03591a97ea43ea104db5ecbf01d33d9d3
Reviewed-on: https://dart-review.googlesource.com/12820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-10-10 21:11:06 +00:00
Terry Lucas 20dfcd3659 Update status for drt/csp 
TBR=rnystrom@google.com

Change-Id: If4a11cab186730ea3cd713a7f1978d8b034da33c
Reviewed-on: https://dart-review.googlesource.com/12800
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-10 20:38:05 +00:00
Bob Nystrom 307742d07e Move tests from package "test" (back) to "unittest". 
Since unittest is known to work with test.dart as a test runner and is
strong mode clean, it's a safer bet than test.

Change-Id: Id120d4f871827b1f131dff2a5ef2f7efb15a8382
Reviewed-on: https://dart-review.googlesource.com/12125
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-10 19:46:12 +00:00
Terry Lucas 8611852b81 Migrated Block 199 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Ic52e7afb489b15b2f2e45f5ad9191cf5e441c047
Reviewed-on: https://dart-review.googlesource.com/11342
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-10 13:53:24 +00:00
Terry Lucas 83ff87e4a3 Migrated Block 204 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I032f25969e75fb9966222da969e73a665bf35f44
Reviewed-on: https://dart-review.googlesource.com/12321
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-10-10 13:00:01 +00:00