dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

793 Commits

Author SHA1 Message Date
Vyacheslav Egorov 5b14ee115a [VM] Make _StringBase implement String 
_StringBase is used everywhere as if it was assignable to String,
however it itself does not implement String, its subclasses do.

This change addresses this.

Also removes unused native runtime method from one of subclasses.

Bug: https://github.com/dart-lang/sdk/issues/31052
Change-Id: Iea2389d1b48a3689fb11c99c0e230747ab1c5962
Reviewed-on: https://dart-review.googlesource.com/12444
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2017-10-10 10:33:31 +00:00
Jennifer Messerly 1da54c2346 fix status files for DDC so local test runs pass 
Change-Id: I43ca656983ea06def076b1e9166f0c7ccaa3b301
Reviewed-on: https://dart-review.googlesource.com/12384
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-10 01:25:01 +00:00
Terry Lucas 2b16dc99ce Updated status with issue on flakiness of websql_test in DDC. 
TBR=rnystrom@gogole.com

Change-Id: I3f11c7a97d107ff8ba52c4cfaa52ad81fccef6be
Reviewed-on: https://dart-review.googlesource.com/12347
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-09 19:54:54 +00:00
Terry Lucas ae14802ebc Update status - test passes in jsshell. 
TBR=rnystrom@google.com

Change-Id: I60b4054322a3c854cc9101f770e4b3c7462a168a
Reviewed-on: https://dart-review.googlesource.com/12320
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-09 12:58:08 +00:00
Terry Lucas f25211f18b Update status for passing test. 
TBR=rnystrom@google.com

Change-Id: I8a44c1e307f5c16345d8beaf46a22f5b48c83d4f
Reviewed-on: https://dart-review.googlesource.com/12308
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-09 03:36:31 +00:00
Terry Lucas 0319fb1e87 Migrated Block 200 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I9d998f61c2bc3d4b9c6ea71cb1111c00983a80a5
Reviewed-on: https://dart-review.googlesource.com/11347
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-09 02:45:04 +00:00
Terry Lucas e5b083270a Another passing tests in FF. 
TBR=rnystrom@google.com

Change-Id: Id2d4adfd62f3f1c545f53056e0ab9b16062cf4c9
Reviewed-on: https://dart-review.googlesource.com/12307
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-09 02:43:59 +00:00
Terry Lucas 17b9d609f3 Updated status 
TBR=rnystrom@google.com

Change-Id: I9d6d7c6d1d78ad8dca3029e47687299de04fd5f3
Reviewed-on: https://dart-review.googlesource.com/12306
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-09 01:34:36 +00:00
Terry Lucas 16b6ba6a04 Splitout another set of group tests. 
TBR=rnystrom@google.com

Change-Id: I6d9aea59eac88de07b76b9597cf6ceac32350b55
Reviewed-on: https://dart-review.googlesource.com/12305
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-09 01:07:37 +00:00
Terry Lucas a15c9c2d89 Need to remove test group as part of split. 
TBR=rnystrom@google.com

Change-Id: Ie1b03e9472048162f2f1c8b3f64976c3c8675bf2
Reviewed-on: https://dart-review.googlesource.com/12304
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-10-08 23:49:18 +00:00
Terry Lucas 61e6389f8a Migrated Block 202 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Ibca90f46788ef86fdc57f746f48e8fd85b78aa5a
Reviewed-on: https://dart-review.googlesource.com/11361
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-08 23:19:49 +00:00
Terry Lucas 584bd34da7 Revert "Another polyfill type need in DDC SDK." 
This reverts commit f16977f194.

Change-Id: Ifa0d31c14a1ba0cdb3ababa95e883b46e10c9db4
Reviewed-on: https://dart-review.googlesource.com/12302
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-07 16:38:36 +00:00
Terry Lucas 869ee11c1d jsshell works too 
TBR=rnystrom@google.com

Change-Id: Ie921b295ef91bbc39bbf9352dbd1e94e0df835c6
Reviewed-on: https://dart-review.googlesource.com/12301
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-07 16:16:46 +00:00
Terry Lucas f16977f194 Another polyfill type need in DDC SDK. 
TBR=rnystrom@google.com

Change-Id: Ibd9ae8f59742f8fcf627bd14b7053e9fb117f1b6
Reviewed-on: https://dart-review.googlesource.com/12300
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-07 16:06:39 +00:00
Terry Lucas 960fff771d Migrated Block 203 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I1f2769da1511570fa55e883a2997b8ceb4932217
Reviewed-on: https://dart-review.googlesource.com/11362
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-07 15:34:17 +00:00
Ben Konyi 24ee7dab3c Migrated test block 35 to Dart 2.0. 
No changes made to tests.

Bug:
Change-Id: I98d755d0c8005fd9cf0770966927b57a5fcc25de
Reviewed-on: https://dart-review.googlesource.com/11620
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-06 23:56:03 +00:00
Ben Konyi e2f92be5ae Migrated test block 34 to Dart 2.0. 
Bug:
Change-Id: Ib2e0effabc354b5864f59b0de6611381d7dfd0df
Reviewed-on: https://dart-review.googlesource.com/11250
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-10-06 22:52:56 +00:00
William Hesse 64dd9dca79 Remove status lines for browser element_types tests from lib_2.status 
Browser tests can only be run with a compiler, so they belong
in lib_2_dart2js.status or lib_2_dartdevc.status

TBR=terry@google.com

Bug:
Change-Id: If3c5c0dc3e4e2180771d2ac9e4deed063b14194b
Reviewed-on: https://dart-review.googlesource.com/11722
Reviewed-by: William Hesse <whesse@google.com>
 2017-10-05 23:41:10 +00:00
William Hesse 353d0505ca Update status for lib_2/html/client_rect_test on dartdevc macos 
BUG=dartbug.com/31019
TBR=bkonyi@google.com

Change-Id: I7902cb8a370259c13ef74ef1c3d13b2cd1ecfea4
Reviewed-on: https://dart-review.googlesource.com/11721
Reviewed-by: William Hesse <whesse@google.com>
 2017-10-05 23:16:44 +00:00
William Hesse b007f955e4 Update status for new lib_2/html/element_types tests on browsers 
BUG=dartbug.com/29922
TBR=terry@google.com

Change-Id: Ib821ffc547e5646ed6ab9a9fa3768b9987421ca2
Reviewed-on: https://dart-review.googlesource.com/11720
Reviewed-by: William Hesse <whesse@google.com>
 2017-10-05 22:04:35 +00:00
Ben Konyi 7ea539a4c5 Migrated test block 190 to Dart 2.0. 
Migrated multiple tests from unittest->test, fixed small strong mode
issue in cross_frame_test.

Bug:
Change-Id: I1c504ab4ac45e487ff3d3d156416e579978adc20
Reviewed-on: https://dart-review.googlesource.com/4820
Reviewed-by: Terry Lucas <terry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-05 22:00:26 +00:00
Ben Konyi d932b15c0d Migrated test block 33 to Dart 2.0. 
Bug:
Change-Id: Ifb1626e45868c1bfc626edd83c7d9db5680764ed
Reviewed-on: https://dart-review.googlesource.com/11246
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-10-05 21:04:03 +00:00
Ben Konyi 992d060da6 Migrated test block 31 to Dart 2.0. 
Minor changes for strong-mode.

Bug:
Change-Id: Ia9387a4d7976156bb592515bb848f7be45699478
Reviewed-on: https://dart-review.googlesource.com/11021
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-05 19:34:33 +00:00
Terry Lucas 949fda879a Restored keygen element test, not in chrome but other browsers support. 
In addition, split out all the group tests to individual ones - unable to detect group failures in DDC.

TBR=bkonyi@google.com

Change-Id: I80b4a146e9bea3fb959d56ec3123667bfec122bd
Reviewed-on: https://dart-review.googlesource.com/11365
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-05 19:15:35 +00:00
Terry Lucas aeb7995355 Migrated Block 201 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Iad6df128725ffc81bbf352b02efc0412aa83272f
Reviewed-on: https://dart-review.googlesource.com/11360
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 18:01:10 +00:00
Jens Johansen 89644d89d2 [kernel] Add check to constant evaluator; pass script on error more often. 
Change-Id: I655121953c7be2e6c3173a3c186339d31a9be7bc
Reviewed-on: https://dart-review.googlesource.com/11500
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-10-05 13:47:20 +00:00
Jens Johansen 5fff3689d6 [kernel] Report error instead of crashing in constant evaluator. 
Change-Id: I2c116cdc6add54194d0641631b3603313603c89e
Reviewed-on: https://dart-review.googlesource.com/11442
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-10-05 12:13:03 +00:00
Terry Lucas 0beb87c853 Migrated Block 197 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Ic5ab3a1a5f300cc6df757ea03119595eac9dafc2
Reviewed-on: https://dart-review.googlesource.com/11340
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 10:46:21 +00:00
Terry Lucas e0794e5de0 Tests can still fail in Firefox and Safari 
TBR=bkonyi@google.com

Change-Id: I952e616db759c2452edd6605512b5676053b84ea
Reviewed-on: https://dart-review.googlesource.com/11364
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-05 10:24:48 +00:00
Jakob Roland Andersen f7a794201e Update status files. 
Removed html/ entries for kernel, since there's a html/* at the top.

Sorted newly added entries in lib_2_dartdevc.status, and added issue
number for webgl_extensions_test.

Bug:
Change-Id: I5bee92e992cd420e9d4b2c0629e2b75b6b22715e
Reviewed-on: https://dart-review.googlesource.com/11441
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
 2017-10-05 10:06:42 +00:00
Terry Lucas 90ca555942 Tests passes in Chrome 
R=bkonyi@google.com

Change-Id: I48c3c2203e0000874e3af9214ecd6e2350753193
Reviewed-on: https://dart-review.googlesource.com/11363
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-05 09:08:05 +00:00
Terry Lucas c886f96a8a Migrated Block 198 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I2280e12ba6d01a40df735083820c0ba96874ded5
Reviewed-on: https://dart-review.googlesource.com/11341
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 08:41:08 +00:00
Jakob Roland Andersen 93c91658cd tests/lib_2/html/websql_test is flaky 
Bug:
Change-Id: I6cc453a084f13415109a9f1210a5f4bcf25cc14c
Reviewed-on: https://dart-review.googlesource.com/11420
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-10-05 08:15:48 +00:00
Jakob Roland Andersen 42e28ca782 Migrated test batch 213 to Dart 2.0. 
Bug:
Change-Id: I31f519c18ab62cc0aef969f60116ed518bcb77e3
Reviewed-on: https://dart-review.googlesource.com/11061
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-05 07:56:30 +00:00
Terry Lucas 76c94d4d52 Update status file, test is expected to fail. 
TBR=bkonyi@google.com

Change-Id: I1082ade4f9a7841ceac1d5bfc58f11106c4aef91
Reviewed-on: https://dart-review.googlesource.com/11348
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-05 06:58:22 +00:00
Terry Lucas bd588dda54 Migrated Block 196 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I1c59698b9cb2d5fd7aac4dec4ddff3cf1a851478
Reviewed-on: https://dart-review.googlesource.com/8742
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 06:33:42 +00:00
Terry Lucas bbbb548e0a Migrated Block 195 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Ic5622d23d3159016625cfc17785f140ba9df409e
Reviewed-on: https://dart-review.googlesource.com/8739
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 06:08:10 +00:00
Jakob Roland Andersen a46ee1294a Migrated test batch 212 to Dart 2.0. 
Bug:
Change-Id: I2a062b9c1c2889355cc85884243bac580f3dce09
Reviewed-on: https://dart-review.googlesource.com/10480
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-05 05:16:20 +00:00
Terry Lucas 7f09d591fd Fix failure in analyzer w/o strong mode. 
TBR=bkonyi@google.com

Change-Id: I6b6faf3117a605793c056c02e1db7dd407f841fe
Reviewed-on: https://dart-review.googlesource.com/11346
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-10-05 04:55:05 +00:00
Terry Lucas 7f137ca921 Migrated Block 194 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I4e77f837a26d37e2d8f650c941f72454e6536b8d
Reviewed-on: https://dart-review.googlesource.com/8737
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 04:19:10 +00:00
Dan Rubel efeaa0eab3 Class header recovery 
This updates the fasta parser to handle out of order clauses
in the class header similar to analyzer.

Also:
* Fix parseTopLevelDeclaration in parser test proxy
* Fix parseStuff to correctly update token stream
* Extract skipUnexpectedTokenOpt
Change-Id: Ic20c0ab1355e866aa241c591ceeada390890c46a
Reviewed-on: https://dart-review.googlesource.com/9880
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-10-04 21:33:09 +00:00
Jakob Roland Andersen 0955c0ca9e Migrated test batch 211 to Dart 2.0. 
Bug:
Change-Id: Iee8198332fd94ef708eab1aa34867c5d68054c6a
Reviewed-on: https://dart-review.googlesource.com/10420
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-04 21:27:40 +00:00
Jakob Roland Andersen 7091266045 Migrated test batch 207 to Dart 2.0. 
Bug:
Change-Id: Ia0bfee80bf788a6eda83813fc986182a0d56a648
Reviewed-on: https://dart-review.googlesource.com/9980
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-04 20:14:19 +00:00
Jennifer Messerly 3a79c35f3c optimize maps/sets in DDC, fixes #29865 
- string/int keys use identity maps
- construct the correct type rather than relying on factory constructors when possible
- checks if key has identity semantics and use that when possible
- avoid helper calls/casts/etc in implementations
- use native ES6 Map/Set key order tracking
- optimized constructor for map literals
- fixes #30466, const maps are now canonicalized correctly

Change-Id: Id44acf3d9bf8cb153a4755aa28df08fe91bfc633
Reviewed-on: https://dart-review.googlesource.com/8167
Reviewed-by: Vijay Menon <vsm@google.com>
 2017-10-04 19:04:27 +00:00
Ben Konyi 5ea40df129 Updated status files to fix some dart2js bots. 
Bug:
Change-Id: Ifc3127afe5706bfd20e2107f582f67f38bc79365
Reviewed-on: https://dart-review.googlesource.com/11022
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-04 16:53:47 +00:00
William Hesse 414ec0aab8 Update lib_2 status file with new failures, merge identical sections. 
Alphabetize lines in sections

Bug:
Change-Id: I93af1111eb2816f37a369fc1102d21ce99185393
Reviewed-on: https://dart-review.googlesource.com/10961
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-10-04 15:33:42 +00:00
Régis Crelier a140d97d3f [gardening] Attempt to reduce redness for dart2js. 
Change-Id: If9ecd5dbbfae0bc2990fe062b8389bd9c00d67cc
Reviewed-on: https://dart-review.googlesource.com/10822
Reviewed-by: Régis Crelier <regis@google.com>
 2017-10-04 01:19:27 +00:00
Ben Konyi 83cc4dc365 Added back HTML related unittest code to a test modified in block 191. 
Bug:
Change-Id: Idb5b98c6af2128aac38e8effe88dbf4cf724c0f5
Reviewed-on: https://dart-review.googlesource.com/10800
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-03 22:33:52 +00:00
Ben Konyi b4d5cbda31 Migrated test block 191 to Dart 2.0. 
WIP.

Fixed status file migration issues for html and isolate directories.

Bug:
Change-Id: Id84c7ee89a7eb283d3202f3018d008cede0fda56
Reviewed-on: https://dart-review.googlesource.com/4920
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-10-03 21:54:44 +00:00
Jakob Roland Andersen 7f34184508 Migrated test batch 210 to Dart 2.0. 
Bug:
Change-Id: I8552149b85676cba497d78a9f6e3861257b746bc
Reviewed-on: https://dart-review.googlesource.com/10361
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-03 14:39:09 +00:00