1ffd31fcde
Fix assert in dart:math/Rectangle.
...
Didn't pass NaN down the correct path, and failed an assertion.
Added tests.
BUG= http://dartbug.com/17734
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//228533002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34822 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 13:12:21 +00:00
8cdf6bde8e
Revert "Add support for closure calls through getters."
...
This reverts commit r34818.
Review URL: https://codereview.chromium.org//228023004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34820 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 13:06:15 +00:00
6c9c0642a0
Add support for closure calls through getters.
...
Support reflect(o).invoke(#bar) where bar is a getter.
library.getField(#foo) where `foo` is a method.
BUG= http://dartbug.com/15138
R=karlklose@google.com
Committed: https://code.google.com/p/dart/source/detail?r=34555
Reverted: https://code.google.com/p/dart/source/detail?r=34556
Committed: https://code.google.com/p/dart/source/detail?r=34779
Reverted: https://code.google.com/p/dart/source/detail?r=34782
Review URL: https://codereview.chromium.org//195793013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34818 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 11:27:00 +00:00
3f6af0d71a
Fix for 15979- class aliases now have missing concrete members warnings generated on them.
...
This CL also changes the ErrorVerifier.visitClassTypeAlias() method to more closely resemble ErrorVerifier.visitClassDeclaration(), a change is made to tests/lib/mirrors/abstract_class_test.dart, and a bug issue is fixed in TestTypeProvider.
Is there a better way to indicate that there is a warning on a line in a test file?
R=scheglov@google.com
Review URL: https://codereview.chromium.org//224963016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34802 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-07 23:30:05 +00:00
b7fefddf34
Revert "Add support for closure calls through getters."
...
This reverts commit r34779.
Review URL: https://codereview.chromium.org//227203007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34782 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-07 15:58:49 +00:00
569e0f50ed
Add support for closure calls through getters.
...
Support reflect(o).invoke(#bar) where bar is a getter.
library.getField(#foo) where `foo` is a method.
BUG= http://dartbug.com/15138
R=karlklose@google.com
Committed: https://code.google.com/p/dart/source/detail?r=34555
Reverted: https://code.google.com/p/dart/source/detail?r=34556
Review URL: https://codereview.chromium.org//195793013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34779 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-07 15:02:01 +00:00
7aad450550
dart:convert: support indented output w/ JsonEncoder
...
BUG= https://code.google.com/p/dart/issues/detail?id=7846
R=lrn@google.com
Review URL: https://codereview.chromium.org//224093007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34758 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-05 20:09:21 +00:00
47a1edad2b
Move mirrors-test from dart2js_extra to lib/mirrors.
...
R=ahe@google.com
Review URL: https://codereview.chromium.org//223673007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34728 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-04 09:48:31 +00:00
6d56854a9a
Add optimization for pow(base, 0.5) to the other architectures as well.
...
R=zra@google.com
Review URL: https://codereview.chromium.org//220723017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34717 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-03 19:44:18 +00:00
6e3128596c
lib/convert: removed unused import, removed redundant test
...
Re-enabled checks in existing test
R=ricow@google.com
Review URL: https://codereview.chromium.org//223053004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34703 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-03 13:41:55 +00:00
9150d1ce0c
Revert "Load deferred chunks in the right order."
...
This reverts commit 34698.
Review URL: https://codereview.chromium.org//223373004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34702 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-03 12:47:20 +00:00
22d8c97cd2
Load deferred chunks in the right order.
...
A chunk can depend on classes in shared chunks. Therefore sort they are
sorted, and loaded sequentially.
BUG= dartbug.com/17890
R=floitsch@google.com
Review URL: https://codereview.chromium.org//221663005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34698 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-03 12:15:18 +00:00
0d8f355788
Improve the mirror support for deferred loading by registering elements only included by mirror-usage seperately.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//220203004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34685 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-03 08:01:17 +00:00
2fe51715e5
Begins work on ARM64, first assembler test.
...
Most new code is in constants_arm64.h and
{assembler,disassembler,simulator}_arm64.{h,cc}
The rest of the CL just #def's out tests, modifies status files,
and adds UNIMPLEMENTED functions, etc.
R=regis@google.com
Review URL: https://codereview.chromium.org//221133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34654 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-02 17:39:32 +00:00
0726458e52
tests: import unittest via package: url
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//218283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34602 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 16:12:39 +00:00
4cf0157e5e
Allow getField of methods.
...
BUG= http://dartbug.com/13002
R=karlklose@google.com
Review URL: https://codereview.chromium.org//217963002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34598 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 14:04:49 +00:00
5952d7a067
Upgrading tests with unittest deprecations
...
R=ricow@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org//218273002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34569 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-31 18:33:18 +00:00
ff402648a2
Revert "Add support for closure calls through getters."
...
This reverts commit r4555.
Review URL: https://codereview.chromium.org//219493003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34556 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-31 15:21:27 +00:00
86303df642
Add support for closure calls through getters.
...
Support reflect(o).invoke(#bar) where bar is a getter.
library.getField(#foo) where `foo` is a method.
BUG= http://dartbug.com/15138
R=karlklose@google.com
Review URL: https://codereview.chromium.org//195793013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34555 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-31 14:22:42 +00:00
f0626388f5
VM: Evaluate metadata on a class in the scope of its library not the scope of the class.
...
BUG=http://dartbug.com/17795
R=gbracha@google.com , hausner@google.com
Review URL: https://codereview.chromium.org//217543004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34537 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 22:38:32 +00:00
264d172ab0
lib.status: de-duped JSON serialization in Dart2Dart + minified
...
R=karlklose@google.com
Review URL: https://codereview.chromium.org//215063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34508 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 16:52:31 +00:00
9c105f7c9c
Handle creating ParameterMirrors for the parameters of forwarding constructors.
...
BUG=http://dartbug.com/17823
R=hausner@google.com , regis@google.com
Review URL: https://codereview.chromium.org//212883009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34494 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 01:22:03 +00:00
09f4894a9c
Fix mirrors test expectation
...
Review URL: https://codereview.chromium.org//215633002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34484 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 22:11:32 +00:00
36d8c9a39c
Fix bug in divpd x64.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//213193009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34475 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 16:43:40 +00:00
56d8742555
Fix test expectations for convert/json2_test.
...
R=sigurdm@google.com
Review URL: https://codereview.chromium.org//212653009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34465 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 08:11:34 +00:00
a0ac63bd57
Fix broken build, by disabling test; investigate failure leisurely.
...
Review URL: https://codereview.chromium.org//212623007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34459 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 23:28:47 +00:00
441bd85c9f
Fix JSON tests, re-enable in all cases - 2nd try
...
R=lrn@google.com
Review URL: https://codereview.chromium.org//212813006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34457 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 23:11:40 +00:00
789cb16956
Revert "Fix JSON tests, re-enable in all cases"
...
TBR=kevmoo@google.com
BUG=
Review URL: https://codereview.chromium.org//212643007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34441 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 18:16:06 +00:00
38b0d362b5
Fix JSON tests, re-enable in all cases
...
R=lrn@google.com
Review URL: https://codereview.chromium.org//208273003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34440 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 17:43:23 +00:00
6e1d5c293a
Update expectations to mark lib/mirrors/immutable_collection_test as failing.
...
BUG= http://dartbug.com/17823
Review URL: https://codereview.chromium.org//212543004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34433 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 15:41:40 +00:00
9da7487c36
Revert accidental parts of "Speed up toLowerCase, by manually inlining the upper-case part."
...
BUG=
Review URL: https://codereview.chromium.org//212753003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34425 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 12:32:58 +00:00
a9f357b4b6
Speed up toLowerCase, by manually inlining the upper-case part.
...
Some benchmarks show up to 25% faster toLowerCase.
BUG=
R=lrn@google.com
Review URL: https://codereview.chromium.org//212163005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34423 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 12:19:55 +00:00
78ab60a0de
Implement MethodMirror.location in the VM.
...
R=gbracha@google.com , hausner@google.com
Review URL: https://codereview.chromium.org//211243009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34400 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 00:44:54 +00:00
877658b6ec
Fix status file.
...
BUG=
Review URL: https://codereview.chromium.org//206613006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34395 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-25 22:50:38 +00:00
38e2e4a18c
Mark deferred_mirrors_metadata_test as crashing with dart2js.
...
BUG=https://code.google.com/p/dart/issues/detail?id=17732
Review URL: https://codereview.chromium.org//199793018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34304 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 13:35:19 +00:00
dc091c476c
Make zone variables accept any value as key.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//196413005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34248 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 13:30:19 +00:00
7c9b135629
Remove cancel and make crash exit with code 253.
...
BUG=http://dartbug.com/17557
R=karlklose@google.com
Review URL: https://codereview.chromium.org//206193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34238 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 09:44:42 +00:00
30ac6d116d
Introduces the new syntax for deferred loading
...
import "lib.dart" deferred as lib;
And then injecting a function of the name "loadLibrary" into the
namespace of the import prefix.
This FunctionElement is a triggers the builder to emit special code that causes _loadLibraryWrapper in js_helper to be called.
Dart2dart will not crash on deferred loading, but calls to
loadLibrary will become calls to a (not-existing) top-level function
loadLibrary.
The old syntax (using metadata) is still working
For now keeping the language tests with the old syntax in addition to
the updated tests.
R=floitsch@google.com , johnniwinther@google.com
Review URL: https://codereview.chromium.org//201613006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34230 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 07:50:08 +00:00
623d3137a3
Use real "package:" imports in pub's plugin-loading code.
...
This works by providing the plugin-loading code to pub's barback instance as
assets for a pseudo-package named "$pub".
BUG=17506
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//198053009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34056 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 19:55:32 +00:00
62c79adbd0
Add entries for ContentShellOnAndroid runtime to status files.
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//203373003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33807 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 14:47:56 +00:00
f8c59de4d6
Clean up ClosureMirror.invoke(#call, ...).
...
R=asiva@google.com , gbracha@google.com
Review URL: https://codereview.chromium.org//196513004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33790 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 23:43:32 +00:00
1cfd291f65
Load the transformer isolate code from pub's asset directory.
...
This renames "resources" to "asset" in the SDK, to better match the suggested
package layout guidelines.
BUG=17506
R=dgrove@google.com , rnystrom@google.com
Review URL: https://codereview.chromium.org//200323008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33786 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 23:20:16 +00:00
34faaf0161
Change expectations for passing tests.
...
R=johnniwhinter@google.com
BUG= http://dartbug.com/17264
Review URL: https://codereview.chromium.org//201713003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33746 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 13:58:27 +00:00
f744481c8e
Mark various tests as slow for FYI
...
BUG=
R=karlklose@google.com
Review URL: https://codereview.chromium.org//199893004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33743 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 13:26:25 +00:00
7d19bc6001
Skip deferred tests on d8 on Windows.
...
BUG=
R=sgjesse@google.com , sigurdm@google.com
Review URL: https://codereview.chromium.org//198853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33691 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 10:39:51 +00:00
8c0e1a602e
Fix LibraryMirror.invoke to call through the contents of an implicit getter.
...
BUG=http://dartbug.com/17452
R=asiva@google.com , gbracha@google.com
Review URL: https://codereview.chromium.org//196953007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33682 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 01:14:06 +00:00
10ecef7968
Remove ObjectMirror.[].
...
R=ahe@google.com , gbracha@google.com
Review URL: https://codereview.chromium.org//165773002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33543 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-11 18:21:13 +00:00
57dd1321d1
Reapply "Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors."
...
Regenerate snapshot test due to change in the size of Namespace. Relate the types source mirror libraries dependencies to the runtime library dependencies.
BUG=http://dartbug.com/10360
Review URL: https://codereview.chromium.org//189843003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33441 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 19:00:20 +00:00
62ad4b82ce
Revert "Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors."
...
Review URL: https://codereview.chromium.org//189293002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33402 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 22:45:29 +00:00
2d0e54a94d
Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors.
...
BUG=http://dartbug.com/10360
R=gbracha@google.com , hausner@google.com
Review URL: https://codereview.chromium.org//154733003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33397 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 22:02:29 +00:00
lrn@google.com