81d0f25293
Reapply "Implement an LRU cache in dart:_internal and use it for the getter/setter caches in the VM's mirrors." Reapply "Use mirror-free LRU test for dart2js"
...
BUG=http://dartbug.com/18445
R=asiva@google.com
Review URL: https://codereview.chromium.org//383903005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38167 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-11 18:59:06 +00:00
f825cc7389
Generate compile errors for illegal uses of const Symbol constructor.
...
BUG=dartbug.com/18755
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//387003003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38163 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-11 18:12:03 +00:00
167d5bbfdd
Revert "Don't use a float32list as storage for simd."
...
This reverts commit r38153.
Review URL: https://codereview.chromium.org//386943004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38157 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-11 13:09:11 +00:00
cf8ac68c0d
Make VM JSON parser parse doubles without doing substring.
...
R=fschneider@google.com
Review URL: https://codereview.chromium.org//385163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38155 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-11 12:14:23 +00:00
b723077e98
Don't use a float32list as storage for simd.
...
R=lrn@google.com
Review URL: https://codereview.chromium.org//278593003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38153 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-11 12:03:33 +00:00
7de52b638e
Don't consider controller.addError to be a zone-crossing.
...
BUG= http://dartbug.com/18776
R=lrn@google.com
Review URL: https://codereview.chromium.org//366813005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38120 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-10 13:51:03 +00:00
af20fc3b0a
Remove skip of
...
language/deferred_*
lib/mirrors/deferred_*
from status files for drt/dartium targets
R=hausner@google.com
Review URL: https://codereview.chromium.org//384463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38108 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-09 21:53:31 +00:00
0b6159778a
Mark convert/streamed_conversion_utf8_decode_test as slow on firefox
...
R=kasperl@google.com
Review URL: https://codereview.chromium.org//382443005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38082 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-09 11:55:11 +00:00
f346a00c0f
Revert r37059 and dependent r37589. This effectively reduced the size of the getter and setter caches, exposing http://dartbug.com/18284 in a C1 application.
...
Revert "Implement an LRU cache in dart:_internal and use it for the getter/setter caches in the VM's mirrors."
Revert "Use mirror-free LRU test for dart2js"
BUG=http://dartbug.com/19909
BUG=http://dartbug.com/18284
BUG=http://dartbug.com/18445
R=asiva@google.com
Review URL: https://codereview.chromium.org//375043003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38076 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-09 00:18:15 +00:00
ec903e2d19
Updates status files for content shell on Android.
...
Review URL: https://codereview.chromium.org//377583002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38026 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-07 15:59:22 +00:00
419bf8df29
Add periodic browser restart to ContentShellOnAndroid test runtime. Update test status for ContentShellOnAndroid.
...
BUG=dartbug.com/19127
R=kustermann@google.com
Review URL: https://codereview.chromium.org//363323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37983 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 12:59:59 +00:00
2e8bdd4128
Revert "Emit declarations for typedefs that are needed by reflection."
...
Does not work in csp-drt.
This reverts commit r37945.
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//363223003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37973 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 07:24:08 +00:00
13c67faf65
Emit declarations for typedefs that are needed by reflection.
...
Typedefs are encoded like closure classes, but without a call-method and a superclass.
For example, the typedef `typedef int Foo(String s);` is emitted as:
Foo: {'^': ':15'},
where `15` is the index into `init.metadata` at which the function type is emitted.
BUG= http://dartbug.com/16939
R=herhut@google.com , floitsch@google.com
Committed: https://code.google.com/p/dart/source/detail?r=37814
Reverted in https://code.google.com/p/dart/source/detail?r=37848
Committed: https://code.google.com/p/dart/source/detail?r=37939
Reverted in https://code.google.com/p/dart/source/detail?r=37940
Review URL: https://codereview.chromium.org//360493002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37945 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 12:43:13 +00:00
d8649cf725
Revert "Emit declarations for typedefs that are needed by reflection."
...
This reverts commit r37939.
TBR=herhut@google.com
Review URL: https://codereview.chromium.org//362973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37940 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 11:04:54 +00:00
abc6e05815
Emit declarations for typedefs that are needed by reflection.
...
Typedefs are encoded like closure classes, but without a call-method and a superclass.
For example, the typedef `typedef int Foo(String s);` is emitted as:
Foo: {'^': ':15'},
where `15` is the index into `init.metadata` at which the function type is emitted.
BUG= http://dartbug.com/16939
R=floitsch@google.com
Committed: https://code.google.com/p/dart/source/detail?r=37814
Reverted in https://code.google.com/p/dart/source/detail?r=37848
Review URL: https://codereview.chromium.org//360493002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37939 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 10:51:01 +00:00
8c4d04d170
Adjust mirrors/regress_19731_test to avoid static warnings.
...
TBR=regis@google.com
Review URL: https://codereview.chromium.org//365713004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37904 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 20:32:37 +00:00
14fcffb2b6
Hide synthetic metadata field exposed in r35926.
...
Also remove Object::CreateInternalMetaData.
BUG=http://dartbug.com/19731
R=iposva@google.com , regis@google.com
Review URL: https://codereview.chromium.org//363473004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37900 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 20:09:09 +00:00
4e134fe26d
Skip the enumerating mirror tests on debug Dartium.
...
They are very on debug Dartium and will simply timeout and waste bot cycles.
Review URL: https://codereview.chromium.org//354583009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37899 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 19:50:30 +00:00
2fedabc080
Mark mirrors/mirrors_used_inheritance_test as RuntimeError except for dart2js.
...
BUG=
R=ricow@google.com , karlklose@google.com
Review URL: https://codereview.chromium.org//367673002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37874 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 13:36:32 +00:00
899c4aa3fb
Mark mirrors/mirrors_used_inheritance_test as Skip except for dart2js.
...
BUG=
TBR=karlklose@google.com
Review URL: https://codereview.chromium.org//365663002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37870 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 13:05:27 +00:00
9cb4631b9c
Take inheritance into account when computing the elements accessible by mirrors.
...
BUG= http://dartbug.com/19179
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//340783011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37868 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 12:42:51 +00:00
eaa2c4da9a
Revert "Add runtime_data.dart to the whitelist of files with unused members." and "Emit declarations for typedefs that are needed by reflection."
...
It does not work in checked mode.
This reverts commits 37814 and 37818.
R=johnniwinther@google.com
BUG=
Review URL: https://codereview.chromium.org//367613003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37848 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 07:40:42 +00:00
2b8981c436
Fix listeners being added to subscription after onListen was called.
...
BUG= http://dartbug.com/19722
R=floitsch@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//357283003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37847 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 07:14:19 +00:00
1502b1899d
Emit declarations for typedefs that are needed by reflection.
...
Typedefs are encoded like closure classes, but without a call-method and a superclass.
For example, the typedef `typedef int Foo(String s);` is emitted as:
Foo: {'^': ':15'},
where `15` is the index into `init.metadata` at which the function type is emitted.
BUG= http://dartbug.com/16939
R=floitsch@google.com
Review URL: https://codereview.chromium.org//360493002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37814 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-30 09:49:39 +00:00
f9b8b18ab8
Rewrite Zone implementation to avoid recursively looking up stuff in the parent chain.
...
Reuses as much as possible of the parent zone's implementation representation.
Increases performance of primitive tests of only async operations by ~10% (but with a lot of variability and a spurious regression).
R=floitsch@google.com
Review URL: https://codereview.chromium.org//331993005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37807 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-30 07:26:01 +00:00
b71b5adb62
Add Future.doWhile to dart:async.
...
This makes both Future.doWhile and Future.forEach interact more
intuitively with zones. It also explicitly allows the callback to
Future.forEach to return a non-Future value.
BUG=http://dartbug.com/19645 , http://dartbug.com/19646
RELNOTE=Add Future.doWhile and allow Future.forEach's callback to return a non-Future.
R=lrn@google.com
Review URL: https://codereview.chromium.org//356773005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37750 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-26 19:53:38 +00:00
80773c1452
Use mirror-free LRU test for dart2js
...
BUG=
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//338893006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37589 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 09:42:43 +00:00
3056f05f32
Add deferred_mirrors failures to test status.
...
BUG=dartbug.com/19449
R=vsm@google.com
Review URL: https://codereview.chromium.org//341473002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37387 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 08:27:01 +00:00
82771a3229
Suppress timing-out tests on android content_shell.
...
BUG=dartbug.com/19127
R=kustermann@google.com
Review URL: https://codereview.chromium.org//334883003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37362 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-16 16:16:06 +00:00
8a0207c763
Second try: fix dartium status file to exclude lib/mirrors/deferred tests
...
Review URL: https://codereview.chromium.org//330363002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37340 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-14 00:44:10 +00:00
e1f2c03aab
Skip deferred load tests on Dartium until loader is fixed.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//336883003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37336 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-13 23:47:49 +00:00
194ffff045
More fixes to test expectations on dart2js-chrome.
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//330863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37318 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-13 16:54:04 +00:00
da3b61d764
Add missing demangling to the VM's NoSuchMethodError. Ensure the VM's NoSuchMethorErrors for reflective invocation match those for non-reflective invocation.
...
Fix bug in VM demangling of setters.
Fix bug where test was not covering invocation on classes as intended.
BUG=http://dartbug.com/18042
R=asiva@google.com
Review URL: https://codereview.chromium.org//326263002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37294 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-12 22:53:00 +00:00
91f5940dbf
Handle metadata in the magic [^] property of class descriptions correctly.
...
BUG= http://dartbug.com/19173
R=karlklose@google.com
Review URL: https://codereview.chromium.org//328803002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37256 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-12 08:34:35 +00:00
ce490637b2
Censor dart:_blink and dart:builtin from the enumeration of libraries in the isolate and from import lists. Note we are not censoring dart:_internal.
...
For the moment, this doesn't seem to break any language invariants, but that may happen if
a) the censored libraries start producing instances, whose classes would claim to have no library
b) types from the censored libraries are used in type annotations in the privileged libraries that can import them, resulting in types other than dynamic that claim to belong to no library
R=iposva@google.com
Review URL: https://codereview.chromium.org//321293002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37238 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-11 17:58:17 +00:00
c68a75e963
Update test status for ContentShellOnAndroid
...
Skipped two more timing-out tests. Merged two issues, alphabetized a status file section.
BUG=dartbug.com/19127
R=ricow@google.com
Review URL: https://codereview.chromium.org//328673002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37165 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 07:23:22 +00:00
56e8555efd
Mark failing android content_shell tests in status files.
...
BUG=dartbug.com/19276 dartbug.com/19274
R=kustermann@google.com
Review URL: https://codereview.chromium.org//316363005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37079 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 13:37:19 +00:00
7f84fb2b7f
Implement an LRU cache in dart:_internal and use it for the getter/setter caches in the VM's mirrors.
...
BUG=http://dartbug.com/18445
R=iposva@google.com
Review URL: https://codereview.chromium.org//268783006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37059 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 00:45:01 +00:00
d9ed5e2d02
Stream_controller_test after it started using non-zero timers.
...
This makes dart2js/jsshell fail.
Review URL: https://codereview.chromium.org//309283003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36914 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-03 10:47:11 +00:00
f3dd052a54
Fix typo in _DoneStreamSubscription.asFuture.
...
Add usage to test.
Review URL: https://codereview.chromium.org//304353016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36865 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-02 11:15:34 +00:00
5cbd1e05e2
Update documentation for "close" and fix subscription returned by closed broadcast streams.
...
The close method on StreamConsumer, StreamSink and StreamController do not explain
the returned future or say when it is completed.
Listening on a closed broadcast stream should not throw, but just give a subscription that sends a done asap.
BUG= http://dartbug.com/19095
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//301193010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36862 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-02 11:03:24 +00:00
f72cd0c296
Remove suppression of lib/mirrors/delegate_test in csp mode
...
Review URL: https://codereview.chromium.org//303373002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36817 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-30 08:36:42 +00:00
3b5ff25469
Lay waste to ClosureMirror.findInContext.
...
BUG=http://dartbug.com/18741
R=gbracha@google.com , iposva@google.com
Review URL: https://codereview.chromium.org//276043003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36704 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 19:35:58 +00:00
5708ec2d9e
Allow delegate calls even though the target is not reflectable.
...
BUG= http://dartbug.com/15138
BUG= http://dartbug.com/17451
R=karlklose@google.com
Review URL: https://codereview.chromium.org//294293003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36621 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-26 08:56:44 +00:00
89c6fb429e
Fix status files for co19 tests, and for test running in jsshell.
...
Review URL: https://codereview.chromium.org//300433004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36552 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-23 09:34:13 +00:00
d14dc6c502
Fix crash when parsing metadata that refers to a static getter.
...
BUG=http://dartbug.com/18949
R=hausner@google.com
Review URL: https://codereview.chromium.org//286903020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36522 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-22 18:56:08 +00:00
95dfe7c083
Mark a lot of ie9 tests as skip instead of timeout or flaky timeout.
...
The majority of these are either not triaged or marked with a bug that is not actively being worked on.
Since we can only run _one_ instance of IE simultainiuosly on windows if we don't want flake this is really slowing us down.
R=blois@google.com
Review URL: https://codereview.chromium.org//296213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36517 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-22 17:33:31 +00:00
de280d96af
Make Stream.where, etc., be documented as inheriting broadcast state.
...
Very few changes were necessary because it was already the behavior in most
cases.
BUG= http://dartbug.com/18586
R=ajohnsen@google.com
Committed: https://code.google.com/p/dart/source/detail?r=36344
Review URL: https://codereview.chromium.org//295913003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36475 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-22 08:44:21 +00:00
b810f77e67
Change expectation for jsshell on lib/async/timer_isolate_test.
...
An uncaught error in an isolate does not cause the program to exit.
R=whesse@google.com
Review URL: https://codereview.chromium.org//296733002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36351 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-20 11:33:34 +00:00
55d24213f6
Revert "Make Stream.where, etc., be documented as inheriting broadcast state."
...
There were ... complications.
Review URL: https://codereview.chromium.org//299623003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36347 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-20 08:30:34 +00:00
rmacnak@google.com