lrn@google.com
33bcf9755c
Make Stream.where, etc., be documented as inheriting broadcast state.
...
Very few changes were necessary because it was already the behavior in most
cases.
BUG= http://dartbug.com/18586
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//295913003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36344 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-20 07:28:12 +00:00
zra@google.com
4a7e022d97
Adds intrinsics for arm64.
...
Also enables tests that no longer time-out.
R=regis@google.com
Review URL: https://codereview.chromium.org//285403004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36330 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-19 21:35:32 +00:00
brianwilkerson@google.com
e0a62bb44d
Fix for issue 14116
...
R=jwren@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//282063004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36282 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-17 02:23:25 +00:00
floitsch@google.com
9cf4d2df03
Work around warning in darttags.
...
R=ahe@google.com
Review URL: https://codereview.chromium.org//284203004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36225 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-15 15:46:04 +00:00
johnniwinther@google.com
3324b73210
Include internal library members when enqueuing everything.
...
BUG=http://dartbug.com/18569
R=floitsch@google.com
Review URL: https://codereview.chromium.org//286983004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36214 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-15 11:42:22 +00:00
efortuna@google.com
2a9588d03d
Reapply "Fix analyzer errors in html Dartium."
...
BUG=
R=leafp@google.com
Review URL: https://codereview.chromium.org//281383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36195 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-14 23:09:04 +00:00
efortuna@google.com
462ca6ea1e
"Reverting 36191"
...
BUG=
Review URL: https://codereview.chromium.org//288873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36193 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-14 22:23:07 +00:00
efortuna@google.com
78a040990d
Fix analyzer errors in html Dartium.
...
BUG=
R=leafp@google.com
Review URL: https://codereview.chromium.org//285123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36191 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-14 21:54:38 +00:00
zra@google.com
03f2f289b4
Adds Math Min/Max to arm64.
...
Also fixes bugs and enables tests.
R=regis@google.com
Review URL: https://codereview.chromium.org//284843004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36116 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-13 18:10:16 +00:00
sigurdm@google.com
21a9788738
When mirrors are used with deferred loading we now go through all
...
elements and query compiler.backend.isNeededForReflection for each of
them.
R=karlklose@google.com
Review URL: https://codereview.chromium.org//278733003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36092 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-13 08:29:14 +00:00
zra@google.com
eb11b8a7a0
Adds far-branches to arm64.
...
Also fixes bugs and enables tests.
R=regis@google.com
Review URL: https://codereview.chromium.org//283513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36051 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-12 18:43:08 +00:00
floitsch@google.com
5e176f17a8
Avoid prototype properties in JS-Object caches.
...
Make sure to create caches with Object.create.
BUG= http://dartbug.com/18754
R=kasperl@google.com
Review URL: https://codereview.chromium.org//271193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36037 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-12 15:50:07 +00:00
lrn@google.com
35466f1e8b
Fix typo in test.
...
Throwing the wrong exception - which was being overruled by a later
exception anyway.
Review URL: https://codereview.chromium.org//271273005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36022 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-12 10:18:37 +00:00
lrn@google.com
f4fc2fc632
Make errors from StreamController onCancel calls end up in the returned future.
...
This changes errors happening in an onCancel callback from being uncaught
async errors (captured by zone.runGuarded) to being put into the result
future every time.
It already happens if the onCancel returns a future containing an error,
but if onCancel throws itself, it was different. This makes onCancel
act the same whether it fails immediately or asynchronously.
It should not change the behavior of current working programs:
an uncaught error would likely terminate the program, and the returned
futures are not checked for errors.
After the change, the error will reach the future and become uncaught there
instead, still terminating the program in the same way.
R=ajohnsen@google.com , floitsch@google.com
Review URL: https://codereview.chromium.org//269283007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36021 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-12 09:48:31 +00:00
floitsch@google.com
a4908c7368
Assume a method can be torn off, if it's accessible through reflection.
...
BUG= http://dartbug.com/18673
R=herhut@google.com , johnniwinther@google.com
Review URL: https://codereview.chromium.org//273723003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35962 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-09 07:55:45 +00:00
rmacnak@google.com
f4f4713eb8
Put metadata fields in their owner class to maintain the class-field bidirectional relationship asserted Field::PrintJSON.
...
Extended metadata scope test based on suspicions regarding the ordering of adding type parameters metadata fields versus ordinary fields of a class.
BUG=http://dartbug.com/18652
R=iposva@google.com , regis@google.com
Review URL: https://codereview.chromium.org//269253005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35926 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-08 18:15:33 +00:00
paulberry@google.com
252f56f9ca
Don't generate errors when failing to follow const constructor redirections.
...
In two cases (circular redirections and redirecting to a non-const
constructor), the error has already been reported. The third case
(external factory constructor) is not an error condition.
Fixes test lib/_internal/compiler/samples/jsonify/jsonify.
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//273703003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35877 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-08 00:24:30 +00:00
scheglov@google.com
3b128404d9
Issue 17894. Scope of metadata on a class is the defining library, not the class.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=17894
Review URL: https://codereview.chromium.org//277523002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35861 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-07 19:46:20 +00:00
paulberry@google.com
099f24cf0e
In constant evaluation, properly handle redirecting factory constructors.
...
In order to unit test that this change doesn't regress the handling of
"const Symbol(...)", it was necessary to expand TestTypeProvider's
Symbol class to include the Symbol constructor.
Note: with this fix, analyzer detected a previously unknown flaw in
tests/language/switch_case_test.dart: class D didn't implement a
getter for x. Test updated accordingly.
This change breaks test lib/_internal/compiler/samples/jsonify/jsonify
by changing analyzer's handling of bool.fromEnvironment(). I plan to
address this in a future changelist.
BUG=dartbug.com/17209
R=brianwilkerson@google.com , floitsch@google.com
Review URL: https://codereview.chromium.org//261403004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35853 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-07 16:27:03 +00:00
asiva@google.com
aff765fc98
Update status file to account for Issue 16564 being fixed.
...
R=keertip@google.com
Review URL: https://codereview.chromium.org//264923013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35821 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-06 19:28:50 +00:00
johnmccutchan@google.com
850074a704
Refactor 'dart:profiler' UserTag API
...
- Each isolate starts off with a 'Default' UserTag set.
- A null tag cannot be set.
- Calls to clearCurrentTag() should be replaced with a call to UserTag.defaultTag.makeCurrent().
- makeCurrent returns the previously current tag.
This allows for the following pattern to work:
callee() {
var old = calleeTag.makeCurrent();
...
old.makeCurrent();
}
caller() {
var old = callerTag.makeCurrent();
...
callee();
assert(getCurrentTag() == callerTag);
...
old.makeCurrent();
}
R=iposva@google.com , zra@google.com
Review URL: https://codereview.chromium.org//266913010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35810 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-06 17:07:26 +00:00
rmacnak@google.com
f0d289599c
VM: Fix TypedefMirror.isPrivate and TypeVariableMirror.isPrivate.
...
BUG=http://dartbug.com/18271
R=asiva@google.com , gbracha@google.com
Review URL: https://codereview.chromium.org//240443007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35758 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-05 19:45:58 +00:00
scheglov@google.com
593096bef2
New analyzer snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//263913003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35704 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-02 20:06:26 +00:00
scheglov@google.com
072c7955ad
Status tweak for make DDA green.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//268543012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35702 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-02 19:09:55 +00:00
leafp@google.com
d1f0594840
Initial overloading implementation in _blink
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//260893007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35662 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-01 22:03:06 +00:00
ricow@google.com
342d4e79da
Update status file entries for mobile safari simulator.
...
Only a few tests are failing that are not failing on the normal safari.
I have marked those with issue 18573
Review URL: https://codereview.chromium.org//268593004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35634 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-01 15:40:33 +00:00
ricow@google.com
67f008486b
Mark lib/mirrors/intercepted_object_test as failing on dart2js checked
...
This is giving a runtime error, see
https://code.google.com/p/dart/issues/detail?id=18569
Review URL: https://codereview.chromium.org//269543004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35613 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-01 05:51:32 +00:00
floitsch@google.com
bcb3c3e8ba
Don't hide interceptors in mirrors.
...
The special code for mirrors was brittle and was the reason for several bugs.
BUG= http://dartbug.com/18076
BUG= http://dartbug.com/15405
BUG= http://dartbug.com/14025
BUG= http://dartbug.com/13842
BUG= http://dartbug.com/16804
BUG= http://dartbug.com/15555
R=karlklose@google.com
Review URL: https://codereview.chromium.org//236313012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35586 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-30 18:21:11 +00:00
jwren@google.com
2ceb165494
Fix for 18468- T << Type where T is a type parameter and Type is the type Type from dart.core
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//252693006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35501 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 22:10:11 +00:00
rmacnak@google.com
f848586f7f
Prevent unbounded growth of the getField/setField closure caches.
...
BUG=http://dartbug.com/16539
R=iposva@google.com
Review URL: https://codereview.chromium.org//241703002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35433 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 17:47:15 +00:00
sra@google.com
93ef680621
Mark Safari lib/mirrors/to_string_test as working
...
TBR=floitsch@google.com
Review URL: https://codereview.chromium.org//248873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35304 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 07:03:00 +00:00
rmacnak@google.com
a8eacc8abf
Blacklist SystemEncoding.decode/encode.
...
Review URL: https://codereview.chromium.org//248133006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35293 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 00:58:47 +00:00
rmacnak@google.com
7ba8ca5753
Reapply "Mark private functions in dart:* that are native or constructors as not visible (omitted from stack traces and ineligible for reflective enumeration or invocation)."
...
With fix for uninitialized is_dart_scheme_ when read from snapshot.
BUG=http://dartbug.com/15274
R=iposva@google.com
Review URL: https://codereview.chromium.org//247683002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35289 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-23 00:05:08 +00:00
jwren@google.com
4f4507b9ef
Fix for 14221/ 15553/ 16673- X isSubtypeOf E now returns false when X is some type and E is a type parameter. This fixes a few issues, but also breaks some assertions (language tests that now have valid warnings from the analyzer).
...
Additional work will need to be done to fix the language tests, and to investigate the case of X isSubtypeOf E where X is of type Type.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//247313004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35281 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 20:07:54 +00:00
ricow@google.com
00c28d1198
Mark lib/mirrors/invoke_natives_fuzz_test as failing on command line javascript engines
...
Review URL: https://codereview.chromium.org//247013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35254 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 11:16:57 +00:00
ricow@google.com
6beeb38f35
Remove suppression for lib/mirrors/invoke_natives_fuzz_test on dart2js
...
This is passing on all configurations as far as I can see
Also, I don't really see why the second of the removed headings is needed, since it seems to be containted in the first
This may be due to commit - status file update - revert.
Review URL: https://codereview.chromium.org//246253004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35247 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 07:01:08 +00:00
rmacnak@google.com
7840906011
Revert "Mark private functions in dart:* that are native or constructors as not visible (omitted from stack traces and ineligible for reflective enumeration or invocation)."
...
Review URL: https://codereview.chromium.org//246173002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35238 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 00:08:52 +00:00
rmacnak@google.com
69d82c334b
Mark private functions in dart:* that are native or constructors as not visible (omitted from stack traces and ineligible for reflective enumeration or invocation).
...
Ensure invocation_fuzz_test doesn't exit prematurely.
Also visit instance methods defined in superclasses.
Complete blacklist so invocation_fuzz_test passes on the VM.
B=http://dartbug.com/15274
R=iposva@google.com
Review URL: https://codereview.chromium.org//241993004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35234 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-21 23:24:17 +00:00
rmacnak@google.com
fe5088a04e
Update mirrors/invoke_natives_fuzz_test status.
...
Review URL: https://codereview.chromium.org//243193003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35172 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-18 16:54:01 +00:00
rmacnak@google.com
cf10eda0f1
Syntax error in test status heading.
...
Review URL: https://codereview.chromium.org//242253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35159 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-17 23:28:23 +00:00
rmacnak@google.com
cd09aca632
Mark invoke_natives_fuzz_test as passing in Dartium, FF, Safari, Chrome, IE.
...
Review URL: https://codereview.chromium.org//242213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35158 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-17 23:22:22 +00:00
rmacnak@google.com
e321ed387f
Add fuzz test for reflective invocation.
...
B=http://dartbug.com/15274
R=gbracha@google.com
Review URL: https://codereview.chromium.org//241483003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35155 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-17 21:48:23 +00:00
sra@google.com
a6a11ab53c
Update status for two tests fixed by r35000
...
TBR=floitsch@google.com
Review URL: https://codereview.chromium.org//229103003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35003 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-12 00:53:27 +00:00
jwren@google.com
b2be15f8ed
Fix for first half of 16078- clarifications on the StaticWarningCode.FUNCTION_WITHOUT_CALL warning
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//231473002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35002 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-12 00:35:36 +00:00
lrn@google.com
2ab1f1238f
Trying to make preamble for d8.
...
Preamble handles timers and task queue.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//201873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34967 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-11 10:29:06 +00:00
johnmccutchan@google.com
8f0056371d
Initial UserTag and dart:profiler library
...
R=asiva@google.com , srdjan@google.com
Review URL: https://codereview.chromium.org//230863005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34949 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-10 22:32:45 +00:00
sigurdm@google.com
dc92146b57
Load deferred chunks in the right order.
...
A chunk can depend on classes in shared chunks. Therefore sort they are
sorted, and loaded sequentially.
BUG= dartbug.com/17890
R=floitsch@google.com
Committed: https://code.google.com/p/dart/source/detail?r=34698
Reverted: r34702
Review URL: https://codereview.chromium.org//221663005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34915 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-10 08:48:11 +00:00
kevmoo@google.com
4283c3e41e
using unittest via package import
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org//231413003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34890 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 19:42:11 +00:00
lrn@google.com
dcbccb5d5d
Fix dart2js custom hashmap/set not using the custom method for string.
...
BUG= http://dartbug.com/18109
R=floitsch@google.com
Review URL: https://codereview.chromium.org//230443002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34870 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 11:02:09 +00:00
floitsch@google.com
07b6c4739e
Add support for closure calls through getters.
...
Support reflect(o).invoke(#bar) where bar is a getter.
library.getField(#foo) where `foo` is a method.
BUG= http://dartbug.com/15138
R=karlklose@google.com
Committed: https://code.google.com/p/dart/source/detail?r=34555
Reverted: https://code.google.com/p/dart/source/detail?r=34556
Committed: https://code.google.com/p/dart/source/detail?r=34779
Reverted: https://code.google.com/p/dart/source/detail?r=34782
Committed: https://code.google.com/p/dart/source/detail?r=34818
Reverted: https://code.google.com/p/dart/source/detail?r=34820
Review URL: https://codereview.chromium.org//195793013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34823 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 13:27:37 +00:00