Commit Graph

1365 Commits

Author SHA1 Message Date
kasperl@google.com 1a56829f81 Use JsonMap even for JSON.decode with custom reviver.
R=floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org//367683002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37931 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 06:29:20 +00:00
kasperl@google.com 7087c8a7b6 Make the JSON decoder (parser) create Dart maps lazily when no reviver is provided (common case).
R=floitsch@google.com, lrn@google.com
BUG=http://dartbug.com/19649

Review URL: https://codereview.chromium.org//336863008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37858 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 09:53:18 +00:00
lrn@google.com 9e765a713c Also fix uri_query_test.
Review URL: https://codereview.chromium.org//354003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37733 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-26 11:49:11 +00:00
lrn@google.com b9d3d5bbae Try to retain original structure of URI.
This changes URI.parse to retain empty autorities, queries and fragments.
That is: `Uri.parse("foo:///x?#")` will give a Uri with toString "foo:///x?#",
as opposed to the previous "foo:/".

It also makes a difference between passing "" and null to the Uri constructor.

We still omit empty user-info and default port values from the toString.

R=ajohnsen@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37690

Review URL: https://codereview.chromium.org//352093003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37728 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-26 09:41:30 +00:00
lrn@google.com f2afbd9a62 Revert "Try to retain original structure of URI."
Breaks dart2js.

Review URL: https://codereview.chromium.org//335773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37692 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-25 11:59:13 +00:00
lrn@google.com 0200cfcc67 Try to retain original structure of URI.
This changes URI.parse to retain empty autorities, queries and fragments.
That is: `Uri.parse("foo:///x?#")` will give a Uri with toString "foo:///x?#",
as opposed to the previous "foo:/".

It also makes a difference between passing "" and null to the Uri constructor.

We still omit empty user-info and default port values from the toString.

R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//352093003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37690 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-25 11:16:32 +00:00
lrn@google.com d4c2b57209 Fix bugs in Uri: Allow empty port, handle path starting with "//" in toString.
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//347393003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37590 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 09:44:05 +00:00
lrn@google.com 306b3af9f0 Fix bug in gen-delims table.
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//344803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37482 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 09:32:28 +00:00
floitsch@google.com 0baf6ab684 Allow #[] and #[]= symbols.
BUG= http://dartbug.com/15653
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//346603003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37481 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 09:29:17 +00:00
lrn@google.com 736db44293 New Uri.parse and validation.
Ensures that the resulting URI is valid.
Escapes invalid characters except the gen-delim group of delimites, where
escapes are allowed.

R=ajohnsen@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//335373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37479 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 09:05:07 +00:00
lrn@google.com 9bdecb9d58 Fix missing + in URI encodeFullTable.
Add tests.

BUG= http://dartbug.com/19463
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//346763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37477 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 07:44:23 +00:00
lrn@google.com 31eeb6caf2 Revert "New, more validating, parser for URI." and follow-up patches.
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//337033003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37359 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-16 12:32:35 +00:00
lrn@google.com c7d98e335b New, more validating, parser for URI.
BUG= https://code.google.com/p/dart/issues/detail?id=16081
R=ajohnsen@google.com, fschneider@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//321543003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37346 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-16 07:00:22 +00:00
karlklose@google.com 4b5921129c Adjust test expectations for corelib string tests.
R=lrn@google.com

Review URL: https://codereview.chromium.org//330793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37311 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-13 12:13:08 +00:00
lrn@google.com 1ec6c5c1db Revert "Add "last" setter to List."
After discussion, we decided not to change the List interface for something that is just a convenience.

Also revert "Mark pkgbuild/pkg/collection as failing when using repository packages"

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//331833003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37307 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-13 09:40:22 +00:00
lrn@google.com f528beb9f2 Add "last" setter to List.
This allows assigning directly as `list.last = value` instead of
having to use the longer `list[list.length - 1] = value`.
It's just an abbreviation, like `list.last` is for reading.

If you use a List as a stack (which is a perfectly good use of it),
modifying the last element like this is a natural operation.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//315173005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37255 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-12 08:11:22 +00:00
iposva@google.com 5f06c8fd1c - Skip flaky Windows x64 test of Stopwatch.
Review URL: https://codereview.chromium.org//327313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37240 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-11 18:39:33 +00:00
lrn@google.com 989709f3a8 Reinstall previous behavior for Set and Queue toString.
A previous change made these omit elements to keep the toString length down.
That could break code that expects the original behavior.

This still avoids using IterableMixinWorkaround.

Add static toString methods on ListBase, SetBase, IterableBase so that users can
get the same behavior as our toString methods, and with the same cycle detection
safety.

Unify all collection toString methods in two methods:
- IterableBase.iterableToShortString
- IterableBase.iterableToFullString

R=floitsch@google.com

Review URL: https://codereview.chromium.org//297053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36616 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-26 06:08:20 +00:00
lrn@google.com 9976e03768 Remove uses of IterableMixinWorkaround outside of VM and dart2js lists.
Remaining uses are in:

- array.dart (VM)
- growable_array.dart (VM)
- typed_data.dart (VM)
- js_array.dart (Dart2js)

These need support from the VM and dart2js teams to remove.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//292323006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36553 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-23 09:39:09 +00:00
ricow@google.com 95dfe7c083 Mark a lot of ie9 tests as skip instead of timeout or flaky timeout.
The majority of these are either not triaged or marked with a bug that is not actively being worked on.

Since we can only run _one_ instance of IE simultainiuosly on windows if we don't want flake this is really slowing us down.

R=blois@google.com

Review URL: https://codereview.chromium.org//296213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36517 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-22 17:33:31 +00:00
lrn@google.com 61fb66c9e4 The toSet operation returns a new Set with the same equality and iteration behavior, and with the same elements.
R=floitsch@google.com, jmesserly@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//288103003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36473 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-22 08:29:59 +00:00
ricow@google.com 0941b69f18 Update status files after update to chrome 35
Review URL: https://codereview.chromium.org//297763005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36406 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-21 06:29:28 +00:00
zra@google.com 4a7e022d97 Adds intrinsics for arm64.
Also enables tests that no longer time-out.

R=regis@google.com

Review URL: https://codereview.chromium.org//285403004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36330 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-19 21:35:32 +00:00
zra@google.com eb11b8a7a0 Adds far-branches to arm64.
Also fixes bugs and enables tests.

R=regis@google.com

Review URL: https://codereview.chromium.org//283513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36051 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-12 18:43:08 +00:00
brianwilkerson@google.com 302b929074 Triage corelib tests
R=scheglov@google.com

Review URL: https://codereview.chromium.org//278993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35998 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-09 21:44:03 +00:00
lrn@google.com 3a743f3d38 Add MapMixin to dart:collection.
BUG= http://dartbug.com/10128
R=ajohnsen@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org//253023004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35904 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-08 11:36:13 +00:00
lrn@google.com 7b040b99c3 Fix bug in SplayTreeSet when removeWhere removes all elements.
BUG= http://dartbug.com/18676
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//274563008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35885 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-08 07:32:40 +00:00
ricow@google.com 9e72fec5b6 Safarimobilesim status file updates.
Fix wrong status in corelib.status to not require both safari and safarimobilesim
Add dart2js extra suppression already in there for safari

Review URL: https://codereview.chromium.org//264743006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35637 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-01 16:38:29 +00:00
ricow@google.com 342d4e79da Update status file entries for mobile safari simulator.
Only a few tests are failing that are not failing on the normal safari.

I have marked those with issue 18573

Review URL: https://codereview.chromium.org//268593004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35634 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-01 15:40:33 +00:00
lrn@google.com f0565a0eea Fix dart2js replace to escape all dollar characters in the replacement string.
BUG= http://dartbug.com/17886
R=herhut@google.com

Review URL: https://codereview.chromium.org//251373006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35516 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-29 08:01:33 +00:00
ahe@google.com d99d6aaa5b string_case_test/02 no longer fails on Chrome.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//257833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35418 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 08:45:39 +00:00
lrn@google.com bd622a6960 Change the badly named RegExp.pattern to return the original source.
On dart2js, it returned the .source property of the underlying JS
regexp, which may not be the same (e.g., for "/" and "").

BUG= http://dartbug.com/17998
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//250573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35368 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 12:33:26 +00:00
johnniwinther@google.com b830dd1f9f Update status.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//252393005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35364 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 10:55:58 +00:00
jwren@google.com 55afabf195 Fix for build in status files, now that 17234 is fixed
Review URL: https://codereview.chromium.org//235723004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34994 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-11 20:57:29 +00:00
ricow@google.com a88c893aa2 Roll V8 deps to version 3.25
R=kasperl@google.com

Review URL: https://codereview.chromium.org//233703005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34962 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-11 08:17:02 +00:00
lrn@google.com 139e447d11 Update status
Fix type annotations on map changes.

BUG= http://dartbug.com/18130
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//232633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34913 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-10 08:18:32 +00:00
whesse@google.com 76a7e968e1 Mark corelib/map_index_test as failing.
Review URL: https://codereview.chromium.org//231093003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34886 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 17:55:49 +00:00
whesse@google.com ec298a01f8 Add new failures to status files, assign issues.
BUG=dartbug.com/18113
R=ricow@google.com

Review URL: https://codereview.chromium.org//230163003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34863 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 08:30:24 +00:00
lrn@google.com 9069c292c6 Also mark string_case_test failing on dart2dart-vm.
Review URL: https://codereview.chromium.org//228493002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34819 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 11:30:40 +00:00
lrn@google.com 88ba8efed9 Optimize one-byte string's toUpperCase.
R=ajohnsen@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//213293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34812 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 07:19:33 +00:00
zra@google.com 2fe51715e5 Begins work on ARM64, first assembler test.
Most new code is in constants_arm64.h and
{assembler,disassembler,simulator}_arm64.{h,cc}

The rest of the CL just #def's out tests, modifies status files,
and adds UNIMPLEMENTED functions, etc.

R=regis@google.com

Review URL: https://codereview.chromium.org//221133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34654 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-02 17:39:32 +00:00
floitsch@google.com ace6af2dc6 Fix bad HttpDate.format.
BUG= http://dartbug.com/17916
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//219503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34557 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-31 15:22:16 +00:00
lrn@google.com 8247480637 Mark corelib/map_test crashing on dart2js checked.
BUG= http://dartbug.com/17829

Review URL: https://codereview.chromium.org//213323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34439 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 17:35:33 +00:00
lrn@google.com 3ba70935ed Remove use of now private class from map_test.
Review URL: https://codereview.chromium.org//212673004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34429 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 13:09:47 +00:00
lrn@google.com bf6e0dab05 Add MapBase and UnmodifiableMapView classes to dart:collection.
Includes supporting classes.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//211223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34422 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 12:10:25 +00:00
ajohnsen@google.com fbdb9a85d8 Add optimized _OneByteString.toLowerCase.
BUG=
R=sgjesse@google.com, sra@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//209443005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34393 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-25 21:44:09 +00:00
lrn@google.com 50d01bda2d Syntax prohibits assignment in assert.
Review URL: https://codereview.chromium.org//207693003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34241 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 10:14:12 +00:00
lrn@google.com 8fd1e2f65d Make generator argument to Iterable.generate optional.
It defaults to an integer identity function.

Also optimize skip/take on the generated iterable by making it
take hold start and end positions instead of just the count.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//207823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34240 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 09:54:46 +00:00
whesse@google.com 127155271e Fix syntax error in status file.
Error introduced in r33807

BUG=

Review URL: https://codereview.chromium.org//203213003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33808 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 15:02:04 +00:00
whesse@google.com 62c79adbd0 Add entries for ContentShellOnAndroid runtime to status files.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//203373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33807 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 14:47:56 +00:00