Commit Graph

1365 Commits

Author SHA1 Message Date
lrn@google.com 1e966793f5 Fix bug in trim introduced by rewrite.
Code worked in V8 because it treats NEL as whitespace (incorrectly),
but failed in Firefox.

R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//196533015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33643 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 09:59:27 +00:00
lrn@google.com f95e190651 Add string.trimLeft/trimRight.
BUG= http://dartbug.com/5589
R=floitsch@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//190853009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33638 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 07:16:51 +00:00
lrn@google.com 13d8eae15a Faster _Smi.toString()
Add tests.

R=ajohnsen@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//183973030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33416 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 09:31:53 +00:00
ajohnsen@google.com c3dfdbe772 Fix fromEnvironment when called from isolates.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//180243022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33363 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 09:16:41 +00:00
ajohnsen@google.com 1ce402ec78 Revert "Re-apply 'Fix fromEnvironment when called from isolates.'"
This reverts commit 1f2ddd083424a93dc0822c2ae86be971d5a97e21.

BUG=

Review URL: https://codereview.chromium.org//185233016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33278 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 16:05:21 +00:00
ajohnsen@google.com fb97ee0fe1 Re-apply 'Fix fromEnvironment when called from isolates.'
Old Review URL: https://codereview.chromium.org//186393004

BUG=

Review URL: https://codereview.chromium.org//177353006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33274 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 14:22:54 +00:00
ajohnsen@google.com e8ad108bec Revert "Fix fromEnvironment when called from isolates."
This reverts commit f5886c3a1fe96580c13d83d6422a6bb6931ae95a.

BUG=

Review URL: https://codereview.chromium.org//186573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33266 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 11:06:39 +00:00
ajohnsen@google.com 7e55a59ce4 Fix fromEnvironment when called from isolates.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//186393004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33264 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 10:26:17 +00:00
ahe@google.com c1cbdbf0d7 Update analyzer status after test.py refactoring.
Review URL: https://codereview.chromium.org//178193017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33200 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 09:48:39 +00:00
karlklose@google.com 32ee534a3f Emit named parameter information in declaration order.
R=floitsch@google.com, kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32880

Review URL: https://codereview.chromium.org//163773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33017 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-25 13:17:54 +00:00
ajohnsen@google.com 65f653a7cb Write custom URI-parser, to avoid using regexp.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//167703010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32966 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-24 14:36:31 +00:00
lrn@google.com 69145994de Allow multi-codeunit padding in String.padLeft/padRight.
Also allow negative repeats.

Based on suggestions from Stephen.

R=sra@google.com

Review URL: https://codereview.chromium.org//171773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32843 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-20 07:17:11 +00:00
lrn@google.com 1534e6729a Remove "static" caused by bad merge.
Review URL: https://codereview.chromium.org//172413002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32792 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 13:53:52 +00:00
lrn@google.com 849dcbeec7 Remove "function" in front of function. This is not JS!
Review URL: https://codereview.chromium.org//172393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32789 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 13:24:16 +00:00
lrn@google.com a809fd5fb7 Add time-zone parsing to DateTime.parse.
A non-zero time offset is now understood, and the result is converted
to the equivalent UTC time.

More comments.

BUG= http://dartbug.com/16527 http://dartbug/16861
R=floitsch@google.com

Review URL: https://codereview.chromium.org//169493002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32787 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 13:21:07 +00:00
lrn@google.com b27ccf41e3 Add toIso8601String to DateTime.
BUG= http://dartbug.com/16902
R=floitsch@google.com

Review URL: https://codereview.chromium.org//165723005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32786 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 13:00:09 +00:00
lrn@google.com a3ad46de0d Add String.repeat, String.padLeft, String.padRight.
We keep seeing reimplementations everywhere, and reimplementing it ourselves.

BUG= http://dartbug.com/16919
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//172153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32784 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 12:32:56 +00:00
lrn@google.com c18aab0e84 Fix bug in DoubleLinkedQueue where removing from empty queue throws.
BUG= http://dartbug.com/16270
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//138953015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32060 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 09:37:02 +00:00
lrn@google.com ac10112114 Fix bug in internal SplayTreeIterator constructor.
Only has performance impact on the filter operations (retainWhere/removeWhere).
Also remove unused empty function.

R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//148523006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32056 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 09:16:27 +00:00
lrn@google.com 1bb616d0ce Fix JSON encoder accepting NaN and Infinity.
BUG= http://dartbug.com/16038
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//136373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31731 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-13 10:00:08 +00:00
lrn@google.com 1fa76c85b5 Fix bug in Duration.toString.
BUG= http://dartbug.com/15678

Review URL: https://codereview.chromium.org//119263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31318 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-20 07:18:21 +00:00
ngeoffray@google.com a4cf4f2334 Remove obsolete TODOs from tests.
R=lrn@google.com

Review URL: https://codereview.chromium.org//100443005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31254 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-19 10:46:15 +00:00
lrn@google.com bd5f28916f Add tests for symbols of operators.
R=ahe@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org//114603004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31187 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-17 12:38:53 +00:00
lrn@google.com 86edf90273 Add num.sign getter.
BUG= http://dartbug.com/15580
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//113833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31126 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-13 12:10:23 +00:00
kustermann@google.com 34afbbc66a Mark symbol_test/0{2,3} as passing on drt (in addition to dartium)
R=whesse@google.com

Review URL: https://codereview.chromium.org//111903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31028 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 17:34:19 +00:00
kustermann@google.com e898028b18 Attempt to deflake our status files
R=whesse@google.com

Review URL: https://codereview.chromium.org//109893004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31022 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 15:37:34 +00:00
sgjesse@google.com 3d2b5c4bd4 Add encodimg argument to Uri.encodeQueryString
R=lrn@google.com
BUG=http://dartbug.com/12780

Review URL: https://codereview.chromium.org//94733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30791 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-02 09:01:22 +00:00
lrn@google.com dbdb16afb3 Reduce running time of nan_parse_test.
It times out on Dartium.
It was testing all combinations of whitespace around all test strings.
Now it just does it around some representable test strings, and only
test space characters around most strings.

Also add a few more tests.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//94173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30749 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-28 08:57:04 +00:00
srdjan@google.com 8058e7b135 Fix simarm test (add timeout).
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//89403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30683 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-26 23:07:27 +00:00
lrn@google.com 700ed41411 Remove num-parse failure expectation for dart2js after changing test.
Review URL: https://codereview.chromium.org//88003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30668 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-26 11:18:00 +00:00
lrn@google.com ef66be8610 Change Expect.identical(NaN, x) to not assume NaNs are identical.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//87953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30667 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-26 10:32:51 +00:00
lrn@google.com e1b4afa85d Add num.parse.
The implementation is still primitive: It calls int.parse, then double.parse, and then fails if it hasn't found a result yet.

BUG= http://dartbug.com/8237
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30624

Review URL: https://codereview.chromium.org//85633003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30663 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-26 08:44:38 +00:00
lrn@google.com f5bf3613dc Revert "Add num.parse."
Fails on IE9.

Review URL: https://codereview.chromium.org//85623004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30631 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-25 14:52:23 +00:00
lrn@google.com 61e1c18e78 Add more tests.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//84993004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30628 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-25 13:50:09 +00:00
lrn@google.com e0f3bb3092 Add num.parse.
The implementation is still primitive: It calls int.parse, then double.parse, and then fails if it hasn't found a result yet.

BUG= http://dartbug.com/8237
R=floitsch@google.com

Review URL: https://codereview.chromium.org//85633003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30624 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-25 13:09:04 +00:00
ngeoffray@google.com f02627fe15 Update status file for safari bug.
R=kasperl@google.com

Review URL: https://codereview.chromium.org//85573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30616 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-25 11:22:39 +00:00
ngeoffray@google.com 27d1f7aa7f Inline the fixed array constructor manually in the SSA builder. Also track whether a fixed array ever flows into a method that may check if it is growable.
Also fixes new List(null): it now throws.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//82953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30612 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-25 09:10:57 +00:00
floitsch@google.com 1b97a4765f Fix timezone extraction for IE and Opera.
Not perfect, but these browsers don't give enough information.

BUG= http://dartbug.com/14717
BUG= http://dartbug.com/14691
BUG= http://dartbug.com/15027
R=lrn@google.com

Review URL: https://codereview.chromium.org//78043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30469 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 13:57:53 +00:00
lrn@google.com 06e97d46b6 Fix expectation of corelib/queue_test to not fail analysis.
Review URL: https://codereview.chromium.org//78333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30464 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 12:56:46 +00:00
lrn@google.com 410268a15e Fix set test, number of arguments to helper function changed.
Review URL: https://codereview.chromium.org//77993003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30457 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 10:42:28 +00:00
lrn@google.com cd2cf5058e Add SplayTreeSet.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//61733013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30444 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 09:35:39 +00:00
floitsch@google.com 7c5a2a13cb Move unicode tests to utf package.
BUG= http://dartbug.com/2252
R=lrn@google.com

Review URL: https://codereview.chromium.org//68563004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30409 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-19 12:58:09 +00:00
sra@google.com c4993e4b62 Reapply "This change makes it easier to put type parameters on JavaScript Arrays."
Updates recursive_import_test

Review URL: https://codereview.chromium.org//75453004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30380 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-18 22:06:48 +00:00
sra@google.com 34fefd2715 Revert "This change makes it easier to put type parameters on JavaScript Arrays."
Review URL: https://codereview.chromium.org//75703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30377 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-18 21:53:27 +00:00
sra@google.com 483cb2553a This change makes it easier to put type parameters on JavaScript Arrays.
There is one special factory constructor for putting the type on an existing Array, and some higher level factory constructors that implement the common List subtypes.

The effect of this is to move the type parameter assignment from every "new List" site to a handful of site within JSArray.  This shrinks some programs by half a percent, e,g, 3k of swarm.

JSArray.toList() and JSArray.sublist() now return JSArrays with the expected type parameters.

R=karlklose@google.com, ngeoffray@google.com

Review URL: https://codereview.chromium.org//70703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30374 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-18 21:06:48 +00:00
karlklose@google.com fe2595422d Register generic type of instantiated Map literal.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//59693006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30041 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 11:31:29 +00:00
floitsch@google.com ec3db0d42c Fix the generic type of Map.values for map literals.
R=karlklose@google.com

Review URL: https://codereview.chromium.org//59463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29995 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 20:58:39 +00:00
floitsch@google.com 6bdd901604 Add test that makes sure print deals with broken toStrings.
R=ahe@google.com

Review URL: https://codereview.chromium.org//60553002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29994 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 20:40:03 +00:00
karlklose@google.com 26877eda37 Change status of corelib/map_values2_test.
On dart2js, the library function to create the values-iterable uses IterableBase.map, which create a MappedIterable where the second type argument is set to dynamic. As a consequence, the result of `get values` is an Iterable<dynamic>.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//57373007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29875 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-05 07:16:53 +00:00
karlklose@google.com 1ddf0d9a53 Reapply "Set runtime type on list and map literals."
Reviewed as: https://chromiumcodereview.appspot.com/54293008/.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//56553004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29798 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-04 10:25:25 +00:00