Commit Graph

1365 Commits

Author SHA1 Message Date
lrn@google.com 7c43721a45 Make RangeError.toString use the name field that it inherits from ArgumentError.
Refactor the toString code to make it reuse more of the logic and
thereby be more consistent.

BUG= http://dartbug.com/22148
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//879893002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43231 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 09:39:05 +00:00
sra@google.com 1204d2b859 Recognize and special case String.fromCharCodes for Uint8List in JavaScript.
Speeds up UTF8 decoding, boosting JsonUtf8RoundTrip 4x.
This should also improve binary protobuf parsing of strings.

R=lrn@google.com

Review URL: https://codereview.chromium.org//860273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43055 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 22:50:00 +00:00
fschneider@google.com 1e7310d48f Improve constant pool implementation in the assembler.
Instead of using RawObject* as keys, use Object*. Using handles eliminates any assumption
about the underlying GC implementation (e.g. requiring that old objects don't move).

Remove special handling of null_object by making HashMap more generic and
allowing the trait to specify the value used to indicate an empty element.

The goal is to use one unified, efficient implementation of the constant
pool on all architectures that require one (x64, arm64, mips).

R=vegorov@google.com, zra@google.com

Review URL: https://codereview.chromium.org//848703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42901 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 10:43:36 +00:00
whesse@google.com 5bba992965 Enable co19 dart2js browser tests on content shell (drt).
Update co19 status files for Firefox update to 35, and other flakes.

TBR=ricow@google.com

Review URL: https://codereview.chromium.org//847393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42873 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 15:56:28 +00:00
lrn@google.com 6d2427d1b6 Update toRadixString test so that it fails on d8 too.
Review URL: https://codereview.chromium.org//847773004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42771 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 13:53:08 +00:00
lrn@google.com 8ebe51d63c Update status files after enforcing integer arguments to toRadixString etc, and adding more and harder tests for toRadixString.
Review URL: https://codereview.chromium.org//849573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42769 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 10:48:49 +00:00
lrn@google.com bb4e97f519 Change dart2js int.toRadixString to not return spurious format on IE.
BUG= http://dartbug.com/15316
R=floitsch@google.com

Review URL: https://codereview.chromium.org//87523003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42764 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 08:59:58 +00:00
zerny@google.com 34a556e5a9 Mark corelib/regexp/pcre_test as slow on debug builds.
TBR=floitsch@google.com,fschneider@google.com
BUG=http://dartbug.com/22008

Review URL: https://codereview.chromium.org//836293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42659 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-07 13:24:58 +00:00
whesse@google.com 37028ca998 Mark dart2js http_test as slow in checked mode.
BUG=
R=zerny@google.com

Review URL: https://codereview.chromium.org//796693004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42652 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-07 10:03:55 +00:00
lrn@google.com cfa14bc32f Fix typo in set_test.dart, makes analyzer complain.
Review URL: https://codereview.chromium.org//837703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42633 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 14:53:22 +00:00
lrn@google.com 182b7b8083 Don't inherit two versions of Comparable. Not supported by dart2js.
Review URL: https://codereview.chromium.org//836123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42625 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 11:21:12 +00:00
lrn@google.com 404d4a7243 Make Super abstract in map_test.dart to avoid warning.
Review URL: https://codereview.chromium.org//820693005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42624 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 11:17:28 +00:00
lrn@google.com 3f1780f70d Change List/Set/Map/Queue.from constructrs to accept any iterable.
This allows using the .from constructor as a cast:

  new Set<int>.from(numSetContainingOnlyInts);

BUG= http://dartbug.com/21731
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//838463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42620 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 10:14:56 +00:00
whesse@google.com 5c6b29f057 Update status for slow regexp test on debug MIPS.
BUG=dartbug.com/21995
R=ricow@google.com

Review URL: https://codereview.chromium.org//788183007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42595 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 14:45:17 +00:00
floitsch@google.com 79f0df2cc8 dart2js: put all type-test related properties on the prototype and not on the constructor.
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42392
Reverted: https://code.google.com/p/dart/source/detail?r=42408

Review URL: https://codereview.chromium.org//802653005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42435 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-17 15:05:15 +00:00
fschneider@google.com 4fada4c9a8 Revert r42426: Re-enable regexp test.
This test still times out with --optimization-counter-threshold=5

TBR=zerny@google.com

Review URL: https://codereview.chromium.org//808143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42428 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-17 13:14:28 +00:00
sigurdm@google.com b0e9fbedce Generative constructors in the new dart backend.
With super and field initializers.

Field initializers and the arguments to a super-initializer
are treated as zero-arg nested functions, and if they assign
to a parameter, that parameter is set to be a closure
variable.

Still no 'this' initializer redirections.

initializing formals (such as `C(this.x)` ) are translated
to field initializers. We might want to revisit this choice.

R=asgerf@google.com, kmillikin@google.com

Review URL: https://codereview.chromium.org//787603003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42427 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-17 10:34:21 +00:00
fschneider@google.com 433f36c06e Re-enable regexp test.
This test was skipped because of too long-running.

It is now finishing faster (2s release-checked, 10s debug mode)

R=zerny@google.com

Review URL: https://codereview.chromium.org//794493003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42426 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-17 10:01:32 +00:00
zerny@google.com 0a80eaec06 Revert "Revert "Revert "Disable the irregexp backend."""
This enables the irregexp backend by reverting commit
http://code.google.com/p/dart/source/detail?r=42246

R=fschneider@google.com
BUG=

Review URL: https://codereview.chromium.org//800453003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42312 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 09:02:24 +00:00
zerny@google.com 0bfa80b5a5 Revert "Revert "Disable the irregexp backend.""
This reverts commit http://code.google.com/p/dart/source/detail?r=42240
Reason for revert: failures and timeouts on Dartium bots.

TBR=fschneider@google.com
BUG=

Review URL: https://codereview.chromium.org//792853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42246 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 15:38:10 +00:00
zerny@google.com d1f5aacd77 Revert "Disable the irregexp backend."
This reverts commit http://code.google.com/p/dart/source/detail?r=41999

R=fschneider@google.com
BUG=

Review URL: https://codereview.chromium.org//774933009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42240 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 09:56:53 +00:00
regis@google.com e20569cf8b Reenable a few previously slow tests on MIPS.
R=zra@google.com

Review URL: https://codereview.chromium.org//781123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42141 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-05 19:32:39 +00:00
lrn@google.com a3c7e0a0d9 Fix date_time_test to not assume a particular slowness of running code.
R=ricow@google.com

Review URL: https://codereview.chromium.org//759753010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42083 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-03 07:19:49 +00:00
regis@google.com a17adcd1de Fix overflow check when shifting unboxed mints on 32-bit platforms, except on
MIPS, which does not yet support unboxed mints (work in progress). Issue 21715.
Add regression test.

R=zra@google.com

Review URL: https://codereview.chromium.org//755383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42003 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-26 17:36:32 +00:00
zerny@google.com 487ca247d7 Disable the irregexp backend.
Currently the use of irregexp breaks the Dartium build.

TBR=vegorov@google.com
BUG=

Review URL: https://codereview.chromium.org//757303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41999 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-26 16:21:08 +00:00
zerny@google.com 858bdd8a8b Skip slow test corelib/regexp/global_test.
R=vegorov@google.com
BUG=http://dartbug.com/21709,http://dartbug.com/21708

Review URL: https://codereview.chromium.org//760043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41994 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-26 14:24:48 +00:00
zerny@google.com 8e807c8550 Integrate the Irregexp Regular Expression Engine.
BUG=http://dartbug.com/19090
R=fschneider@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41949

Review URL: https://codereview.chromium.org//744853003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41983 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-26 09:32:43 +00:00
zerny@google.com 84a4135901 Revert "Integrate the Irregexp Regular Expression Engine."
This reverts commit https://code.google.com/p/dart/source/detail?r=41949

TBR=fschneider@google.com
BUG=

Review URL: https://codereview.chromium.org//754383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41950 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-25 13:36:40 +00:00
zerny@google.com 43ac0c6f33 Integrate the Irregexp Regular Expression Engine.
BUG=http://dartbug.com/19090
R=fschneider@google.com

Review URL: https://codereview.chromium.org//744853003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41949 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-25 13:10:21 +00:00
johnniwinther@google.com ba110b93ff Avoid patching in dart2dart.
BUG=http://dartbug.com/21441
R=floitsch@google.com

Review URL: https://codereview.chromium.org//746993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41901 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-21 13:42:56 +00:00
regis@google.com 3c16a2c0f9 Skip MIPS tests. Still too slow. See issue 20879.
Review URL: https://codereview.chromium.org//728483004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41729 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-14 01:21:25 +00:00
regis@google.com defc9a5c54 Specialize _toPow2String for bigint to make it linear instead of quadratic.
Remove some duplicated bigint corelib tests.
Cleanup corelib tests status file.
Partially fix issue 20879 (not closed).

R=zra@google.com

Review URL: https://codereview.chromium.org//723963006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41728 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-13 23:54:33 +00:00
whesse@google.com e5d6c3d424 Update status for fixed test.
BUG=dartbug.com/21582
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//724013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41712 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-13 13:14:18 +00:00
ricow@google.com 4ff8c06729 Mark corelib/regexp/pcre_test as slow on dart2js
Filed issue 21593 to track this

Review URL: https://codereview.chromium.org//718393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41706 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-13 07:44:25 +00:00
lrn@google.com e8ca26953e Reduce foot-print of Error.safeToString on strings.
Use existing JSON encoding instead of a custom encoding.
This allows dart2js to use the system JSON stringifier directly.

R=sra@google.com

Review URL: https://codereview.chromium.org//718053003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41704 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-13 06:47:17 +00:00
lrn@google.com b02786e0c1 Mark Firefox/jsshell as failing on double_parse_test.
The ECMAScript spec allows non-IEEE-754 compliant parsing, probably because
that was what Netscape was already doing.

Review URL: https://codereview.chromium.org//718713002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41665 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-11 14:25:24 +00:00
lrn@google.com 5bb4d992b4 Add more double-parsing tests.
I was looking at double parsing, and wanted more tests for myself anyway.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//712603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41664 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-11 13:31:40 +00:00
lrn@google.com 42dac4c7b4 Add some ArgumentError and RangeError constructors that capture more information.
Switch some uses of RangeError.range to RangeError.index.
Fix bug in Queue where elementAt allowed `length` as input.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//711003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41653 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-11 07:55:47 +00:00
lrn@google.com e5bc666107 Change SplayTreeMap test to not cause static type warnings, only runtime errors.
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//710063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41627 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-10 11:53:34 +00:00
lrn@google.com 583f408260 Fix type in generic type of parameters to SplayTreeMap.fromIterable.
Add tests.

BUG = http://dartbug.com/21542
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//716513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41624 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-10 10:39:28 +00:00
zerny@google.com f579383d56 Reapply "Port regexp tests from V8 to Dart."
This fixes checked mode issues and reapplies commit
https://code.google.com/p/dart/source/detail?r=41354

R=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//691473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41416 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 11:34:18 +00:00
whesse@google.com 53264f42c0 Mark tests flaky on Safari 6.2
BUG=dartbug.com/21434
R=ricow@google.com

Review URL: https://codereview.chromium.org//659173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41393 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 10:30:25 +00:00
zerny@google.com 488b0e1630 Revert "Port regexp tests from V8 to Dart."
Reason: The tests do not run cleanly in checked mode.

TBR=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//687613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41358 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 13:33:15 +00:00
zerny@google.com c67ccb1c0c Capture group error has been fixed.
BUG=http://dartbug.com/21396
R=lrn@google.com

Review URL: https://codereview.chromium.org//681313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41357 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 13:11:17 +00:00
zerny@google.com 19a7c86e6b Rename RegExp_test.dart to regexp_kde_test.dart to avoid conflict with regexp_test.dart on Windows.
TBR=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//683833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41356 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 13:00:54 +00:00
zerny@google.com f68daab3f9 Port regexp tests from V8 to Dart.
This adds V8s suite of regular expressions tests. The tests are skipped
for all none d8 runtimes until irregexp has been ported and enabled for
the other runtimes. The tests are enabled when compiling with dart2js
and running with d8.

BUG=http://dartbug.com/21396
R=lrn@google.com

Review URL: https://codereview.chromium.org//667043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41354 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 12:33:15 +00:00
lrn@google.com f7fd659ce0 Expect dart2dart to fail on string_split_test.
Review URL: https://codereview.chromium.org//684723003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41351 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 09:03:46 +00:00
whesse@google.com aeba67e44e Add builder tag for Safari 6.2 slave. Update status files for Safari 6.2.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//679153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41323 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 16:09:00 +00:00
lrn@google.com 75e49f5220 Fix test warnings and expect Safari mobile simulator bug.
Review URL: https://codereview.chromium.org//679143003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41319 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 15:07:20 +00:00
lrn@google.com a38f54ead0 Make dart2js String.split match the VM version.
The dart2js version used the JS version of string split, which
includes captures between the parts. The Dart version doesn't do
that.

BUG= http://dartbug.com/21395
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//677013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41313 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 12:52:35 +00:00