dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

262 Commits

Author SHA1 Message Date
Martin Kustermann 173f53a6b4 [Gardening] Skip co19_2 test, which causes other tests to fail 
Issue https://github.com/dart-lang/co19/issues/177

Change-Id: I5743fdc144d83d0f7fd8cb77d2449267a2de0af8
Reviewed-on: https://dart-review.googlesource.com/c/81609
Reviewed-by: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-10-26 13:37:48 +00:00
Vyacheslav Egorov b3055a1482 [gardening] Mark co19 LibTest/io/RawDatagramSocket/any_A01_t03 flaky 
TBR=kustermann@google.com

Change-Id: Ie4fa7b875989ea31370c028d07e4ca5c9be0b310
Reviewed-on: https://dart-review.googlesource.com/c/81364
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
 2018-10-24 20:13:13 +00:00
Vyacheslav Egorov a902fc351f [gardening] Mark co19 LibTest/io/Stdin/readByteSync_A02_t01 flaky 
Issue https://github.com/dart-lang/co19/issues/175

TBR=kustermann@google.com

Change-Id: I1518f7a2a63d9347e858f67733202e07e932ae22
Reviewed-on: https://dart-review.googlesource.com/c/81361
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-10-24 16:39:44 +00:00
Vyacheslav Egorov b9999b6c27 [gardening] Mark co19 LibTest/io/RawDatagramSocket/lastWhere_A01_t02 flaky 
Issue https://github.com/dart-lang/co19/issues/170

TBR=kustermann@google.com

Change-Id: I7f4dbf8127a044e27773cf331c099839638f98ac
Reviewed-on: https://dart-review.googlesource.com/c/81276
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
 2018-10-24 13:28:55 +00:00
Vyacheslav Egorov 0b15595913 [gardening] Mark co19 LibTest/io/Link/rename_A02_t01 flaky 
Issue https://github.com/dart-lang/co19/issues/174

TBR=kustermann@google.com

Change-Id: I69070d0bf6d27a7e5aed93c1fde36c1a3960178b
Reviewed-on: https://dart-review.googlesource.com/c/81273
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-10-24 10:37:07 +00:00
Martin Kustermann 1515d4fe34 [Gardening] Mark LibTest/io/RawDatagramSocket/timeout_A06_t01 as flaky 
Change-Id: I8c853c188f14ac4e23cfd1fa16ff389ee0caae9a
Reviewed-on: https://dart-review.googlesource.com/c/81000
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-10-22 12:10:29 +00:00
Daco Harkes cfbb70aa1c [gardening] Mark various RawDatagramSocket/ tests as flaky 
Issue: https://github.com/dart-lang/co19/issues/170
Change-Id: Ib0a80d12fab5f968e26a28988ef8d6c0973b48d1
Reviewed-on: https://dart-review.googlesource.com/c/80800
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-10-19 09:46:41 +00:00
Stephen Adams bff11184fe dart2js co19_2 status bingo 
TBR=sigmund@google.com

Change-Id: Ibc04004851166c11f4ddfd8bde22e0a5a19bf7bd
Reviewed-on: https://dart-review.googlesource.com/c/80720
Reviewed-by: Stephen Adams <sra@google.com>
 2018-10-18 22:04:31 +00:00
Stephen Adams fdca304de5 Safari status bingo 
TBR=sigmund@google.com

Change-Id: I823d447a6cc281446223ba4f82266a816cdf9bb0
Reviewed-on: https://dart-review.googlesource.com/c/80702
Reviewed-by: Stephen Adams <sra@google.com>
 2018-10-18 21:32:18 +00:00
Stephen Adams ac2036d76b Firefox status bingo 
Change-Id: I29dc392f8adcf67acc3b9ac49afbaa9271988504
Reviewed-on: https://dart-review.googlesource.com/c/80701
Reviewed-by: Stephen Adams <sra@google.com>
 2018-10-18 21:13:19 +00:00
Vyacheslav Egorov 4585b8eb44 [gardening] Mark RawDatagramSocket/any_A01_t02 co19 test flaky 
TBR=kustermann@google.com

Bug: https://github.com/dart-lang/co19/issues/170
Change-Id: I55c1fa15c886f9e31203499a3fba8991938ddd36
Reviewed-on: https://dart-review.googlesource.com/c/80665
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-10-18 13:39:47 +00:00
Sergey G. Grekhov fed5bc62b6 [co19] DEPS and .status files updated 
Change-Id: If0747db4bd02d31814b407970b11d16519329625
Reviewed-on: https://dart-review.googlesource.com/c/79661
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-10-18 11:45:54 +00:00
Martin Kustermann f4ffb426c4 [Gardening] Mark flaky co19 tests and filed issue 
Issue https://github.com/dart-lang/co19/issues/173

Change-Id: Idcd4b994a022140d422ff71bb0b5e71c3d286388
Reviewed-on: https://dart-review.googlesource.com/c/80142
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2018-10-16 16:17:53 +00:00
Alexander Markov 2ed614819d [vm] Fix MakeUnusedSpaceTraversable in the 'Instance' filler case 
Object::MakeUnusedSpaceTraversable fills leftover with Instance
if leftover is less than TypedData::InstanceSize(0). This code is
outdated and was not working as the smallest TypedData is just
2 words. This CL updates this code to prepare for future TypedData
changes.

Also, test vm/cc/GrowableObjectArray is changed to be more flexible wrt
sizes of TypedData instances.

Change-Id: I32e21d5038163590ba618d8525aacd17e88800d9
Reviewed-on: https://dart-review.googlesource.com/c/79921
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-10-15 21:20:56 +00:00
Johnni Winther dc9d6785de Report compile-time errors on invalid switch cases 
This is a temporary fix for issue 32557 until CFE handles it.

Change-Id: I4f0cfa5a98af6b25536f0c8e0a257940f8ce708b
Reviewed-on: https://dart-review.googlesource.com/c/79561
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Auto-Submit: Johnni Winther <johnniwinther@google.com>
 2018-10-12 17:52:12 +00:00
Vyacheslav Egorov 1f4dfce179 [gardening] Mark co19 LibTest/io/HttpServer/close_A05_t01 flaky 
TBR=kustermann@google.com

Bug: https://github.com/dart-lang/co19/issues/172
Change-Id: If5dd45ef092943cee97b34906c8704361eab9f39
Reviewed-on: https://dart-review.googlesource.com/c/79264
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-10-12 10:39:28 +00:00
Kevin Millikin 2fa1143600 Check classes at mixin applications 
When a declared mixin is applied to a class, the class must implement
the superclass constraint interfaces named in the mixin declaration.

Change-Id: I6ace9fe244c1c87860b69c2c5e68f2c31ae73d7c
Reviewed-on: https://dart-review.googlesource.com/c/79206
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Daniel Hillerström <hillerstrom@google.com>
 2018-10-12 08:34:07 +00:00
Alexander Markov 6b67cd784b [vm] Make UBSAN happy for the code in Range::BitwiseOp 
Change-Id: I3f3ca03a0930f9feac1e7e94cdb5c50ece8d7856
Reviewed-on: https://dart-review.googlesource.com/c/79420
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-10-11 20:02:53 +00:00
Vyacheslav Egorov 1a4933715e [gardening] Mark co19 LibTest/io/RawDatagramSocket/any_A03_t01 flaky 
TBR=kustermann@google.com

Bug: https://github.com/dart-lang/co19/issues/170
Change-Id: I39a11ec752d49e2e87dbcc8caedbc2851c4e7e8b
Reviewed-on: https://dart-review.googlesource.com/c/79342
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-10-11 18:07:17 +00:00
Vyacheslav Egorov c347850976 [gardening] Mark co19 LibTest/io/RawDatagramSocket/timeout_A06_t01 as flaky 
TBR=kustermann@google.com

Bug: https://github.com/dart-lang/co19/issues/170
Change-Id: I1dd2fb67c4e5574499d5b0e4221c848acd810fe9
Reviewed-on: https://dart-review.googlesource.com/c/79215
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-10-11 14:35:06 +00:00
Dmitry Stefantsov 8648d782ae Reland "[fasta] Report errors for bounds violations" 
The original commit:
https://github.com/dart-lang/sdk/commit/aa6fb2d3a4298e60b5635f26507d5b39f4e531cb

Change-Id: I34287ec856fde16d56e9369ef2620311ba9bb722
Reviewed-on: https://dart-review.googlesource.com/c/79200
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-10-11 10:20:01 +00:00
Dmitry Stefantsov a539d2ef5f Revert "[fasta] Report errors for bounds violations" 
The CL is reverted because it didn't account for the case when a check
of a user-specified type argument against the bound depends on another
type that is only known after type inference is done.

Change-Id: I1fd140af95ed37b9191a5b161a281d4639e3453f
Reviewed-on: https://dart-review.googlesource.com/c/79048
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-10-10 15:31:27 +00:00
Martin Kustermann 327a1a9a00 [Gardening] Mark more co19_2 test as always flaky, filed co19 issues 
Issue https://github.com/dart-lang/co19/issues/170
Issue https://github.com/dart-lang/co19/issues/171

Change-Id: Ida6c7c97c43164573e368c96ccc361a311cc7f51
Reviewed-on: https://dart-review.googlesource.com/c/79045
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2018-10-10 13:23:03 +00:00
Dmitry Stefantsov aa6fb2d3a4 [fasta] Report errors for bounds violations 
Fixes #33308.

Bug: http://dartbug.com/33308
Change-Id: Iae087928468ed6883c438db95644135dc7ef0a6a
Reviewed-on: https://dart-review.googlesource.com/c/57621
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-10-10 12:03:36 +00:00
Martin Kustermann da48c1d960 [Gardening] Mark more tests as flaky and filed co19 issues 
Change-Id: I93c50eadf5de287b19caa0ebf8f5b1632fe670af
Reviewed-on: https://dart-review.googlesource.com/c/79022
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2018-10-10 11:26:13 +00:00
Martin Kustermann 41866e87da [Gardening] Mark co19_2 test as always flaky, filed co19 issue (and co19 PR) 
Issue https://github.com/dart-lang/co19/issues/165

Change-Id: Ide3d2fbcd2f68f2b0ebe78fc8ea5ef6ed1230470
Reviewed-on: https://dart-review.googlesource.com/c/78981
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2018-10-10 09:57:47 +00:00
Alexander Markov 2695f36016 [Gardening] Status update (co19_2, optcounter/ia32) 
Change-Id: Ica90e83995ad2e89548c07824dc525f1cd84fd71
Reviewed-on: https://dart-review.googlesource.com/c/78921
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-10-09 23:56:31 +00:00
Paul Berry b3af151325 Rework detection of uninstantiated bound errors. 
We now determine whether a type is simply bounded in the summary
linker, so that we can take advantage of the linker's circularity
detection logic.

Fixes #34635.
Fixes #34636.

Change-Id: I6c5040dbaeb79957d8a84e3f76e6a51834b57f05
Reviewed-on: https://dart-review.googlesource.com/c/78867
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-10-09 22:07:02 +00:00
Kevin Millikin 4e4e9ec74a Implement int-to-double literal conversion. 
The implementation strategy is to replace int literals with double
literals during type inference, provided they occur in a double
context and can be represented exactly as a double.  This requires us
to keep integer literals larger than the 64-bit range until after type
inference and to keep the source text of 64-bit integers until after
type inference for error reporting.

We postpone the check for web int literals as well because the
expression generator that was performing it isn't otherwise needed.

Fixes https://github.com/dart-lang/sdk/issues/34357.

Change-Id: Ia78c031565cad83961675fc4fb1cc871eaed01d3
Reviewed-on: https://dart-review.googlesource.com/c/78122
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-10-09 09:15:28 +00:00
Aske Simon Christensen 79e8b3d57f Make importing two libraries with the same name a warning 
Bug: https://github.com/dart-lang/sdk/issues/34612
Change-Id: I2697b56fb02d6bee8ea3bc2d06329100e287ae34
Reviewed-on: https://dart-review.googlesource.com/c/78242
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2018-10-09 06:56:13 +00:00
Kevin Millikin 0566f5fa27 Remove unnecessary test status lines 
* The co19_2 test suite doesn't have collection/Maps at all.  Though
  test.py will ignore the unnecessary test status lines, there is no
  reason to have them.

* The co19 test suite has these tests but they are not expected to
  pass with a Dart 2 SDK.  They are already skipped for all Fasta
  targets, so the individual expectations can be removed.

Change-Id: I4d4c27254d4ff7da5a49da77fb2314b5beb035c1
Reviewed-on: https://dart-review.googlesource.com/c/78500
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-10-08 14:29:48 +00:00
Mike Fairhurst 198b05279b Fix #33599 circular typedef stack overflow. 
Fix #33599 stack overflow for recursive function type parameters

Bug: 33599
Change-Id: I31a14e9f941bfd6bb7c2dba09f671d887e535b2a
Reviewed-on: https://dart-review.googlesource.com/c/76040
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-10-05 15:59:42 +00:00
Mike Fairhurst 765b8e2d66 More void cleanup 
Change-Id: I21e23ab6dec654242d049935e2665389e61dd3d7
Reviewed-on: https://dart-review.googlesource.com/c/78189
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-10-05 15:34:31 +00:00
Sergey G. Grekhov e8e9677fad [co19] co19_2 roll. 
* co19_2 tests enabled for vm-kernel CQ builders.

Change-Id: I5ccc27d1110c22960e550b060a7e140bc1ac68b1
Reviewed-on: https://dart-review.googlesource.com/c/76820
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2018-10-05 06:35:43 +00:00
Aske Simon Christensen bb2775b16a Only perform override check on declared members. 
The code in class_hierarchy.dart that looped over override pairs
included implementations inherited from its superclass as potential
overriders, presumably in a broken attempt to include some interface
checks into the mix.

With this problem fixed, the special case in kernel_class_builder.dart
that excluded overriders not declared in the current class (i.e.
declared in a mixin) could be removed without incurring false
positives.

These override checks performed on members from a mixin produce an
extra context message indicating the class where the two members meet,
giving rise to the override relation (similarly to interface checks).

Since the same member can now override more than one member (or even
the same member more than once), the diagnostics message duplication
check has been extended to also include the context in the comparison.

Fixes https://github.com/dart-lang/sdk/issues/34235
Fixes https://github.com/dart-lang/sdk/issues/34285

Change-Id: I990e5719ae1749fd1aad1ad478aaa6e173cb170b
Reviewed-on: https://dart-review.googlesource.com/c/76900
Reviewed-by: Daniel Hillerström <hillerstrom@google.com>
 2018-10-03 14:56:43 +00:00
Paul Berry 32af1be0a4 Check type arguments against bounds when instantiating a typedef. 
Change-Id: I38f390abd2c409694ad15cbc35654ba5dab9b9ce
Reviewed-on: https://dart-review.googlesource.com/77015
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-01 20:43:19 +00:00
Johnni Winther 41a875f420 Fix (super)mixins issues 
Change-Id: I5892f2fec7fc7b7449fb600c74e4d105dc0f4bbe
Reviewed-on: https://dart-review.googlesource.com/77180
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Auto-Submit: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-09-28 23:03:24 +00:00
Lasse R.H. Nielsen 429bca8e65 Make Uri.parse accept [ and ] in path, query and fragment. 
Also accept `#` in fragment.
Fix bug in parsing URI where first character of path needs escaping.
The characters are escaped, but parsing doesn't fail, like it previously
did on misplaced general delimiters in those places

Fixes #34451.

Bug: https://dartbug.com/34451
Change-Id: I99aa39bd2909661802ad9d1bb5dada94d579141b
Reviewed-on: https://dart-review.googlesource.com/74780
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-09-26 14:09:37 +00:00
Paul Berry b1a54154f8 Check that implicit type arguments satisfy bounds. 
This required adding an implementation of super-bounded types to the
analyzer.

We really could use some more tests to verify that we disallow
super-bounded types in all the appropriate locations, but allow it in
other cases (it seems that there are no language_2 tests to verify
this).  To avoid churn, I'll wait until I have confirmation that my
reasoning is correct in #34583 before submitting test cases.

Fixes #34532.
Fixes #34560.

Change-Id: I3c5def60bcac0d31b56bead31cb1aab445f18e96
Reviewed-on: https://dart-review.googlesource.com/76280
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-09-26 01:12:28 +00:00
Jens Johansen 570fd5a788 Error on re-export, export and import of libraries with same name. 
Fixes #12916.

Change-Id: Icef0f04f1575c8dad5f1cd23a9363f06fa2a2b35
Reviewed-on: https://dart-review.googlesource.com/74161
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-09-25 09:09:21 +00:00
Brian Wilkerson 95831136b4 Fix NPE when accessing superclass 
Change-Id: I64da591bfa33a5202b7bd15de451be84330cc8bb
Reviewed-on: https://dart-review.googlesource.com/75403
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-09-24 17:11:23 +00:00
Daniel Hillerström 7ad1e5da99 Perform substitution on type argument/parameter bounds. 
Fixes regression #34528. Introduces a new test to mitigate future
regressions.

Closes #34528.

Change-Id: Iaf0a8f44db2a8b4a8151c391ddb8dff69910fe3a
Reviewed-on: https://dart-review.googlesource.com/75840
Commit-Queue: Daniel Hillerström <hillerstrom@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2018-09-24 14:02:01 +00:00
Daniel Hillerström de984e58cb Type checking for redirecting factories. 
Implements static semantics for redirecting factories (c.f. §10.6.2 of
the specification). This CL does not include inference of actual type
arguments on redirectees, that is it does not handle the case where
type arguments have been omitted on the redirectee as in this
following example program:

  class A<T> {
    factory A() = B;
  }
  class B<T> implements A<T> {
    B();
  }

Closes https://github.com/dart-lang/sdk/issues/32988.

Also resolves the second part of
https://github.com/dart-lang/sdk/issues/30579.

Can possibly also close https://github.com/dart-lang/sdk/issues/11578.

Change-Id: I5f1fb60510ba6cdc917321239819c1f817b5b85d
Reviewed-on: https://dart-review.googlesource.com/74580
Commit-Queue: Daniel Hillerström <hillerstrom@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-09-19 06:20:20 +00:00
Stephen Adams c733ed7fd7 firefix status for LayoutTests/fast/dom/Range/getClientRects-character_t01 
TBR=whesse@google.com

Change-Id: I2b30bf344e0572afd431914ecc5ff7e2c5efc517
Reviewed-on: https://dart-review.googlesource.com/75384
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-09-18 20:01:56 +00:00
Johnni Winther 2da165a62d Stop compilation early on CFE compile-time errors 
Change-Id: Ie93af5880bbd0b9f0c72aa6c1832550bf9025595
Reviewed-on: https://dart-review.googlesource.com/75160
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2018-09-18 06:50:55 +00:00
Dan Rubel 49da026e3e Report error for extends void type parameters 
Change-Id: I634b836ea40199a1e7962b7d07ca9f5d1ef3f16a
Reviewed-on: https://dart-review.googlesource.com/74680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-09-13 20:27:56 +00:00
William Hesse e6a9551e58 Add 1 more flaky test on co19_2 chrome 
Change-Id: I56d044329baeba674ce5ba1ae9169b4b9d7b5a8f
Reviewed-on: https://dart-review.googlesource.com/74800
Reviewed-by: William Hesse <whesse@google.com>
 2018-09-13 14:03:12 +00:00
William Hesse 85e3251f05 Mark 3 flaky co19_2 tests on chrome 
TRB: sra@google.com
Change-Id: If49a98a07767a80b74023863a283608bec33e190
Reviewed-on: https://dart-review.googlesource.com/74781
Reviewed-by: William Hesse <whesse@google.com>
 2018-09-13 12:53:59 +00:00
Mike Fairhurst 4ee66c9708 Const evaluation for int2double 
Change-Id: I4673ab47d9dfcb8de62a5190a6dd2b9c79ef1d19
Reviewed-on: https://dart-review.googlesource.com/74496
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-09-13 00:02:54 +00:00
danrubel 4fe0088962 Report error if super on RHS of binary expression 
Change-Id: I6251d56f4df5ebb603b653a100fed2c643870c96
Reviewed-on: https://dart-review.googlesource.com/74601
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-09-12 18:10:26 +00:00