Commit Graph

262 Commits

Author SHA1 Message Date
Ben Konyi bb560bb233 [ VM / dart:io ] Adding to a closed IOSink now throws a StateError
Based off of these original changes:
https://codereview.chromium.org/2857393003

This is a breaking change and will require an annoucement stating such
before landing.

Fixes #29554.

Change-Id: Ibb56fd49648edc6b9fd567240a3bebb05a14234d
Reviewed-on: https://dart-review.googlesource.com/c/90120
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2019-01-25 19:23:56 +00:00
asiva 0a41a2d292 [ Test ] Remove support for flutter runtime from the test framework
Support for the flutter runtime (sky_shell) was added to the Dart
test framework in the hope that one could run the flutter engine
through the Dart test suite. We never got around to running these
tests on the build bots, the sky_shell executable has been deprecated
and there are plans in the flutter engine team to have their own
unit test frame work.

See Issue https://github.com/flutter/flutter/issues/9115 for more
details.

Change-Id: I6ee9e8c919721dccecf4202ab0778939aeb79174
Reviewed-on: https://dart-review.googlesource.com/c/91103
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2019-01-25 04:16:43 +00:00
Kevin Millikin afc7f47aaa Clean up co19_2 Kernel status files
Change-Id: I0a939b2d2cfafbf4971124168e8bdae02faad7f4
Reviewed-on: https://dart-review.googlesource.com/c/90820
Auto-Submit: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
2019-01-24 09:55:03 +00:00
Sergey G. Grekhov 581af6eb56 [co19] DEPS and status file updated
Change-Id: Ifd19de6d5482d2d00736078cb1858ee0a7a37fd9
Reviewed-on: https://dart-review.googlesource.com/c/89151
Reviewed-by: William Hesse <whesse@google.com>
2019-01-18 12:53:04 +00:00
Kevin Millikin b00193fa5f [Kernel] Signal an error for invalid native invocations
Calls to the factory constructor 'new List' can turn into static
invocations of a backend-specific factory function.  Signal an error
instead of crashing.

Change-Id: Id0a8a7f0f847c03225b7fa9da2351032d15522e0
Reviewed-on: https://dart-review.googlesource.com/c/90006
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
2019-01-17 15:12:04 +00:00
Kevin Millikin e36ad1dad0 [Kernel] Build an invalid constant for evaluation errors
An invalid constant is (currently) represented by an unevaluated
invalid expression.  Using this instead of null fixes 63 out of 125
CFE constant-evaluation crashes with constant-update-2018 and
correctly signals 26 more previously-missed compile-time errors.

Change-Id: I5b4de3995b3a59978dfa08fc542ef0f027572eb6
Reviewed-on: https://dart-review.googlesource.com/c/89506
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
2019-01-17 07:26:04 +00:00
Kevin Millikin 215f6620e7 [Kernel] Signal errors on static fields in constant contexts
Fasta allows some non-const static field access in constant contexts
which leads to the constant evaluator trying to evaluate them.  Signal
an error instead of crashing.  This will double-report errors for the
cases that Fasta already catches, and we should fix that
double-reporting.

Fix unbounded recursion in printing unevaluated constants (writeNode
called visitUnevaluatedConstant which called defaultConstant which
called writeNode...).

Fix a spurious trailing comma in printing of instance constants.

Change-Id: Idff3169a3a56432ad67c27ff9c267ef355c4c1dc
Reviewed-on: https://dart-review.googlesource.com/c/89514
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
2019-01-16 15:07:58 +00:00
Kevin Millikin 8a91948c03 [Kernel] Properly signal compilation errors for constants
Instead of simply printing a message, properly signal a Fasta problem for
constant errors.  This causes 68 tests (presumably missing compile-time
errors) to start passing with --enable-experiment=constant-update-2018.

Change-Id: Ia9f1809305bbef7b4652ce49acf6fb9c18408207
Reviewed-on: https://dart-review.googlesource.com/c/89580
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
2019-01-16 08:15:34 +00:00
Liam Appelbe df0671d664 [VM] Experimental flags in the dart CLI
Blocked on https://dart-review.googlesource.com/c/sdk/+/88840

Bug: https://github.com/dart-lang/sdk/issues/35602
Change-Id: I72b1cf574c9cb3d1dac2fbd8dfeb0f3fd80e330e
Reviewed-on: https://dart-review.googlesource.com/c/89042
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
2019-01-15 01:02:07 +00:00
Aske Simon Christensen 1842020a69 Fix empty set/map literal disambiguation rule.
The criterion for an empty set/map literal without type arguments to
become a set literal was implemented as "superclass of Set and not
superclass of Map". This CL changes it to the rule now stated in the
spec: "subtype of Iterable and not subtype of Map".

Change-Id: I52d3a11e29ed9b1feb0f2b52a3f4beebe3833e31
Reviewed-on: https://dart-review.googlesource.com/c/88828
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2019-01-11 15:14:05 +00:00
William Hesse 7e3f4516b8 Allow crashes on fasta compiler co19_2 tests of Constant-update2018. Needed to turn ci bot green.
Change-Id: I23cc564c01af0620a96c72cec72fdb512d81febc
Reviewed-on: https://dart-review.googlesource.com/c/88921
Reviewed-by: William Hesse <whesse@google.com>
2019-01-10 01:17:42 +00:00
William Hesse 3c9e2cf8c9 Update front-end compiler status for co19_2 tests
Change-Id: I2b7aa2b4d1ccc8000e7c15bcd9df0fcef6ed6890
Reviewed-on: https://dart-review.googlesource.com/c/88920
Reviewed-by: William Hesse <whesse@google.com>
2019-01-10 01:07:08 +00:00
William Hesse cb966bdce7 Unify parsing of co19 test options and regular test options.
Keeps comment that many test options should not be used in co19 tests.

Change-Id: Iacdc6a8d240d8fd5d6ac87fc5a16ff38978d2040
Reviewed-on: https://dart-review.googlesource.com/c/88704
Reviewed-by: Alexander Thomas <athom@google.com>
2019-01-09 17:05:41 +00:00
Stevie Strickland 3f797f1223 [gardening] Marking ListBase_class_A01_t03 as Slow.
Similar to the changes made in 78482496d5.

Change-Id: Iebaf87506bad7ed3927b52fef9134c514edafc7c
Reviewed-on: https://dart-review.googlesource.com/c/88576
Reviewed-by: Stevie Strickland <sstrickl@google.com>
Commit-Queue: Stevie Strickland <sstrickl@google.com>
2019-01-07 17:00:22 +00:00
Stevie Strickland 78482496d5 [gardening] Mark more large list sorts as slow.
These are tests split off from _A01_t02 in the resolution to
https://github.com/dart-lang/co19/issues/198.

Also removing the Timeout markers from the original tests,
since they should be smaller and thus no longer causing
timeouts.

Change-Id: I07699ae41a0c8e3f892cca5e29855b52fe7c2829
Reviewed-on: https://dart-review.googlesource.com/c/88570
Reviewed-by: Stevie Strickland <sstrickl@google.com>
Commit-Queue: Stevie Strickland <sstrickl@google.com>
2019-01-07 12:55:02 +00:00
Ben Konyi f1002ce11b [ Gardening ] Marked co19_2/LibTest/isolate/Isolate/kill_A01_t01 as Timeout, Pass.
Change-Id: I6d20f6d727aa89561c4cace0aaf51d4ae3ba4a33
Reviewed-on: https://dart-review.googlesource.com/c/88129
Auto-Submit: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-12-28 19:31:52 +00:00
Sergey G. Grekhov 1172c36c87 [co19] DEPS updated
Change-Id: Ia5d4bade61125f1726dd4be4c2a38de6d545d16f
Reviewed-on: https://dart-review.googlesource.com/c/87560
Reviewed-by: Alexander Thomas <athom@google.com>
2018-12-20 13:56:11 +00:00
Sigmund Cherem b7a1eb4aea Simplify co19_2-dart2js status file to only track skips
Yay new workflow!!! Woo hoo!

Change-Id: I2218468c4acbe42d0a079c88153ec0a1797ba2b7
Reviewed-on: https://dart-review.googlesource.com/c/87166
Auto-Submit: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-12-17 20:04:14 +00:00
Martin Kustermann 4949f89ae4 Skip faulty test co19/LibTest/io/File/openRead_A02_t01
Issue https://github.com/dart-lang/co19/issues/206

Change-Id: I505f9b2aa6ce34078cc4f81f5791fae2b6265e05
Reviewed-on: https://dart-review.googlesource.com/c/87324
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
2018-12-14 16:12:14 +00:00
Martin Kustermann 76fb4d5b11 [Gardening] Skip co19 tests affected by race until pull request lands
PR https://github.com/dart-lang/co19/pull/204

Change-Id: Id099b04120985d52bd2a255f82b784021d1af1df
Reviewed-on: https://dart-review.googlesource.com/c/87185
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
2018-12-13 18:15:25 +00:00
Brian Wilkerson b0cca3e82d Attempt to fix the bots
Change-Id: I81c161a3784c99116bb95521e335b75bdb44dab3
Reviewed-on: https://dart-review.googlesource.com/c/86981
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-12-11 21:09:01 +00:00
Sergey G. Grekhov 6a99a9a85f [co19] DEPS updated
Change-Id: I101eae9189848a699e4b186f363d9a684d7b2d02
Reviewed-on: https://dart-review.googlesource.com/c/85703
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-12-11 12:58:51 +00:00
William Hesse df8accc735 Merge analyzer branch into master
Some work on the Dart analyzer was done on a branch, to avoid disrupting
others, and is landed with this commit. It is a merge, in order to
preserve the history of work on that branch.
2018-12-05 11:47:28 +01:00
Alexander Markov 7fbd67a3fc [gardening] Update status for incorrect co19 test
Issue: https://github.com/dart-lang/co19/issues/195
Change-Id: I9091a16a4391cd204b324b8d1553a52910ccb767
Reviewed-on: https://dart-review.googlesource.com/c/86105
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
2018-12-04 23:11:30 +00:00
Paul Berry 0a4873bb35 Merge commit '191a09f540ac0516c4088fb8454c693743be8b3f' into analyzer 2018-12-04 09:41:55 -08:00
Daco Harkes f6852fa9c8 [gardening] Mark LibTest/collection/ListMixin/ListMixin_class_A01_t02 as ExtraSlow
Issue https://github.com/dart-lang/sdk/issues/35316

Change-Id: Iac3c038f9f447e52dd420ad1158cdf153aa99f3e
Reviewed-on: https://dart-review.googlesource.com/c/85943
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
2018-12-04 15:12:20 +00:00
Paul Berry 63770042aa Merge commit '80c23f87a3e3123d7e337c1fc8bc3b5ec49b34a0' into analyzer 2018-11-30 08:12:45 -08:00
Daco Harkes 20e819cbbe [gardening] Mark LibTest/io/FileSystemCreateEvent/isDirectory_A01_t06 flaky
The test makes assumptions about file system events firing synchronously with file system operations

Issue https://github.com/dart-lang/co19/issues/186

Change-Id: Ic54782662e453c240d92113d25f7a6897b268130
Reviewed-on: https://dart-review.googlesource.com/c/85684
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
2018-11-30 13:08:17 +00:00
Daco Harkes 40dd503b3a [gardening] Mark LibTest/io/RawDatagramSocket/singleWhere_A03_t01 failing
The test make assumptions about delivery order which UDP does not
provide

Issue https://github.com/dart-lang/co19/issues/195

Change-Id: I1c1ed618a68ea9e7a96e2733ed78095451aa5d89
Reviewed-on: https://dart-review.googlesource.com/c/85700
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
2018-11-30 10:49:03 +00:00
Paul Berry 5949a3f984 Merge commit '5a54f0eb577f0f4a1708ddbd4f69bf70458ff647' into analyzer 2018-11-27 08:34:40 -08:00
Paul Berry 0e275f123c Fix analyzer co19 status after d7ee7b9516
Change-Id: Id9277f2d98c289eeb187e9a3222cbc1c1d7a7a27
Reviewed-on: https://dart-review.googlesource.com/c/85400
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-11-26 18:47:27 +00:00
Stevie Strickland 10dac37103 [gardening] Marking slow tests as possible timeouts.
Followup to https://dart-review.googlesource.com/c/sdk/+/85200, since
these tests are timing out sporadically on the Mac debug build.

Change-Id: I43d58ce9c2ed56396c94974525594d62ec652101
Reviewed-on: https://dart-review.googlesource.com/c/85382
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Stevie Strickland <sstrickl@google.com>
2018-11-26 15:56:50 +00:00
Vyacheslav Egorov 682b9e3479 [gardening] Mark LibTest/io/RawDatagramSocket/close_A01_t01 failing
The test make assumptions about delivery order which UDP does not
provide

Issue https://github.com/dart-lang/co19/issues/195

Change-Id: I5278f8c38c0a23142285167590f3eb30f95fa8fd
Reviewed-on: https://dart-review.googlesource.com/c/85345
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-11-26 10:55:30 +00:00
Martin Kustermann a29f55e296 [VM] Mark tests slow after removing unsafe optimization for integer operation folding
Follow-up to https://dart-review.googlesource.com/c/sdk/+/84720

Change-Id: I25b5f8d51c225c8f088937580259d4fd9b8b40ed
Reviewed-on: https://dart-review.googlesource.com/c/85200
Reviewed-by: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
2018-11-22 16:23:14 +00:00
Samir Jindel 48fee5f591 Update status file for receive_A01_t01 and where_A01_t01.
Change-Id: I7f4b67c9682ae57523c228262220570031257da6
Reviewed-on: https://dart-review.googlesource.com/c/85172
Reviewed-by: Samir Jindel <sjindel@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
2018-11-22 15:07:40 +00:00
Martin Kustermann ad7fbb6dd7 [VM] Fix flow graph builder to not generate different code in unoptimized/optimized mode
Change-Id: I752be6bd97dcd892ea6ba5d7fdd30575d4cee489
Reviewed-on: https://dart-review.googlesource.com/c/84720
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-11-22 14:05:47 +00:00
Sergey G. Grekhov 8b2458c97b [co19] DEPS and .status file update
Change-Id: I718a5d70874e7090cb42f1d452cd8dcf020d337e
Reviewed-on: https://dart-review.googlesource.com/c/84631
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-11-22 11:28:15 +00:00
Daco Harkes 3f2b605b57 [gardening] Mark LibTest/io/Stdin/first_A04_t01 as flaky
Issue: https://github.com/dart-lang/co19/issues/193
Change-Id: I42cb92ce8bb624a9869d9c86594b807bbf606ffc
Reviewed-on: https://dart-review.googlesource.com/c/84639
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
2018-11-20 09:47:15 +00:00
Martin Kustermann e17960cee3 [Gardening] Mark co19 test as flaky and filed issue
Issue https://github.com/dart-lang/co19/issues/186

Change-Id: Id15b08a4d1483431a8f8b2ad0224e0d672d61878
Reviewed-on: https://dart-review.googlesource.com/c/83387
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
2018-11-07 12:46:59 +00:00
Martin Kustermann 660f64ed6b [Gardening] Mark test as flaky, reference existing co19 issue
Issue https://github.com/dart-lang/co19/issues/184

Change-Id: I20f08b6e494ca50b17d78d25ff422fd34153ef89
Reviewed-on: https://dart-review.googlesource.com/c/83384
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
2018-11-07 11:47:55 +00:00
Sergey G. Grekhov 7df494cecc [co19] DEPS updated to the latest co19_2 commit
Change-Id: I8e37c6dc29dc5ee00525364bfdb6eaee02a37416
Reviewed-on: https://dart-review.googlesource.com/c/82202
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-11-07 08:30:38 +00:00
Sigmund Cherem c1523d45de Status bingo: and the fight continues...
TBR=johnniwinther@google.com,sra@google.com

Change-Id: I2c258c16c409bd73a2e8d101ff49396e260f7016
Reviewed-on: https://dart-review.googlesource.com/c/82761
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-11-02 23:24:22 +00:00
Sigmund Cherem 7f84476dff Status bingo: more updates to FF and Safari status files...
TBR=johnniwinther@google.com,sra@google.com

Change-Id: I8ea752da987bcb3e356898de0710d16fb72e75d8
Reviewed-on: https://dart-review.googlesource.com/c/82708
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-11-02 21:47:17 +00:00
Sigmund Cherem 4098beae73 Status file bingo: attempt to make FF and Safari green again
TBR=sra@google.com

Change-Id: I1ba896bd6a3b37df517f1aadd0177a9c18c3308f
Reviewed-on: https://dart-review.googlesource.com/c/82660
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-11-02 17:32:14 +00:00
Jens Johansen 993f7260c1 Labeled variable declarations shouldn't introduce a new scope
Before, e.g.
```
main() {
  L: var x, y;
  x = 42;
  y = x;
}
```

would produce something like
```
static method main() → dynamic {
  {
    dynamic x;
    dynamic y;
  }
  x = 42;
  y = x;
}
```

i.e., the variable declaration was in another scope, and their usage
isn't legal.

This CL fixes that by either
a) (the normal case) not wrapping it --- the label is not used anyway.
b) (the case that cannot happen) put a label on the first part so the
   output would be something like
```
  L: dynamic x;
  dynamic y;
  x = 42;
  y = x;
```

Fixes #34943.

Change-Id: I24132665dab53fb8fb024f73dd11e0d1f1945812
Reviewed-on: https://dart-review.googlesource.com/c/82063
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-11-02 10:20:42 +00:00
Ben Konyi a828f48c6e [ VM / Gardening ] Mark co19_2/LibTest/io/FileSystemEntity/identical_A01_t06 as flaky (see issue #183)
Change-Id: I6a1bf438fd7760c0670dfc7d02486bd30600b67a
Reviewed-on: https://dart-review.googlesource.com/c/82540
Auto-Submit: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-11-02 05:27:23 +00:00
Martin Kustermann aaf5d7f7de [Gardening] Mark LibTest/io/Stdin/last_A02_t01 as flaky
Issue https://github.com/dart-lang/co19/issues/182

Change-Id: Iaa22c02be11283b47f664a63f0cc3fe8a662dea9
Reviewed-on: https://dart-review.googlesource.com/c/82444
Reviewed-by: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
2018-11-01 15:04:47 +00:00
Daco Harkes 24190318a2 [gardening] mark another co19 RawDatagramSocket test as flaky
Issue: https://github.com/dart-lang/co19/issues/170
Change-Id: I4224d9d9796b94f9ee8485171fd0be4791d6d80a
Reviewed-on: https://dart-review.googlesource.com/c/82206
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
2018-10-31 10:02:26 +00:00
Johnni Winther a09ec46da6 Test in-memory serialization/deserialization in test-mode
+ fixes for switch and continue

Change-Id: I1f4fb9327b9db08eb69f750a66073affe2659f7d
Reviewed-on: https://dart-review.googlesource.com/c/81603
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-10-30 11:18:24 +00:00
Jens Johansen a1293f1591 test.py -c fasta: Enable asserts and verify
Change-Id: Ie7ff93cb552a0b2ae8e11078dd19358d199889d1
Reviewed-on: https://dart-review.googlesource.com/c/82040
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2018-10-30 08:34:03 +00:00