dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

262 Commits

Author SHA1 Message Date
Dmitry Stefantsov 4a1b153fe1 [cfe] Enable type promotion in if-elements of literal collections 
Closes #36396.

Bug: http://dartbug.com/36396
Change-Id: I223267cdee1aca38d69354e4f97df7dcc76e9553
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98461
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-04-02 13:33:19 +00:00
Mayank Patke ba473d579f Unskip co19_2/Control-flow-collections for dart2js. 
We fail the following:
* type_promotion_A01_t01
* static_errors_A04_t01/01
* static_errors_A04_t01/02
* const_collections_A02_t02/01
* const_collections_A02_t02/03
* const_collections_A02_t02/04

Change-Id: Id568d5ab6ea2047f4bc0ff0d212ae22b6a9ee22f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98444
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-04-02 01:16:53 +00:00
William Hesse 1e77c187c8 Update front-end status for added tests and changed results 
Added tests and changes to constant implementation have changed
the result of the front-end compiler on some tests.

Change-Id: I112027f2ca5ed72cc640ce01f577e498020866f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98356
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-04-01 15:52:08 +00:00
William Hesse dc1f6b352a Update front-end status for co19 roll 
This adds some missing status file fixes for the latest co19 roll.
That roll was https://dart-review.googlesource.com/c/sdk/+/98344

Change-Id: I0b7f6ecd993d1a7bfeced7ca4f4d1a7b6a118cd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98354
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-04-01 12:02:55 +00:00
Dmitry Stefantsov e0a2651ce0 [cfe] Fix downcasts added during set/map disambiguation 
Change-Id: I79d559c756994424eb395ecc8f12f84c1bf1e257
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98327
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-03-29 17:18:55 +00:00
Aske Simon Christensen fb58826aa3 [CFE] Compensate for lowering and desugaring in spread. 
This fixes a problem where a set or map in a spread would not be
properly recognized by the constant evaluator when compiling for a
VM target.

Fixes https://github.com/dart-lang/sdk/issues/36387

Change-Id: I01efc932994c143fa5a5a2fbacda21fe9206e3e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98330
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-03-29 16:59:06 +00:00
William Hesse 00d65e2d84 Roll co19 to revision c3b33ee 
Rolls the version of co19 tests in the SDK checkout to
c3b33ee90c5ee7f88fdb0ead08fdbb40c54954d2

Change-Id: I11a181e2fb1e37ff73fb038cd51b3ad38e2a0ae9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98344
Reviewed-by: Jonas Termansen <sortie@google.com>
 2019-03-29 16:22:42 +00:00
Sergey G. Grekhov a506c708f2 [co19] DEPS updated 
Change-Id: Idf7c5bab05f7247853bf3e2f2accbc96e2f8550f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98181
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-29 10:31:48 +00:00
Vijay Menon bc0148cf87 [ddc] Skip unsupported co19 tests on ddc/ddk 
Change-Id: I3a365828a6e7c0f5060238bf65eb11512b66934b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98160
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2019-03-28 19:03:33 +00:00
Aske Simon Christensen 018fd36557 [CFE] Handle spread and if in const map literals. 
Change-Id: I5250a115c1c98849a695e1d159532a49605c7caf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98014
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-03-28 15:00:58 +00:00
Aske Simon Christensen b5be157e09 [CFE] Handle spread and if in const set literals. 
Change-Id: I7db79282c1caafb2f8f07cd676e4bbe0941cd264
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98009
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-03-28 15:00:58 +00:00
Aske Simon Christensen 102b1fa39e [CFE] Handle spread and if in const list literals. 
Change-Id: I534dcd2e02d8d70b83b55a4890fb1a6e1bf6170d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97307
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-03-28 15:00:58 +00:00
Aske Simon Christensen 665d2d0003 [CFE] Leave const collections to the constant evaluator. 
Change-Id: Ib828bfa7f5695657e9e5ca67f7a9c3868a2a8fa1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97936
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-03-28 15:00:58 +00:00
Dmitry Stefantsov 864b22d3ce [cfe] Add inference and type checks to if-elements in maps 
Change-Id: I3cacaee173320dd52bead6688fac24e4e4a01f0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97962
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-28 12:30:41 +00:00
Sergey G. Grekhov f12715354a [co19] DEPS updated 
Change-Id: Ic4b915c1b1fe355577da564ca57d1d6a5c714ee6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97980
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-03-27 14:49:31 +00:00
Sergey G. Grekhov 4256a97a3d [co19] DEPS file updated 
Change-Id: I9a691a5efc92cc3a32feca683df7c6ec934cce11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97900
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-03-27 08:08:05 +00:00
Dmitry Stefantsov fbc70da0d3 [cfe] Add inference and type checks in for-elements in lists and sets 
Change-Id: Ib8e85f674caf0565b25cf29642f4981a4a1534e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97934
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-26 17:23:10 +00:00
Dmitry Stefantsov 49a7fa1c11 [cfe] Add inference and type checks for if-elements in lists and sets 
Change-Id: Iad4e6a6ed86e17f97f6bb7ad16f2bff20ab84fae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97925
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-26 17:23:10 +00:00
Kevin Millikin 1af9f99a5f [cfe] Compile loops in map literals 
Add support for compiling for and for-in loops in map literals.  They
are lowered to block expressions.

Change-Id: I555401257ba028543310edbd0547166d7c6a26a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97929
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-03-26 13:45:52 +00:00
Kevin Millikin ac21076110 [cfe] Implement compilation of loops in lists and sets 
Implement the translation of for and for-in loops in non-const lists
and sets.  They are lowered to block expressions containing a loop.
It is impossible to target these loops with a break or continue
because they do not contain statements in their body.

Type inference is not yet implemented.

Change-Id: I35ff1650fde54cd376fe0b444891010435c74507
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97922
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-03-26 12:16:22 +00:00
Kevin Millikin e5374a688c [cfe] Add front-end support for for and for-in 
In collection literals, support for and for-in in Fasta's body
builder.  They are removed when encountered during type inference and
their lowering to block expressions is not yet implemented.

Change-Id: I41e6a7a4aca7ffafdc12119e1503e9c0df5a6589
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97628
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-03-26 09:45:29 +00:00
Aske Simon Christensen 2ce1af9cbe [CFE] Constant evaluation of newly added operators 
Change-Id: I2fa73e458035a5703536faccbe8b90eb5e86d2be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97509
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-03-25 12:56:10 +00:00
Aske Simon Christensen 133d1b5afe [CFE] Allow 'as' and 'is' expressions as constants. 
Also clean out obsolete status file entries due to renamed constant
update test directory.

Change-Id: I135d8c9cac19342143bf8154d1b2e72cf0b8dd01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/93161
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-03-25 09:17:58 +00:00
Sergey G. Grekhov 578249629d [co19 DEPS updated] 
Change-Id: Idb3b63052e2981e8a4fc163a7461be1d53a577f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97303
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-20 10:41:31 +00:00
Kevin Millikin 4daa9b94ea [cfe] Compile if elements in lists and sets 
If elements are compiled to if statements.  The type inference rules
including insertion of runtime checks are not yet implemented.

Change-Id: Iaa7ab709a7acacf952887b17ac1081a9fecd7cef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97200
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-03-20 08:43:03 +00:00
William Hesse d6ffee639b [co19] Roll co19 
Change-Id: I9fa1568bc172636b2ed3d1c2f73e88d9d3950ba1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96947
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-15 12:05:39 +00:00
Kevin Millikin c9e9b76d4d Skip control-flow-collections tests on all runtimes 
This feature is under development in the front end.  Testing it on the
runtimes leads to numerous spurious status changes.  Skip the tests
for now.  The intent is that when a backend change causes a test to
start passing, then that test will be un-skipped.

Change-Id: I6c8c1f45315607039240c3edc61ba8340ae9cda0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96902
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-03-14 13:09:07 +00:00
Kevin Millikin 9aea5536fb [cfe] Initial support for compiling if in collections 
Support compiling if elements and map entries by constructing
IfElement or IfMapEntry when they are seen.  There is no support for
lowering them to block expressions yet.

Change-Id: I74c2492fefc9703e9e2f639baad7f737bbe63721
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96786
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-03-14 10:08:36 +00:00
Sergey G. Grekhov 8436dca626 [co19] DEPS updated 
Change-Id: I487418f0a8a1cad37585d985ac2da6807556b4f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96620
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-03-13 12:12:06 +00:00
Dmitry Stefantsov 1ce3e8af71 Reland "[cfe] Handle spread map entries of static type Null" 
This is a reland of ccd2c85a1a

Original change's description:
> [cfe] Handle spread map entries of static type Null
> 
> Change-Id: I164b3fa471deb65da93ecfd60ee836ec22eb93e1
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96080
> Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
> Reviewed-by: Kevin Millikin <kmillikin@google.com>

Change-Id: I4519970d8259481e137424f3506b7fb97307b14a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96134
Reviewed-by: Régis Crelier <regis@google.com>
 2019-03-08 19:05:19 +00:00
Régis Crelier afccd8cbc7 Revert "[cfe] Handle spread map entries of static type Null" 
This reverts commit ccd2c85a1a.

Reason for revert: very red bots, gardener not going to blindly approve all redness

Original change's description:
> [cfe] Handle spread map entries of static type Null
> 
> Change-Id: I164b3fa471deb65da93ecfd60ee836ec22eb93e1
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96080
> Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
> Reviewed-by: Kevin Millikin <kmillikin@google.com>

TBR=dmitryas@google.com,askesc@google.com,kmillikin@google.com

Change-Id: Ia8f60993222851a73291662f75556b2e4111a6f0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96123
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2019-03-08 17:19:35 +00:00
Dmitry Stefantsov ccd2c85a1a [cfe] Handle spread map entries of static type Null 
Change-Id: I164b3fa471deb65da93ecfd60ee836ec22eb93e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96080
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-08 15:46:31 +00:00
Dmitry Stefantsov 52ff930338 [cfe] Desugar map spread entries in non-const map literals 
Change-Id: Ie8f6cc0294888716f4e0349ba07320e684e26e1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95640
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-08 12:08:42 +00:00
Aske Simon Christensen 99093c0610 [fasta] Required but not inferred constant context. 
Add a new kind of constant context in the body builder for expressions
that must be constant but where constness is not inferred.

This context is used for parameter default values and initializing
expressions for non-final fields in classes containing at least one
const constructor.

Fixes https://github.com/dart-lang/sdk/issues/34191

Change-Id: I200ca88586b19335b185dad0839dfad4eef1f75f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/93520
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-03-05 09:23:57 +00:00
Sergey G. Grekhov 2c087433db [co19] DEPS and status files updated 
Change-Id: I75e42be513c65799bcb9332a5c4614c00461ec85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94283
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-04 15:35:31 +00:00
Dmitry Stefantsov 2c8f70cde3 [cfe] Add type inference for spreads in set literals 
Change-Id: I60250ec4ba7dba2381d84328095d38cf47b4ea8b
Reviewed-on: https://dart-review.googlesource.com/c/94548
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-01 15:17:13 +00:00
Kevin Millikin 5f095b7039 [Fasta] Add support for spread in map literals 
Spreads are compiled as if they were spread elements in list or set
literals.  When one occurs in a map literal it is translated to a new
spread map entry.

Change-Id: Ic618b1e85e595b4c2cd65e184b9d2c49e9c34b79
Reviewed-on: https://dart-review.googlesource.com/c/94547
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-02-28 06:05:00 +00:00
Kevin Millikin a9ef31ba43 [Fasta] Add Kernel syntax for spread elements 
Add spread elements to the Kernel syntax.  They are currently replaced
by an invalid expression during type inference.

Change-Id: Icdb489e2c9993c6517983cfafdefc801ebb378ab
Reviewed-on: https://dart-review.googlesource.com/c/94501
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-02-27 11:48:12 +00:00
Dan Rubel 58cea93953 Update BodyBuilder to use handleLiteralSetOrMap 
This is the second of several CLs updating the parser and its listeners
to conform to the unified collection spec:
https://github.com/dart-lang/language/pull/200

Change-Id: I5c277d05a3726a3f5a40823cf878f025167340e6
Reviewed-on: https://dart-review.googlesource.com/c/93741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-02-22 17:31:24 +00:00
Sergey G. Grekhov 70e300fea0 [co19] DEPS updated 
Change-Id: I487933deef8968e2c82904a895ea948831fcd9ff
Reviewed-on: https://dart-review.googlesource.com/c/92700
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-02-14 09:02:50 +00:00
William Hesse 65ac1d08d9 Dartdevc co19 tests - skip co19_2 tests that time out 
Change-Id: Ibb27bda2462c673f2e3442fcb80c41ee5e62154a
Reviewed-on: https://dart-review.googlesource.com/c/92425
Reviewed-by: William Hesse <whesse@google.com>
 2019-02-08 13:33:41 +00:00
William Hesse 392a869ee4 [infra] Skip all co19_2 tests that are timing out on dartdevc. 
The deflaking phase of testing is breaking when trying to handle
too many timing-out tests at once, stopping the builder runs.
Skipping them until we can debug the problem.

Change-Id: Id3243d8123465ca119262028dfe04d18d41b48c6
Reviewed-on: https://dart-review.googlesource.com/c/92139
Reviewed-by: Vijay Menon <vsm@google.com>
 2019-02-06 17:25:25 +00:00
Kevin Millikin 0828d2c786 [Fasta] Implement exact types for Set literals 
Set literals have an exact type of Set<T> for some T.  An implicit
downcast to a subtype is a static error.

Change-Id: I922b078b1b9e595243520e73c7130c23fe91f454
Reviewed-on: https://dart-review.googlesource.com/c/91640
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-02-05 07:43:52 +00:00
Alexander Markov b59d5a2be9 [vm] Relax assertion about duplicated direct implementors 
When mixin application is transformed, mixin is added to the end of
interfaces list. This may cause assertion failure if the same class
is used as mixin and mentioned among implemented interfaces.
This CL relaxes that assertion for mixins as this duplication is very
rare and seems harmless.

Note that it would not be valid to remove duplicated interface/mixin
from the list of interfaces, as it would break dart:mirrors in this case:
dart:mirrors needs to reflect duplicated interface/mixin both in
ClassMirror.superinterfaces (which is populated from the
list of interfaces without last element) and ClassMirror.mixin (the last
element in the list of interfaces).

Fixes https://github.com/dart-lang/sdk/issues/35854

Change-Id: I9b986f7759a76cb6f963ebd837e9ea26f6242f8e
Reviewed-on: https://dart-review.googlesource.com/c/91961
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2019-02-05 00:35:02 +00:00
Alexander Markov 8231cdb7a3 [gardening] Update status for issue 35854 
Issue: https://github.com/dart-lang/sdk/issues/35854
Change-Id: Iea1fca6d203741cf7b7962c90c2170e91910a651
Reviewed-on: https://dart-review.googlesource.com/c/91960
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2019-02-04 22:53:42 +00:00
Alexander Markov 569ee07f91 [vm] Cleanup class finalization checks 
Change-Id: If262b5fd271ce8fa0aaa49959f808792f66578cd
Reviewed-on: https://dart-review.googlesource.com/c/90580
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2019-02-04 21:00:49 +00:00
Konstantin Shcheglov b196cd2acb Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden. 
Downgrade INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_NAMED and INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_POSITIONAL to warnings.

Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: I4399839e04135a5d9a557c0ab06f319d9759af23
Reviewed-on: https://dart-review.googlesource.com/c/91460
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-29 22:35:15 +00:00
Paul Berry ec5ba8a252 Revert "Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden." 
This reverts commit 6699384ddd.

Reason for revert: Breakages in Flutter - see https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8923238548150736816/+/steps/analyze_flutter/0/stdout

Original change's description:
> Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden.
> 
> R=​brianwilkerson@google.com, paulberry@google.com
> 
> Bug: https://github.com/dart-lang/sdk/issues/34437
> Change-Id: Ic54d2e074bc764376f970c9c29ba260e7a373d93
> Reviewed-on: https://dart-review.googlesource.com/c/91170
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: I07c96c8131c16b2748a403f38d5f15b814131c63
Reviewed-on: https://dart-review.googlesource.com/c/91360
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-01-28 17:09:24 +00:00
Konstantin Shcheglov 6699384ddd Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: Ic54d2e074bc764376f970c9c29ba260e7a373d93
Reviewed-on: https://dart-review.googlesource.com/c/91170
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-26 20:12:55 +00:00
Liam Appelbe c167cd3572 [VM] Experimental flags in dartkp tests 
Plumb experimental flags found in a test's SharedOptions through to the
gen_kernel command invoked in dartkp tests. Also enable a whole bunch
of tests that are now passing.

Bug: https://github.com/dart-lang/sdk/issues/35602
Change-Id: I425f55ea6c84d28e085ab2c848376e396e68a225
Reviewed-on: https://dart-review.googlesource.com/c/90860
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-01-25 19:47:40 +00:00