dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1605 Commits

Author SHA1 Message Date
John McCutchan 0f13b9c931 Allow Dart code to register service protocol handlers 
- Add 'registerExtension' to dart:developer
- A service protocol handler must implement ServiceExtensionHandler
- Service extensions can report result OR error code / message

R=turnidge@google.com

Review URL: https://codereview.chromium.org//1270103002 .
 2015-08-06 16:20:56 -07:00
Todd Turnidge 38b9945cfd Improve display of library dependency information. 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1276013002 .
 2015-08-06 12:55:33 -07:00
Todd Turnidge 227010d9dc Order the vm's isolate list by isolate start time. 
This has the effect of making isolate lists more predictable for the user.

BUG=23717
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1275713002 .
 2015-08-06 10:17:07 -07:00
Todd Turnidge f73b8aa019 Resolve some input focus issues for the debugger. 
We were dropping clicks with selection type "None" on the floor, mistakenly.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1275543004 .
 2015-08-05 12:43:20 -07:00
John McCutchan a2757141b0 Make dart:developer log more user friendly 
- Make required arguments required.
- Validate required arguments in Dart before calling native.
- timestamp is now a DateTime.
- level has a default (ALL).
- sequence number is last + 1 if not provided.

R=lrn@google.com

Review URL: https://codereview.chromium.org//1266053003 .
 2015-08-04 07:12:39 -07:00
John McCutchan 7640cf4b85 Fix test failure 
patch from issue 1271693003 at patchset 20001 (http://crrev.com/1271693003#ps20001)

Review URL: https://codereview.chromium.org//1270953003 .
 2015-08-04 07:05:34 -07:00
Todd Turnidge 2eeb8ef945 Fix failing version test. 
BUG=
R=nweiz@google.com

Review URL: https://codereview.chromium.org//1267183002 .
 2015-08-03 15:12:44 -07:00
Todd Turnidge 401075fbbf Remember when a variable has been expanded/unexpanded in the debugger. 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1269083006 .
 2015-08-03 14:54:23 -07:00
Todd Turnidge fa1d1e9faf Observatory fixes: 
- Fix bug where we incorrectly tell the user to use "anext".
- Allow debugger input box to retain focus when curly-blocks are expanded.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1265153005 .
 2015-08-03 13:16:30 -07:00
John McCutchan 868109bf97 Auto scroll debugger console text only when already scrolled down 
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1263853004 .
 2015-08-03 12:50:50 -07:00
John McCutchan 33831aaa6b Add log support to debugger 
- Add 'log' command to control log level.
- Manage Logging stream subscription whenever isolate changes.
- Rename _VMStreamPrinter to _ConsoleStreamPrinter.
- Pipe log events to _ConsoleStreamPrinter.

R=turnidge@google.com

Review URL: https://codereview.chromium.org//1258063005 .
 2015-08-03 12:42:59 -07:00
John McCutchan fbb32461d8 Stop unnecessary Observatory rebuilds 
*) Turns out that gyp generates broken Makefiles when a target has more than one output. Avoid this bug by changing Observatory targets to have one output.
*) NOTE: generate_snapshot_bin still has two outputs and will always rebuild because of this.
*) Some misc. cleanups to observatory.gypi (removing redundant dependencies / inputs).

R=zra@google.com

Review URL: https://codereview.chromium.org//1270033002 .
 2015-08-03 10:04:27 -07:00
John McCutchan 319b274362 Stop displaying inline, optimized, and unoptimized tags next to functions in profile tree 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1269843007 .
 2015-07-31 15:04:55 -07:00
John McCutchan 390a44ccdf Make Observatory analyzer clean 
BUG=

Review URL: https://codereview.chromium.org//1267033002 .
 2015-07-31 14:57:55 -07:00
John McCutchan fc2d849cd5 Fix http requests and the crash dump RPC 
- Fix HTTP and crash dump service requests by giving them a non-null id.
- Add basic heartbeat test for _getCrashDump RPC over HTTP.
- Fix some analyzer warnings.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1266943005 .
 2015-07-31 14:38:04 -07:00
Daniel Andersson 40fc14d75a Fix incorrect expectation in allocations_test. 
The old code worked most of the time, since the Foo objects were usually not promoted to oldspace.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1269553004 .
 2015-07-31 14:34:23 -07:00
John McCutchan 4e9716ee40 Update view footer with github bug report url 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1254413011 .
 2015-07-31 14:23:45 -07:00
John McCutchan de035901a1 Introduce two utility elements for the cpu profiler 
- Add <sample-buffer-control> which manages fetching a sample buffer from an isolate.
- Remove duplicate code by using <sample-buffer-control> in both the tree and table profile views.
- Add <stack-trace-tree-config> which manages how a stack trace tree should be displayed (function or code objects, bottom up or top down).
- Remove duplicate code by using <stack-trace-tree-config> in both the tree and table profile views.

This is the first of many CLs refactoring the CPU profile related code in Observatory. This introduces some naming inconsistencies (CpuProfile vs. SampleBuffer) that will converge to SampleBuffer over time.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1266193003 .
 2015-07-31 14:19:17 -07:00
Rico Wind 93ec16c34c Nuke some whitespace in observatory 
R=johnmccutchan@google.com
BUG=

Review URL: https://codereview.chromium.org//1255273007 .
 2015-07-30 17:47:50 +02:00
Natalie Weizenbaum 61ea0618ce Support JSON-RPC 2.0-compatible VM service events. 
This adds a parameter to streamListen that will cause it to produce JSON-RPC
2.0-compatible events.

R=turnidge@google.com

Review URL: https://codereview.chromium.org//1257943003 .
 2015-07-28 17:17:40 -07:00
John McCutchan d9394ac865 Fix exception on first navigation to metrics page 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1262003002 .
 2015-07-28 16:13:09 -07:00
Ryan Macnak 8c98455ab5 Retaining path improvements. 
- Don't answer retaining paths that go through ICData.
 - Associate edge labels with the referer instead of the referent.
 - Give edge labels for VM classes (offsets only).
 - Make is possible to distinguish closures and functions from their refs.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1246073005 .
 2015-07-28 15:56:10 -07:00
John McCutchan d3154f4247 Logging page 
- Per isolate logging page.
- Drop down to control log level threshold.
- Console area where messages are displayed.
- UI test.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1250853006 .
 2015-07-22 14:33:13 -07:00
Ryan Macnak f26050ce08 Automatically step past async state-machine switch for 'anext'. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1244983002 .
 2015-07-21 10:36:00 -07:00
John McCutchan bfd2d4ed2a Refactor dart:developer log to use named parameters 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1247803002 .
 2015-07-21 10:01:37 -07:00
John McCutchan 9a90002eda Add missing toInt call 
BUG=

Review URL: https://codereview.chromium.org//1243893003 .
 2015-07-21 08:48:30 -07:00
John McCutchan f818f9dc0f Support piping log data over the service protocol 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1241683005 .
 2015-07-21 07:54:46 -07:00
Ryan Macnak ba27c453ed Remove a source of flakiness from async_step_test. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1234783007 .
 2015-07-20 10:21:45 -07:00
Ryan Macnak 4b5d321682 Add prints to help diagnose flaky async_step_test failure. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1234203003 .
 2015-07-17 11:08:02 -07:00
Ryan Macnak 7663e4a894 Rename 'astep' to 'anext' to better reflect its semantics. 
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1243523002 .
 2015-07-16 17:34:34 -07:00
Ryan Macnak 0979a7b23e Async-step, first cut. 
Also fix inclusion of internal variables from outer scopes in var descriptors.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1241673003 .
 2015-07-16 13:05:37 -07:00
Ryan Macnak c165fee611 Insert debug step check at the beginning of a function. 
BUG=http://dartbug.com/23827
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1237203002 .
 2015-07-14 15:27:44 -07:00
John McCutchan 4747a63ad6 Factor cpu profile tree into separate element and expose allocation tracing UI 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1241653002 .
 2015-07-14 13:56:45 -07:00
John McCutchan b6b3c3e93b Make observatory tests analyzer clean 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1238803002 .
 2015-07-14 13:49:08 -07:00
Todd Turnidge f544a3c3ca Fix problem when running new test in checked mode. 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1237893002 .
 2015-07-14 13:43:23 -07:00
Todd Turnidge e4684c7627 Provide stdout and stderr output in the Observatory debugger. 
Implement two new streams, 'Stdout' and 'Stderr' in the service protocol.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1232193003 .
 2015-07-14 12:54:07 -07:00
Todd Turnidge a02c7694c5 Make random clicks in the debugger give the command line input focus. 
If the user selects a range, respect that.

Add some inner spacing on the command line input box.  Makes it feel
less claustrophobic.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1233053002 .
 2015-07-14 12:35:32 -07:00
John McCutchan a92a3c8af3 Expose allocation tracing over service protocol 
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1231603008 .
 2015-07-14 11:41:57 -07:00
John McCutchan 07a927e74d Do not report Observatory analytics when running in Dart 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1236223002 .
 2015-07-14 11:34:55 -07:00
Ryan Macnak 1ef2b68e65 Deal with Javascript integer limitations in heap snapshot processing to handle 64-bit target VMs. 
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1219103002 .
 2015-07-13 17:27:55 -07:00
Srdjan Mitrovic a3e1db6263 Fix --compile_all flag (--compile-all is wrong) 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1230883002 .
 2015-07-09 13:16:37 -07:00
Todd Turnidge c4dad3117a Make VM event streams look like real dart streams. 
This is a bit ugly in that vm event streams are created
asynchronously, which is not very natural with the dart libs.

Update tests accordingly.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1217823009 .
 2015-07-08 14:18:59 -07:00
Kevin Moore 161c40f24d ignore .packages file in runtime/observatory 
TBR

Review URL: https://codereview.chromium.org//1220953002.
 2015-07-01 07:50:33 -07:00
Ryan Macnak f84461ed48 Observatory improvements for exploring compiled code. 
- Views for ObjectPool, Instructions, ICData.
 - Allow querying retained size of non-Instances.
 - References to non-Dart functions as links.
 - Find ic data array from a Function.
 - Fix NPE when current token position in a script inset cannot be mapped.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1212933003.
 2015-06-26 14:29:49 -07:00
Ryan Macnak 69938db31a Include pattern and functions for RegExps over the service protocol. 
Remove some quadratic behavior from processing/display of Code in Observatory, so we can actually look at 300k regexp instructions.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1208153002.
 2015-06-25 12:56:59 -07:00
Ryan Macnak e747d0516b Observatory UI tweaks. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1194103002.
 2015-06-19 14:26:34 -07:00
John McCutchan b4e416dde8 Fix analyzer error in get_ports_rpc_test.dart 
BUG=

Review URL: https://codereview.chromium.org//1196663004.
 2015-06-19 10:41:33 -07:00
John McCutchan b4c1344100 Add _getPorts rpc test 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1194893002.
 2015-06-19 09:52:37 -07:00
Ryan Macnak 723334d344 UI for setting/clearing closure-specific breakpoints. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1191133002.
 2015-06-18 14:01:19 -07:00
John McCutchan 851ef4a4af Ports page for isolates 
Per isolate list of open ports and their handler

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1189543003.
 2015-06-18 10:24:28 -07:00