d4d8098029
Roll observatory_pub_packages to 5c199c5954146747f75ed127871207718dc87786
...
BUG=
R=whesse@google.com
Review URL: https://codereview.chromium.org/1400023002 .
2015-10-13 10:17:41 -07:00
8341085f11
Add view for MegamorphicCache. Update view for ObjectPool.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/1392953003 .
2015-10-12 13:57:48 -07:00
49b627c366
Shrink by 33% the allocation profile pie charts
...
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org/1401763003 .
2015-10-12 13:08:53 -07:00
fc3baf97e3
Fix class hierarchy display
...
- Left align 'Class'
- Increase minimum width for expander to be 2em (fixes offset problem)
R=turnidge@google.com
Review URL: https://codereview.chromium.org/1395423002 .
2015-10-12 13:01:02 -07:00
53ebbc968b
Fix bad isolate summary charts
...
Charted charts persist some DOM children in the element and Polymer sends multiple attached() events, resulting in a stale chart svg element offsetting the current one.
Fix is simple- remove stale elements in detached().
R=turnidge@google.com
Review URL: https://codereview.chromium.org/1401113004 .
2015-10-12 12:53:30 -07:00
9dd7680fd8
Straw man setExceptionPauseMode
...
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org/1399743002 .
2015-10-12 11:04:44 -07:00
435bcdbe6c
We can now name the current VM using the service protocol.
...
Adds a 'VM' stream and a 'VMUpdate' event.
Makes Event.isolate optional in service.md.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/1398823002 .
2015-10-08 15:37:49 -07:00
97c643a5f4
Improve isolate list. Expose isolate origin.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/1395693003 .
2015-10-07 14:35:01 -07:00
228e527793
Reload an isolate once it is runnable.
...
This makes sure that an isolate has its rootLib properly initialized.
This issue came up while doing tab completion after vm restart.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/1390343002 .
2015-10-07 13:12:45 -07:00
129d7d3cec
Ensure the debugger considers parameters to be in scope at the method entry debug step.
...
Push entry debug step check after parameter capturing and give it the token position of the last parameter.
BUG=http://b/24200673
R=hausner@google.com
Review URL: https://codereview.chromium.org/1393453004 .
2015-10-07 12:33:29 -07:00
3388f2dc98
Fix evaluation in frames with _private variable names.
...
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/1391953003 .
2015-10-07 11:09:44 -07:00
7415161a1f
Trim a line on the right before determining max breakpoint column
...
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/1387413003 .
2015-10-07 11:04:13 -07:00
b3267fe638
Support tab completion of line:col in the debugger.
...
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/1393523002 .
2015-10-07 09:44:38 -07:00
0d501ad53d
VM restart + shutdown fixes
...
This change add the ability to restart the vm through the service
protocol. All isolates are killed, and then the main isolate is
restarted cooperatively by the embedder.
This change also fixes the message handler to prevent it from
accidentally ignoring vm shutdown messages.
Previously, we would stop handling messages whenever we hit an error
(such as a compile error or an unhandled exception). This would leave
shutdown requests sitting the oob queue, neglected.
We now process *all* oob requests, up to the first shutdown request.
When we hit a shutdown request, we clear the oob queue and process no
more messages.
To make all of this work, we had to change the return value of
HandleMessage from bool to a new enum type, allowing the message
handler to distinguish *normal* error cases from the more rarified
shutdown and restart cases.
R=johnmccutchan@google.com , zra@google.com
Review URL: https://codereview.chromium.org/1371193005 .
2015-10-06 11:27:26 -07:00
23823cd0fd
Add a scroll bar when the console prints looooooooong lines.
...
Closes #24299
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/1383843002 .
2015-10-01 11:10:50 -07:00
fd6135927e
Ensure that service protocol specification and implementation use the correct numeric types
...
Fixes #24245
R=turnidge@google.com
Review URL: https://codereview.chromium.org/1387433002 .
2015-10-01 11:05:13 -07:00
473413753d
Some changes to service protocol before we land 1.13.
...
- Split AddBreakpoint into two rpcs: AddBreakpoint and
AddBreakpointWithScriptUri.
- Remove Isolate.entry.
Closes #24329
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1379163002 .
2015-10-01 10:46:44 -07:00
4995b84051
Remove obsolete timer list from VM
...
The functionality is now covered with TimeLine and CompilerStats
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1375343002 .
2015-09-30 12:47:23 -07:00
95513b0a1d
Switch from Google charts to Charted
...
R=turnidge@google.com
Review URL: https://codereview.chromium.org//1310153002 .
2015-09-29 12:59:05 -07:00
85d1e2c908
Bump observatory_pub_packages in DEPS
...
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1377583002 .
2015-09-28 12:57:19 -07:00
c2ff661740
Mark service/process_service_test as flaky on arm
...
Updated issue 24344 to reflect that this is flaky
R=fschneider@google.com
BUG=
Review URL: https://codereview.chromium.org//1373853002 .
2015-09-28 17:01:35 +02:00
d7b46bf5c1
Don't use a special var descriptor for :async_op since it can now be either stack or context allocated.
...
BUG=http://dartbug.com/24439
R=regis@google.com
Review URL: https://codereview.chromium.org//1361423004 .
2015-09-25 13:47:41 -07:00
d4fa240a25
Address static warning about service library's Isolate hiding dart:isolate's Isolate.
...
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1364903002 .
2015-09-23 14:05:55 -07:00
66f9abc7e3
Refactor isolate interrupts to use OOB messages instead of interrupt bits.
...
Closes #24349
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1344993002 .
2015-09-23 12:13:25 -07:00
eb3fe78200
Automatically set correct Observatory analytics version
...
R=turnidge@google.com
Review URL: https://codereview.chromium.org//1352493002 .
2015-09-16 10:47:19 -07:00
b956f981e5
getIsolate rpc now returns collected sentinel for expired isolate.
...
Closes #24353
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1347693004 .
2015-09-16 10:10:16 -07:00
b6e48e9617
Use cammelCase for all service extension variables
...
R=johnmccutchan@google.com , johnmmccutchan@google.com
BUG=
Review URL: https://codereview.chromium.org//1343033002 .
2015-09-16 07:27:45 +02:00
fad876aa30
Fix static analysis warnings in Observatory
...
- Type check SourceLocation and UnresolvedSourceLocation.
- Return null explicitly.
- Remove unused import.
R=turnidge@google.com
Review URL: https://codereview.chromium.org//1340073002 .
2015-09-15 12:57:43 -07:00
f3f358e5f3
Change times reported from io resource meta data to be milliseconds since epoch
...
Change tests accordingly (and add a few extra tests)
Move the logic to the _IOResource class to only have one datetime and one stopwatch.
R=johnmccutchan@google.com , sgjesse@google.com
BUG=
Review URL: https://codereview.chromium.org//1341733003 .
2015-09-15 07:42:06 +02:00
3507b7d3f0
suppress service/process_service_test on arm
...
Filled issue 24344 to track this
R=sgjesse@google.com
BUG=
Review URL: https://codereview.chromium.org//1336303003 .
2015-09-14 14:29:49 +02:00
38b579fa78
Add tracking of open processes to the new io resource tracking.
...
I plan on refactoring the io_resource_info.dart file a bit in a follow up, but I keept this simple
I also plan on adding some sort of sanity checking when the vm exits, to make sure
all 3 maps are empty (in debug mode)
This fixes issue #24314 , before we would hold on to process that failed to start
running in the _processes map.
Closes #24314
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1331033003 .
2015-09-14 12:54:36 +02:00
931e41777e
Merge pull request #24236 from a14n/use-const
...
use const constructors of Utf8* at several places
2015-09-11 12:26:27 +02:00
e07d9e8918
Use the checked in SDK to build Observatory
...
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org//1337503003 .
2015-09-10 11:15:41 -07:00
5dcad9482d
Fix analyzer problems in object.dart.
...
BUG=
Review URL: https://codereview.chromium.org//1320793005 .
2015-09-09 09:56:36 -07:00
dee6ddf966
Support column-based breakpoints in the VM and Observatory.
...
BUG=
R=hausner@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org//1312763010 .
2015-09-09 09:01:13 -07:00
c6918fb126
Refactor the io resource classes
...
Move stopwatch so that we will only ever need one instance
Add utility functions for doing reads and writes
The only functional change here is that I say that an except is a read
of one byte, which also updates the readcount. I think this is just as
correct as what we did before.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//1320023008 .
2015-09-09 09:18:07 +02:00
db0d25efd1
Add resource metadata for open files.
...
Start tracking the read/write information for files in the new
resource management class.
There is currently no time information, I will refactor the timings so that the
static stopwatch from the socket_patch class is moved into the resource class
instead in a follow up (keeping this simply and only about the file addition).
The testing setup may seem a bit strange, but it is the only way I
seem to be able to guarantee that setup actually finishes and that we
get it cleaned up. John may know of a better way
R=sgjesse@google.com , johnmccutchan@google.com
BUG=
Review URL: https://codereview.chromium.org//1326703004 .
2015-09-08 11:27:06 +02:00
8d68f91055
Do not emit coverage/callsite info for implicit closure functions.
...
They are all forwarding functions now, and this was causing some
oddities in the observatory UI where some functions had coverage info
on their first line and some didn't. The coverage info always
reflected merely whether or not the closure had been invoked yet,
which was confusing.
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1330703002 .
2015-09-04 14:48:34 -07:00
5a0a8aede9
IO resource tracking. Add test that we correctly remove closed sockets
...
The other tests simply check that we actually get the open sockets, this will make sure we don't get sockets already closed
R=sgjesse@google.com
BUG=
Review URL: https://codereview.chromium.org//1317683009 .
2015-09-04 05:55:19 +02:00
06ab2bdbdd
Extract meta data about open sockets into separate class.
...
The current implementation only has information about tcp and udp
sockets, and we explicitly do not track internal and pipe uses of
_NativeSockets.
The testing of this is done through the service layer, which is the end user of
this.
BUG=
R=sgjesse@google.com
Committed: https://github.com/dart-lang/sdk/commit/01eff8ce18be7eceb6ce0be1097005965edf2588
Review URL: https://codereview.chromium.org//1323943003 .
2015-09-03 19:18:42 +02:00
e30f7638e2
observatory: change help text to match break-on-exception option name
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1317563008 .
2015-09-02 17:05:58 -07:00
665f397bb8
Revert "Extract meta data about open sockets into separate class."
...
This reverts commit 01eff8ce18R=sgjesse@google.com
BUG=
Review URL: https://codereview.chromium.org//1323183002 .
2015-09-02 16:18:52 +02:00
01eff8ce18
Extract meta data about open sockets into separate class.
...
The current implementation only has information about tcp and udp
sockets, and we explicitly do not track internal and pipe uses of
_NativeSockets.
The testing of this is done through the service layer, which is the end user of
this.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//1323943003 .
2015-09-02 15:26:35 +02:00
535f57a84a
Add source annotations for breakpoints.
...
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1305413004 .
2015-08-31 12:10:49 -07:00
7ac3150ee3
Improve display of simd vector types and stack traces in Observatory.
...
Associated protocol changes.
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1316123004 .
2015-08-31 10:35:01 -07:00
0784fc3134
use const constructors of Utf8*
2015-08-29 22:44:28 +02:00
de300cfa0e
Process service events as microtasks.
...
This preserves the ordering among rpc responses and events.
Add assertions that events are processed in order.
Add a correct timestamp for Resume events when we are paused at start.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1315673007 .
2015-08-27 12:31:06 -07:00
ea873dceca
Stop analyzer from looking at developer_extension_test
2015-08-27 12:03:41 -07:00
7052bd6bed
Rework service extensions to be safe
...
- When scheduling a service extension to be invoked, store the closure in an array held in the isolate.
- At the tail of IsolateMessageHandler::HandleMessage, invoke all pending service extension closures.
R=iposva@google.com , turnidge@google.com
Review URL: https://codereview.chromium.org//1299493007 .
2015-08-27 11:23:39 -07:00
c9a4013553
More logging for pause tests
...
BUG=
Review URL: https://codereview.chromium.org//1310863004 .
2015-08-26 16:45:36 -07:00
John McCutchan