dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1605 Commits

Author SHA1 Message Date
ricow@google.com e92f697236 Remove dart2dart support from testing scripts and status files 
I will leave it to the dart2js people to remove the support from the dart2js tools (there is also a bunch of comments still in code, do a git grep)

R=kustermann@google.com, floitsch@google.com, kmillikin@google.com
BUG=

Review URL: https://codereview.chromium.org//1126363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45588 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-07 11:29:55 +00:00
rmacnak@google.com b48fc7a2f4 Make script-insets obey their bounds, and other padding tweaks. 
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1123143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45570 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-06 17:10:43 +00:00
johnmccutchan@google.com 1c16abecf7 Fix breakage due to package upgrades 
Paired with https://codereview.chromium.org/1129463003/

Review URL: https://codereview.chromium.org//1125203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45567 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-06 14:53:12 +00:00
johnmccutchan@google.com a25e355731 Add hasStoppedAtBreakpoint 
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1128583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45532 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-05 17:30:19 +00:00
johnmccutchan@google.com a19cd071e5 Add 'dart:debugger' library 
- Add the 'dart:debugger' library.
- Add the 'Debugger' class.
- Add explicit Dart breakpoint triggered by a call to: Debugger.breakHere();
- Add Debugger.breakHereIf(bool expr)

R=hausner@google.com, turnidge@google.com

Review URL: https://codereview.chromium.org//1116263004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45529 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-05 17:05:37 +00:00
johnmccutchan@google.com e862e8ad8f Fix analyzer warnings in service tests 
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1127693003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45511 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-04 21:29:01 +00:00
johnmccutchan@google.com 2f7cff7170 Display isolate message queue in Observatory debugger 
- Log the parameters to RPCs
- Display messages like stack frames
    - handler function and script visible
    - message preview instead of local variables
- Expanded and previewed messages do not collapse when stepping within the existing message
- Mark patch classes as finalized to avoid ASSERT on class_finalizer.cc:2358 **
- Support iterating over message queues
- Support printing the message queue as JSON
- Inhibit OOB messages from being handled if we are iterating over the message queue
    - avoids dead lock when looking up port handler (done in Dart code with message handler locked) and a stack overflow trigger to handle OOB messages
- make getObject understand message ids
- Fix dartbug.com/23355

** Need to discuss with Ivan and Matthias (reviewed code differs from committed code but matches my fix):
https://codereview.chromium.org//828353002
https://code.google.com/p/dart/source/detail?r=42612

R=turnidge@google.com

Review URL: https://codereview.chromium.org//1122503003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45505 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-04 20:20:44 +00:00
rmacnak@google.com 6b85ce75dc When attempting to navigate to a page for an isolate that doesn't exist, offer to visit the same page for the each of the isolates that currently exist. 
- Remove trailing slash from vm-connect page for uniformity with other pages
- Fix script-inset sizing.

R=turnidge@google.com

Review URL: https://codereview.chromium.org//1072423003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45472 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-01 18:39:19 +00:00
rmacnak@google.com 18a5d6f392 Add breadcrumb for the VM. 
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1103643004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45471 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-01 18:23:24 +00:00
turnidge@google.com b18024efb1 Add the --steal-breakpoints flag. 
Add a test.

Update debugging_test.dart to not use line number instead of token pos to make it modestly less fragile.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1113243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45470 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-01 17:56:35 +00:00
fschneider@google.com ca629181d0 VM: Use canonical empty-array for empty inlining meta-data. 
When inlining meta-information is not used, use Object::empty_array()
instead of Array::New(0), thus saving those allocations.

Guard places for length 0 - before all code objects had an inlining
interval array of length at least 1.

This saves 2 old-space array allocations per unoptimized code object.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//1096203007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45435 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-27 22:50:02 +00:00
johnmccutchan@google.com c670979533 - Fully load both Dart and Stub code kinds 
- Ouptut "_optimized" field for fake code objects.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//1105273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45433 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-27 22:00:18 +00:00
rmacnak@google.com 0184cf0eca Add links to Observatory documentation and bug tracking. 
BUG=http://dartbug.com/23224
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1063063006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45428 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-27 17:25:33 +00:00
johnmccutchan@google.com e23be8563a Fixes to enable building dart:io implementation cleanly in mojo tree 
+ make Observatory respect script line offsets (which Sky uses).

R=iposva@google.com

Review URL: https://codereview.chromium.org//1101083003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45427 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-27 14:46:32 +00:00
nweiz@google.com 67f65fef97 Make observatory keep using html5lib. 
Observatory has its own separate set of third_party packages.

TBR

Review URL: https://codereview.chromium.org//1060463006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45413 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-24 20:50:24 +00:00
rmacnak@google.com 9b245afa1e Fix showing values of instance fields. 
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1102993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45411 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-24 20:13:42 +00:00
nweiz@google.com 70a846ad6c Update pubspecs and dependencies to get pkgbuild tests working. 
This also removes the vendored copy of Angular, which was an outdated version of
an unstaffed branch.

R=pquitslund@google.com

Review URL: https://codereview.chromium.org//1058283006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45410 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-24 20:08:53 +00:00
johnmccutchan@google.com 583f48a132 Add crash dumps to service protocol and Observatory 
- Add _getCrashDump RPC
- crash dump service response is map of request uris to responses, includes:
  -- getVM
  -- getFlagList
  -- for each isolate:
      -- getIsolate
      -- _getAllocationProfile
      -- getStack
- Add FakeVM to service library
- Add load crash dump to Observatory connect page
- Removes old chromium target support from connect page
- Make debugger page display stack even if libraries can't be loaded
- Fix reload of vm-connect page
- Fix polymer initialization calls

R=turnidge@google.com

Review URL: https://codereview.chromium.org//1100583006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45390 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-24 00:08:07 +00:00
turnidge@google.com aa1363c2af Update hack in test_helper.dart to handle new error message. 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1063853006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45379 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-23 18:32:54 +00:00
turnidge@google.com d9f65329c3 Do not JSON encode the 'result' of a service rpc. 
Before a response looked like this...

{ result:<string> id:* }

...where result was always a json encoded string.  This meant that
users of the service protocol had to json decode both the outer
message and the result, which was silly.

Now a response looks like this:

{ result:<map> id:* }

This means that users of the service protocol only need to decode once.

We have changed event formats as well.  Previously, an event looked like this:

{ result:<string> }

(Essentially a result without an id.)  The result was json encoded,
requiring the user to double-decode.

Now an event looks like this:

{ event:<map> }

This allows us to distinguish events from rpc results and avoids
double-decoding.  It also avoids having an id-less rpc result mistaken
for an event.

------------

Some details and associated changes:

- Unify GCEvent and ServiceEvent in the VM.

- Move sequence number handling out of dart code and into JSONStream
  in the VM.  Plumbing.  I needed to do this to avoid double-encoding.
  Some of the dart code gets a bit simpler.

- Update C++ tests to have a sequence number.

- Change format of method/params used in Error responses to be more json-y.

- Strip out double decoding in the service lib.

- Improvements to tests.  I was running into some races and other issues.

- Fail fast when we run into a message decoding problem.  Instead of
  returning a service exception, we now disconnect from the vm.

- VMDisconnected => ConnectionClosed.

- Add some support for a reason string when disconnecting from the vm
  in the service library.

Review URL: https://codereview.chromium.org//1093043004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45378 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-23 17:55:08 +00:00
rmacnak@google.com 948e638dd8 Fix script-view. Hide annotations except the current position when debugging. 
Review URL: https://codereview.chromium.org//1079163009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45364 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-22 20:49:33 +00:00
johnmccutchan@google.com 73fe0259ff CPU profile displayed in three tables with a tree 
Table #1:
All functions sortable on inclusive or exclusive.

Table #2:
Callers of focused function.

Table #3:
Callees of focused function.

Tree:
Inclusive or Exclusive rooted profile tree filtered by focused function.

Also includes:

- Kill LinkLocationManager.
- Merge HashLocationManager into LocationManager.
- Kill nav-control element.
- Add goParameter to navigate based on page parameters (e.g. ?isolateId=...).

R=turnidge@google.com

Review URL: https://codereview.chromium.org//1013563002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45348 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-22 14:05:20 +00:00
rmacnak@google.com 529993214f Fix missing annotations in script inset when first annotation is outside the subset of lines being displayed. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1057793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45326 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-22 00:42:55 +00:00
johnmccutchan@google.com 0afab79fde Skip coverage test on Windows 
BUG=

Review URL: https://codereview.chromium.org//1099953003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45319 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-21 20:10:13 +00:00
rmacnak@google.com 11d54fd84f Reapply "Add tests for evalutating against activation records." 
Also kill the testee if the tester has an exceptions running its tests.

BUG=http://dartbug.com/20047
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1099663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45305 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-21 01:13:59 +00:00
rmacnak@google.com f415625d5c Revert "Add tests for evalutating against activation records." 
BUG=

Review URL: https://codereview.chromium.org//1094993003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45264 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-18 00:56:26 +00:00
rmacnak@google.com 677c32a426 Add tests for evalutating against activation records. 
Report an exception when the testee hits an assertion failure.

BUG=http://dartbug.com/20047
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1075423002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45263 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-18 00:06:21 +00:00
turnidge@google.com ec2519c464 Apparently every flag is modified in some test configurations on the buildbot. 
This broke my assumption that I could find at least one unmodified flag.

BUG=

Review URL: https://codereview.chromium.org//1057173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45261 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-17 23:28:00 +00:00
turnidge@google.com a91774ba56 Fix buildbot. 
BUG=

Review URL: https://codereview.chromium.org//1092053005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45260 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-17 22:32:09 +00:00
turnidge@google.com ad2bb796bc My new tests made some bad assumptions about flag values. 
BUG=

Review URL: https://codereview.chromium.org//1092123003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45259 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-17 22:04:32 +00:00
turnidge@google.com ca5de9eac9 Kill service_test.cc tests in favor of dart tests for the service protocol. 
Associated cleanups and fixes that I noticed as I rewrote the tests.

Review URL: https://codereview.chromium.org//1090293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45257 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-17 21:08:02 +00:00
johnmccutchan@google.com 900f88389c Set version back to 111 
BUG=

Review URL: https://codereview.chromium.org//1091373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45255 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-17 20:35:43 +00:00
johnmccutchan@google.com 75ac0ef5e8 Analytics version for 1.10 
TBR=iposva

Review URL: https://codereview.chromium.org//1096613006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45254 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-17 20:31:50 +00:00
rmacnak@google.com 899490d306 Add annotation for function declarations. Mark functions with performance problems in red. 
Reduce the saturation of the coverage markers.

Creating service-refs is horribly expensive: build the details for call sites and function declarations lazily.

Report is_inlinable instead of CanBeInlined because the latter depends whether the function currently has code or breakpoints.

Review URL: https://codereview.chromium.org//1087833005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45217 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-16 19:06:35 +00:00
johnmccutchan@google.com 138828554a Add page view analytics to Observatory 
BUG=
R=sethladd@google.com

Review URL: https://codereview.chromium.org//1087393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45215 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-16 16:36:27 +00:00
johnmccutchan@google.com 484a2d2cfa Disable debugging_test on Windows 
BUG=

Review URL: https://codereview.chromium.org//1081383003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45141 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-14 15:56:10 +00:00
rmacnak@google.com c4403ec250 Ensure call_site_data_test runs with unoptimized code so invocation counts are accurate. 
BUG=http://dartbug.com/23160
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1078893004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45073 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-10 17:12:06 +00:00
ricow@google.com 8a77499ec5 Mark service/call_site_data_test as flaky on linux 
This is not really flaky, but is failing when running with optimization counter tresshold 5

R=iposva@google.com
BUG=23160

Review URL: https://codereview.chromium.org//1078013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45050 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-10 06:56:03 +00:00
johnmccutchan@google.com 093460be01 Run service tests in a zone that gracefully handles websocket disconnections 
BUG=

Review URL: https://codereview.chromium.org//1074053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45046 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 23:58:31 +00:00
johnmccutchan@google.com f6a86e830e Disable code_test on Windows 
BUG=

Review URL: https://codereview.chromium.org//1070383003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45045 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 23:38:56 +00:00
johnmccutchan@google.com 647c355f8c Relocate service library tests and hookup a working status file 
BUG=

Review URL: https://codereview.chromium.org//1071363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45043 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 22:57:59 +00:00
johnmccutchan@google.com cef8aa3a34 Enable observatory tests by default 
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1075013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45039 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 21:43:28 +00:00
koda@google.com 61c32bf1b8 Update graph_test with new class id. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1072943002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45038 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 21:40:26 +00:00
turnidge@google.com 0edd5aae1e Some cleanups in the code that posts results to service clients. 
- Remove the notion of event families and masks.  This wasn't really used.

- Change "response" to "result" in our response map to be more json-rpc-like.

- Pass events to the service isolate as Strings.

- Add more type declarations around raw data (Uint8List) responses.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1077823003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45034 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 21:08:38 +00:00
turnidge@google.com 6f519e9d96 Fix all Observatory warnings/errors. 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1076003004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45032 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 20:30:59 +00:00
koda@google.com ea5a3de93d Fix auto-refresh in Heap profile. 
To avoid lag when the profile page cannot keep up with the GC events,
keep at most one outstanding auto-refresh request (but make sure to refresh
up to and including the latest GC).

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1065303003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45015 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 16:01:39 +00:00
turnidge@google.com fb591fc36a Continue improving the documentation for the vm service protocol. 
Clean up the protocol a bit as I go.

---

Addendum:

Clean up inconsistencies between field and function ownership in the protocol.

Change the names of implicit closure functions (!)

Review URL: https://codereview.chromium.org//1057333004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44923 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-06 19:24:47 +00:00
rmacnak@google.com 7b24669458 Display multiline strings as multiline in Observatory's inspector. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1062593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44892 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 21:30:50 +00:00
turnidge@google.com 52538c5315 Tidy up the service protocol. Begin improving the documentation. 
BUG=

Review URL: https://codereview.chromium.org//1053053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44865 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-02 19:16:35 +00:00
rmacnak@google.com 61639129a7 Call site data UI tweaks. 
- Make calls have the same cursor as links.
 - Highlight a call site when its data it visible.
 - Don't display the table header when a call site has no data.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1039863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44840 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-01 19:43:36 +00:00