nweiz@google.com
4eb2c68adf
Fix a dartc error for pkg/http/multipart_test.
...
BUG=7458
Review URL: https://codereview.chromium.org//12368002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19180 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 22:55:22 +00:00
gram@google.com
2e8f08f25b
TBR: Fix dartc break by removing re-export of fail from unittest; already in matcher.dart.
...
Review URL: https://codereview.chromium.org//12315140
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19173 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 21:37:54 +00:00
gram@google.com
512208ecaa
Aligns with usage of FailureHandler and behavior of expect
...
Eliminates call: expect(false, isTrue, reason: ...)
BUG= https://code.google.com/p/dart/issues/detail?id=8450
Review URL: https://codereview.chromium.org//12328143
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19168 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 20:51:22 +00:00
gram@google.com
017d21bdc0
Unit test changes:
...
- add back KevMoo's assertions now that the bugs they exposed ar efixed
- remove onTestResult methods from a couple of configs; these did nothing other
than prevent the base class implementation from being called which is wrong.
- fix the TestFunction signature
- change from ExpectException, which is deprecated, to TestFailure.
Review URL: https://codereview.chromium.org//12335113
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19166 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 19:57:40 +00:00
lrn@google.com
cea269dca8
Make List.from default to not growable.
...
Review URL: https://codereview.chromium.org//12335131
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19130 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 13:09:11 +00:00
lrn@google.com
501819c2bf
Make unit-test not create a fixed-length list of tests.
...
Review URL: https://codereview.chromium.org//12340100
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19122 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 10:15:31 +00:00
lrn@google.com
fa78a93635
Make arg parser return growable list of rest arguments.
...
This allows the user to remove them when he's done, which is what
is currently being done.
Review URL: https://codereview.chromium.org//12316155
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19119 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 09:48:17 +00:00
lrn@google.com
6b4f4b1bab
Change new List(n) to return fixed length list.
...
Deprecate List.fixedLength, add List.filled.
Make Iterable.toList and List.from take "growable" argument,
defaulting to false.
Review URL: https://codereview.chromium.org//12328104
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19112 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 08:45:04 +00:00
gram@google.com
1f69581fb4
TBR: Removing the config assertions again; they still seem to be causing problems.
...
Review URL: https://codereview.chromium.org//12328120
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19094 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 23:03:22 +00:00
gram@google.com
0485f787c0
pkg/unittest: fixed asserts around currentTestCase
...
Fixed asserts originally in https://codereview.chromium.org/12328090/
removed by https://codereview.chromium.org/12330145/
Review URL: https://codereview.chromium.org//12340082
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19088 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 22:06:06 +00:00
gram@google.com
336df64c51
Added ability for test cases to return Futures.
...
Review URL: https://codereview.chromium.org//12310123
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19087 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 22:02:23 +00:00
sigmund@google.com
5ad88c9e0b
unittest fix: Get rid of the deprecation of IllegalJsRegexException's matcher. The underlying type has
...
been deprecated for some time already, so I think we can safely get rid of this.
Adding the @deprecated works, but adding the dependence on meta breaks some of
our bots that don't use pub.
Review URL: https://codereview.chromium.org//12326134
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19083 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 21:39:34 +00:00
sigmund@google.com
198f8a4189
Fix unittest in checked mode
...
(partial revert of https://codereview.chromium.org/12328090 )
Review URL: https://codereview.chromium.org//12330145
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19068 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 18:45:40 +00:00
sigmund@google.com
5947cf902c
Configuration: make currentTestCase get-only
...
- Should be updated only by onTestStart, onTestResult
- Added asserts to ensure calls to the above happen in expected order with reasonable values
Configuration: removed notifyController from
- Does nothing, never called, never overridden
Configuration: add types to properties
- Nice for dartdoc
deprecated throwsIllegalJSRegExpException
- since IllegalJSRegExpException is also deprecated
Review URL: https://codereview.chromium.org//12328090
Patch from Kevin Moore <kevmoo@j832.com >.
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19067 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 18:34:59 +00:00
nweiz@google.com
c9c40b0c40
Add a nothing descriptor to scheduled_test.
...
BUG=8511
Review URL: https://codereview.chromium.org//12321122
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19018 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 23:26:51 +00:00
nweiz@google.com
0014d54850
Add an async descriptor to scheduled_test.
...
BUG=8511
Review URL: https://codereview.chromium.org//12330120
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19008 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 22:10:17 +00:00
sigmund@google.com
a50b019f35
Add comment in unittest
...
Review URL: https://codereview.chromium.org//12316106
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18993 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 19:23:56 +00:00
lrn@google.com
3c0ac360e7
Remove deprecated string features.
...
Make String.codeUnits return a List.
Review URL: https://codereview.chromium.org//12282038
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18960 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 10:48:09 +00:00
devoncarew@google.com
8fb803a971
Disambiguate a library prefix and a local variable in pkg/scheduled_test/lib/src/descriptor/utils.dart - fix for the dartc bots.
...
Review URL: https://codereview.chromium.org//12340041
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18943 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-24 00:34:19 +00:00
nweiz@google.com
2431045f4d
One final fix to the descriptor test on Windows.
...
TBR
Review URL: https://codereview.chromium.org//12330090
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18936 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-23 00:56:48 +00:00
nweiz@google.com
26e739d11c
Always use POSIX path in Entry.load in scheduled_test.
...
TBR
Review URL: https://codereview.chromium.org//12313083
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18935 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-23 00:41:47 +00:00
nweiz@google.com
60539a0bae
Match cross-platform path separators.
...
TBR
Review URL: https://codereview.chromium.org//12310079
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18931 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 23:50:13 +00:00
nweiz@google.com
f338f92978
Ensure scheduled_test directory entries are sorted when displaying error messages.
...
TBR
Review URL: https://codereview.chromium.org//12326087
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18930 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 23:20:25 +00:00
nweiz@google.com
1b886552df
Fix some dumb test-breaking errors.
...
TBR
Review URL: https://codereview.chromium.org//12321091
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18929 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 23:05:45 +00:00
nweiz@google.com
3dc2490a27
Add a filesystem descriptor library to scheduled_test.
...
BUG=8511
Review URL: https://codereview.chromium.org//12330062
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18928 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 23:01:51 +00:00
sigmund@google.com
1ce392bfb1
Fix use of string buffer in pathos
...
Review URL: https://codereview.chromium.org//12330077
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18917 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 21:17:55 +00:00
nweiz@google.com
c8f6014ae7
Move pkg/path to pkg/pathos.
...
Review URL: https://codereview.chromium.org//12316056
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18906 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 18:45:55 +00:00
sigmund@google.com
16eba207b6
Fix use of stringbuffer in pkg/args
...
Review URL: https://codereview.chromium.org//12335035
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18902 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 18:21:18 +00:00
sigmund@google.com
55cfa2d3d5
Some fixes in unittest after io v2
...
Review URL: https://codereview.chromium.org//12316072
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18899 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 17:34:17 +00:00
nweiz@google.com
0faec39c7e
Add path.joinAll.
...
Review URL: https://codereview.chromium.org//12314047
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18860 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 22:48:30 +00:00
sgjesse@google.com
488b016a2f
Merge IO v2 branch to bleeding edge
...
R=ager@google.com , ajohnsen@google.com , whesse@google.com
BUG=
Review URL: https://codereview.chromium.org//12316036
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18820 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 11:58:11 +00:00
kustermann@google.com
d2c575c0b0
Create generated tests inside the build directory
...
Patch Set 1 is a revert of r18295.
Review URL: https://codereview.chromium.org//12223074
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18802 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 08:10:37 +00:00
nweiz@google.com
94eaaa79d1
Support nested tasks in scheduled_test.
...
BUG=8511
Review URL: https://codereview.chromium.org//12288061
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18800 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-20 23:57:28 +00:00
floitsch@google.com
ecce8a6293
Remove deprecated Strings class.
...
Review URL: https://codereview.chromium.org//12295014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18686 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 13:57:03 +00:00
ahe@google.com
4791afea54
Provide more information about non-unittest failures.
...
Review URL: https://codereview.chromium.org//12296025
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18679 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 12:47:50 +00:00
lrn@google.com
bbfe7b02dc
Reapply "Make Comparable generic."
...
Avoid concurrent modification in dart2js.
Avoid crash in VM by not using self-referential type bound.
Review URL: https://codereview.chromium.org//12288040
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18667 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 10:29:44 +00:00
kasperl@google.com
d4feeb4910
Revert "Make Comparable generic."
...
This reverts commit dd714db881a0ad63eaa1e5491e93dd8843eb5929.
R=lrn@google.com
BUG=
Review URL: https://codereview.chromium.org//12298027
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18657 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 08:06:03 +00:00
lrn@google.com
a0f22b77be
Make Comparable generic.
...
It's now allowed to write "class X implements Comparable<X>" to make
X comparable only to X's. The argument type of Comparable<T>.compareTo
is now T.
Review URL: https://codereview.chromium.org//12255055
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18655 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 07:52:24 +00:00
lrn@google.com
03f5a66836
Recommit changing List.skip/take/revert returns Iterable and remove mappedBy.
...
This reverts r18591.
Review URL: https://codereview.chromium.org//12295009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18615 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-18 10:35:51 +00:00
rnystrom@google.com
0e0473d33a
Unbreak pub:
...
Revert "Make List.skip, List.take and List.reversed return Iterables, not Lists."
This reverts commit 44c3745a76acfad3d1d5bfc7a8b8c8e2def30e09.
Revert "Remove deprecated mappedBy."
This reverts commit 779ab69eab73e5e349245e99560b18955908e0cc.
BUG=dartbug.com/8560
Review URL: https://codereview.chromium.org//12286004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18591 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 18:38:42 +00:00
floitsch@google.com
0672317bec
Remove deprecated mappedBy.
...
Committed: https://code.google.com/p/dart/source/detail?r=18575
Reverted: http://code.google.com/p/dart/source/detail?r=18576
Review URL: https://codereview.chromium.org//12212213
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18579 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:57:18 +00:00
floitsch@google.com
ad839e6957
Revert "Remove deprecated mappedBy."
...
This reverts commit 18575.
Review URL: https://codereview.chromium.org//12207205
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18576 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:23:22 +00:00
floitsch@google.com
b37100770b
Remove deprecated mappedBy.
...
Review URL: https://codereview.chromium.org//12212213
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18575 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:18:17 +00:00
lrn@google.com
ecbf4478c2
Reapply "New implementation of {,Linked}Hash{Set,Map}."
...
Review URL: https://codereview.chromium.org//12212211
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18573 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:07:22 +00:00
lrn@google.com
b7f36d0d11
Make List.skip, List.take and List.reversed return Iterables, not Lists.
...
Removes ListView. It was premature optimization to have classes that combined any sequence of reverse, skip and take instead of just wrapping iterables.
Review URL: https://codereview.chromium.org//12262037
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18570 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 10:43:21 +00:00
dgrove@google.com
278d7b0c74
Update documentation links to point to the correct URLs.
...
Review URL: https://codereview.chromium.org//12252055
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18552 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 01:27:10 +00:00
vsm@google.com
e2ef36a751
Fix dart.js to handle query strings
...
Still needs an automated test, but this passes my local ones.
BUG=http://code.google.com/p/dart/issues/detail?id=8408
Review URL: https://codereview.chromium.org//12212203
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18549 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 23:38:20 +00:00
efortuna@google.com
7120208746
Fix test status for analyzer test.
...
BUG=
Review URL: https://codereview.chromium.org//12252045
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18544 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 22:03:28 +00:00
pquitslund@google.com
c5fba36a7a
Test status fix to properly exclude analyzer tests from dart2js builds.
...
Review URL: https://codereview.chromium.org//12263045
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18538 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 19:51:22 +00:00
pquitslund@google.com
fc2c75acda
Fresh drop of analyzer-experimental.
...
Among other things,
* adds resolver and tests (in progress)
* more tests in general (e.g., ast_test.dart and element_test.dart)
* fixes getter/setter name generation
Review URL: https://codereview.chromium.org//12253009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18535 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 19:28:02 +00:00