Commit Graph

35087 Commits

Author SHA1 Message Date
nweiz@google.com 88c193cf05 Add a bunch of ugly debugging prints to figure out why the bots are failing.
Review URL: https://codereview.chromium.org//12732004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19751 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 23:52:09 +00:00
nweiz@google.com 8fe98eca6c Fix the build breakages caused by r19742.
TBR

Review URL: https://codereview.chromium.org//12663006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19746 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 23:31:02 +00:00
nweiz@google.com 15762df9f4 Stop working around issue 8512.
Review URL: https://codereview.chromium.org//12452008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19743 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 23:04:09 +00:00
nweiz@google.com b67be38c35 Add a ScheduledProcess class to pkg/scheduled_test.
BUG=8511

Review URL: https://codereview.chromium.org//12377093

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19742 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 23:02:04 +00:00
kevmoo@j832.com 72390e1545 pkg/unittest: fixed references to configuration implementations
Removed references to removed config libraries.
Replaced with references to existing config libraries
Tightened up description of matcher library

Review URL: https://codereview.chromium.org//12458002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19741 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 22:40:28 +00:00
amouravski@google.com 5ea5ef0145 Fix webdriver build warnings.
Review URL: https://codereview.chromium.org//12566008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19723 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 21:06:55 +00:00
ahe@google.com e6d4c9925c Revert "Don't output tons of messages on apidoc." and "Fix bot breaks."
This reverts r19662 and r19666.

Review URL: https://codereview.chromium.org//12690003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19694 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 13:55:39 +00:00
floitsch@google.com d9fc776d43 Mark date_time_format_unitialized_test as flaky.
Review URL: https://codereview.chromium.org//12521008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19691 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 13:12:40 +00:00
floitsch@google.com dd48256fe5 Remove deprecated StringBuffer.add, addAll and addCharCode.
Review URL: https://codereview.chromium.org//12473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19690 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 13:07:18 +00:00
lrn@google.com bead146749 Renamed StreamSink to EventSink. Renamed signalError to addError.
Review URL: https://codereview.chromium.org//12610006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19683 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 11:31:19 +00:00
sgjesse@google.com b6096848b1 Make IOSink implement StringSink
Besides adding the StringSink methods I also added writeBytes and
deprecated both add and addString.

To handle the encoding of strings the IOSike has an encoding
property. This property is mutable in situation when it makes sense to
change encoding of what is written. The exception here is for HTTP
where the encoding is determined from the header and the encoding
cannot be changed.

R=ajohnsen@google.com, ager@google.com, nweiz@google.com

BUG=

Review URL: https://codereview.chromium.org//12504006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19676 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 10:06:28 +00:00
amouravski@google.com cc1932ca71 Don't output tons of messages on apidoc.
Review URL: https://codereview.chromium.org//12642004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19662 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-07 23:19:45 +00:00
ricow@google.com bf4db7b7be Suppress failure in pkg/intl/test/date_time_format_http_request_test
Filed http://dartbug.com/8983
Review URL: https://codereview.chromium.org//12576004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19627 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-07 14:13:14 +00:00
sgjesse@google.com ff47888a0d Make instances of HeaderValue and ContentType immutable
Their parameters map is still mutable though.

R=ajohnsen@google.com

BUG=

Review URL: https://codereview.chromium.org//12440002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19598 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-07 07:25:56 +00:00
scheglov@google.com 31636d35f5 Use JavaFile instead of Dart File.
This fixes two failing tests (which we were have to comment out).
Plus, it also looks better IMHO, isolates File in single class, removing additional top-level functions.

R=pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//12543009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19585 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-06 22:16:13 +00:00
dgrove@google.com 7d86e62d26 Import packages outside oauth2 via ../../.../pkg/ . This allows packages
to have their imports rewritten and uploaded to pub.
Review URL: https://codereview.chromium.org//12543004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19566 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-06 17:17:05 +00:00
scheglov@google.com be50bddc3e Use limited JavaStringBuilder implementation instead of Dart StringBuffer.
StringBuffer.clear() is deprecated and will be removed.

R=pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//12543003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19565 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-06 17:12:47 +00:00
scheglov@google.com 6e7bff23f8 Attempt to fix builds after analyzer-experimental fixes.
TBR

R=pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//12447008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19533 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-06 01:19:01 +00:00
scheglov@google.com 3a98de6d0a Update analyzer-experimental.
R=pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//12502002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19532 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-06 00:10:49 +00:00
gram@google.com 8b1e26736c pkg/unittest: fix TestCase.runningTime
issue 4437 has been fixed for a while
Review URL: https://codereview.chromium.org//12442005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19522 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-05 22:27:04 +00:00
gram@google.com c9a3ba45af Tweak mismatch description message to check for Iterable, not Collection.
See https://code.google.com/p/dart/issues/detail?id=8880
Review URL: https://codereview.chromium.org//12391076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19428 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-04 22:23:41 +00:00
gram@google.com 7ba1dbb148 Don't throw if a non-string is passed to RegExpMatcher.
See https://code.google.com/p/dart/issues/detail?id=8881
Review URL: https://codereview.chromium.org//12395024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19426 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-04 22:10:35 +00:00
rnystrom@google.com 58c337d775 Fix scheduled_test after corelib broke it.
Review URL: https://codereview.chromium.org//12388085

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19416 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-04 19:28:07 +00:00
alanknight@google.com 25619b3922 Fix deprecated StringBuffer usages in Intl
BUG=

Review URL: https://codereview.chromium.org//12382036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19412 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-04 18:41:28 +00:00
amouravski@google.com e84340b7b6 Fixed two doc comments in pathos.
Review URL: https://codereview.chromium.org//12386051

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19401 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-04 17:26:37 +00:00
floitsch@google.com d91bca2813 Add List.asMap().
Review URL: https://codereview.chromium.org//12391046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19399 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-04 16:57:52 +00:00
lrn@google.com f4300b84a2 Make List.from and Iterable.toList default to not growable.
Review URL: https://codereview.chromium.org//12401002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19391 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-04 14:55:40 +00:00
gram@google.com 786a2463a6 There are features needed for unittest impl that don't make a lot of sense for users.
BUG=https://code.google.com/p/dart/issues/detail?id=8878
Review URL: https://codereview.chromium.org//12377055

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19347 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-02 01:08:33 +00:00
gram@google.com b1f515c1ce Fix build break with dart2js not liking conditional expressions in initializers of const classes.
Review URL: https://codereview.chromium.org//12393020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19341 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 22:20:14 +00:00
gram@google.com 9b40e6b13e Fix issue with async callbacks that get called synchronously while running test case function causing the test to be marked as complete prematurely.
Added an optional id to completion matchers that can be used in error messages (this was invaluable in tracking down the above problem).

Re-enable pub tests. https://code.google.com/p/dart/issues/detail?id=8862
Review URL: https://codereview.chromium.org//12393017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19339 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 21:49:15 +00:00
sigmund@google.com 5a1ee934cb pkg/unittest: Types, deprecations, docs
Add return types to a number of top-level members
deprecate callbackDone
guardAsync: added types, fixed documentation
- Shouldn't refer to private field in docs

Review URL: https://codereview.chromium.org//12381016
Patch from Kevin Moore <kevmoo@j832.com>.

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19335 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 18:49:35 +00:00
sigmund@google.com d43f565f97 Don't use package: imports in logging until dartdoc/mirros support them.
Review URL: https://codereview.chromium.org//12380042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19270 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 00:32:14 +00:00
gram@google.com d3a373e812 When we have excess callbacks, throw instead of calling error() so that we
get a stack trace.
Clean up SpreadArgsHelper.
We can now specify a min and max count for callbacks.
Split onTestResult into two - onTestResult and onTestResultChanged. The
first one is called initially, and the second if further callbacks occur 
after the test was considered complete, or if teardown fails.

See https://code.google.com/p/dart/issues/detail?id=8660
Review URL: https://codereview.chromium.org//12366004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19269 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 00:27:47 +00:00
nweiz@google.com a903dfd3a4 Remove the wrapStream workaround for issue 8310.
Review URL: https://codereview.chromium.org//12374033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19266 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 23:24:21 +00:00
nweiz@google.com 3ce4e71a92 Make use of Completer.isComplete in pub and pkg/scheduled_test.
Review URL: https://codereview.chromium.org//12385027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19264 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 23:18:27 +00:00
nweiz@google.com 284649357a Fix the pkg/http multipart test to avoid a race condition.
BUG=8843

Review URL: https://codereview.chromium.org//12374027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19263 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 23:15:59 +00:00
nweiz@google.com 3dc5889034 Make oauth2 warning-clean.
Review URL: https://codereview.chromium.org//12379021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19262 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 23:08:27 +00:00
floitsch@google.com 51212d24ed Remove deprecated ms arguments for Timer and Future.
Review URL: https://codereview.chromium.org//12342014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19220 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 13:24:12 +00:00
nweiz@google.com 755454d444 Fix the pkg/http multipart tests.
Review URL: https://codereview.chromium.org//12385010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19200 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 01:46:46 +00:00
nweiz@google.com ad5ec46189 Un-mark scheduled_test_test as skipped.
BUG=8844

Review URL: https://codereview.chromium.org//12377008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19198 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 01:33:10 +00:00
nweiz@google.com a5c797e98d Reduce the number of times pumpEventQueue pumps.
r19179 makes pumping the event queue enough more expensive that the scheduled
test tests were routinely timing out.

Review URL: https://codereview.chromium.org//12391003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19197 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 01:22:41 +00:00
nweiz@google.com 1ac65e06fe Add a change for r19194 that got eaten in a merge.
TBR

Review URL: https://codereview.chromium.org//12388004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19196 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 01:21:57 +00:00
asiva@google.com 1c8138978c Fix status file.
Review URL: https://codereview.chromium.org//12383011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19195 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 01:21:18 +00:00
nweiz@google.com 63a8d1271f Change MultipartFile.fromFile to MultipartFile.fromPath in pkg/http.
This re-commits r19185, with all package: imports removed from pkg/http so that
it can transitively depend on pkg/path without breaking pub. This also marks
pkg/http/multipart_test as skipped temporarily (see issue 8843).

Review URL: https://codereview.chromium.org//12385007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19194 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 01:16:10 +00:00
asiva@google.com a4338c4865 Skip scheduled_test_test in debug mode under the VM as it seems to timeout always.
Review URL: https://codereview.chromium.org//12377006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19190 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 00:55:14 +00:00
nweiz@google.com f28a7cbab9 Revert "Change MultipartFile.fromFile to MultipartFile.fromPath in pkg/http."
Review URL: https://codereview.chromium.org//12382003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19188 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 00:07:21 +00:00
sigmund@google.com b9f616ec35 LoggerEvents get on -> Stream<LogRecord> get onRecord
Removed LoggerEvents, LoggerHandlerList, LoggerHandler

BUG=

Review URL: https://codereview.chromium.org//12334093
Patch from Kevin Moore <kevmoo@j832.com>.

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19187 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 00:05:06 +00:00
sigmund@google.com f937c3629b make dartdoc and editor happy
added type to Logger.level setter
added type to Logger.root

Review URL: https://codereview.chromium.org//12316126
Patch from Kevin Moore <kevmoo@j832.com>.

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19186 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 23:43:01 +00:00
nweiz@google.com e575394847 Change MultipartFile.fromFile to MultipartFile.fromPath in pkg/http.
This also makes pkg/http warning-clean.

Review URL: https://codereview.chromium.org//12351006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19185 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 23:35:57 +00:00
nweiz@google.com 0a107333b7 Remove wrapInputStream and wrapOutputStream from pkg/http.
Review URL: https://codereview.chromium.org//12372002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19184 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 23:31:39 +00:00