Commit Graph

35087 Commits

Author SHA1 Message Date
alanknight@google.com d98dc62e7d Parameterize the import directories, fix test to behave correctly on an error
Review URL: https://codereview.chromium.org//12478010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20241 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 20:53:26 +00:00
nweiz@google.com 90e03e6ac9 Miscellaneous small improvements for scheduled_test.
Review URL: https://codereview.chromium.org//12678011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20240 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 20:53:11 +00:00
ricow@google.com b3d14f201d Mark pkg/scheduled_test/test/descriptor_test as flaky.
Filed 9266
Review URL: https://codereview.chromium.org//12621007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20227 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 18:21:06 +00:00
nweiz@google.com 8f7295dce7 Work around issue 9252 in scheduled_test and pkg/http.
Review URL: https://codereview.chromium.org//12540010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20187 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 00:25:05 +00:00
nweiz@google.com 94c07e5281 Change the way Patterns work in scheduled_test/descriptor.
Instead of every Entry being able to have a pattern as a name, now there's a
separate Pattern entry that encapsulates the logic of finding entries that match
a pattern.

The Pattern class also has different semantics than the old pattern names. The
old semantics required only one filesystem entity with a name matching the
pattern; now any number are allowed, as long as only one of them matches the
Entry (that is, has the expected contents).

Review URL: https://codereview.chromium.org//12853005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20185 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-18 23:24:09 +00:00
alanknight@google.com 6bda92055d Update Intl's json data file generation to current APIs
Review URL: https://codereview.chromium.org//12918018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20182 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-18 22:47:42 +00:00
scheglov@google.com 1dd8b25904 Fix analyzer_experimental.
TBR

Forgot to comment out Resolver tests :-(

R=pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//12529022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20179 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-18 21:28:22 +00:00
scheglov@google.com 1c4bc14d27 analyzer_experimental checkpoint and AnalysisContext example.
R=pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//12604020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20178 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-18 21:17:54 +00:00
ngeoffray@google.com 124e5a1bf1 We might have hit the same safari bug again.
Review URL: https://codereview.chromium.org//12905004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20161 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-18 14:50:59 +00:00
ricow@google.com 25850a01ec Mark scheduled_test/test/scheduled_test_test slow
I have filed dartbug.com/9231
Review URL: https://codereview.chromium.org//12917004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20160 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-18 14:13:46 +00:00
iposva@google.com cdcb3e5b09 - Make test code fail when run from unexpected location.
Review URL: https://codereview.chromium.org//12787011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20122 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 23:14:07 +00:00
rnystrom@google.com affd53983e Fix escaping in YAML RegExp.
This was causing it to try to parse "m4" as a number, which fails.
Fixes #9128.
BUG=

Review URL: https://codereview.chromium.org//12876003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20107 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 20:48:26 +00:00
scheglov@google.com d7729fdac6 Update generated analyzer_experimental for new List interface.
R=pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//12603007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20103 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 20:13:21 +00:00
alanknight@google.com 52f0f0a262 Add issue number to failing test
Review URL: https://codereview.chromium.org//12752005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20100 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 18:35:31 +00:00
blois@google.com 343f7c001e Tweaking html_config to stabilize location test.
I believe that changes I made recently to html_config may have destabilized the html/location_test. Basically the location_test does a hash change and when this test is run after other tests, it may be causing a browser reload.

I'd actually like to refactor the printing of the results completely to build them programmatically (and clean them up?), but this is a larger change.

BUG=

Review URL: https://codereview.chromium.org//12890002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20092 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 16:53:39 +00:00
floitsch@google.com f85fa4feff Make argument to StringSink.writeln optional.
BUG= http://dartbug.com/9102

Review URL: https://codereview.chromium.org//12870003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20074 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 12:45:40 +00:00
lrn@google.com 844cd39fad Change getRange to sublist. Make getRange deprecated.
This changes the exception behavior of getRange. It used to accept
a length of zero, no matter what start value. Now the start value
must be a valid list index.

Review URL: https://codereview.chromium.org//12817003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20064 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 09:15:39 +00:00
alanknight@google.com 16a944bce1 Change status file for intl test with encoding issue on Windows
Review URL: https://codereview.chromium.org//12630013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20058 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 00:08:56 +00:00
nweiz@google.com 6a22d28a86 Add the ability to abort a scheduled test.
Review URL: https://codereview.chromium.org//12753005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20056 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 22:37:41 +00:00
alanknight@google.com ab0ead6b50 Intl test spawning processes must specify the encoding for stdout
Review URL: https://codereview.chromium.org//12645010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20055 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 22:17:24 +00:00
nweiz@google.com a9a8d42063 Add a SafeHttpServer shim to work around issue 9140.
Review URL: https://codereview.chromium.org//12633015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20054 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 22:12:19 +00:00
blois@google.com cf827e4814 Making it easier to run individual HTML tests.
BUG=

Review URL: https://codereview.chromium.org//12824008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20051 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 21:38:27 +00:00
alanknight@google.com afc98385b5 Fix windows and pub failures in intl tests
Review URL: https://codereview.chromium.org//12448008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20049 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 21:36:18 +00:00
alanknight@google.com 0446767578 Adds facilities for extracting Intl.message calls and generating code from translations
This adds both general libraries for extracting messages and generating translations and scripts for using them with a trivial translation format. It removes the previous mechanism in message_lookup_local that relied on mirrors and traversing libraries in favor of one with a more explicit lookup by library that's consistent with the generated code. It also changes the code in basic_example to use that.

It also includes a couple of other changes. It now uses pathos for path manipulation, and the data_directory.dart hack for running tests from multiple different places was cleaned up and made more general. In addition, Intl.message now returns a string rather than a Future, which was changed as part of the libv2 integration.

This version does not yet support the plural syntax, as it disallows any interpolations that aren't just replacing a variable name. It also doesn't support named arguments to functions containing Intl.message, and it doesn't yet have a mechanism for designating sections of a text as not being subject to translation.

Finally, it relies on analyzer-experimental, which has a different name in the repository and in pub. So this version will run in the repository but will not run if used from pub. Bug 9071 asks for the names to be made consistent.

Review URL: https://codereview.chromium.org//12733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20047 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 20:49:26 +00:00
nweiz@google.com b44320b987 Add a ScheduledServer class.
Review URL: https://codereview.chromium.org//12809002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20042 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 18:20:08 +00:00
kevmoo@j832.com 519fa6c224 pkg/args Option should be more strict about names and abbreviations
Should not allow: space, \t, \r, \n, single- and double-quote, slashes
Should not allow empty string
Should not allow '-' as the beginning character

name should not be allowed to be null (although it's fine for abbreviation)

BUG=https://code.google.com/p/dart/issues/detail?id=8965

Review URL: https://codereview.chromium.org//12472019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20040 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 18:00:21 +00:00
gram@google.com 9827d99e2a Bring webdriver up to date with SDK changes, and a bit of refactoring.
Review URL: https://codereview.chromium.org//12413012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20038 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 17:45:09 +00:00
floitsch@google.com 76d507cb6f Add List.insert.
BUG= http://dartbug.com/5375

Review URL: https://codereview.chromium.org//12383073

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20037 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 17:38:14 +00:00
erikcorry@google.com 2a857debea dart2js: Create noSuchMethod handlers at runtime to reduce overhead.
This reduces the overhead for using noSuchMethod from over 10% to around 2%.
Following this change the original source names are not present when
minifying.  This means you get the minified name in the methodName property
on InvocationMirror objects.

R=ngeoffray@google.com
BUG=

Review URL: https://codereview.chromium.org//12499005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20005 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 11:49:13 +00:00
scheglov@google.com 139e02c68e Rename analyzer-experimental to analyzer_experimental.
https://code.google.com/p/dart/issues/detail?id=9071

R=pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//12838003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19973 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 21:42:01 +00:00
kevmoo@j832.com 050c82b520 pkg/unittest: locking down TestCase
Strip out most of the public API, leaving only read-only properties that might
be interesting for users of unittest.

This class is not designed to be instantiated or reused outside of unitttest.

The only constructor for TestCase makes strict assumptions about the unittest
environment, specifically _currentGroup, _testSetup, _testTeardown.

This enables maximum flexibility to evolve and improve the unittest library
without concern for supporting random use cases invented by 3rd-parties trying to be clever

Before: http://cl.ly/image/41230W032h1d
After: http://cl.ly/image/0K0E2S3g1327

All unittest via ./tools/bots/pub.py -n pub-mac pass

Review URL: https://codereview.chromium.org//12452004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19972 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 21:18:45 +00:00
scheglov@google.com ec569934ae Disable resolver_test.
TBR

I still cannot find way to get SDK path on bot :-(

R=pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//12545032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19943 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 16:31:06 +00:00
scheglov@google.com d946286578 Look for dart-sdk in two places.
For standalone dart-sdk and for test bot.

R=pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//12809003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19942 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 16:19:54 +00:00
floitsch@google.com 482b2f34e8 Move Options to dart:io.
Review URL: https://codereview.chromium.org//12794002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19927 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 13:12:00 +00:00
ager@google.com 26c4b3a58d Fix file descriptor leak in event handler implementation. When shutting down an isolate, we did not destruct the eventhandler so we leaked the file descriptors for it.
Also fix leak of monitor wait data objects on Windows.

R=sgjesse@google.com
BUG=dartbug.com/9021

Review URL: https://codereview.chromium.org//12646007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19921 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 11:11:38 +00:00
kevmoo@j832.com 3f6b0a78d0 pkg/unittest: fixed deprecations in alt configs
specifically compact_vm_config, html_layout_config, interactive_html_config

No tests exist for these. Verified interactive_html_config is no longer broken
All are now 'green' under editor analysis

Review URL: https://codereview.chromium.org//12598008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19908 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 02:03:29 +00:00
nweiz@google.com ecf000d1af Use ".."-style imports in scheduled_test.
This will allow it to be imported by Pub, and to import pkg/http for future
tests.

Review URL: https://codereview.chromium.org//12449016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19905 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 23:57:47 +00:00
nweiz@google.com 813010cf01 Display which nested tasks are running when an error occurs in a scheduled test.
Review URL: https://codereview.chromium.org//12512005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19900 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 22:09:55 +00:00
nweiz@google.com bed4ef5d73 Display metadata about out-of-band callbacks in scheduled test errors.
Review URL: https://codereview.chromium.org//12637020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19896 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 20:57:07 +00:00
floitsch@google.com 65718c56df Rename XMatching to XWhere.
For example firstMatching -> firstWhere.

BUG= http://dartbug.com/8664
BUG= http://dartbug.com/8337

Review URL: https://codereview.chromium.org//12537009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19880 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 17:34:49 +00:00
scheglov@google.com 7a5e2100ad Skip analyzer-experimental/.../resolver_test test.
TBR

R=efortuna@google.com
BUG=

Review URL: https://codereview.chromium.org//12440028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19830 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 23:27:53 +00:00
scheglov@google.com 5ef5ba52e4 Fixing build.
TBR

R=pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//12637014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19821 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 21:15:36 +00:00
scheglov@google.com 204d01da8d Push new analyzer-experimental with Resolver and ResolverTest.
R=pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//12671003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19820 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 20:52:08 +00:00
amouravski@google.com 6e056b8044 Lots of little changes for dartdoc/apidoc.
* Alphabetized imports.
* Added TODOs.
* Removed some prefixes.
* Cleaned up a LOT of async code to make it work better.
* Much, much, much friendlier status messages for dartdoc/apidoc. More to do...
* Prevented many, many bad warnings from showing up... by fixing them.
* Smarter finding of packages directories.
* Started using pathos all over the place.
* Added indexed_db to html_diff.

Review URL: https://codereview.chromium.org//12448006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19817 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 20:27:53 +00:00
floitsch@google.com cead1d41f1 ceil/floor/truncate/round return integers.
This CL supercedes https://codereview.chromium.org/11748016/

Review URL: https://codereview.chromium.org//12317107

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19810 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 18:54:37 +00:00
lrn@google.com 53f877edb7 Rename String.concat to operator+.
Review URL: https://codereview.chromium.org//12441003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19788 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 12:59:17 +00:00
floitsch@google.com 5dc8107c53 Revert "Remove Expect from core library."
This reverts commit 19755.

Review URL: https://codereview.chromium.org//12743005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19756 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 03:19:07 +00:00
floitsch@google.com 12dbd2fd70 Remove Expect from core library.
Review URL: https://codereview.chromium.org//12212016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19755 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 02:40:37 +00:00
nweiz@google.com afcfccea83 Accommodate a race condition in pkg/scheduled_test/scheduled_process_test.
BUG=9022

Review URL: https://codereview.chromium.org//12741004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19754 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 02:02:26 +00:00
nweiz@google.com b73ee6b89a Remove debugging prints and comment out a few more tests in pkg/scheduled_test.
BUG=9022

Review URL: https://codereview.chromium.org//12735002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19753 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 00:08:49 +00:00