dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

10502 Commits

Author SHA1 Message Date
Sam Rawlins 8886230803 Format analyzer's mock SDK code 
Change-Id: Id7e4d84414a85e3d5301453456bb4b90d192508c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142563
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-07 18:00:56 +00:00
Sam Rawlins a31781f737 Add Window and DocumentFragment to analyzer's mock SDK. 
These are required for upcoming changes to the unsafe_html lint.

Change-Id: I71018e3702b4c1e88b4b5071a150ad5b8ed99304
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142560
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-04-07 17:29:06 +00:00
Konstantin Shcheglov 91b581fb2c Fix LinterContext().canBeConst() - compute dependencies. 
Change-Id: Ibcf08f79a9990ca714dd69a0dd0cc856e99335c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142581
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-07 16:38:34 +00:00
Konstantin Shcheglov dcdc71d763 Report CONFLICTING_GENERIC_INTERFACES using ClassHierarchy. 
Change-Id: Ib5d79403358efffd5365ac4931c3163d746d933a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142567
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-07 15:50:28 +00:00
Konstantin Shcheglov 8a8c2e74d2 Update constants_2018/constant_types_test to allow type parameters in 'as'. 
Change-Id: I37b0413914d6677e2be53fb0ce98c51f81694edb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142568
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-04-07 06:50:28 +00:00
Konstantin Shcheglov 92f6b03513 Update ClassHierarchy for legacy support, record errors. 
Change-Id: I6a07a750293fa0a16c5b101142e023c8105a85aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142544
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-06 23:07:37 +00:00
Konstantin Shcheglov 0bb6143f17 Clear class hierarchies to reduce memory consumption. 
Hopefully this will improve the memory usage benchmark.

Change-Id: I7d79153a77a03926f850ca7130ecbcfa24277f4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-06 19:23:34 +00:00
Konstantin Shcheglov e5e9bc74db Allow potentially constant type expression in 'as'. 
Change-Id: I6790816daa0c02dd3d12ffd4aba00f514bf03922
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142449
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-06 17:06:14 +00:00
Konstantin Shcheglov bac08fb339 Implement interfaces subtyping check using allSupertypes. 
Change-Id: I43a4b98bae913895c7e176dd24a17fc5df7666e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-06 00:20:10 +00:00
Johnni Winther 05103dfe5a [cfe] Implement factor function 
+ share test with analyzer

Change-Id: Ie19a8746e65986f46f75c1bdd6bac3e79aedb922
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142369
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-04-05 18:16:00 +00:00
Konstantin Shcheglov 806ff47b0f Match InterfaceType(s) using allSupertypes. 
Change-Id: I6694f4c4c0df74dd1d7c1bc9f00792bc419c83bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-04 00:06:27 +00:00
Paul Berry 47293f3030 Prepare to publish analyzer 0.39.5 
Change-Id: Ib5c8319fab68d52bdf06d72678647e9212597c8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142323
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-04-03 17:28:47 +00:00
Konstantin Shcheglov be76b03b1a Update MockSdkElements to create only migrated SDK. 
Also update TestAnalysisContext to set AnalysisSessionImpl.

R=brianwilkerson@google.com

Change-Id: I21aafdc602ab049280c199b990ec9df5563fa494
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-03 17:08:07 +00:00
Jens Johansen cd629791d2 [analyzer] Regression test for constructor with operator name 
This is a follow up to
https://dart-review.googlesource.com/c/sdk/+/142161

Change-Id: I735854eb74e064ad714d69f8280532d1448fd914
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142153
Auto-Submit: Jens Johansen <jensj@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-03 14:09:35 +00:00
Jens Johansen b93f3dd3a7 [analyzer] Fix crash with _OperatorName in Constructor 
Parser recovery was recently changed so the name in a Constructor can
(again --- this was a bug that was previously semi-fixed) be
_OperatorName because everything with initializers gets recovered as a
constructor.
This fixes the analyzer crash caused by that.

Change-Id: Idc62d1a6f17b671476df051a0b5f3c2d1246c920
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-04-03 06:32:31 +00:00
Konstantin Shcheglov 1ad0ee1444 Infer when nullable type parameter type. 
R=brianwilkerson@google.com

Change-Id: Ifd59905c25cbe979d1c7090e92159124c9fa2ef4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142207
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-02 21:11:19 +00:00
Konstantin Shcheglov c147b3dfce More work on ConstraintMatchingTest. 
R=brianwilkerson@google.com

Change-Id: I49fa8cd4839ae452d18d49a92b150d57c68be2b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142261
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-02 19:11:59 +00:00
Konstantin Shcheglov 6ef554958f Remove typeParameterType() and replace with typeParameterTypeStar() mostly. 
R=brianwilkerson@google.com

Change-Id: I66f9323859ecaba9f3f3270132b670c3fe596deb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142069
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-02 15:54:09 +00:00
Konstantin Shcheglov afab7d6652 Remove unused TypeComparison. 
R=brianwilkerson@google.com

Change-Id: I02941aa828feb2c7748a29057e01b8df6e5b496f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142091
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-02 15:46:05 +00:00
Konstantin Shcheglov b6317c881c Replace interfaceType() with interfaceTypeNone() in ConstraintMatchingTest. 
R=brianwilkerson@google.com

Change-Id: I4c0c369c37d51293c2d647046a29df9882cd1541
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142070
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-02 15:43:24 +00:00
Johnni Winther fae35fca47 [cfe] Handle potentially constant type expressions in CFE 
Closes #41305

Change-Id: Ibb839c5b6619ae2f7e90cc956c7de20d8c76ae3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142120
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-04-02 13:23:04 +00:00
Konstantin Shcheglov a373aa7ce1 Convert GenericInferrer tests to non-nullable. 
I.e. print types with nullabilities, and use 'none' types in tests.

R=brianwilkerson@google.com

Change-Id: Ia53885ebe7077b0de12e01ac5171711ca8b57e46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142086
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 22:36:18 +00:00
Konstantin Shcheglov 3af491ecd8 Move additional tests and remove GreatestLowerBoundTest. 
Change-Id: I463e4dacb5226d417e6ee13b53540c7c6b76cfc2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142065
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 21:38:48 +00:00
Konstantin Shcheglov 191be51124 Extract GenericInferrer and type schema. 
Change-Id: Ic306342609911e3e232dbf95f30b60cff94c34be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142062
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 20:54:48 +00:00
Konstantin Shcheglov 43115b0f75 Extract SubtypeHelper. 
Change-Id: I6534e68e71108db2dbdca36897694179ec218cb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141902
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-01 18:46:38 +00:00
Konstantin Shcheglov cf5620fa9e Use the deep-most packages. 
Change-Id: I8c03e67d16a58f48e0ac334c216b21dcf2e532c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 17:42:52 +00:00
Konstantin Shcheglov 0e5b596e0d Extract GreatestLowerBoundHelper and LeastUpperBoundHelper. 
Change-Id: I1e10798d2dfe231ab5e6fb87a5eed42e81e43998
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141905
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 17:41:42 +00:00
Johnni Winther d68f552e70 [analyzer,cfe] Handle (un)assigned state in try-statement 
This handles (un)assigned state in try-statement that do not
complete normally. In this case we could create a variable model
for an unreachable state that would be both assigned and unassigned
leading to an assertion failure.

Closes #41284

Change-Id: Id4c7689bc7c614338af3542eb342c964696fca1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141981
Auto-Submit: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 15:46:15 +00:00
Konstantin Shcheglov 37773d39be Make 'covariant' parameter required in tryMatchSubtypeOf(). 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I7a30e886c8fe2abdc5402d0d9da283cdd8f32c87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141913
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 15:36:45 +00:00
Mike Fairhurst 5999b6bad5 Reland "[analyzer] Remove deprecated language version API" 
This is a reland of 65a377b967

Original change's description:
> [analyzer] Remove deprecated language version API
> 
> Change-Id: I10122c8860b7b4c7dfcea1d6f8829ad6be439e7e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141300
> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

Change-Id: I1c5180fcc40b14b4bcc209e0b6b9bc053814047d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141720
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2020-03-31 18:41:50 +00:00
Konstantin Shcheglov e8c4aed700 Remove implementedForMixing from inheritance manager. 
Change-Id: I4f698e1210d86e7c3d168e99b69aea0c075cc10e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141843
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-31 15:59:55 +00:00
Konstantin Shcheglov fb4b59e043 Deprecate isProxy / isOrInheritsProxy in ClassElement. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ied4011961d4dece33d527888d274893985d85f93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141767
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-30 23:27:39 +00:00
Konstantin Shcheglov 9864a9532a Set dynamic resolution for super MethodInvocation in invalid context. 
Every MethodInvocation should be resolved, even if to dynamic.
Leaving it undersolved caused NPEs later.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I43ad2889639684ecaecf3810127213f69765a271
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-30 23:25:49 +00:00
Konstantin Shcheglov 44b6f02985 Revert "Fix the result type of binary expression with the left TypeParameter extends num type." 
This reverts commit 35ebf66c6a.

Reason for revert: This change is not supported by the specification.

Original change's description:
> Fix the result type of binary expression with the left TypeParameter extends num type.
> 
> R=​brianwilkerson@google.com, paulberry@google.com
> 
> Change-Id: I279093c6d155a667b42c47dcd8ca734b874dde57
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141473
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I84e90001d97f95dc729072d4dfa54a9bb53ab002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141640
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-30 16:35:56 +00:00
Keerti Parthasarathy 1364488dce Add guard code for exceptions from ResourceProvider when reading contents. 
Change-Id: I5deb050874c0f0c665777b365cfac59425fb1e76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141440
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-30 02:32:54 +00:00
Konstantin Shcheglov 35ebf66c6a Fix the result type of binary expression with the left TypeParameter extends num type. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I279093c6d155a667b42c47dcd8ca734b874dde57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141473
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-29 04:09:23 +00:00
Brian Wilkerson 9d5fcfc7e7 Remove an unused variable in AstBuilder 
Change-Id: I3497a21b78797abcebc03a59a44176a5fd78588b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141469
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-28 17:12:23 +00:00
Konstantin Shcheglov 1807cf2030 Add LibraryElement.languageVersionMajor/Minor 
Change-Id: I33d2acb269381abf4f26aad0abe4e1feb2435931
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141464
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-28 17:01:08 +00:00
Konstantin Shcheglov 9ba1dc4e56 Report exceptions with the file content for getResult(). 
We report the exception to the caller via Future, but it is still
useful to report it into the exceptions stream with additional data.

R=brianwilkerson@google.com

Change-Id: I89bce59986b5df35072460e2bc36eaefc170fa98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141468
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-28 16:53:25 +00:00
Konstantin Shcheglov ea9df6827e Fix crash in index when the invoked element is multiply defined. 
Saw this in crash reports.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ib2052c8d17abcd0194d75eae43f9f0df37d123db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141522
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-28 16:53:03 +00:00
Alexander Markov a32dc76b86 Revert "[analyzer] Remove deprecated language version API" 
This reverts commit 65a377b967.

Reason for revert: this change broke Flutter HHH and Flutter Golem build:

third_party/dart/third_party/pkg/pub/lib/src/validator/language_version.dart:57:40: Error: The getter 'languageVersion' isn't defined for the class 'CompilationUnit'.
 - 'CompilationUnit' is from 'package:analyzer/dart/ast/ast.dart'

Original change's description:
> [analyzer] Remove deprecated language version API
> 
> Change-Id: I10122c8860b7b4c7dfcea1d6f8829ad6be439e7e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141300
> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

TBR=scheglov@google.com,mfairhurst@google.com

Change-Id: I979fa6201f03e1957bb2557d507b5090c303c82c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141521
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2020-03-28 00:35:21 +00:00
Mike Fairhurst 65a377b967 [analyzer] Remove deprecated language version API 
Change-Id: I10122c8860b7b4c7dfcea1d6f8829ad6be439e7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141300
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-27 18:54:47 +00:00
Mike Fairhurst 2753365946 Revert "[analyzer] Copy result of allSupertypes for now." 
This reverts commit 8f492da139.

Reason for revert: ACX has been updated to not rely on this.

Original change's description:
> [analyzer] Copy result of allSupertypes for now.
> 
> Change-Id: I7713c439872734c94681fa1826e443a33fbec14f
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141030
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>

TBR=scheglov@google.com,mfairhurst@google.com

Change-Id: I59b24b1f7ece65975ca3a8c0016389d85cfafff7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141282
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-03-27 16:36:37 +00:00
Konstantin Shcheglov 8120ee57d2 Merge types during instance member inference. 
Change-Id: If3f252d1c031fcb5219e485ac7a053186e6b950c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141207
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-27 16:22:26 +00:00
Konstantin Shcheglov 126ee948c8 Catch linking exceptions and include the cycle file contents. 
I hope that this will help us to find and fix crashes that we see
during linking.

R=brianwilkerson@google.com

Change-Id: I2e269763395b68fa7bb1a4169b2d681a6834b8eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-27 16:21:58 +00:00
Johnni Winther 25060e63c6 [cfe] Add tool for updating all id-tests and expectation tests 
Change-Id: I191ebe0d59d44055a6818505db0112d3a452bdbb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141242
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-03-27 14:52:20 +00:00
Jens Johansen 4ab3bda5db [parser] Change recovery for constructor; report errors in bad constructors 
Change-Id: I3d656afce4a3ec14c7c099893a434abba3945ebf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140862
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-27 11:57:56 +00:00
Konstantin Shcheglov 216d98ad2c Use NNBD_TOP_MERGE to combine signatures of the inherited members. 
Initial: https://dart-review.googlesource.com/c/sdk/+/133041
Reverted: https://dart-review.googlesource.com/c/sdk/+/133086

Instance inference is not supported yet in this CL, will continue
in following CLs.

Change-Id: I72de01180b0624eeafc03bfe415ed3d928f1110f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133167
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-26 21:13:12 +00:00
Konstantin Shcheglov 1089356a21 Update checkForWrongTypeParameterVarianceInMethod(), fix NPE. 
Saw in crash logs:

NoSuchMethodError: NoSuchMethodError: The getter 'type' was called on null.
Receiver: null
Tried calling: type
at Object.noSuchMethod	(dart:core )
at ErrorVerifier._checkForWrongTypeParameterVarianceInMethod	(error_verifier.dart:5002 )
at ErrorVerifier.visitMethodDeclaration	(error_verifier.dart:973 )
at MethodDeclarationImpl.accept	(ast.dart:6978 )
Change-Id: I17b3db0d537827e34c4cc63a9ebdf1ecbda455f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141023
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-26 17:15:48 +00:00
Mike Fairhurst 8f492da139 [analyzer] Copy result of allSupertypes for now. 
Change-Id: I7713c439872734c94681fa1826e443a33fbec14f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141030
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-03-26 17:15:09 +00:00