dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

10502 Commits

Author SHA1 Message Date
Konstantin Shcheglov 7e4673f497 Check overrides using only direct superinterfaces. 
Change-Id: Ib17c3fb18d6ec4ff4541835a78c645a7b13affd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142760
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-21 02:42:04 +00:00
Konstantin Shcheglov 85336d761f Fail building SDK summary if diagnostics during parsing. 
Change-Id: I1ec1d45b362177ae883f7c0d3a78c081ffaa27bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-21 00:40:04 +00:00
Konstantin Shcheglov b779c938eb Convert element type in for-each to legacy if opt-out library. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://buganizer.corp.google.com/issues/154515220
Change-Id: Ic62feab5fa090a9994b25769729d56fdfed97335
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-20 22:12:54 +00:00
Paul Berry 925e3fe782 Migration: detect weak-only code in conditional expressions. 
This change adds the ability to detect when one branch of a
conditional expression is weak-only due to nullability.  For example,
in the following code:

  int f(int/*!*/ i) => i == null ? g(null) : i;
  int g(int j) => ...;

the call to `g` can only happen in weak checking mode.  The migrator
also now understands that j only needs to be nullable if i is
nullable.

Fixes #41555.
Partially addresses #41551.

Bug: https://github.com/dart-lang/sdk/issues/41555
Change-Id: I02c9c3072f0104db0f1a5b432fb1f2f8f06d5282
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144120
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-04-20 19:09:32 +00:00
Paul Berry aebd854015 Make StaticTypeAnalizer.recordStaticType public. 
This will be needed in a future CL to allow
ResolverVisitorForMigration to set the static type of conditional
expressions when the migration tool is eliminating dead code.

Change-Id: I1361a78d42dd96718edfac99710270046016bff1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144002
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-04-20 17:26:26 +00:00
Konstantin Shcheglov a12c36dd97 Issue 41557. Support for breaks out of labeled blocks. 
Bug: https://github.com/dart-lang/sdk/issues/41557
Change-Id: Ica1c6c04acf600cb20d11a195d6c6da73197733c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143889
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-20 16:30:56 +00:00
Konstantin Shcheglov bf363c5b32 Update types in Future in MockSdk. 
Change-Id: I71e8c5f8345ffb2ce5beb780a5a6399f51ee9628
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144062
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-19 19:58:13 +00:00
Brian Wilkerson 88876d5642 Add documentation for most of the Null Safety diagnostics 
This also updates the testing framework to allow experiments to be
specified with code snippets so that the examples can be tested.

Change-Id: Ifd15c321fef60c736124d368f4d6bfa947460fe8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144060
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-19 15:24:59 +00:00
Konstantin Shcheglov cf70a46f8e Change the default type of the exception to 'Object' instead of 'dynamic'. 
Bug: https://github.com/dart-lang/sdk/issues/41521
Change-Id: I4410bb5b968899b6368eed304e1dfb84f4451554
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143980
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-18 01:33:17 +00:00
Konstantin Shcheglov 780bea595e Add CiderCompletionComputer. 
It encapsulates resolution logic, creating completion request and
manager, caching and reusing suggestions from imported libraries.

In the spirit of keeping the Cider part thin.

R=brianwilkerson@google.com, keertip@google.com

Change-Id: I95f13a98d776eb418b40ea2fae421654eef7602d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-17 18:47:36 +00:00
Konstantin Shcheglov b691657a10 Store isLegacy flag for elements into summary. 
Bug: https://buganizer.corp.google.com/issues/153397493
Change-Id: I10c325bc63a8c057475b75240a4a641370016f61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-16 23:30:21 +00:00
Johnni Winther 594f77715b [cfe] Handle potentially constant type expression in is expression 
Closes #41385

Change-Id: Ia2fa829621931d52c5e41ac0414d12b9caa1256d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142860
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-04-16 09:07:21 +00:00
Jens Johansen c670ae42b0 [analyzer] Add test for parser fix of bang question index 
This is a follow-up to
https://dart-review.googlesource.com/c/sdk/+/141886 adding the
requested test to analyzer.

Change-Id: Ibb34886943b6a80c218212acad17b93b83faadb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142999
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-04-16 06:36:10 +00:00
Paul Berry 188a6a1e20 Prepare to publish analyzer 0.39.7 
Change-Id: I851057811c88c51e766c49df9695442023b6d3f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143561
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-04-15 19:50:09 +00:00
Konstantin Shcheglov 69526e6512 Depecate many AnalysisOptions fields. 
Change-Id: Ibe219527d9abdad38bb99390d3023e7ee6bb8420
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143251
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-15 18:36:52 +00:00
Alexander Thomas 3c85da7778 [release] Bump version to 2.9 
Change-Id: I2fc393cbb7a9111f4c09db6a2a7a202eeb88992c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142996
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-04-15 18:36:42 +00:00
Sam Rawlins bac18c3efd analyzer: Add Element.createFragment and .setInnerHtml to mock SDK 
This will allow improved testing of the unsafe_html rule in the linter:
https://github.com/dart-lang/linter/pull/2057

Change-Id: Ia98f07fd1c5fb27e6250c2c5281e3c49001fc55a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143482
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-15 18:04:05 +00:00
Konstantin Shcheglov d16eacd5e9 Add FileResolver.getErrors() to use instead of resolve() for diagnostics in Cider. 
Change-Id: I4eeab48a15d2ada7df16859d61a7fc013f2f8cc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143480
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-15 17:50:03 +00:00
Sam Rawlins 2feaa2ad81 analyzer: Add SecurityLintCode and a new getter on ErrorCode, isIgnorable 
`isIgnorable` is the new way to determine whether a report from the
analyzer can be ignored. Codes with an ERROR severity are not ignorable,
and the new SecurityLintCode is not ignorable.

Change-Id: Ied72f1b61808eda088b947b8836e0cf1dfdd9850
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143331
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-15 01:51:59 +00:00
Konstantin Shcheglov aa636281a9 Don't do TOP_MERGE when computing inheritedMap. 
Bug: https://github.com/dart-lang/sdk/issues/41470
Change-Id: I9a97ab0b505e4614a338ae20c011ccef7f9026c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-14 20:33:05 +00:00
Johnni Winther dc97454b63 [analyzer,cfe,dart2js] Add pretty printing to id testing 
Adds support for pretty printing verbose annotations.
Adds support for force updating annotation texts useful for applying
the pretty printing to valid annotations.

Change-Id: I8fe9b6d2f8198bd5e160854053c8d964ef832a8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129710
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-04-14 13:24:09 +00:00
Konstantin Shcheglov dd033a6ab7 Report HintCode.NULLABLE_TYPE_IN_CATCH_CLAUSE. 
Change-Id: I747fa9992243f811b4a98320a4ebd169f35daec0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143326
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 20:21:42 +00:00
Konstantin Shcheglov f5b3a0abb0 Save state in FileResolver 
Change-Id: I926346c66a5438b3dc97e638ccc34869457f7968
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143014
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-04-13 19:03:32 +00:00
Konstantin Shcheglov ec3dd52462 The type 'dynamic' is defined in dart:core. 
This makes fixes to analyzer and update the test for updated spec.

Change-Id: Ie5222bcf9056d5cbb7f18437dec04d5af21ff314
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143245
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 17:55:36 +00:00
Konstantin Shcheglov 3d19be30b5 Report errors for enum constants conflics. 
This should fix:
language/enum/syntax_test/05
language/enum/syntax_test/06

Change-Id: Id9cfc9ebd3a39d7234ed7e898196b8d30f417877
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143244
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-13 17:52:32 +00:00
Konstantin Shcheglov c57fe977f0 Make exception and stack trace variables final. 
This should fix:
language/exception/try_catch_on_syntax_test/10

Bug: https://github.com/dart-lang/sdk/issues/41460
Change-Id: Id300deeeab5d25c5ab8062c8b8f5a887dc8c318b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143243
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 17:30:52 +00:00
Konstantin Shcheglov 5d703a5c9c Fix computing annotation values when referencing opt-in from opt-out. 
Bug: https://buganizer.corp.google.com/issues/153801444
Change-Id: If3297aebd9f72b5d774af5b4570ac9f76638da8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143250
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 16:42:31 +00:00
Konstantin Shcheglov f290ae0696 Issue 40554. Apply NORM and TOP_MERGE only when one of the interfaces is not syntactically equal. 
Bug: https://github.com/dart-lang/sdk/issues/40554
Change-Id: Ib96873a825a5a33142655231881562e278b586d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143249
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 16:42:13 +00:00
Sam Rawlins c9710e5059 analyzer: Do not report on a bad type of return expression if function has illegal return type 
Fixes #38188 and fixes #41439

Change-Id: Id6339529afba331750858fb34771bed627ece0be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143248
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 03:42:35 +00:00
Konstantin Shcheglov 23a8788f6a Issue 41378. Update on-catch and throw for the spec changes. 
Now it is not an error to use a potentially nullable type in on-catch.

But it is an error for throw an expression of type that is not
assignable to Object.

Bug: https://github.com/dart-lang/sdk/issues/41378
Change-Id: If0a198ae618cd01d03f45a46aa1efa6179df76ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143220
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-11 20:08:03 +00:00
Konstantin Shcheglov 89b0f67261 Implement InterfaceType.asInstanceOf() using allSupertypes. 
Change-Id: I2e67f68dd924d1abc9718f5e822980692ce47408
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-11 18:39:53 +00:00
Sam Rawlins 5ddea4b8f6 analyzer: Fix analyzer crash when spreading a mixin 
Fixes #41424

Change-Id: I2093b02d325f1593f36c4752dd665601d6d0422c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143141
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-10 23:50:12 +00:00
Mike Fairhurst 353ebdc251 [analyzer] Fix windows test path in micro file resolution 
Change-Id: I67b63187894bb59450a50bf5243a60ce85ccf73f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143120
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-04-10 19:41:54 +00:00
Sam Rawlins 2c420267b7 analyzer: Do not allow errors to be ignored inline. Fixes #27218 
Change-Id: If37dabba3ec18a9f79f44c4ea38d6920a4013019
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140142
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2020-04-10 17:16:24 +00:00
Konstantin Shcheglov 830bfd8886 Rename several FunctionExpressionTest, use shared method. 
Change-Id: Id73036441bf1ec165ee84f3b6580eedec87bba28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143012
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-10 16:02:29 +00:00
Konstantin Shcheglov 450ae848f6 Applying a mixin replaces corresponding names in the interface. 
Change-Id: I5e2ada71af50aa580f5d236773ccb122fca5591c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-10 15:57:44 +00:00
Konstantin Shcheglov 516f297d87 Generator function bodies don't need a return. 
This should fix:
language/async_star/yield_expressions_test

Change-Id: Ifa1dc86f442ca36b292a587d67a208fc15d370dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143011
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-10 15:07:34 +00:00
Konstantin Shcheglov fa3a4eb956 Update TOP_MERGE according to the spec change. 
Bug: https://github.com/dart-lang/sdk/issues/41412
Change-Id: If61638188e594cb1b4272e0011ff0ebd5dbb2772
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142942
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-09 16:28:09 +00:00
Sam Rawlins 38be00f971 analyzer: Do not mark any enum values as unused if the values accessor is accessed 
Fixes #41377

Change-Id: I8c3c03c033a18c6770ab7fbe00435eccb747fb49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-09 15:51:49 +00:00
Konstantin Shcheglov f72378eb1b Test that hints are reported. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: Ief4be0bf88e22c7a1462495d4319a9c0ba3cbb08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142888
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-09 01:24:56 +00:00
Konstantin Shcheglov f557fbd943 Support for TypedLiteral in LinterContext.canBeConst(). 
Bug: https://github.com/dart-lang/linter/issues/2058
Change-Id: I8a037cec8d0b3488733f8cb34eddb3ff2cce5600
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142907
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-08 22:04:15 +00:00
Konstantin Shcheglov bcdfdeb280 Issue 41399. Check for 'dynamic' and 'Never' when verifying EXPORT_LEGACY_SYMBOL. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/41399
Change-Id: I7d36c16085bed80460269f477dcb13fdddfd8603
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-08 17:18:53 +00:00
Konstantin Shcheglov 4d8a98d18c Make all named parameters of BestPracticesVerifier required. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://buganizer.corp.google.com/issues/153520946
Change-Id: I67c7554944283d8626b05f911b96b51fc4ea8cc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-08 17:00:45 +00:00
Konstantin Shcheglov d43eb2b368 Support for analysis options in FileResolver. 
Change-Id: Ifaebeaf87abdac0260c0084090c39d64c699585e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142821
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2020-04-08 16:19:15 +00:00
Konstantin Shcheglov 842d1ceff0 Remove the special case for getGreatestLowerBound() in inference. 
Change-Id: Iac50b8eede9b66bf329680aa2891816f4fb76cef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142807
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-08 15:54:03 +00:00
Konstantin Shcheglov ed38c78397 Don't report MISSING_DEFAULT_VALUE_FOR_PARAMETE for external factory constructors. 
See https://dart-review.googlesource.com/c/sdk/+/142555 for the context.

Change-Id: I0d20c7ef40f6e59e184a2891b061d82492329545
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142822
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-08 15:53:24 +00:00
Paul Berry d8fcc657ee Prepare to publish analyzer 0.39.6. 
Change-Id: Iec8274e7997191061e0ff657c7536406a6c7367c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142702
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-04-07 19:38:16 +00:00
Konstantin Shcheglov 2d47db7424 Improve DOWN for FutureOr vs. FutureOr or Future. 
https://github.com/dart-lang/language/pull/903
https://github.com/dart-lang/sdk/issues/41363

Change-Id: Ieedd4468bbf44b2fec9abba22955eac9b8905a24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141846
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-07 18:35:21 +00:00
Konstantin Shcheglov fa66c73fea Implement hasTypeParameterReference using RecursiveTypeVisitor. 
Change-Id: I351f2b03e1866a15528ed781689e2c894a20d466
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-07 18:27:36 +00:00
Konstantin Shcheglov 696c655140 Remove disableConflictingGenericsCheck flag. 
Change-Id: I994b59131e362c55e388e75a5f5cef04ec1b5cd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-07 18:27:16 +00:00