dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

10502 Commits

Author SHA1 Message Date
Konstantin Shcheglov b598f417dd Use separate Conflict subclasses in inheritance manager. 
R=brianwilkerson@google.com

Change-Id: I45377fed1cc28a7d0301fdc2d7b7897ccf2b3e84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-07 01:23:32 +00:00
Konstantin Shcheglov 0fd787e02c Don't create extra InheritanceManager3 instances. 
Change-Id: If09b6031bd67da506e622814bb4e86323e0cd30f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146987
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-07 00:48:22 +00:00
Konstantin Shcheglov 8bfd2e4090 Fix InheritanceManager3.getOverridden() backward compatibility. 
TBR

R=brianwilkerson@google.com

Change-Id: I23584737fe809052bdb14effde7dcfaeba8fd30c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146985
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-05-06 22:47:36 +00:00
Konstantin Shcheglov e6a3125492 Fix for crash when reporting ABSTRACT_SUPER_MEMBER_REFERENCE for PropertyAccess in mixin. 
Change-Id: I3270ac34b837fc5940e6f4938627bb7479eff851
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-06 19:27:58 +00:00
Konstantin Shcheglov f6d0f462fb Don't report MISSING_DEFAULT_VALUE_FOR_PARAMETER for redirecting factory constructors. 
Change-Id: Ia218070ae332aae8e071e76b2b2bcbc06983e191
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146698
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-06 18:09:44 +00:00
Brian Wilkerson 4da5b40fb6 Remove unnecessary braces in a string interpolation 
Change-Id: I16d86df473e054a5f17b6c72f155467618ef0307
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146823
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-06 16:59:45 +00:00
Konstantin Shcheglov 9b3f9db65a Switch InheritanceManager3 to computing ClassElement interfaces. 
Change-Id: Id9148d1bf3fc369eeabe2b1acc7507c20986a3e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146682
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-06 03:09:03 +00:00
Konstantin Shcheglov 91ca5a3e00 Ignore uninitialized fields in FFI Struct. 
Change-Id: I61b2a7e1059befd99469a617b1eed0e2220041d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-05 22:45:16 +00:00
Keerti Parthasarathy 1e2ebe8506 Add support for part of 
Change-Id: I8002a6449f95422700b522a9cbae0a8c55ee460d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146401
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-05-05 19:57:47 +00:00
Konstantin Shcheglov f724ff477b Extract INCONSISTENT_INHERITANCE tests. 
R=brianwilkerson@google.com

Change-Id: I069859da9e2d34f7c7b97f653a8f875794e502d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-05 15:23:44 +00:00
Paul Berry b71d09542c Migration: extend compound assignment diagnostics to ++ and --. 
Bug: https://github.com/dart-lang/sdk/issues/38676
Change-Id: Iab5097359d8de7aa9411f51ee0ec6212c3adb678
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145920
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-05-04 23:02:17 +00:00
pq 767e78cb4d add lint reporting for offsets 
Change-Id: I56898228f19039aeb6f241080cd3324027763b6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-05-04 20:32:17 +00:00
Keerti Parthasarathy 01820c20a5 Fix checking path for windows 
Change-Id: I7ad6bb40be07dc2cf9d609c7c379dc7ec6725da1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146400
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-05-04 19:56:54 +00:00
Keerti Parthasarathy cc7c0ffa15 Fix test failure on windows bot 
Change-Id: I30b4208420d5160ed00b06d5cfdfe15562703dfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146280
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-05-04 15:57:08 +00:00
Konstantin Shcheglov 3a7633a191 Remove unnecessary null checks in BinaryExpressionResolver. 
Change-Id: Iedc37b7f5f68828fc7c4a9765649b5ba5d44f0a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146067
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-03 18:00:27 +00:00
Konstantin Shcheglov c3ce873556 Inline intermediate method for user defined element resolution for binary expressions. 
Also rename corresponding element/type resolving methods.

R=brianwilkerson@google.com

Change-Id: Ic66ab0716ba98e23aabd713e8cd66c47f048807d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146065
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-03 00:40:56 +00:00
Konstantin Shcheglov 908f630813 Issue 41724. Resolve operator== using NonNull(leftType). 
Bug: https://github.com/dart-lang/sdk/issues/41724
Change-Id: Ie16e6853c5cd5254663bf2d87ef044b8e56734c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-02 19:40:06 +00:00
Sam Rawlins 018dab4568 Analyzer: Report a constructor which redirects to a constructor of an abstract class 
Fixes https://github.com/dart-lang/sdk/issues/37552 and
fixes https://github.com/dart-lang/sdk/issues/34370

Change-Id: I75e68157cf7e6e9824353c307a8e9f6669f8ea82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145571
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-05-02 03:53:55 +00:00
Keerti Parthasarathy eca696c026 Use third_party analysis options file for third_party code. 
Change-Id: Ia88180cd1a5ba186796bd7081721cd0da756ad50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146022
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-05-01 23:09:25 +00:00
Konstantin Shcheglov 798ea59564 Remove invalid assert from ErrorVerifier.enclosingClass=. 
Change-Id: Ic811d3576a041fba88675ff9eec2cf059745c5d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145760
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-01 17:21:43 +00:00
Konstantin Shcheglov eaf46c9ccf Remove unused _isInConstInstanceCreation. 
Change-Id: Id989fd41a3249fc35147b5be43c935bc5a2ce340
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145601
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-30 23:46:36 +00:00
Konstantin Shcheglov 087d3166a2 In getLibraryLinkedSignature() access just file. 
We don't need to configure the analysis context with file specific
analysis options, we are not going to resolve this file.

R=brianwilkerson@google.com, keertip@google.com

Change-Id: Ie0efafc39a35622f12f4110097ff9e804ef87cde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145663
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-30 23:45:46 +00:00
Konstantin Shcheglov 0b8b1515dd Apply new AnalysisOptions for the library context. 
Now we find different options for files more often, and it was affecting
completion performance if we reset the library context every time.

I had to change some shared analyzer objects to be updatable.

Change-Id: If4eee82df62d5115b12fce5865ff3be12aac8c6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145645
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-30 20:21:22 +00:00
Konstantin Shcheglov cf3a034210 Implement promotion via initialization in flow analysis. 
Change-Id: I10a5f6bfeb5a05dd144db5212c9f31796f5a2385
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145502
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-30 16:26:27 +00:00
Konstantin Shcheglov 768fad820b Extract EnclosingExecutableContext. 
Change-Id: Ib4a8344db60c8c717dd6259ff550088d3b30d100
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145447
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-30 16:18:22 +00:00
Sam Rawlins 5506769402 Count variables checked with ArgumentError.checkNotNull as not null 
Fixes https://github.com/dart-lang/sdk/issues/39644

Change-Id: I552e87e7c57dd2c5a012b76d9c73c24fefb19785
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145025
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-29 22:35:18 +00:00
Konstantin Shcheglov 7deb5a3874 Fix documentation for EXPORT_LEGACY_SYMBOL. 
With https://dart-review.googlesource.com/c/sdk/+/145220 specifying
the current language version using `// @dart=` does not opt-out from
experiments.

Change-Id: Ibee76c35af8e829bef7d14347fe155ba876c1033
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145445
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-29 20:36:39 +00:00
Konstantin Shcheglov 2ccfc88f25 Change Feature.restrictToVersion() to keep features of the current language version. 
See https://github.com/dart-lang/sdk/issues/41691

Change-Id: I3ee40592158d4054d187120048f1eb805108ee69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145220
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-29 15:24:54 +00:00
Konstantin Shcheglov 1eb7ed02eb Fix leak of changed FileState(s). 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I8b68eee0b0a3cdf613912615198990edec7768dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145309
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-29 05:10:14 +00:00
Konstantin Shcheglov 39c503970b Reset the library context in FileResolver by timeout. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I4dafff7229ad8a6f6713d6929121222ad818eccf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144996
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2020-04-28 19:38:02 +00:00
Paul Berry f4efe7bdb8 Prepare to publish analyzer 0.39.8 
Change-Id: I6712e973c11da7e443a12ccda86aa411781bdf75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145024
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-04-28 17:18:02 +00:00
Sam Rawlins af1ba835da Analyzer: unnamed ExtensionElement should have a null name 
Fixes #41614

Change-Id: I5221f0e7dcff26c4115eaa673cd4cab65af6fdbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145023
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-28 16:17:51 +00:00
Konstantin Shcheglov 14f41846ab Add CiderFixesComputer. 
Change-Id: Ie0a69ccbba5a6b9afec322caeb3d8edfe8293abd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-28 15:34:31 +00:00
Sam Rawlins 2032460323 analyzer: Fix message of REDIRECT_TO_INVALID_TYPE 
Fixes #37048

Change-Id: I15ada167d2665b017b078710d5798a4deedf2248
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145022
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-28 03:59:37 +00:00
Konstantin Shcheglov 3e26a5d0dd Issue 40957. Report the language feature, and recommend to set SDK constraint. 
...but don't recommend to enabled any experiment.

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/40957
Change-Id: I556ce9952b28d0b079521ac46558f8e3adf352c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144982
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-27 22:11:46 +00:00
Konstantin Shcheglov eada4d8d65 Implement Factor in flow analysis. 
Bug: https://github.com/dart-lang/sdk/issues/40014
Change-Id: I8d21d3c3368495d9d0dbb1cd52317b053657a176
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144804
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-27 18:47:08 +00:00
Konstantin Shcheglov a18e3f6fb4 Issue 41645. Report assigning to Never type variables. 
Bug: https://github.com/dart-lang/sdk/issues/41645
Change-Id: I877ef09a4650b40577d2f0af63427432a8396dec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144811
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-25 00:25:59 +00:00
Konstantin Shcheglov 46a2086e6c Issue 41479. When terminate null shorting at CascadeExpression, don't make it nullable. 
Bug: https://github.com/dart-lang/sdk/issues/41479
Change-Id: I2d843846ca2a0232dbea60ad2b71e745ac118588
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144672
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-24 18:45:13 +00:00
Konstantin Shcheglov 8bce5840a5 Incrementally invalidate file state and library context for Cider. 
Change-Id: I278b990d27a380bded958681e07a47ffcedc8e56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144690
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-24 17:10:53 +00:00
Konstantin Shcheglov 8990c063b7 Issue 41603. await voidExpression is an error. 
Bug: https://github.com/dart-lang/sdk/issues/41603
Change-Id: I6cbd8938c62e7f5f60e48e0ee65b80f4924a3a65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144681
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-24 03:42:52 +00:00
Konstantin Shcheglov 4490e2f541 Deprecate VariableElement.constantValue, use computeConstantValue(). 
Bug: https://github.com/dart-lang/linter/issues/2073
Change-Id: I68d9c8eaf632c72c4634bb56f13af7ab603e3c5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144666
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-24 00:37:52 +00:00
Konstantin Shcheglov a36ec667e6 Issue 41630. Catch exceptions from Directory.listSync() in EvictingFileByteStore. 
Bug: https://github.com/dart-lang/sdk/issues/41630
Change-Id: I02d581c984d69876432b6e17616cab6f84725b38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144663
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-23 19:01:14 +00:00
Konstantin Shcheglov 9b2663939a Issue 41632. Support Never in NNBD_TOP_MERGE. 
Bug: https://github.com/dart-lang/sdk/issues/41632
Change-Id: Ic3d91c8d155068056e2177b2658b99913c95dc05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144661
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-23 18:53:10 +00:00
Keerti Parthasarathy 2c5969d0f2 Add workspace root to ContextRoot.included 
Change-Id: Id73d78e904e7548aad3365c5fa3f3bb27cefd89d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144496
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-04-23 03:46:18 +00:00
Konstantin Shcheglov 7f57c06e84 Log cumulative statistics for getFileContext(). 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I9135651a277d04d0891d968b9e46cd031490b089
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144491
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-22 23:33:54 +00:00
Konstantin Shcheglov 838b2eca6a Clean up ClassHierarchy after linking. 
So that we don't keep references to ClassElement(s) being linked.
We will reload libraries from bytes, and rebuild necessary hierarchies.

Change-Id: Ibef128779e5422bdcdb8b5cc92d4676d76a8ed77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144485
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-22 21:04:29 +00:00
Konstantin Shcheglov a934ec2961 If possible, reuse the last completion result. 
Also rename "character" to "column".

R=brianwilkerson@google.com, keertip@google.com

Change-Id: I6167de6e1fd5aede2a619603635e96f16bfbcc8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144352
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-22 14:50:38 +00:00
Konstantin Shcheglov ea58996b27 Issue 41593. End dead code flow at TryStatement body. 
Bug: https://github.com/dart-lang/sdk/issues/41593
Change-Id: I7d8bc076143a253ea40d0ed04bbceab507c33bc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144348
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-22 03:15:28 +00:00
Konstantin Shcheglov 6f97affca2 Don't apply substitution for top-level function members. 
Bug: https://buganizer.corp.google.com/issues/154516150
Change-Id: I353701ec0e6d2384644685a4d950be7751a6c6b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-21 20:10:55 +00:00
Konstantin Shcheglov 704642a9b0 Report DEAD_CODE using flow analysis when NNBD. 
Bug: https://github.com/dart-lang/sdk/issues/35716
Change-Id: I066d744e30ec582f0c79a238dc5bf8194eaef578
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143900
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-21 03:47:54 +00:00