dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

7128 Commits

Author SHA1 Message Date
Konstantin Shcheglov a6148714f0 Annotate two failing inference tests with the corresponding issue. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/25824
Change-Id: I485f87f526c1251363349e9d354eefdc57d24120
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-14 21:32:25 +00:00
Konstantin Shcheglov 8ae35ec089 Remove SetLiterals specific subtypes of tests. 
Change-Id: Ic39e515249d7caab11ce686b2c1fe6ebab6a8456
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148148
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-14 19:33:44 +00:00
Johnni Winther 383a8ea857 [cfe] Initial support for external fields. 
Change-Id: Iccee87f40df395c928dc1a9dc81ddad8813a5000
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147906
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-05-14 18:34:06 +00:00
Konstantin Shcheglov ea4e4367bc Fix MISSING_RETURN after function expression return type inference. 
Bug: https://buganizer.corp.google.com/issues/156495751
Change-Id: I0b994d9023cf9282048b2ec9462190f579ce620d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148001
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-13 21:46:42 +00:00
Konstantin Shcheglov 251933ca62 Implement futureValueType() operation. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I34cca0aa0ee8ca8237a5bfb3c123bc732a279c4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147824
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-13 15:36:16 +00:00
Konstantin Shcheglov 9d0d7a675c The formal spec has a typo around async functions and void. 
R=brianwilkerson@google.com

Change-Id: Idd87f69a6eb406f911d11c923ee13eb1cef6c55b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-13 15:28:33 +00:00
Konstantin Shcheglov 0861470197 Update ReturnTypeVerifier to be what the spec says. 
See also https://github.com/dart-lang/language/issues/960

Change-Id: I5cfc672e7902fba15ec940afb07f324cd21da686
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-12 23:54:06 +00:00
Sam Rawlins b9e10e3870 analyzer: Remove unused imports 
These were previously undetected due to https://github.com/dart-lang/sdk/issues/38784

Change-Id: I546f698d992142f5e1d1260fba1cfd4a5308a0d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-05-12 23:45:24 +00:00
Paul Berry 275b922ee8 Revert recent parser fixes 
Commit 1f9b5c1996 causes tests to fail
in angular when rolled into internal sources; the other two commits
need to be reverted as well to avoid merge conflicts.

This reverts commit 1f9b5c1996.
This reverts commit c40b24da48.
This reverts commit 96df1f9e6c.

Change-Id: Ic4e55181ef60e825ce4409a9a9528ecbf19c39c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147822
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-12 22:02:09 +00:00
Konstantin Shcheglov 8963497d55 Ensure that URIs end with '/', fixes empty 'packageUri'. 
Bug: https://github.com/dart-lang/pub/issues/2482
Change-Id: Ibaf94b44532b44c9a87c05cb8c6eaa523fbbb6ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-12 19:30:51 +00:00
Konstantin Shcheglov 5ab1687ee7 Create updated ParameterElement(s) using replace(). 
Change-Id: I1038f119e9678eb6bb24fa4b10513a28a701d782
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147424
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-12 17:04:09 +00:00
Konstantin Shcheglov 4ead8ad652 Resolve operands of '==='. 
Change-Id: Ib6fddcb62dfeb840276e188b77119e661c7ce5cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-11 17:22:58 +00:00
Konstantin Shcheglov 29c340fb94 Perform return type inference using BodyInferenceContext. 
Change-Id: I713a01add6da45aa03d6e15d1374297182d39116
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-11 17:20:57 +00:00
Konstantin Shcheglov 4e520824f5 Deprecated DartType.isObject 
R=brianwilkerson@google.com

Change-Id: If588b23668764b07c99e327281bfeb11c8e31367
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147423
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-11 16:14:37 +00:00
Jens Johansen 96df1f9e6c [parser] Add ErrorToken for ignored (unmatched) end parenthesis, brackets etc 
Change-Id: Idb57295700988d71321743af9782134b02562311
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146240
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-05-11 14:46:47 +00:00
Konstantin Shcheglov 81780821e8 Extract FunctionExpressionResolver. 
R=brianwilkerson@google.com

Change-Id: I363f0bfe91328c2729fe268d2dcb79f61d51b91c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147338
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-09 18:19:09 +00:00
Konstantin Shcheglov da02189198 Split computing interface for class and mixin. 
Change-Id: I1d936dd7aee83f4436183f2e20433cfed7ebc747
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147330
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-08 16:08:39 +00:00
Konstantin Shcheglov 7161036eb7 Fix avoid_unused_constructor_parameters in analyzer. 
Bug: https://github.com/dart-lang/sdk/issues/41797
Change-Id: I6fb201b549a599b12d022abd6108d3418966c4f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147221
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-05-08 04:44:58 +00:00
Sam Rawlins d0d0952546 analyzer: Report unused public members of private and unnamed extensions 
Fixes #41592

Change-Id: I95b79724bfcfc5d48b8f6cca61c6a3a681de3662
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144353
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-07 15:34:48 +00:00
Konstantin Shcheglov e6a3125492 Fix for crash when reporting ABSTRACT_SUPER_MEMBER_REFERENCE for PropertyAccess in mixin. 
Change-Id: I3270ac34b837fc5940e6f4938627bb7479eff851
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-06 19:27:58 +00:00
Konstantin Shcheglov f6d0f462fb Don't report MISSING_DEFAULT_VALUE_FOR_PARAMETER for redirecting factory constructors. 
Change-Id: Ia218070ae332aae8e071e76b2b2bcbc06983e191
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146698
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-06 18:09:44 +00:00
Konstantin Shcheglov 9b3f9db65a Switch InheritanceManager3 to computing ClassElement interfaces. 
Change-Id: Id9148d1bf3fc369eeabe2b1acc7507c20986a3e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146682
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-06 03:09:03 +00:00
Konstantin Shcheglov 91ca5a3e00 Ignore uninitialized fields in FFI Struct. 
Change-Id: I61b2a7e1059befd99469a617b1eed0e2220041d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-05 22:45:16 +00:00
Keerti Parthasarathy 1e2ebe8506 Add support for part of 
Change-Id: I8002a6449f95422700b522a9cbae0a8c55ee460d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146401
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-05-05 19:57:47 +00:00
Konstantin Shcheglov f724ff477b Extract INCONSISTENT_INHERITANCE tests. 
R=brianwilkerson@google.com

Change-Id: I069859da9e2d34f7c7b97f653a8f875794e502d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-05 15:23:44 +00:00
Keerti Parthasarathy cc7c0ffa15 Fix test failure on windows bot 
Change-Id: I30b4208420d5160ed00b06d5cfdfe15562703dfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146280
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-05-04 15:57:08 +00:00
Konstantin Shcheglov c3ce873556 Inline intermediate method for user defined element resolution for binary expressions. 
Also rename corresponding element/type resolving methods.

R=brianwilkerson@google.com

Change-Id: Ic66ab0716ba98e23aabd713e8cd66c47f048807d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146065
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-03 00:40:56 +00:00
Konstantin Shcheglov 908f630813 Issue 41724. Resolve operator== using NonNull(leftType). 
Bug: https://github.com/dart-lang/sdk/issues/41724
Change-Id: Ie16e6853c5cd5254663bf2d87ef044b8e56734c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-02 19:40:06 +00:00
Sam Rawlins 018dab4568 Analyzer: Report a constructor which redirects to a constructor of an abstract class 
Fixes https://github.com/dart-lang/sdk/issues/37552 and
fixes https://github.com/dart-lang/sdk/issues/34370

Change-Id: I75e68157cf7e6e9824353c307a8e9f6669f8ea82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145571
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-05-02 03:53:55 +00:00
Keerti Parthasarathy eca696c026 Use third_party analysis options file for third_party code. 
Change-Id: Ia88180cd1a5ba186796bd7081721cd0da756ad50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146022
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-05-01 23:09:25 +00:00
Konstantin Shcheglov eaf46c9ccf Remove unused _isInConstInstanceCreation. 
Change-Id: Id989fd41a3249fc35147b5be43c935bc5a2ce340
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145601
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-30 23:46:36 +00:00
Konstantin Shcheglov 0b8b1515dd Apply new AnalysisOptions for the library context. 
Now we find different options for files more often, and it was affecting
completion performance if we reset the library context every time.

I had to change some shared analyzer objects to be updatable.

Change-Id: If4eee82df62d5115b12fce5865ff3be12aac8c6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145645
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-30 20:21:22 +00:00
Konstantin Shcheglov 768fad820b Extract EnclosingExecutableContext. 
Change-Id: Ib4a8344db60c8c717dd6259ff550088d3b30d100
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145447
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-30 16:18:22 +00:00
Konstantin Shcheglov 39c503970b Reset the library context in FileResolver by timeout. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I4dafff7229ad8a6f6713d6929121222ad818eccf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144996
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2020-04-28 19:38:02 +00:00
Konstantin Shcheglov eada4d8d65 Implement Factor in flow analysis. 
Bug: https://github.com/dart-lang/sdk/issues/40014
Change-Id: I8d21d3c3368495d9d0dbb1cd52317b053657a176
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144804
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-27 18:47:08 +00:00
Konstantin Shcheglov a18e3f6fb4 Issue 41645. Report assigning to Never type variables. 
Bug: https://github.com/dart-lang/sdk/issues/41645
Change-Id: I877ef09a4650b40577d2f0af63427432a8396dec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144811
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-25 00:25:59 +00:00
Konstantin Shcheglov 46a2086e6c Issue 41479. When terminate null shorting at CascadeExpression, don't make it nullable. 
Bug: https://github.com/dart-lang/sdk/issues/41479
Change-Id: I2d843846ca2a0232dbea60ad2b71e745ac118588
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144672
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-24 18:45:13 +00:00
Konstantin Shcheglov 8bce5840a5 Incrementally invalidate file state and library context for Cider. 
Change-Id: I278b990d27a380bded958681e07a47ffcedc8e56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144690
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-24 17:10:53 +00:00
Konstantin Shcheglov 8990c063b7 Issue 41603. await voidExpression is an error. 
Bug: https://github.com/dart-lang/sdk/issues/41603
Change-Id: I6cbd8938c62e7f5f60e48e0ee65b80f4924a3a65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144681
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-24 03:42:52 +00:00
Konstantin Shcheglov 4490e2f541 Deprecate VariableElement.constantValue, use computeConstantValue(). 
Bug: https://github.com/dart-lang/linter/issues/2073
Change-Id: I68d9c8eaf632c72c4634bb56f13af7ab603e3c5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144666
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-24 00:37:52 +00:00
Konstantin Shcheglov 9b2663939a Issue 41632. Support Never in NNBD_TOP_MERGE. 
Bug: https://github.com/dart-lang/sdk/issues/41632
Change-Id: Ic3d91c8d155068056e2177b2658b99913c95dc05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144661
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-23 18:53:10 +00:00
Konstantin Shcheglov ea58996b27 Issue 41593. End dead code flow at TryStatement body. 
Bug: https://github.com/dart-lang/sdk/issues/41593
Change-Id: I7d8bc076143a253ea40d0ed04bbceab507c33bc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144348
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-22 03:15:28 +00:00
Konstantin Shcheglov 6f97affca2 Don't apply substitution for top-level function members. 
Bug: https://buganizer.corp.google.com/issues/154516150
Change-Id: I353701ec0e6d2384644685a4d950be7751a6c6b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-21 20:10:55 +00:00
Konstantin Shcheglov 704642a9b0 Report DEAD_CODE using flow analysis when NNBD. 
Bug: https://github.com/dart-lang/sdk/issues/35716
Change-Id: I066d744e30ec582f0c79a238dc5bf8194eaef578
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143900
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-21 03:47:54 +00:00
Konstantin Shcheglov 7e4673f497 Check overrides using only direct superinterfaces. 
Change-Id: Ib17c3fb18d6ec4ff4541835a78c645a7b13affd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142760
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-21 02:42:04 +00:00
Konstantin Shcheglov b779c938eb Convert element type in for-each to legacy if opt-out library. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://buganizer.corp.google.com/issues/154515220
Change-Id: Ic62feab5fa090a9994b25769729d56fdfed97335
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-20 22:12:54 +00:00
Brian Wilkerson 88876d5642 Add documentation for most of the Null Safety diagnostics 
This also updates the testing framework to allow experiments to be
specified with code snippets so that the examples can be tested.

Change-Id: Ifd15c321fef60c736124d368f4d6bfa947460fe8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144060
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-19 15:24:59 +00:00
Konstantin Shcheglov cf70a46f8e Change the default type of the exception to 'Object' instead of 'dynamic'. 
Bug: https://github.com/dart-lang/sdk/issues/41521
Change-Id: I4410bb5b968899b6368eed304e1dfb84f4451554
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143980
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-18 01:33:17 +00:00
Konstantin Shcheglov b691657a10 Store isLegacy flag for elements into summary. 
Bug: https://buganizer.corp.google.com/issues/153397493
Change-Id: I10c325bc63a8c057475b75240a4a641370016f61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-16 23:30:21 +00:00
Jens Johansen c670ae42b0 [analyzer] Add test for parser fix of bang question index 
This is a follow-up to
https://dart-review.googlesource.com/c/sdk/+/141886 adding the
requested test to analyzer.

Change-Id: Ibb34886943b6a80c218212acad17b93b83faadb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142999
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-04-16 06:36:10 +00:00