dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

7128 Commits

Author SHA1 Message Date
Sam Rawlins 42d2996773 Analyzer: Move NON_BOOL_* tests to diagnostics/ 
Change-Id: I5bc58d78bf4f15e860759176d2e6abc670666e46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-07-06 00:49:10 +00:00
Konstantin Shcheglov 69aba23371 Move TypeSystemImpl to src/dart/element/type_system.dart 
R=brianwilkerson@google.com

Change-Id: I0d9acad041c1038f6f2be6c09855488287ba5e97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-05 16:44:59 +00:00
Konstantin Shcheglov d1c9b09042 Set uri for implicit dart:core import. 
R=brianwilkerson@google.com

Change-Id: Ie354df1cd541480f4deb3a4d29c7068990072f6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-03 22:54:02 +00:00
Konstantin Shcheglov 326f7b4a8f Remove DartSdk.useSummary. 
Initial:  https://dart-review.googlesource.com/c/sdk/+/149495
Reverted: https://dart-review.googlesource.com/c/sdk/+/149687
Change-Id: Ibd3f1af1aef83adc35f77cfbda66e07c5ae99922
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-03 15:56:41 +00:00
Konstantin Shcheglov 9cfdc02e58 Stop depending on exports from generated/resolver.dart 
We cannot remove them completely just yet, there are users in google3.
But this CL will allow experimenting internally to track these users
and update them similarly.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: Ic588b2873f9d5202783c8991f58e86bab28bd47e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-03 15:55:41 +00:00
Sam Rawlins f19ed288ed Analyzer: Move INVALID_ASSIGNMENT tests to diagnostics 
Change-Id: I111c64bb743dfb531e05be8594cab72c36866274
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-07-02 16:29:49 +00:00
Konstantin Shcheglov c0a7ee9b65 Issue 42007. Don't report UNNECESSARY_CAST when casting from a star to question type. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/42007
Change-Id: I1c7f353a4e5a18c028d2a1c746ec76c916fcaaa3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-30 17:59:44 +00:00
Konstantin Shcheglov 76852100ea Test UNNECESSARY_CAST for FunctionType(s) and NullSafety. 
R=brianwilkerson@google.com

Change-Id: I1e6cee6b0c574f93a31a0eb14f68b2cfb1c1fd78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152734
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-29 17:57:39 +00:00
Konstantin Shcheglov 6e9aa86d6f Stop using AnalysisOptions.signature and multiple paths in SdkDescription. 
Basically reduce it to a single path.

R=brianwilkerson@google.com

Change-Id: Ia532a5c7f6ae1464b77c5e9d23b3aaa7e85a6bf0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152710
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-29 17:50:14 +00:00
Konstantin Shcheglov e77e270cc2 Make all parameters of ExperimentalFeature constructor named required. 
Change-Id: Ib0af7526923653992c13002c808197cc16ffa98b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152619
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-29 17:49:33 +00:00
Brian Wilkerson d074bb1596 Improve the range selected by const_constructor_with_field_initialized_by_non_const 
Instead of highlighting the entire constructor, which might be long, we
now highlight just the keyword `const`.

Change-Id: Ie520db0a2fcaf05db79d9e49e08f06a5212fef7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152727
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-28 14:51:31 +00:00
Brian Wilkerson 30fe39b92d Do not report a missing implicit default super constructor when subclassing an non-subclassable class 
Change-Id: I015ebb07ae341bcee615e032be460b3e59e149c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152726
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-28 14:51:24 +00:00
Konstantin Shcheglov f91547d6dd Separate signatures for linked elements from signatures for resolution. 
So, lints and error filters don't affect cache keys for summaries, and
we can reuse them more often across analysis contexts.

This makes `dart flutter_tools/bin/flutter_tools.dart analyze --flutter-repo`
about 35% faster, from 153 seconds to 113 seconds.

Change-Id: I606acce7ef712450783c75d24bc52fd5877b3f1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152725
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-27 19:14:41 +00:00
Sam Rawlins 6bf946bbfc analyzer: Always declare return types. 
Change-Id: I23d89bb572310a1a8deef8e173630d9bb59c9a50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152708
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-06-26 23:54:28 +00:00
Konstantin Shcheglov 4b93c8aabd Remove unused AnalysisDriver flag 'disableChangesAndCacheAllResults'. 
R=brianwilkerson@google.com

Change-Id: Ic9a98493496cf875434d0d6c2246721d4985c8c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152707
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-26 21:16:38 +00:00
Sam Rawlins c68fd58513 Use ///-style doc comments in analyzer/test 
Bug: https://github.com/dart-lang/sdk/issues/33892
Change-Id: If61e07fda4d74b1e5171d22403b156855cd00596
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152701
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-06-26 18:45:05 +00:00
Konstantin Shcheglov 13a24f4de1 Issue 42474. Add LibraryElement.languageVersion 
Bug: https://github.com/dart-lang/sdk/issues/42474
Change-Id: I316f34b14f01daa517182c1cb7b7c3fb038f0be2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152601
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-25 23:54:03 +00:00
Konstantin Shcheglov 616ed353a2 Rename / deprecate FileResolver methods. 
R=keertip@google.com

Change-Id: I684465db327f5f448a95f57a18cf65e172c09b01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152603
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-25 20:59:32 +00:00
Brian Wilkerson 898f2cc6c7 Remove extraneous references to the virtual annotation 
Change-Id: I9361d030ffa9aabeb8c4253553c04d356fc7ff45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152580
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-25 17:04:42 +00:00
Konstantin Shcheglov 52d16dfbba Resolve only relevant portion of the file for Cider completion. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: Icf23a79f25baf309f88b737ac061a10a655d2f7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152407
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-25 01:02:41 +00:00
Konstantin Shcheglov 2ec47ad273 Use ElementKind.ENUM for enums. 
There was a crash internally, caused by the fact that when we have
duplicate name for class and enum, during linking we put them into
different Reference bucket - @class and @enum, and also inside
the class, the reference to its name is the class.

But when we resolve, we check equality of elements using not
references, but locations. So, we need to make sure that their
kinds are also different, so go into different bucket, and so
not equal.

When they are InterfaceType and equal, we would try to match
type arguments against the wrong number of type parameters and crash.

Change-Id: Iee3f8691adac65d4b0395ceec7fc7250f96afa88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152404
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-25 00:20:31 +00:00
Konstantin Shcheglov 05167f3b63 Clean up isUnnecessaryCast() and many of its tests. 
Change-Id: I74c509aa43fa7e8850b6e2026c570606a8cb18e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-24 05:16:01 +00:00
Konstantin Shcheglov 6a46af25d1 Fix UNUSED_LOCAL_VARIABLE in UnnecessaryCastTest. 
R=brianwilkerson@google.com

Change-Id: Iff17cb9c3708b8dfa10c7d9911c42eeccb87b2d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152204
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-23 21:55:35 +00:00
Konstantin Shcheglov 6b630c3719 Enabled allowed experiments for the whole package, including bin/ and test/. 
Change-Id: I617b80f0ea6a182d6e48eeb731c89cd5659cb567
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-23 18:30:23 +00:00
Brian Wilkerson ab73158758 Fix the windows bot and update MockSdk 
Fixing the test that's causing the Windows bot to fail required updating
the MockSdk, which cause a lot of other changes. I would have done this
in two separate CLs if I'd known how big this was going to get, but I'm
hoping it isn't too big.

Change-Id: Idee56bab5e73a78ab7857e81177090493aa08b40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151874
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-22 14:34:25 +00:00
Konstantin Shcheglov 67173ade40 Record performance for analysis operations. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: Ib85680d37f36c9a34f61b8d215a68ed2bd71f8d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151884
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-19 20:15:35 +00:00
Konstantin Shcheglov 62cc07dbca Issue 42385. Fix for analyzing 'prefix?.foo'. 
Bug: https://github.com/dart-lang/sdk/issues/42385
Change-Id: I4dabfbda01a37210c57cb5ba6b5a7d530752e029
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151628
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-18 21:22:42 +00:00
Sam Rawlins 10c5c113f3 Analyzer: Allow factory const ctor with non-const final fields 
Fixes https://github.com/dart-lang/sdk/issues/36315

Change-Id: I010d4d6e855e243931f34e9dc55d537551dc9cb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151661
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-18 18:17:06 +00:00
Konstantin Shcheglov cd360dee2a Non-nullify types during inheritance inference. 
Change-Id: I97567a6d77e2afdbc995d7561d87baabaae5abfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151634
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-18 17:14:41 +00:00
Konstantin Shcheglov 60bb0d3a41 Separate current and to restrict FeatureSet(s) in scanner. 
Bug: https://buganizer.corp.google.com/issues/159207726
Change-Id: I41b4c79590dccd05d8b0fa42d296f00a3c3ee229
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151620
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-17 23:32:31 +00:00
Konstantin Shcheglov 327304cb59 Issue 42356. Report constant errors for arguments in constant instance creations. 
Bug: https://github.com/dart-lang/sdk/issues/42356
Change-Id: I674878c12b82af229d70e7a6eca5cd662ec29394
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151623
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-17 21:49:55 +00:00
Konstantin Shcheglov 9468ba063e Non-nullify types when inferring types of top-level variables and fields. 
Change-Id: Id272958725d582892aa9cacdddbb5cde89793bf5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151444
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-17 05:15:10 +00:00
Konstantin Shcheglov d279cb47b5 Enforce sorting in analyzer/. 
Change-Id: If7e76e442e64cd4991b80c3993e3da10bb3a19ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151462
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-17 05:04:30 +00:00
Konstantin Shcheglov 021a49e88c Update the way to get feature set and language version. 
https://github.com/dart-lang/sdk/issues/42274
https://github.com/dart-lang/sdk/issues/42321

Change-Id: I5551ecd2803f9d26e720e5cf5671b3be8236bce9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151423
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-16 19:05:43 +00:00
Konstantin Shcheglov 7f6b0d82eb Issue 42337. Report BODY_MIGHT_COMPLETE_NORMALLY for factory constructors. 
Bug: https://github.com/dart-lang/sdk/issues/42337
Change-Id: I9209d7bf519ec61026ffe22bb05145e776e8517d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151344
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-15 23:46:38 +00:00
Konstantin Shcheglov 18b753cbcd Support for null-aware ExtensionOverride. 
Bug: https://github.com/dart-lang/sdk/issues/41780
Change-Id: Ib5d11000847434c679df1ec882ee6d9777670fe0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151097
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-15 23:45:08 +00:00
Jaime Wren 920ddae937 Re-write of the computation of the context type for code completion.  Instead of passing a parent and child node, a parent node with an offset is passed.  The primary purpose of this change was to fix a bug with argument lists which is close to being fixed. 
I will follow up with some additional fixes and tests for map and list literals.

Change-Id: I1a26e8f900dcf13402385a49e8f3538c5d1b39df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151030
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-15 18:19:42 +00:00
Konstantin Shcheglov 48f2d10d3e Deprecate ClassElement.hasReferenceToSuper 
Change-Id: Ie94d8e2b0be6ccb30c7ca59c80da2832cfed3689
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151168
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-15 17:45:06 +00:00
Konstantin Shcheglov b7efcd276c Report NO_COMBINED_SUPER_SIGNATURE. 
https://github.com/dart-lang/language/pull/975

Change-Id: I8ecd191efa84f17d36ea09ef1db33a401c67fda3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151093
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-15 17:42:45 +00:00
Sam Rawlins 294a2cffd1 Analyzer: print constructor name when constructor returns invalid type 
Fixes https://github.com/dart-lang/sdk/issues/27387

Change-Id: I8ce81bab4c4601c5157977d3f43f73903dae7f8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151200
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-15 13:52:56 +00:00
Sam Rawlins b0d4c359d8 Move tests for 4 codes to diagnostics directory. 
Also add some tests for function-typed field formal parameters.

Change-Id: Ia6cb23c15e695a540ac3c6df0a7af8110a8fc1f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-06-14 22:12:07 +00:00
Sam Rawlins 32a93e2147 Analyzer: Remove error on class-used-as-mixin referencing super 
Fixes https://github.com/dart-lang/sdk/issues/34806

Change-Id: I1cfd0b9c0699734b172aa62f7a04ab533a6cd03f
Fixed: 34806
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151099
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-06-13 15:11:25 +00:00
Brian Wilkerson c22dc20a93 Use the const-ness of an element when completing in a const context using available declarations 
Change-Id: Ia950ad81ed571cbcf1f0060da0cba26406206ad1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151031
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-06-12 22:15:55 +00:00
Konstantin Shcheglov fda4238285 During linking, resolve initializers of constant variables with flow analysis. 
Change-Id: I6189cdf86f0e285883da769ceb0b36d6ee85588c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151086
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-12 19:40:18 +00:00
Konstantin Shcheglov 24852421e2 Change method override inference to use combined member signature. 
https://github.com/dart-lang/language/pull/975

Change-Id: I5cec14a384b124a29dcd5adac0f0be6e5214cc9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151044
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-12 18:59:28 +00:00
Sam Rawlins 56dbe294f2 Analyzer: Do not report const constructors with mixed in synthetic fields 
Fixes https://github.com/dart-lang/sdk/issues/37810

Also report the offending fields in the error.

Change-Id: I8328bf5f16f56f1b70bbe4bdb7623ade6f11943c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151027
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-12 16:24:35 +00:00
Sam Rawlins 9f6c372228 Analyzer: forward const constructors to mixin apps as const 
Fixes https://github.com/dart-lang/sdk/issues/41072

Relevant text from spec:

> If $S_q$ is a generative const constructor, and $MC$ does
> not declare any instance variables, $C_q$ is also a const
> constructor.

Relevant language tests:

  language_2/mixin_constructor_forwarding/const_constructor*

Change-Id: I8ad9e9dd3907b5dd29aa8f10aab6ec604a1aaa4b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150682
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-06-11 21:05:29 +00:00
Konstantin Shcheglov 1ce143cfc1 Issue 42278. Null-nullify types after function expression inference, not the context type. 
Bug: https://github.com/dart-lang/sdk/issues/42278
Change-Id: I40abcb6e7e97ef4f3993da65a21dffbdbc1f483a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-11 20:39:59 +00:00
Sam Rawlins 32559d3799 Analyzer: Do not forward factory constructors to mixin applications 
Fixes https://github.com/dart-lang/sdk/issues/38306

Change-Id: I1424425ad6b04f1b611661cfca6ff5113b2cf0df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150681
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-06-11 17:40:24 +00:00
Konstantin Shcheglov b19e9075db Non-nullify types after inference. 
Change-Id: Ie50ea84d18bc44799cadc797c76d6506539de719
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150842
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-11 16:50:43 +00:00